GNU logs - #76602, boring messages

Message sent to guix-patches@HIDDEN:

Subject: [bug#76602] Reprotest fails to run due to missing execute bit
Resent-From: Vagrant Cascadian <vagrant@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 26 Feb 2025 22:12:02 +0000
Resent-Message-ID: <handler.76602.B.174060790426257 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 76602 <at> debbugs.gnu.org
Cc: me@HIDDEN, tanguy@HIDDEN, lars@HIDDEN, sharlatanus@HIDDEN, jgart@HIDDEN
From: Vagrant Cascadian <vagrant@HIDDEN>
Date: Wed, 26 Feb 2025 14:11:03 -0800
Message-ID: <87jz9c73wo.fsf@wireframe>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="==-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Received-SPF: pass client-ip=173.255.214.101;
 envelope-from=vagrant@HIDDEN; helo=cascadia.aikidev.net
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

--==-=-=
Content-Type: multipart/mixed; boundary="=-=-="

--=-=-=
Content-Type: text/plain

Reprotest fails to run correctly due to files that are not marked
executable:

reprotest --verbose --vary=-fileordering,-domain_host,-user_group,-time -c 'date > date' . date -- null
WARNING:reprotest:The control build runs on 1 CPU by default, give --min-cpus to increase this.
WARNING:reprotest:diffoscope not available, falling back to regular diff
INFO:reprotest:STARTING VIRTUAL SERVER ['/gnu/store/7cglj9r39y4hfbwzd3rbh2rgl1yg343v-reprotest-0.7.28/lib/python3.10/site-packages/reprotest/virt/autopkgtest-virt-null']
Traceback (most recent call last):
  File "/gnu/store/7cglj9r39y4hfbwzd3rbh2rgl1yg343v-reprotest-0.7.28/lib/python3.10/site-packages/reprotest/__init__.py", line 862, in run
    return 0 if check_func(*check_args) else 1
  File "/gnu/store/7cglj9r39y4hfbwzd3rbh2rgl1yg343v-reprotest-0.7.28/lib/python3.10/site-packages/reprotest/__init__.py", line 370, in check
    proc = test_args._replace(result_dir=result_dir).corun_builds(testbed_args)
  File "/gnu/store/7cglj9r39y4hfbwzd3rbh2rgl1yg343v-reprotest-0.7.28/lib/python3.10/site-packages/reprotest/__init__.py", line 114, in start
    next(cr)
  File "/gnu/store/7cglj9r39y4hfbwzd3rbh2rgl1yg343v-reprotest-0.7.28/lib/python3.10/site-packages/reprotest/__init__.py", line 322, in corun_builds
    with start_testbed(virtual_server_args, temp_dir, no_clean_on_error,
  File "/gnu/store/50047r6f9chb6dwd01f9hai90y9arwb4-python-3.10.7/lib/python3.10/contextlib.py", line 135, in __enter__
    return next(self.gen)
  File "/gnu/store/7cglj9r39y4hfbwzd3rbh2rgl1yg343v-reprotest-0.7.28/lib/python3.10/site-packages/reprotest/__init__.py", line 85, in start_testbed
    testbed.start()
  File "/gnu/store/7cglj9r39y4hfbwzd3rbh2rgl1yg343v-reprotest-0.7.28/lib/python3.10/site-packages/reprotest/lib/adt_testbed.py", line 134, in start
    self.sp = subprocess.Popen(self.vserver_argv,
  File "/gnu/store/50047r6f9chb6dwd01f9hai90y9arwb4-python-3.10.7/lib/python3.10/subprocess.py", line 969, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/gnu/store/50047r6f9chb6dwd01f9hai90y9arwb4-python-3.10.7/lib/python3.10/subprocess.py", line 1845, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
PermissionError: [Errno 13] Permission denied: '/gnu/store/7cglj9r39y4hfbwzd3rbh2rgl1yg343v-reprotest-0.7.28/lib/python3.10/site-packages/reprotest/virt/autopkgtest-virt-null'

The reprotest version 0.7.21 included in guix v1.4.0 did have these
files marked executable, but for some reason in recent versions (maybe
changes in pyproject-build-system?), they are shipped without the
execute bit set. I have not git bisected between all the versions of
guix to see exactly where it starts failing.

CCed members of the python team if they have ideas about changes in the
build system which might cause the issue.

The attached patch marks the necessary files are executable with an
added phase. Open to refactorring the patch, but my guile skills are
quite limited and this works!


live well,
  vagrant

--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline;
 filename=0001-gnu-reprotest-Add-phase-fixing-executable-bit-on-vir.patch
Content-Transfer-Encoding: quoted-printable

From=205ed6bdda83e9e06f5984faac3d347b91438e9b04 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@HIDDEN>
Date: Wed, 26 Feb 2025 11:49:48 -0800
Subject: [PATCH] gnu: reprotest: Add phase fixing executable bit on virt
 files.

* gnu/packages/diffoscope.scm (reprotest): Add 'make-virt-files-executable
phase.
=2D--
 gnu/packages/diffoscope.scm | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/gnu/packages/diffoscope.scm b/gnu/packages/diffoscope.scm
index d0e911363d..90be6e68ec 100644
=2D-- a/gnu/packages/diffoscope.scm
+++ b/gnu/packages/diffoscope.scm
@@ -273,6 +273,13 @@ (define-public reprotest
       #:tests? #f
       #:phases
       #~(modify-phases %standard-phases
+          (add-after 'compress-documentation 'make-virt-files-executable
+            ;; The autopkgtest-virt- files need to be marked executable for
+            ;; reprotest to function correctly.
+            (lambda _
+              (for-each (lambda (file)
+                          (invoke "chmod" "+x" file))
+                        (find-files #$output "autopkgtest-virt-.*"))))
           (add-after 'install 'install-doc
             (lambda _
               (let* ((mandir1 (string-append

base-commit: 54ff5d33739ae95c19f4ed5bea38d2613f6f7d3c
=2D-=20
2.39.5


--=-=-=--

--==-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZ7+ReAAKCRDcUY/If5cW
qn3WAP9KkbpEZlSTUpQw5apcFCtQkhhj7GS/BGqfqw4xZWguowEA+9TPtpJ0Gqxi
5Z00KPmo3Nwqx9d6iaaviYHT4p5utQg=
=h8ZM
-----END PGP SIGNATURE-----
--==-=-=--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Vagrant Cascadian <vagrant@HIDDEN>
Subject: bug#76602: Acknowledgement (Reprotest fails to run due to missing
 execute bit)
Message-ID: <handler.76602.B.174060790426257.ack <at> debbugs.gnu.org>
References: <87jz9c73wo.fsf@wireframe>
X-Gnu-PR-Message: ack 76602
X-Gnu-PR-Package: guix-patches
Reply-To: 76602 <at> debbugs.gnu.org
Date: Wed, 26 Feb 2025 22:12:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 76602 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
76602: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D76602
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to guix-patches@HIDDEN:

Subject: [bug#76602] Reprotest fails to run due to missing execute bit
Resent-From: Lars-Dominik Braun <lars@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 28 Feb 2025 14:31:15 +0000
Resent-Message-ID: <handler.76602.B.174075307317947 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Vagrant Cascadian <vagrant@HIDDEN>
Cc: me@HIDDEN, jgart@HIDDEN, tanguy@HIDDEN, sharlatanus@HIDDEN, 76602 <at> debbugs.gnu.org
Date: Fri, 28 Feb 2025 15:30:17 +0100
From: Lars-Dominik Braun <lars@HIDDEN>
Message-ID: <Z8HIeQGvVEI_Eiar@HIDDEN>
References: <87jz9c73wo.fsf@wireframe>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <87jz9c73wo.fsf@wireframe>
Received-SPF: pass client-ip=80.241.56.172; envelope-from=lars@HIDDEN;
 helo=mout-p-202.mailbox.org
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,
 RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.3 (/)

Hi,

> The reprotest version 0.7.21 included in guix v1.4.0 did have these
> files marked executable, but for some reason in recent versions (maybe
> changes in pyproject-build-system?), they are shipped without the
> execute bit set. I have not git bisected between all the versions of
> guix to see exactly where it starts failing.

my best guess is that the package previously used python-build-system
instead of pyproject-build-system. The latter basically builds a zip file
(wheel) of everything and extracts it to site-packages. Zip files don’t
include the +x bit and so it gets lost in the process.

I believe this is a bug in the package. It should either indirectly call
these files via the python3 executable or mark them as entry points[1],
so pyproject-build-system can put an executable into /bin.

[1] https://setuptools.pypa.io/en/latest/userguide/entry_point.html

> The attached patch marks the necessary files are executable with an
> added phase. Open to refactorring the patch, but my guile skills are
> quite limited and this works!

Perhaps (chmod file #o755) instead of (invoke …)? Otherwise should be
fine to get it working again.

Cheers,
Lars

Message sent to guix-patches@HIDDEN:

Subject: [bug#76602] Reprotest fails to run due to missing execute bit
Resent-From: Vagrant Cascadian <vagrant@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 28 Feb 2025 21:51:02 +0000
Resent-Message-ID: <handler.76602.B76602.174077944129085 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Lars-Dominik Braun <lars@HIDDEN>
Cc: me@HIDDEN, jgart@HIDDEN, 76602 <at> debbugs.gnu.org, tanguy@HIDDEN, sharlatanus@HIDDEN
From: Vagrant Cascadian <vagrant@HIDDEN>
In-Reply-To: <Z8HIeQGvVEI_Eiar@HIDDEN>
References: <87jz9c73wo.fsf@wireframe> <Z8HIeQGvVEI_Eiar@HIDDEN>
Date: Fri, 28 Feb 2025 13:50:23 -0800
Message-ID: <87bjul7n8g.fsf@wireframe>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 2025-02-28, Lars-Dominik Braun wrote:
>> The reprotest version 0.7.21 included in guix v1.4.0 did have these
>> files marked executable, but for some reason in recent versions (maybe
>> changes in pyproject-build-system?), they are shipped without the
>> execute bit set. I have not git bisected between all the versions of
>> guix to see exactly where it starts failing.
>
> my best guess is that the package previously used python-build-system
> instead of pyproject-build-system. The latter basically builds a zip file
> (wheel) of everything and extracts it to site-packages. Zip files don=E2=
=80=99t
> include the +x bit and so it gets lost in the process.

Good hint! It was switched to pyproject-build-system in
d3bad46f990fbd884ca114dddd5af0eae434aecc ... and reverting that commit
does get it running again!

I have had a git bisect running in the background for days now to try
and identify the commit, as most of the builds fail, but can stop that
now! *sigh*


> I believe this is a bug in the package. It should either indirectly call
> these files via the python3 executable or mark them as entry points[1],
> so pyproject-build-system can put an executable into /bin.
>
> [1] https://setuptools.pypa.io/en/latest/userguide/entry_point.html

Will try to wrap my head around that and get it fixed upstream...


>> The attached patch marks the necessary files are executable with an
>> added phase. Open to refactorring the patch, but my guile skills are
>> quite limited and this works!
>
> Perhaps (chmod file #o755) instead of (invoke =E2=80=A6)? Otherwise shoul=
d be
> fine to get it working again.

Will try it! Thanks!


live well,
  vagrant

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZ8IvnwAKCRDcUY/If5cW
qoyPAQDEKQKXdPxfM18k1311LTTTgqJVSmSOatbYBBbNCFdTJwD7BSyCQKX1L1oN
MKfzqM+76jqHUcURdxnqcRdj5lsGsws=
=YsnO
-----END PGP SIGNATURE-----
--=-=-=--

Message sent:

MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Vagrant Cascadian <vagrant@HIDDEN>
Subject: bug#76602: closed (Reprotest fails to run due to missing execute bit)
CC: tracker <at> debbugs.gnu.org
Message-ID: <handler.76602.D76602.174086704832310.ackdone <at> debbugs.gnu.org>
References: <8734fw767c.fsf@wireframe> <87jz9c73wo.fsf@wireframe>
X-Gnu-PR-Message: closed 76602
X-Gnu-PR-Package: guix-patches
Date: Sat, 01 Mar 2025 22:11:01 +0000
Content-Type: multipart/mixed; boundary="----------=_1740867061-32369-0"

This is a multi-part message in MIME format...

------------=_1740867061-32369-0
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=utf-8

Your message dated Sat, 01 Mar 2025 14:10:31 -0800
with message-id <8734fw767c.fsf@wireframe>
and subject line Re: Reprotest fails to run due to missing execute bit
has caused the debbugs.gnu.org bug report #76602,
regarding Reprotest fails to run due to missing execute bit
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@HIDDEN)


--=20
76602: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D76602
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

------------=_1740867061-32369-0
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

Received: (at submit) by debbugs.gnu.org; 26 Feb 2025 22:11:44 +0000
Received: from localhost ([127.0.0.1]:55899 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tnPd2-0006pQ-3f
	for submit <at> debbugs.gnu.org; Wed, 26 Feb 2025 17:11:44 -0500
Received: from lists.gnu.org ([2001:470:142::17]:42150)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <vagrant@HIDDEN>)
 id 1tnPcx-0006p4-U2
 for submit <at> debbugs.gnu.org; Wed, 26 Feb 2025 17:11:41 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <vagrant@HIDDEN>)
 id 1tnPcd-000256-4C
 for guix-patches@HIDDEN; Wed, 26 Feb 2025 17:11:27 -0500
Received: from cascadia.aikidev.net ([173.255.214.101])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <vagrant@HIDDEN>)
 id 1tnPcY-0003U1-8B
 for guix-patches@HIDDEN; Wed, 26 Feb 2025 17:11:16 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
 d=reproducible-builds.org; s=1.vagrant; t=1740607869;
 bh=6Wiyx0OZ3H22MWEwlz0VPfmM10122T34guqHp0QStOE=;
 h=From:To:Cc:Subject:Date:From;
 b=vpFejSMBKI5zvfPmqcSrzAjN4Ee+jC+paeFAd8dMmThRzg1WBw1i7munI3psx/nqB
 y3KlUW+c4FjFlclVHpJwkv/uE9SE++mnkAkOOzlPcHty/JCvMtgc1x/JIHJ7KUd2Qn
 A+bICjlyvUqx3MUqZK50Okj0LTGX+saCXsBAgFS2STxsczgIN9mgZNCmoHLNir9Yrr
 zUfn7LlFCQCz/AuzcYy5PMW87sCdAAiawiyNsiXyHt6gwiWWyr3Ei1eT7jBLNRtFJL
 8HFz10SSvhc7CcYHhm7bTEV05htkxxL57UfwvIbND6SssjirSfS+cKDLswnJppu2Hs
 hiaRCbqkjfmdQ==
Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:50])
 by cascadia.aikidev.net (Postfix) with ESMTPSA id 4CCDA309C;
 Wed, 26 Feb 2025 14:11:09 -0800 (PST)
From: Vagrant Cascadian <vagrant@HIDDEN>
To: guix-patches@HIDDEN
Subject: Reprotest fails to run due to missing execute bit
Date: Wed, 26 Feb 2025 14:11:03 -0800
Message-ID: <87jz9c73wo.fsf@wireframe>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="==-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Received-SPF: pass client-ip=173.255.214.101;
 envelope-from=vagrant@HIDDEN; helo=cascadia.aikidev.net
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
Cc: me@HIDDEN, tanguy@HIDDEN, lars@HIDDEN,
 sharlatanus@HIDDEN, jgart@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

--==-=-=
Content-Type: multipart/mixed; boundary="=-=-="

--=-=-=
Content-Type: text/plain

Reprotest fails to run correctly due to files that are not marked
executable:

reprotest --verbose --vary=-fileordering,-domain_host,-user_group,-time -c 'date > date' . date -- null
WARNING:reprotest:The control build runs on 1 CPU by default, give --min-cpus to increase this.
WARNING:reprotest:diffoscope not available, falling back to regular diff
INFO:reprotest:STARTING VIRTUAL SERVER ['/gnu/store/7cglj9r39y4hfbwzd3rbh2rgl1yg343v-reprotest-0.7.28/lib/python3.10/site-packages/reprotest/virt/autopkgtest-virt-null']
Traceback (most recent call last):
  File "/gnu/store/7cglj9r39y4hfbwzd3rbh2rgl1yg343v-reprotest-0.7.28/lib/python3.10/site-packages/reprotest/__init__.py", line 862, in run
    return 0 if check_func(*check_args) else 1
  File "/gnu/store/7cglj9r39y4hfbwzd3rbh2rgl1yg343v-reprotest-0.7.28/lib/python3.10/site-packages/reprotest/__init__.py", line 370, in check
    proc = test_args._replace(result_dir=result_dir).corun_builds(testbed_args)
  File "/gnu/store/7cglj9r39y4hfbwzd3rbh2rgl1yg343v-reprotest-0.7.28/lib/python3.10/site-packages/reprotest/__init__.py", line 114, in start
    next(cr)
  File "/gnu/store/7cglj9r39y4hfbwzd3rbh2rgl1yg343v-reprotest-0.7.28/lib/python3.10/site-packages/reprotest/__init__.py", line 322, in corun_builds
    with start_testbed(virtual_server_args, temp_dir, no_clean_on_error,
  File "/gnu/store/50047r6f9chb6dwd01f9hai90y9arwb4-python-3.10.7/lib/python3.10/contextlib.py", line 135, in __enter__
    return next(self.gen)
  File "/gnu/store/7cglj9r39y4hfbwzd3rbh2rgl1yg343v-reprotest-0.7.28/lib/python3.10/site-packages/reprotest/__init__.py", line 85, in start_testbed
    testbed.start()
  File "/gnu/store/7cglj9r39y4hfbwzd3rbh2rgl1yg343v-reprotest-0.7.28/lib/python3.10/site-packages/reprotest/lib/adt_testbed.py", line 134, in start
    self.sp = subprocess.Popen(self.vserver_argv,
  File "/gnu/store/50047r6f9chb6dwd01f9hai90y9arwb4-python-3.10.7/lib/python3.10/subprocess.py", line 969, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/gnu/store/50047r6f9chb6dwd01f9hai90y9arwb4-python-3.10.7/lib/python3.10/subprocess.py", line 1845, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
PermissionError: [Errno 13] Permission denied: '/gnu/store/7cglj9r39y4hfbwzd3rbh2rgl1yg343v-reprotest-0.7.28/lib/python3.10/site-packages/reprotest/virt/autopkgtest-virt-null'

The reprotest version 0.7.21 included in guix v1.4.0 did have these
files marked executable, but for some reason in recent versions (maybe
changes in pyproject-build-system?), they are shipped without the
execute bit set. I have not git bisected between all the versions of
guix to see exactly where it starts failing.

CCed members of the python team if they have ideas about changes in the
build system which might cause the issue.

The attached patch marks the necessary files are executable with an
added phase. Open to refactorring the patch, but my guile skills are
quite limited and this works!


live well,
  vagrant

--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline;
 filename=0001-gnu-reprotest-Add-phase-fixing-executable-bit-on-vir.patch
Content-Transfer-Encoding: quoted-printable

From=205ed6bdda83e9e06f5984faac3d347b91438e9b04 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@HIDDEN>
Date: Wed, 26 Feb 2025 11:49:48 -0800
Subject: [PATCH] gnu: reprotest: Add phase fixing executable bit on virt
 files.

* gnu/packages/diffoscope.scm (reprotest): Add 'make-virt-files-executable
phase.
=2D--
 gnu/packages/diffoscope.scm | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/gnu/packages/diffoscope.scm b/gnu/packages/diffoscope.scm
index d0e911363d..90be6e68ec 100644
=2D-- a/gnu/packages/diffoscope.scm
+++ b/gnu/packages/diffoscope.scm
@@ -273,6 +273,13 @@ (define-public reprotest
       #:tests? #f
       #:phases
       #~(modify-phases %standard-phases
+          (add-after 'compress-documentation 'make-virt-files-executable
+            ;; The autopkgtest-virt- files need to be marked executable for
+            ;; reprotest to function correctly.
+            (lambda _
+              (for-each (lambda (file)
+                          (invoke "chmod" "+x" file))
+                        (find-files #$output "autopkgtest-virt-.*"))))
           (add-after 'install 'install-doc
             (lambda _
               (let* ((mandir1 (string-append

base-commit: 54ff5d33739ae95c19f4ed5bea38d2613f6f7d3c
=2D-=20
2.39.5


--=-=-=--

--==-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZ7+ReAAKCRDcUY/If5cW
qn3WAP9KkbpEZlSTUpQw5apcFCtQkhhj7GS/BGqfqw4xZWguowEA+9TPtpJ0Gqxi
5Z00KPmo3Nwqx9d6iaaviYHT4p5utQg=
=h8ZM
-----END PGP SIGNATURE-----
--==-=-=--



------------=_1740867061-32369-0
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

Received: (at 76602-done) by debbugs.gnu.org; 1 Mar 2025 22:10:48 +0000
Received: from localhost ([127.0.0.1]:45609 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1toV2l-0008P2-LI
	for submit <at> debbugs.gnu.org; Sat, 01 Mar 2025 17:10:48 -0500
Received: from cascadia.aikidev.net ([173.255.214.101]:41474)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <vagrant@HIDDEN>)
 id 1toV2g-0008Nz-Ux
 for 76602-done <at> debbugs.gnu.org; Sat, 01 Mar 2025 17:10:45 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
 d=reproducible-builds.org; s=1.vagrant; t=1740867036;
 bh=S7ceI2WgEyjbfOQ3Iz/ulvym8pjelTO4D1VX+tAhiVY=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=BxGrpjG7xcG36+DFWOGNKl55awm3a9ZovE3ff8QcznSl00LG7S2qEHYt04RYwLs26
 O/inj+sZQn5lb1B4RwY9AnzBHIXFUDTu3JI5dw0/v/WtW3e1nUr8/3T1NFzC83J834
 pudh7uLj+w6XLWlJJv3H9HRSt2gOw7KjWS82rbQTfbNjMsGkBvEWLmjNzkeW8BS0s2
 orvCtYEumWgha0AEF+DafiwCA5M0IdB+Ulg4t49Sv3gZlioXbpyeSAkf5P8SoRD+1z
 r9Na2KrkwvmzrafnVrlWiaNLfLeh/QLwnJuTfJF6gsMGYmdRG9xs2xQQMwEEa+oJEr
 3eWMMT9Alo8WA==
Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:50])
 by cascadia.aikidev.net (Postfix) with ESMTPSA id 2B5AF3140;
 Sat,  1 Mar 2025 14:10:36 -0800 (PST)
From: Vagrant Cascadian <vagrant@HIDDEN>
To: Lars-Dominik Braun <lars@HIDDEN>
Subject: Re: Reprotest fails to run due to missing execute bit
In-Reply-To: <87bjul7n8g.fsf@wireframe>
References: <87jz9c73wo.fsf@wireframe> <Z8HIeQGvVEI_Eiar@HIDDEN>
 <87bjul7n8g.fsf@wireframe>
Date: Sat, 01 Mar 2025 14:10:31 -0800
Message-ID: <8734fw767c.fsf@wireframe>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 76602-done
Cc: me@HIDDEN, jgart@HIDDEN, 76602-done <at> debbugs.gnu.org,
 tanguy@HIDDEN, sharlatanus@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 2025-02-28, Vagrant Cascadian wrote:
> On 2025-02-28, Lars-Dominik Braun wrote:
>>> The reprotest version 0.7.21 included in guix v1.4.0 did have these
>>> files marked executable, but for some reason in recent versions (maybe
>>> changes in pyproject-build-system?), they are shipped without the
>>> execute bit set. I have not git bisected between all the versions of
>>> guix to see exactly where it starts failing.
>>
>> my best guess is that the package previously used python-build-system
>> instead of pyproject-build-system. The latter basically builds a zip file
>> (wheel) of everything and extracts it to site-packages. Zip files don=E2=
=80=99t
>> include the +x bit and so it gets lost in the process.
>
> Good hint! It was switched to pyproject-build-system in
> d3bad46f990fbd884ca114dddd5af0eae434aecc ... and reverting that commit
> does get it running again!
>
> I have had a git bisect running in the background for days now to try
> and identify the commit, as most of the builds fail, but can stop that
> now! *sigh*
>
>
>> I believe this is a bug in the package. It should either indirectly call
>> these files via the python3 executable or mark them as entry points[1],
>> so pyproject-build-system can put an executable into /bin.
>>
>> [1] https://setuptools.pypa.io/en/latest/userguide/entry_point.html
>
> Will try to wrap my head around that and get it fixed upstream...

Still should do this at some point...


>>> The attached patch marks the necessary files are executable with an
>>> added phase. Open to refactorring the patch, but my guile skills are
>>> quite limited and this works!
>>
>> Perhaps (chmod file #o755) instead of (invoke =E2=80=A6)? Otherwise shou=
ld be
>> fine to get it working again.
>
> Will try it! Thanks!

Pushed as:

2558392803663f4381fa9c09a53d329b719152bd gnu: reprotest: Add phase fixing e=
xecutable bit on virt files.

Thanks for your help!

live well,
  vagrant

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZ8OF1wAKCRDcUY/If5cW
qgRnAQCiV9rMG07o1fOPlKHkPCJCL7BoJL+m/r/O/RkyrNotEgD9FMasOcXjvhCZ
mRB9WBgbVp5xGWHFDIgYkIz2Qt5AkA8=
=r4XN
-----END PGP SIGNATURE-----
--=-=-=--


------------=_1740867061-32369-0--

Message sent:

MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Vagrant Cascadian <vagrant@HIDDEN>
Subject: bug#76602: closed (Re: Reprotest fails to run due to missing
 execute bit)
Message-ID: <handler.76602.D76602.174086704832310.notifdone <at> debbugs.gnu.org>
References: <8734fw767c.fsf@wireframe> <87jz9c73wo.fsf@wireframe>
X-Gnu-PR-Message: they-closed 76602
X-Gnu-PR-Package: guix-patches
Reply-To: 76602 <at> debbugs.gnu.org
Date: Sat, 01 Mar 2025 22:11:02 +0000
Content-Type: multipart/mixed; boundary="----------=_1740867062-32369-1"

This is a multi-part message in MIME format...

------------=_1740867062-32369-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"

Your bug report

#76602: Reprotest fails to run due to missing execute bit

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 76602 <at> debbugs.gnu.org.

--=20
76602: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D76602
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

------------=_1740867062-32369-1
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

Received: (at 76602-done) by debbugs.gnu.org; 1 Mar 2025 22:10:48 +0000
Received: from localhost ([127.0.0.1]:45609 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1toV2l-0008P2-LI
	for submit <at> debbugs.gnu.org; Sat, 01 Mar 2025 17:10:48 -0500
Received: from cascadia.aikidev.net ([173.255.214.101]:41474)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <vagrant@HIDDEN>)
 id 1toV2g-0008Nz-Ux
 for 76602-done <at> debbugs.gnu.org; Sat, 01 Mar 2025 17:10:45 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
 d=reproducible-builds.org; s=1.vagrant; t=1740867036;
 bh=S7ceI2WgEyjbfOQ3Iz/ulvym8pjelTO4D1VX+tAhiVY=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=BxGrpjG7xcG36+DFWOGNKl55awm3a9ZovE3ff8QcznSl00LG7S2qEHYt04RYwLs26
 O/inj+sZQn5lb1B4RwY9AnzBHIXFUDTu3JI5dw0/v/WtW3e1nUr8/3T1NFzC83J834
 pudh7uLj+w6XLWlJJv3H9HRSt2gOw7KjWS82rbQTfbNjMsGkBvEWLmjNzkeW8BS0s2
 orvCtYEumWgha0AEF+DafiwCA5M0IdB+Ulg4t49Sv3gZlioXbpyeSAkf5P8SoRD+1z
 r9Na2KrkwvmzrafnVrlWiaNLfLeh/QLwnJuTfJF6gsMGYmdRG9xs2xQQMwEEa+oJEr
 3eWMMT9Alo8WA==
Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:50])
 by cascadia.aikidev.net (Postfix) with ESMTPSA id 2B5AF3140;
 Sat,  1 Mar 2025 14:10:36 -0800 (PST)
From: Vagrant Cascadian <vagrant@HIDDEN>
To: Lars-Dominik Braun <lars@HIDDEN>
Subject: Re: Reprotest fails to run due to missing execute bit
In-Reply-To: <87bjul7n8g.fsf@wireframe>
References: <87jz9c73wo.fsf@wireframe> <Z8HIeQGvVEI_Eiar@HIDDEN>
 <87bjul7n8g.fsf@wireframe>
Date: Sat, 01 Mar 2025 14:10:31 -0800
Message-ID: <8734fw767c.fsf@wireframe>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 76602-done
Cc: me@HIDDEN, jgart@HIDDEN, 76602-done <at> debbugs.gnu.org,
 tanguy@HIDDEN, sharlatanus@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 2025-02-28, Vagrant Cascadian wrote:
> On 2025-02-28, Lars-Dominik Braun wrote:
>>> The reprotest version 0.7.21 included in guix v1.4.0 did have these
>>> files marked executable, but for some reason in recent versions (maybe
>>> changes in pyproject-build-system?), they are shipped without the
>>> execute bit set. I have not git bisected between all the versions of
>>> guix to see exactly where it starts failing.
>>
>> my best guess is that the package previously used python-build-system
>> instead of pyproject-build-system. The latter basically builds a zip file
>> (wheel) of everything and extracts it to site-packages. Zip files don=E2=
=80=99t
>> include the +x bit and so it gets lost in the process.
>
> Good hint! It was switched to pyproject-build-system in
> d3bad46f990fbd884ca114dddd5af0eae434aecc ... and reverting that commit
> does get it running again!
>
> I have had a git bisect running in the background for days now to try
> and identify the commit, as most of the builds fail, but can stop that
> now! *sigh*
>
>
>> I believe this is a bug in the package. It should either indirectly call
>> these files via the python3 executable or mark them as entry points[1],
>> so pyproject-build-system can put an executable into /bin.
>>
>> [1] https://setuptools.pypa.io/en/latest/userguide/entry_point.html
>
> Will try to wrap my head around that and get it fixed upstream...

Still should do this at some point...


>>> The attached patch marks the necessary files are executable with an
>>> added phase. Open to refactorring the patch, but my guile skills are
>>> quite limited and this works!
>>
>> Perhaps (chmod file #o755) instead of (invoke =E2=80=A6)? Otherwise shou=
ld be
>> fine to get it working again.
>
> Will try it! Thanks!

Pushed as:

2558392803663f4381fa9c09a53d329b719152bd gnu: reprotest: Add phase fixing e=
xecutable bit on virt files.

Thanks for your help!

live well,
  vagrant

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZ8OF1wAKCRDcUY/If5cW
qgRnAQCiV9rMG07o1fOPlKHkPCJCL7BoJL+m/r/O/RkyrNotEgD9FMasOcXjvhCZ
mRB9WBgbVp5xGWHFDIgYkIz2Qt5AkA8=
=r4XN
-----END PGP SIGNATURE-----
--=-=-=--


------------=_1740867062-32369-1
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

Received: (at submit) by debbugs.gnu.org; 26 Feb 2025 22:11:44 +0000
Received: from localhost ([127.0.0.1]:55899 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tnPd2-0006pQ-3f
	for submit <at> debbugs.gnu.org; Wed, 26 Feb 2025 17:11:44 -0500
Received: from lists.gnu.org ([2001:470:142::17]:42150)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <vagrant@HIDDEN>)
 id 1tnPcx-0006p4-U2
 for submit <at> debbugs.gnu.org; Wed, 26 Feb 2025 17:11:41 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <vagrant@HIDDEN>)
 id 1tnPcd-000256-4C
 for guix-patches@HIDDEN; Wed, 26 Feb 2025 17:11:27 -0500
Received: from cascadia.aikidev.net ([173.255.214.101])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <vagrant@HIDDEN>)
 id 1tnPcY-0003U1-8B
 for guix-patches@HIDDEN; Wed, 26 Feb 2025 17:11:16 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
 d=reproducible-builds.org; s=1.vagrant; t=1740607869;
 bh=6Wiyx0OZ3H22MWEwlz0VPfmM10122T34guqHp0QStOE=;
 h=From:To:Cc:Subject:Date:From;
 b=vpFejSMBKI5zvfPmqcSrzAjN4Ee+jC+paeFAd8dMmThRzg1WBw1i7munI3psx/nqB
 y3KlUW+c4FjFlclVHpJwkv/uE9SE++mnkAkOOzlPcHty/JCvMtgc1x/JIHJ7KUd2Qn
 A+bICjlyvUqx3MUqZK50Okj0LTGX+saCXsBAgFS2STxsczgIN9mgZNCmoHLNir9Yrr
 zUfn7LlFCQCz/AuzcYy5PMW87sCdAAiawiyNsiXyHt6gwiWWyr3Ei1eT7jBLNRtFJL
 8HFz10SSvhc7CcYHhm7bTEV05htkxxL57UfwvIbND6SssjirSfS+cKDLswnJppu2Hs
 hiaRCbqkjfmdQ==
Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:50])
 by cascadia.aikidev.net (Postfix) with ESMTPSA id 4CCDA309C;
 Wed, 26 Feb 2025 14:11:09 -0800 (PST)
From: Vagrant Cascadian <vagrant@HIDDEN>
To: guix-patches@HIDDEN
Subject: Reprotest fails to run due to missing execute bit
Date: Wed, 26 Feb 2025 14:11:03 -0800
Message-ID: <87jz9c73wo.fsf@wireframe>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="==-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Received-SPF: pass client-ip=173.255.214.101;
 envelope-from=vagrant@HIDDEN; helo=cascadia.aikidev.net
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
Cc: me@HIDDEN, tanguy@HIDDEN, lars@HIDDEN,
 sharlatanus@HIDDEN, jgart@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

--==-=-=
Content-Type: multipart/mixed; boundary="=-=-="

--=-=-=
Content-Type: text/plain

Reprotest fails to run correctly due to files that are not marked
executable:

reprotest --verbose --vary=-fileordering,-domain_host,-user_group,-time -c 'date > date' . date -- null
WARNING:reprotest:The control build runs on 1 CPU by default, give --min-cpus to increase this.
WARNING:reprotest:diffoscope not available, falling back to regular diff
INFO:reprotest:STARTING VIRTUAL SERVER ['/gnu/store/7cglj9r39y4hfbwzd3rbh2rgl1yg343v-reprotest-0.7.28/lib/python3.10/site-packages/reprotest/virt/autopkgtest-virt-null']
Traceback (most recent call last):
  File "/gnu/store/7cglj9r39y4hfbwzd3rbh2rgl1yg343v-reprotest-0.7.28/lib/python3.10/site-packages/reprotest/__init__.py", line 862, in run
    return 0 if check_func(*check_args) else 1
  File "/gnu/store/7cglj9r39y4hfbwzd3rbh2rgl1yg343v-reprotest-0.7.28/lib/python3.10/site-packages/reprotest/__init__.py", line 370, in check
    proc = test_args._replace(result_dir=result_dir).corun_builds(testbed_args)
  File "/gnu/store/7cglj9r39y4hfbwzd3rbh2rgl1yg343v-reprotest-0.7.28/lib/python3.10/site-packages/reprotest/__init__.py", line 114, in start
    next(cr)
  File "/gnu/store/7cglj9r39y4hfbwzd3rbh2rgl1yg343v-reprotest-0.7.28/lib/python3.10/site-packages/reprotest/__init__.py", line 322, in corun_builds
    with start_testbed(virtual_server_args, temp_dir, no_clean_on_error,
  File "/gnu/store/50047r6f9chb6dwd01f9hai90y9arwb4-python-3.10.7/lib/python3.10/contextlib.py", line 135, in __enter__
    return next(self.gen)
  File "/gnu/store/7cglj9r39y4hfbwzd3rbh2rgl1yg343v-reprotest-0.7.28/lib/python3.10/site-packages/reprotest/__init__.py", line 85, in start_testbed
    testbed.start()
  File "/gnu/store/7cglj9r39y4hfbwzd3rbh2rgl1yg343v-reprotest-0.7.28/lib/python3.10/site-packages/reprotest/lib/adt_testbed.py", line 134, in start
    self.sp = subprocess.Popen(self.vserver_argv,
  File "/gnu/store/50047r6f9chb6dwd01f9hai90y9arwb4-python-3.10.7/lib/python3.10/subprocess.py", line 969, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/gnu/store/50047r6f9chb6dwd01f9hai90y9arwb4-python-3.10.7/lib/python3.10/subprocess.py", line 1845, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
PermissionError: [Errno 13] Permission denied: '/gnu/store/7cglj9r39y4hfbwzd3rbh2rgl1yg343v-reprotest-0.7.28/lib/python3.10/site-packages/reprotest/virt/autopkgtest-virt-null'

The reprotest version 0.7.21 included in guix v1.4.0 did have these
files marked executable, but for some reason in recent versions (maybe
changes in pyproject-build-system?), they are shipped without the
execute bit set. I have not git bisected between all the versions of
guix to see exactly where it starts failing.

CCed members of the python team if they have ideas about changes in the
build system which might cause the issue.

The attached patch marks the necessary files are executable with an
added phase. Open to refactorring the patch, but my guile skills are
quite limited and this works!


live well,
  vagrant

--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline;
 filename=0001-gnu-reprotest-Add-phase-fixing-executable-bit-on-vir.patch
Content-Transfer-Encoding: quoted-printable

From=205ed6bdda83e9e06f5984faac3d347b91438e9b04 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@HIDDEN>
Date: Wed, 26 Feb 2025 11:49:48 -0800
Subject: [PATCH] gnu: reprotest: Add phase fixing executable bit on virt
 files.

* gnu/packages/diffoscope.scm (reprotest): Add 'make-virt-files-executable
phase.
=2D--
 gnu/packages/diffoscope.scm | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/gnu/packages/diffoscope.scm b/gnu/packages/diffoscope.scm
index d0e911363d..90be6e68ec 100644
=2D-- a/gnu/packages/diffoscope.scm
+++ b/gnu/packages/diffoscope.scm
@@ -273,6 +273,13 @@ (define-public reprotest
       #:tests? #f
       #:phases
       #~(modify-phases %standard-phases
+          (add-after 'compress-documentation 'make-virt-files-executable
+            ;; The autopkgtest-virt- files need to be marked executable for
+            ;; reprotest to function correctly.
+            (lambda _
+              (for-each (lambda (file)
+                          (invoke "chmod" "+x" file))
+                        (find-files #$output "autopkgtest-virt-.*"))))
           (add-after 'install 'install-doc
             (lambda _
               (let* ((mandir1 (string-append

base-commit: 54ff5d33739ae95c19f4ed5bea38d2613f6f7d3c
=2D-=20
2.39.5


--=-=-=--

--==-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZ7+ReAAKCRDcUY/If5cW
qn3WAP9KkbpEZlSTUpQw5apcFCtQkhhj7GS/BGqfqw4xZWguowEA+9TPtpJ0Gqxi
5Z00KPmo3Nwqx9d6iaaviYHT4p5utQg=
=h8ZM
-----END PGP SIGNATURE-----
--==-=-=--



------------=_1740867062-32369-1--

Last modified: Sat, 1 Mar 2025 22:15:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.