GNU bug report logs - #76732
30.1; image-dired fails with files with only open bracket

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Reported by: Sanel Zukan <sanelz@HIDDEN>; Done: Stefan Kangas <stefankangas@HIDDEN>; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 76732-done <at> debbugs.gnu.org:


Received: (at 76732-done) by debbugs.gnu.org; 4 Mar 2025 10:00:05 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Mar 04 05:00:05 2025
Received: from localhost ([127.0.0.1]:55394 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tpP4H-0002hb-Es
	for submit <at> debbugs.gnu.org; Tue, 04 Mar 2025 05:00:05 -0500
Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]:44232)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
 id 1tpP4F-0002gV-C5
 for 76732-done <at> debbugs.gnu.org; Tue, 04 Mar 2025 05:00:04 -0500
Received: by mail-ed1-x52e.google.com with SMTP id
 4fb4d7f45d1cf-5e095d47a25so9698818a12.0
 for <76732-done <at> debbugs.gnu.org>; Tue, 04 Mar 2025 02:00:03 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1741082397; x=1741687197; darn=debbugs.gnu.org;
 h=to:subject:message-id:date:mime-version:references:in-reply-to:from
 :from:to:cc:subject:date:message-id:reply-to;
 bh=S5nR6k2FK3yLsm3hR2566QS81dU4gr1w+am69bd9fE0=;
 b=fvcgDw+E2fczDBifoJwCRk7kYjuJT5tlXXAkzi/9dgykV2lpJplxT1q6GxJF14qJ76
 069yfbKPCBdibntfd/WUASXwBWZx8Un7CDID7ePWML0dm9my/EGBFKWdJsmIvvn8oX7E
 sdTWpzgizrtSKvTVFsOWW+funXeeqxBwwDDd/+27ARyuapaDumrv/60jzetv6w5FMwhF
 up3R9LqosvDyTJ5H3kbe7orEfcTuWtV43tOmZ5d64oj4IukHJdSVTjoww2Exw2VzdGii
 s4yBxLYUQdPyT+kRLN9pn6XctRafZkFdCOxjc7Gx/KFXPZbn4fVzVNUPtCjsHoR9i6Uk
 tYmA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1741082397; x=1741687197;
 h=to:subject:message-id:date:mime-version:references:in-reply-to:from
 :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=S5nR6k2FK3yLsm3hR2566QS81dU4gr1w+am69bd9fE0=;
 b=vksAga20u76o/wSPkcUD9dyTgMUB6aw1EsNv+TD0HxeBSu8VrGgwq/pcP9+CPt/ZLr
 O5Dr61dZ6y2ztQdrmMKRFZ6kel4gPDis6C6uG2Gy8OyVWEFXcMlz19v32wPNSK99650m
 +j/mvUuxOR3PxmWiFumGWUHrnH4alPTQibEXqFa0srlzc4+IBA7b8vRvFnldizTBeLTG
 rMOMqfPC1KZpbe2SOybQTJi4lGMFfvEGPMhHyIpFaR8mmcNL7EYGLKLZptKW6WKMhNQ+
 3/EUx6Vy9lHXqhOz/sYSzePi2IuV1iOyMzZ1ngvq/mnQ9I7eZRri0KpftP0nTkiGCDPP
 FM9A==
X-Forwarded-Encrypted: i=1;
 AJvYcCUJUApaU8w6fxpV9daLZnnbA2H4gkU+dfweIUY4Bs5cwTi1s1m4/vfPgOny9N08gB3rtAPUhUt/22aa <at> debbugs.gnu.org
X-Gm-Message-State: AOJu0YyJO9Xjpe2PnfmHol4vUQUo/b0Cf6ALanunYbyyzzyZfnlXYHJE
 0a1tnliorqab6LwqlS0gBcgxXy9zsMRen/KvmMoGQdY5N8XVMcKKgIHa+K/4p0IKysV8+5/h6rV
 van1ceeSzly8kRB/mQs+UIVBptv8=
X-Gm-Gg: ASbGncvCln4LxE1wYOb9t+JbqVkxAk3+6XyMVcofObgeDBGUkEiaMaEBPZpirlz/SDk
 tb1CNYr5ckSuuWC3XhoPPOWuPlPze8nhIATEX5D98+d4TF3ttBTMcLw+bk7Jd08rqYEP8n2GuMt
 zVF/4EN7ks0AD1+ykDzw/Mg51fm6M=
X-Google-Smtp-Source: AGHT+IGVs56GllAiZG1HeG6FAsv2CZoAEn25fdSG2KbYhI338bsD6VjcuqZ76c3o7gv651ldpw0e+2Ga8pW9iHsWlWU=
X-Received: by 2002:a05:6402:1d4a:b0:5de:6486:3f52 with SMTP id
 4fb4d7f45d1cf-5e4d6ade29fmr15025314a12.9.1741082396698; Tue, 04 Mar 2025
 01:59:56 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Tue, 4 Mar 2025 01:59:56 -0800
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <87zfi14dve.fsf@HIDDEN>
References: <87zfi14dve.fsf@HIDDEN>
MIME-Version: 1.0
Date: Tue, 4 Mar 2025 01:59:56 -0800
X-Gm-Features: AQ5f1JrbX9vED4HWc-iRLsGpbxrBzqJG92XU-CLEHYryQJKxOdx704EL_R2mHm8
Message-ID: <CADwFkmn=WNR0-a3wecsYzwoZT3zScVhvn_7VRHwR9FyQxdUMFg@HIDDEN>
Subject: Re: bug#76732: 30.1;
 image-dired fails with files with only open bracket
To: Sanel Zukan <sanelz@HIDDEN>, 76732-done <at> debbugs.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 76732-done
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Sanel Zukan <sanelz@HIDDEN> writes:

> Hi,
>
> When image-dired is run on folder where at least one file has open
> bracket ('[') in it's name, without closing bracket, it will fail with
> this stacktrace:
>
> Debugger entered--Lisp error: (invalid-regexp "Unmatched [ or [^")
>   search-forward-regexp("^/home/user/ooo/[img.png" nil t)
>   image-dired-list-tags("/home/user/ooo/[img.png")
>   image-dired-insert-thumbnail("/home/user/.emacs.d/image-dired/7099b45a60beaf2cdfa5d644d7cc5ad99d915ca0.jpg" "/home/user/ooo/[img.png" #<buffer ooo>)
>   image-dired-display-thumbs()
>   image-dired("~/ooo/")
>   funcall-interactively(image-dired "~/ooo/")
>   call-interactively(image-dired record nil)
>   command-execute(image-dired record)
>   execute-extended-command(nil "image-dired" nil)
>   funcall-interactively(execute-extended-command nil "image-dired" nil)
>   call-interactively(execute-extended-command nil nil)
>   command-execute(execute-extended-command)
>
> To reproduce it:
>
>  1. Start Emacs with "emacs -Q"
>  2. Create temporary folder and copy one png file to it and rename it to
>  '[img.png'.
>  3. Try to open that folder with image-dired. You should get stacktrace
>  as above.
>
> It will fail also with files like 'im[g.png' but not with files with
> only closed bracket. E.g. this works: ']img.png' or 'im]g.png'.

Thanks for the bug report!

This is actually already fixed on master.  I have now backported the fix
to the emacs-30 branch, which means that it will be in Emacs 30.2.

I'm therefore closing this bug report.




Notification sent to Sanel Zukan <sanelz@HIDDEN>:
bug acknowledged by developer. Full text available.
Reply sent to Stefan Kangas <stefankangas@HIDDEN>:
You have taken responsibility. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 4 Mar 2025 04:30:54 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Mar 03 23:30:53 2025
Received: from localhost ([127.0.0.1]:54131 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tpJvh-0005tj-4K
	for submit <at> debbugs.gnu.org; Mon, 03 Mar 2025 23:30:53 -0500
Received: from lists.gnu.org ([2001:470:142::17]:47304)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <sanelz@HIDDEN>) id 1tpJvc-0005Zj-Ne
 for submit <at> debbugs.gnu.org; Mon, 03 Mar 2025 23:30:50 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <sanelz@HIDDEN>) id 1tpJvM-0001fG-6B
 for bug-gnu-emacs@HIDDEN; Mon, 03 Mar 2025 23:30:33 -0500
Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <sanelz@HIDDEN>) id 1tpJuz-0002fW-MW
 for bug-gnu-emacs@HIDDEN; Mon, 03 Mar 2025 23:30:31 -0500
Received: by mail-ed1-x52e.google.com with SMTP id
 4fb4d7f45d1cf-5e4f5cc3172so5852497a12.0
 for <bug-gnu-emacs@HIDDEN>; Mon, 03 Mar 2025 20:30:02 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1741062600; x=1741667400; darn=gnu.org;
 h=mime-version:message-id:date:subject:to:from:from:to:cc:subject
 :date:message-id:reply-to;
 bh=7QuDrDNWEewi7Rz0Eq8pglT9NvHIQgjXF5OKDvQb3d4=;
 b=X4O7Cmgg4RsAS4JEzicjsfwRhD6vsHs29UDjAhKcPpt9RSaOP0LlGja9qBLlxP6elH
 p33Qp+AzuAMCV8v0IjAZIsjfaYb4B9E/L9ecoMQW+N0BynDTkGAzHJ3JKbuxSimQqd+b
 68c1uFSq3SSTHfXS4jyigJpfkAIwtZuM13RyP3cp5nouQ2YUydll/VfC73Iy2oQuDX2Z
 Bj0tibhAM3cTgERNmY7G6BXLpjcWZ5QxjGp0smez0ZmpjEE6piY3vS4eqy4DRtny2SJy
 9tQla6DDPf8XsRl/fA6KO/NWHHn+BnaUg/EPoubV+YLjL/EhvwbFbO27HkCsqok/TdCl
 lMMw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1741062600; x=1741667400;
 h=mime-version:message-id:date:subject:to:from:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=7QuDrDNWEewi7Rz0Eq8pglT9NvHIQgjXF5OKDvQb3d4=;
 b=l4VNO6OSPsRKxEqEzha4XcCS+pTBvou0VKYziqZzQWsuiNxazzyRAPfcbsVwJwxNS1
 NFruVBwLUM+MBq+z/lM9N7qcf7kUX7kWzszuE1wgK0uikPJc+WDJZsqN19T3zPH+wPoz
 t6EuKFhNl9Dt12jyAf7GGLJNPX2YHoaIkya/I3hc2RkMRnC2h4mtJBiAFe7TxiRlDCow
 p8BcAbLrL2NWJymRvR6HpuRd1GqN3pXY3NN4ac8d05jHY6qZG2RKXrvW+8EnJXSMeagL
 OwWtSxuXVE6niyg3j/AGcRk8RABtOcEROoMWmDCnPPelQ6l9qJ5RqtlZdCAwndbPtY43
 DNoQ==
X-Gm-Message-State: AOJu0Yx4f/P0Mt06oAo3TaPn3OG03dbEZAwewuKWP+ozLHx8cO1vmgGn
 qnOPD6YJXxyXjdZhZ5mpwbOjXIE/4zFXgdjcGysOSSQSsmKduhLiZ0vWXELN
X-Gm-Gg: ASbGncvewRRMdGiq/Bur3iLWR/OGmn9tUACnz5zOCkSCMYcyVJNgBKHd6VhQTTO8PUh
 Aqn6/6IpoS1e4dzhUHBJ0DMpCKslcMCw1lXHP53KM00CTiknc9NE4E9eIpjtaVl8WzJDBk/xZ66
 6L2fi4gGybv2SOScdAQC9SAUCXGsZVYrxa0yBegM7gMSUtUkZknBoBTvco8rwjmu1id8PT3cfS3
 rRi78o6O1LV9FDoovyUiNYBn9ukqqNTUhzI0zCF5qnCYJ1aycRG677XGA0vhP0e6IBOx1DZ3svx
 466ca4ReUHnzd8NCb0h87nKOgHqGn7Q5y63V
X-Google-Smtp-Source: AGHT+IHRh36gVF+r+BwfqnCJ97TOzj1J+Dvw8B2c8wj0tGwv3SJhhjD8E7/IdNHv4IocYEppcveNBg==
X-Received: by 2002:a05:6402:1e8a:b0:5de:39fd:b2f5 with SMTP id
 4fb4d7f45d1cf-5e4d6ac4237mr16149968a12.1.1741062599483; 
 Mon, 03 Mar 2025 20:29:59 -0800 (PST)
Received: from localhost ([46.36.160.183]) by smtp.gmail.com with ESMTPSA id
 4fb4d7f45d1cf-5e4c3b6dbbbsm7723458a12.22.2025.03.03.20.29.58
 for <bug-gnu-emacs@HIDDEN>
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 03 Mar 2025 20:29:58 -0800 (PST)
From: Sanel Zukan <sanelz@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 30.1; image-dired fails with files with only open bracket
X-Debbugs-Cc: 
Date: Tue, 04 Mar 2025 05:29:57 +0100
Message-ID: <87zfi14dve.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=2a00:1450:4864:20::52e;
 envelope-from=sanelz@HIDDEN; helo=mail-ed1-x52e.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

Hi,

When image-dired is run on folder where at least one file has open
bracket ('[') in it's name, without closing bracket, it will fail with
this stacktrace:

Debugger entered--Lisp error: (invalid-regexp "Unmatched [ or [^")
  search-forward-regexp("^/home/user/ooo/[img.png" nil t)
  image-dired-list-tags("/home/user/ooo/[img.png")
  image-dired-insert-thumbnail("/home/user/.emacs.d/image-dired/7099b45a60beaf2cdfa5d644d7cc5ad99d915ca0.jpg" "/home/user/ooo/[img.png" #<buffer ooo>)
  image-dired-display-thumbs()
  image-dired("~/ooo/")
  funcall-interactively(image-dired "~/ooo/")
  call-interactively(image-dired record nil)
  command-execute(image-dired record)
  execute-extended-command(nil "image-dired" nil)
  funcall-interactively(execute-extended-command nil "image-dired" nil)
  call-interactively(execute-extended-command nil nil)
  command-execute(execute-extended-command)

To reproduce it:

 1. Start Emacs with "emacs -Q"
 2. Create temporary folder and copy one png file to it and rename it to
 '[img.png'.
 3. Try to open that folder with image-dired. You should get stacktrace
 as above.

It will fail also with files like 'im[g.png' but not with files with
only closed bracket. E.g. this works: ']img.png' or 'im]g.png'.

Emacs details:

In GNU Emacs 30.1 (build 1, x86_64-slackware-linux-gnu, GTK+ Version
 3.24.31, cairo version 1.16.0) of 2025-02-26 built on
 z-mp.slackware.lan
Windowing system distributor 'The X.Org Foundation', version 11.0.12014000
System Description: Slackware 15.0 x86_64

Configured using:
 'configure --prefix=/usr --sysconfdir=/etc --localstatedir=/var
 --program-prefix= --program-suffix= --mandir=/usr/man
 --infodir=/usr/info --without-gconf --without-gsettings --with-modules
 --with-x --with-x-toolkit=gtk3 --with-pdumper=auto
 --without-native-compilation --build=x86_64-slackware-linux 'CFLAGS=-O2
 -fPIC''

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM HARFBUZZ JPEG LCMS2
LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3
THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB

Important settings:
  value of $LC_COLLATE: C
  value of $LANG: en_US.utf8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  minibuffer-regexp-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message mailcap yank-media puny dired
dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068
epg-config gnus-util text-property-search time-date subr-x mm-decode
mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader
cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util
mail-prsvr mail-utils rmc iso-transl tooltip cconv eldoc paren electric
uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel
term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset
image regexp-opt fringe tabulated-list replace newcomment text-mode
lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch
easymenu timer select scroll-bar mouse jit-lock font-lock syntax
font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
theme-loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind inotify lcms2
dynamic-setting font-render-setting cairo gtk x-toolkit xinput2 x
multi-tty move-toolbar make-network-process emacs)

Memory information:
((conses 16 38651 9082) (symbols 48 5368 0) (strings 32 12518 2548)
 (string-bytes 1 300947) (vectors 16 9239)
 (vector-slots 8 109765 4279) (floats 8 21 3) (intervals 56 244 3)
 (buffers 984 10))

Best,
Sanel




Acknowledgement sent to Sanel Zukan <sanelz@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#76732; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Tue, 4 Mar 2025 10:15:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.