GNU bug report logs - #76744
[PATCH] etags test doesn't pass

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Reported by: Vladimir Gorsunov <gorsunov@HIDDEN>; Keywords: patch; Done: Stefan Kangas <stefankangas@HIDDEN>; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 76744-done <at> debbugs.gnu.org:

Received: (at 76744-done) by debbugs.gnu.org; 10 Mar 2025 21:10:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Mar 10 17:10:27 2025
Received: from localhost ([127.0.0.1]:40152 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1trkOJ-00044p-1O
	for submit <at> debbugs.gnu.org; Mon, 10 Mar 2025 17:10:27 -0400
Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]:60567)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
 id 1trkOF-00044V-PV
 for 76744-done <at> debbugs.gnu.org; Mon, 10 Mar 2025 17:10:24 -0400
Received: by mail-ed1-x535.google.com with SMTP id
 4fb4d7f45d1cf-5e5bc066283so7298446a12.0
 for <76744-done <at> debbugs.gnu.org>; Mon, 10 Mar 2025 14:10:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1741641018; x=1742245818; darn=debbugs.gnu.org;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:from:to:cc:subject:date:message-id:reply-to;
 bh=nPp1hAK0qf2j4Dap+zz0kB7HteVhPB/OumHsC+08IH8=;
 b=PfUiZMwtoJ1sT03GrUxoDeb0hpimTRi1WgD7lHXDnOoTdLYDxHcVAe+1OYbsQaAWVv
 ctjhQBMHJKylTLpaGuIObBcEBOcOWz9gcHLPftxvxRovVB3a3Y071su7Y1Lq72Ice2qn
 xDdp71vLrxNgU0ywXrU/vGnp1FTFPDeK8meq7kIJNPfVML2lF7amDHUieBsFs6RvYp3u
 lhJMPJQ5wk//c7eJ6LgTt5zmcu0B6A/WEc4MrK8Sgy5kYazpz5AtjaTIwz35fqICADnA
 OOZ00CqS4BpRyw3umv3FH1etc23sRr1CFYhGBBpfyNi0ZvngIiR85yNHFW0U6QptoVNz
 onGg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1741641018; x=1742245818;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=nPp1hAK0qf2j4Dap+zz0kB7HteVhPB/OumHsC+08IH8=;
 b=hcfpMe65ShEws+rZmCqDOTW6NtvPL01+erPDDT6lcJw0E93edKo1Pg94d7ceMzPZXs
 PE5015rHOMbIgZyMqaDXtrHgxfAQ1na7r1J/SMnLCEovAvWOGHqerH1Wc/KSF3/tDc7X
 06hSmX0zYiXNNMvx4DAvEHESEXBSiFReSbTHt6JytjER7KjJqN4A+GdEZmiIEgVabbeF
 mjT98aKP95aJwSAs52laD5Imv8wB4wJbIBVeXlYtHjjPKHY4XvdkwxkaOJfaJHGZoS5b
 wYgbQ6SS569sTZPaFLi6A9xdI2Tbooq/RFxktbfvS4zsxg4FfJepDWOvQJ/oIncmDLUN
 r9+A==
X-Forwarded-Encrypted: i=1;
 AJvYcCWJYzZpScR/9DBoXBUq6W9e79fu4sbw8JOBtXmrCO/hnTYl06WQpoRRAzKvZ3O84gcmBg7CRQ68zh83 <at> debbugs.gnu.org
X-Gm-Message-State: AOJu0YztJDZ+vYS4DiV7yamMUhW0mWyLQfiYT8JeQlTW2UPEo3jIx7YM
 YzwLqy3oDkmLcR2gd0VUf1wwjn3KqA7GITZYuKMkGHjR8IIaYO/cVQL/SeqtYJ10EyeRFVCZPyD
 g8hhJtcufMSqGNQfA4GR6urQxYxY=
X-Gm-Gg: ASbGncvyor1ZIxzNtQ/EPfRx0SS5oezG2siWTB1kPTRwLtca6x0wsFCffiK/b27+zcw
 Ds0rTuXjv234EO44pPkLWP11mknZ2GbcymNV0VD2KoXgEKP/JyakY/x+5bZ4lgGnhhljy7AplDR
 JTqZ1B3PTGKrwtaaj+fabaKb0wbR4=
X-Google-Smtp-Source: AGHT+IHqH6pBa3FWIqlE10fII6fH3ST/o+sXBiKK/chKzYy+XXZPbhPoPyG9G0Oyk3j1/Kws0KNzU0nesj4wxtCg454=
X-Received: by 2002:a05:6402:354f:b0:5de:dd31:1fad with SMTP id
 4fb4d7f45d1cf-5e5e22b1bf7mr14020466a12.6.1741641017503; Mon, 10 Mar 2025
 14:10:17 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Mon, 10 Mar 2025 14:10:17 -0700
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <86wmd2mppt.fsf@HIDDEN>
References: <CAC6E6R=NhNdcngYqxhKhVJTH=hA=zY+SKquVZ9mO-PduK9HYXA@HIDDEN>
 <CADwFkm==-K8V+FRzN=hD7jtR9BGw9CnzR1+d8NixNmODUVoOVw@HIDDEN>
 <f5226b9a-97ea-4e15-b4bb-1a9669b140fb@HIDDEN> <86wmd2mppt.fsf@HIDDEN>
MIME-Version: 1.0
Date: Mon, 10 Mar 2025 14:10:17 -0700
X-Gm-Features: AQ5f1JoYI7-peTIx0EQNU0jKp8bnZT2VyA3L8njtMb_NtWdnUaZ1lc28rBmOkM0
Message-ID: <CADwFkmk3+83_v-A5MhU6AnyZ2MG4Vf24NetquWXTBWy8yzRaNA@HIDDEN>
Subject: Re: bug#76744: [PATCH] etags test doesn't pass
To: Eli Zaretskii <eliz@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 76744-done
Cc: gorsunov@HIDDEN, 76744-done <at> debbugs.gnu.org,
 Paul Eggert <eggert@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Eli Zaretskii <eliz@HIDDEN> writes:

>> Cc: Vladimir Gorsunov <gorsunov@HIDDEN>, 76744 <at> debbugs.gnu.org
>> Date: Tue, 4 Mar 2025 13:48:51 -0800
>> From: Paul Eggert <eggert@HIDDEN>
>>
>> On 3/4/25 11:22, Stefan Kangas wrote:
>> >> * build-aux/update-copyright: Added check to not change test data
>> > This script is maintained in Gnulib, so I'm not sure where to put this,
>> > as it's only relevant to Emacs.
>>
>> Yes, changes like this should be put into admin/update-copyright, not
>> build-aux/update-copyright.
>>
>> However, this kind of change is heading in the wrong direction, as the
>> test files in question mutate from time to time, e.g., commit
>> d0be0965ca344caab7879b2ac2373a68025c9ba2. Instead, either the tests
>> should be redone to be robust in the presence of line number changes, or
>> (probably easier) admin/update-copyright should be taught not to change
>> the number of lines when it updates a copyright date.
>
> For now, I simply updated the expected-results files in
> test/manual/etags/.  This is what we've been doing this since these
> tests were added.  If someone wants to modify the update-copyright
> scripts to skip those files, feel free, but TBH I'm not sure we are
> allowed not to update the copyright of test files.

I'd tend to agree.  I'm therefore closing this bug report.

Thanks Vladimir for the patches, nevertheless.

Notification sent to Vladimir Gorsunov <gorsunov@HIDDEN>:
bug acknowledged by developer. Full text available.

Reply sent to Stefan Kangas <stefankangas@HIDDEN>:
You have taken responsibility. Full text available.