Received: (at 76839) by debbugs.gnu.org; 22 Mar 2025 11:18:04 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Mar 22 07:18:04 2025 Received: from localhost ([127.0.0.1]:41098 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tvwrb-0006yW-PR for submit <at> debbugs.gnu.org; Sat, 22 Mar 2025 07:18:04 -0400 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]:46483) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1tvwra-0006xu-Op for 76839 <at> debbugs.gnu.org; Sat, 22 Mar 2025 07:18:03 -0400 Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-5e5b6f3025dso4275168a12.1 for <76839 <at> debbugs.gnu.org>; Sat, 22 Mar 2025 04:18:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742642276; x=1743247076; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date:message-id:reply-to; bh=3ESfiZiUUjKoAVnFp42i8SGww4ApnLbtj14PgezdyQo=; b=DjM5uF/5k0Qr0L2VXEDRVmvhXMDL0s6NokzT3qSn8CHb8gKtoKejhgtXhoKB/mWrlf kAy4PWJM4VzOx1rpPcdnd4ep2tPIG2fVLNJh8jCD8wR3m3YeDtKet8t6cskPRdL9mcNs odkI7bcYdlCiikAkqKbDB4GdZzpt38J5G8ZaYg6xSKub32+3XrLUi5tQ5qbEzxDzt1wn CSBBazahL+BkQmQoUenYOOGp/zscnJv881n1TCuUQT/K7wkH3prZ54WDmH1eMsey1tyV bkllI92Cmivx1aOml4ndQ05fu/08HCJt1VVe71cf+YtafjsoR2UeLNEMGB9kRPAnaXiN schA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742642276; x=1743247076; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3ESfiZiUUjKoAVnFp42i8SGww4ApnLbtj14PgezdyQo=; b=ZhkMysK1EjDSH4mpT24mN2AocHmiEL36fm6HFvAlJyfK+qWRzchRNqywdlroOERw28 rZE7qasf4DtNnH+/BrxEZ/7t3SFsBs0woxvoMmDZbuGI6/lZ+ob4XRjsYZdNVdPtjYil G0JdB06IZjtJOPdigWVheKeqa+xq5MzsTZMU0v9LJzW2N8JyeP340oCQut/C8+Q48SPM bUvLjf7gTmODvUShRyBHv32EZJkoN7F6Q9wQHripIDUSKQXE/zB+jq/HEMJtpVyNTpEv FgXhlCz6sTVuYmSg2DplcEePPszH0MR+tUapf5Xewl5/wDqxCtdVnEW+mQWBBn/z4uPz L+2A== X-Forwarded-Encrypted: i=1; AJvYcCUOOV7T66PJnfldcPMS2ZM/HC+OolPnUDIQMCZl6I4UNeFgj1qafLmE5rZuC5E9slUR4qLrbA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwLtAx0VoS4W5VAp21TjLXCIpneUKtj6HMpp4YrRs7WdMJ00Zwy 9fqszWnHd0kMq2hOLdMDuYGf5bBS60FyaYRP2TeT9ZoMUUElQl/JVDnQL59kpGYLNrrw/T3T+7R xJ+mmIy9FfyMJzvDgCjaLTeXz8/c= X-Gm-Gg: ASbGncuNR9Wj2bTtvWNJTKs3lcj3CHpBFdRQoZ8VhTXQBOxLlUVppZuSkI1fNj96Lb9 RXmRWzDzc/UmATySCwsY/wKAnKI/6nBUDIm/VtNt+EfBMo7+szphUPtqinvKNLIrAvvTa+sDXIc /i7dxH17jnEdG8BFne5/sxWDOBcdM= X-Google-Smtp-Source: AGHT+IGxbEcLUvYEAAzaCcPUvcZxt5jkgTLr7FF6QGJGhTdrTsWip3inUequ5uS9v4m2ITYFc+caIjsC8xHFHaF1EuU= X-Received: by 2002:a05:6402:3582:b0:5e5:d91c:4151 with SMTP id 4fb4d7f45d1cf-5ebcd4636a1mr5543999a12.16.1742642276339; Sat, 22 Mar 2025 04:17:56 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 22 Mar 2025 11:17:55 +0000 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <87h63rmrtp.fsf@HIDDEN> References: <871pv9rkjj.fsf@HIDDEN> <CADwFkmni55dmzN-Ai8miQbhXig_SqfY5ESVdhmw23gj1FdkutQ@HIDDEN> <87jz908pe1.fsf@HIDDEN> <CADwFkmmB+9FUvtk6p34cnpZEZVpAHj2AXzf+jQOQb4wMOSjsfA@HIDDEN> <87senov34i.fsf@HIDDEN> <CADwFkmmsifOtcyY6+m4BLVFo5xwkaH9MW7b8G1bV8F5DpVGQ2g@HIDDEN> <87frjnuxe7.fsf@HIDDEN> <87h63rmrtp.fsf@HIDDEN> MIME-Version: 1.0 Date: Sat, 22 Mar 2025 11:17:55 +0000 X-Gm-Features: AQ5f1JqrxzFSHsFkJm4JyYuUXCuVthTxNDxlrRzB4FfOxcdY6p12Y0HlBiJ0T0o Message-ID: <CADwFkm=w0J5cKhk9rV5QoyNesnVN_KyW+82nxCZaHVy6fWG9Cw@HIDDEN> Subject: Re: bug#76839: [Roi Martin] [PATCH] Fix 'Skip' behavior in erts files To: Roi Martin <jroi.martin@HIDDEN>, 76839 <at> debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76839 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Roi Martin <jroi.martin@HIDDEN> writes: > Do you think we can merge this? It is a bug fix and being so small I > guess it is within the limits of a contribution that do not require CA. > > In any case, my CA paperwork is in progress but it seems that it will > take a bit more time. Unfortunately, I think we have to wait for the paperwork to come through here. Roughly speaking, any contribution above 15 lines or so counts as significant enough to require a copyright assignment. Please feel free to ping again when you have confirmation that the papers are done.
bug-gnu-emacs@HIDDEN:bug#76839; Package emacs.
Full text available.Received: (at 76839) by debbugs.gnu.org; 17 Mar 2025 18:32:17 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Mar 17 14:32:17 2025 Received: from localhost ([127.0.0.1]:60870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tuFG5-0005o8-1o for submit <at> debbugs.gnu.org; Mon, 17 Mar 2025 14:32:17 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]:42491) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <jroi.martin@HIDDEN>) id 1tuFG1-0005nM-Lq for 76839 <at> debbugs.gnu.org; Mon, 17 Mar 2025 14:32:14 -0400 Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-3913fdd003bso2371524f8f.1 for <76839 <at> debbugs.gnu.org>; Mon, 17 Mar 2025 11:32:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742236327; x=1742841127; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :from:to:cc:subject:date:message-id:reply-to; bh=oDh4vsT01q3+1kTLOGewlvRTdOt6kiqcLEQPpqKafPc=; b=ZxdsA3KFu1wr1BV1HCJr94VtJYNz+Ct9XGtDsmktUd+uFRJPiaiezOrXGY+Zg11j9K fmyqeW34CDuAObzZYCtdCXTWjR6CERW8uw9LywFzjC401kpjYUaRfGfkasS3FY7wOXf6 YNQvCHPJ74VdzKmakGgJLEU3w6WVIZH6Ok81qXHHmyfiWYImbv7tDhhFKC+X//6S9lk8 zEr1fNPGHi15YEoGuEZ1H29xPY0r6FdMMXH/crXL9xPAMTSRWUPIV/xOb+PZBq0/BDBc EkvQp+beHY9hvG1wfb0521Spa65Eokaw7HqmVB65j/GiYH0oErEauDkQyQ/KfmXmXljR DvfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742236327; x=1742841127; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oDh4vsT01q3+1kTLOGewlvRTdOt6kiqcLEQPpqKafPc=; b=S0lt/8O0CHxbH7ThT854LOTD8n8Boxb+Ai2KYO6gBWuq4qbZNmqWB3BXQ7rze2PSpI OOCkZ8Yjix/ipVFcRYoj0OYadTbiDIYAx6P39fkeYdzbNm71sv00x4SmlJsqpvHWd4Qz CL591wXic29ILS66BftqLnn3CbcLVu7H1amHPuvISpX141j1TwYjMs28uH9jzSi5S5Xa s7L/qfnweqcUuxJgORcico79FuV4psQIPTTQehl4DmlqMYmXoEVG29HWbTeGGei5RZOv R0lHDiYSqbkAKbQGKfE2sBwFwEgMli4DoYG4DWygMz2WCKQwgp+2sln8BZjyxkKTG58i YtRw== X-Forwarded-Encrypted: i=1; AJvYcCXCFNNlljSTUiGEf9tiNDd+iFz/Emh8UhJBQVNBR8OGU4NB/pogPJg7KUHhq5MBUjBxqzaIbg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyUOKXJn8K3WymJ0pHRSMkG152wVUUcA5elN/hlz6AlKyINHas5 6PB+O3KF7REq369o9ZX3Z8qXq7ziUuofwV1ZvwD3DdCO6rNtej9/ X-Gm-Gg: ASbGncv4FTWUS1w2fyBHTeITsfbp7F1ao92LdGCD//V5YDTCvyB9W/jvqd8D5pcCE3Q CxnHy1rWLUR/e1a9/UsvTpUJhD5/pi4jpixpLyl/uYlxmpAK8JDR69lWSqbIvkacq4y8iy8hntQ WuiDplMFaBcIxEwy1/MXSwO3YK8Guf4WvEER0tQCeYRVMzf1Hio4W3MBt0fiqcN03PgeQbafmbO GwMfYUbm6IoNpbofKZyAREkja6SD5Aio4gcUCjrMs1Ydo9mH+V+CyT0yyK3TMN9NXM47oba4TtY 5wOLBeHCw47QBbkRvcEBwyoPuoyAuGAdnvDXKSKp2eE= X-Google-Smtp-Source: AGHT+IHUolwtcv6T+CcI/AhFpNzrXeDVqijsEDZ+zAO8tzvDHcQOcU4BfB5miEMjtugx106LsZHSIg== X-Received: by 2002:a5d:5f93:0:b0:390:ec6e:43ea with SMTP id ffacd0b85a97d-3996bb51f57mr407630f8f.15.1742236326681; Mon, 17 Mar 2025 11:32:06 -0700 (PDT) Received: from localhost ([84.79.205.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d1fd274c4sm73232775e9.0.2025.03.17.11.32.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Mar 2025 11:32:06 -0700 (PDT) From: Roi Martin <jroi.martin@HIDDEN> To: Stefan Kangas <stefankangas@HIDDEN>, 76839 <at> debbugs.gnu.org Subject: Re: bug#76839: [Roi Martin] [PATCH] Fix 'Skip' behavior in erts files In-Reply-To: <87frjnuxe7.fsf@HIDDEN> References: <871pv9rkjj.fsf@HIDDEN> <CADwFkmni55dmzN-Ai8miQbhXig_SqfY5ESVdhmw23gj1FdkutQ@HIDDEN> <87jz908pe1.fsf@HIDDEN> <CADwFkmmB+9FUvtk6p34cnpZEZVpAHj2AXzf+jQOQb4wMOSjsfA@HIDDEN> <87senov34i.fsf@HIDDEN> <CADwFkmmsifOtcyY6+m4BLVFo5xwkaH9MW7b8G1bV8F5DpVGQ2g@HIDDEN> <87frjnuxe7.fsf@HIDDEN> Date: Mon, 17 Mar 2025 19:32:02 +0100 Message-ID: <87h63rmrtp.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76839 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Do you think we can merge this? It is a bug fix and being so small I guess it is within the limits of a contribution that do not require CA. In any case, my CA paperwork is in progress but it seems that it will take a bit more time.
bug-gnu-emacs@HIDDEN:bug#76839; Package emacs.
Full text available.
Received: (at 76839) by debbugs.gnu.org; 8 Mar 2025 19:37:34 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Mar 08 14:37:34 2025
Received: from localhost ([127.0.0.1]:56905 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tqzzK-0006TI-0z
for submit <at> debbugs.gnu.org; Sat, 08 Mar 2025 14:37:34 -0500
Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]:58369)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <jroi.martin@HIDDEN>)
id 1tqzzH-0006T3-TQ
for 76839 <at> debbugs.gnu.org; Sat, 08 Mar 2025 14:37:32 -0500
Received: by mail-wr1-x431.google.com with SMTP id
ffacd0b85a97d-3913fdd0120so176224f8f.0
for <76839 <at> debbugs.gnu.org>; Sat, 08 Mar 2025 11:37:31 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1741462646; x=1742067446; darn=debbugs.gnu.org;
h=mime-version:message-id:date:references:in-reply-to:subject:to:from
:from:to:cc:subject:date:message-id:reply-to;
bh=ktZmvs1iqwyHB3qVVgbgT2M8+KmQb4k2eWE5iO/8dXU=;
b=d2YDaxOyO3Vmpah3aqcfZhdlCOYnk5W+7Uz0VqMLRP0KDa3dt8Wm3Gje/mJGz5tNab
Myb5O31843ThO7zr13oFUc8fWNIY90obyNOczd2VHZ8xG6+Q00jT5tz/iqE0bvvpdYct
kYOptA9OY2qjkhy7/ZyxONsY7Ott1jE0FNe1WUyFaFSaQhOQ4xO1vLDYcFGxXF/hNULm
UJtbebMw3k1xn0L0WMT6wQoEnBSQF6MCxuTYxGryZW1cRxkOlDsIKroFq1fTUf0E1Gqq
P+RZRSZbpwreGHzbeqGe5CSnT4AnKcEY/tNO0a7IPN1/PvZoS00IzpN/b2GTRY41AQhs
d1+w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1741462646; x=1742067446;
h=mime-version:message-id:date:references:in-reply-to:subject:to:from
:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=ktZmvs1iqwyHB3qVVgbgT2M8+KmQb4k2eWE5iO/8dXU=;
b=FMQJEIeByiUwtDvSfIZspuljz0MkRhcxse2Z0mVg358BuKX+GE1dmSWSzHU/3FwnOU
VtyNZwAMoQbZItKWcD/AdkQvYnyqA0aQioTUINQmeGaY2QSJhpkvtJVJfVhDm4RJt9R0
n52utUWr2BeZ0PDta22j7R2NV9VYuc/iTFJ8rCuIXQydaztOKP83WLdwIo+ryEy8iCj3
tsILdyidFdrb8wPf+J7CfFKDShrwTTEijwDeqfSuFK+IPWvKJ/bBgoKKOiZbpLAPlZW4
hFt87pS6WGsw4sV0SO93SCDqgzGPcbAGvAeomVGNbPjHZ2mcWrpBnfG/O8YvYwNc0F/3
vWyg==
X-Forwarded-Encrypted: i=1;
AJvYcCXEr+NBpiPwEMjFmRuqUyhxKjfM/Al3bca1Ng/bO01xoD+PThib/mXNUWVcwLOI+Tu8hpSe6Q==@debbugs.gnu.org
X-Gm-Message-State: AOJu0YzUIsuD73zAiU5pAENR6kMJuAJa4dz6UY0aMETmykmkz6bZ5HPp
XKaAFvuL+UUbmxO2lTuIBJstVTUSUlNyOTJUhaO8gFkMbEs9mPTM
X-Gm-Gg: ASbGncuRtTozjEdrhZVXRlUKhV9Nu81+FVoes+klT+8ElcYu/0Q3ihpO+722Ffsnj/v
UQCdAnArsVgRA6JaLhu9TLHnnxB11DfhwapN0nTJQF3Q0yIGXBU2oS1YajAaWQKSuNMuTAIOfbC
zxN8t0XFswd/mLAK2u6VgwaZcr70yZokp3Q9YKYkpSQE5yUCPW+uBWT/iGY7zRzyjOGZRUZQMTV
uaroOJPl8v6c/KJ/tUxlhwX3yFWSUoTDt6VBV23WmvrDGOWxLA5O7k3G8DQtO3Q7t0vAA+79orO
iiSLpjWIKuej8wGwrd4G3dFMVEiqVdrtPImJComgTCZ8QpCePPCl6g==
X-Google-Smtp-Source: AGHT+IH8aqi7oBZu8jxIdMrDVbbLUVJhDykJTezS10iy5v1TprmOO8KMVGXGg+iZaEbF7jub9cAMNg==
X-Received: by 2002:a05:6000:2cb:b0:391:2306:5131 with SMTP id
ffacd0b85a97d-39132da8b45mr5724161f8f.45.1741462645188;
Sat, 08 Mar 2025 11:37:25 -0800 (PST)
Received: from localhost ([84.79.205.209]) by smtp.gmail.com with ESMTPSA id
5b1f17b1804b1-43ceed32e64sm11006365e9.5.2025.03.08.11.37.24
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sat, 08 Mar 2025 11:37:24 -0800 (PST)
From: Roi Martin <jroi.martin@HIDDEN>
To: Stefan Kangas <stefankangas@HIDDEN>, 76839 <at> debbugs.gnu.org
Subject: Re: bug#76839: [Roi Martin] [PATCH] Fix 'Skip' behavior in erts files
In-Reply-To: <CADwFkmmsifOtcyY6+m4BLVFo5xwkaH9MW7b8G1bV8F5DpVGQ2g@HIDDEN>
References: <871pv9rkjj.fsf@HIDDEN>
<CADwFkmni55dmzN-Ai8miQbhXig_SqfY5ESVdhmw23gj1FdkutQ@HIDDEN>
<87jz908pe1.fsf@HIDDEN>
<CADwFkmmB+9FUvtk6p34cnpZEZVpAHj2AXzf+jQOQb4wMOSjsfA@HIDDEN>
<87senov34i.fsf@HIDDEN>
<CADwFkmmsifOtcyY6+m4BLVFo5xwkaH9MW7b8G1bV8F5DpVGQ2g@HIDDEN>
Date: Sat, 08 Mar 2025 20:37:20 +0100
Message-ID: <87frjnuxe7.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 76839
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-=-=
Content-Type: text/plain
Stefan Kangas <stefankangas@HIDDEN> writes:
>> I guess I could handle the `ert-test-failed' error signaled by
>> `ert-test-erts-file' when it calls `ert-fail', but is it much better?
>
> I think it's better, because then you reduce the scope to just that one
> error.
>
> The test could also fail for any other reason, including that some form
> couldn't be read, an incorrect erts file, and so on. We would want such
> things to be flagged, in case they happen.
>
> Does that make sense? Could you propose an updated patch along these
> lines?
Yes, it makes sense. I attached a new version that implements your
suggestions.
--=-=-=
Content-Type: text/plain
Content-Disposition: attachment;
filename=0001-Fix-Skip-behavior-in-erts-files-Bug-76839.patch
From 82d65b947e3c5f84a17d21aa8fd6fb288628bf7f Mon Sep 17 00:00:00 2001
From: Roi Martin <jroi.martin@HIDDEN>
Date: Thu, 6 Mar 2025 20:26:46 +0100
Subject: [PATCH] Fix 'Skip' behavior in erts files (Bug#76839)
* lisp/emacs-lisp/ert.el (ert-test--erts-test): Fix 'Skip' behavior in
erts files, so only the test case where it is specified is skipped.
* test/lisp/emacs-lisp/ert-tests.el (ert-test-erts-skip-one)
(ert-test-erts-skip-last): Add test cases.
---
lisp/emacs-lisp/ert.el | 2 +-
.../emacs-lisp/ert-resources/erts-skip-last.erts | 8 ++++++++
.../emacs-lisp/ert-resources/erts-skip-one.erts | 16 ++++++++++++++++
test/lisp/emacs-lisp/ert-tests.el | 12 ++++++++++++
4 files changed, 37 insertions(+), 1 deletion(-)
create mode 100644 test/lisp/emacs-lisp/ert-resources/erts-skip-last.erts
create mode 100644 test/lisp/emacs-lisp/ert-resources/erts-skip-one.erts
diff --git a/lisp/emacs-lisp/ert.el b/lisp/emacs-lisp/ert.el
index c57bd0a69e2f..eedff982940f 100644
--- a/lisp/emacs-lisp/ert.el
+++ b/lisp/emacs-lisp/ert.el
@@ -2901,7 +2901,7 @@ ert-test--erts-test
(if (and skip
(eval (car (read-from-string skip))))
;; Skipping this test.
- ()
+ (goto-char end-after)
;; Do the test.
(goto-char end-after)
;; We have a separate after section.
diff --git a/test/lisp/emacs-lisp/ert-resources/erts-skip-last.erts b/test/lisp/emacs-lisp/ert-resources/erts-skip-last.erts
new file mode 100644
index 000000000000..fd39efcaaa6c
--- /dev/null
+++ b/test/lisp/emacs-lisp/ert-resources/erts-skip-last.erts
@@ -0,0 +1,8 @@
+Name: last
+Skip: t
+
+=-=
+FOO
+=-=
+BAR
+=-=-=
diff --git a/test/lisp/emacs-lisp/ert-resources/erts-skip-one.erts b/test/lisp/emacs-lisp/ert-resources/erts-skip-one.erts
new file mode 100644
index 000000000000..3b35081c4148
--- /dev/null
+++ b/test/lisp/emacs-lisp/ert-resources/erts-skip-one.erts
@@ -0,0 +1,16 @@
+Name: first
+Skip: t
+
+=-=
+FOO
+=-=
+FOO
+=-=-=
+
+Name: second
+
+=-=
+FOO
+=-=
+BAR
+=-=-=
diff --git a/test/lisp/emacs-lisp/ert-tests.el b/test/lisp/emacs-lisp/ert-tests.el
index aec2c92ba811..5de8706e8ed4 100644
--- a/test/lisp/emacs-lisp/ert-tests.el
+++ b/test/lisp/emacs-lisp/ert-tests.el
@@ -28,6 +28,7 @@
(require 'cl-lib)
(require 'ert)
+(require 'ert-x)
;;; Self-test that doesn't rely on ERT, for bootstrapping.
@@ -1021,6 +1022,17 @@ ert-test-with-test-buffer-selected/buffer-name
(ert-with-test-buffer (:name "foo" :selected t)
(buffer-name)))))
+(ert-deftest ert-test-erts-skip-one ()
+ "Test that Skip does not affect subsequent test cases (Bug#76839)."
+ (should-error (ert-test-erts-file (ert-resource-file "erts-skip-one.erts")
+ (lambda () ()))
+ :type 'ert-test-failed))
+
+(ert-deftest ert-test-erts-skip-last ()
+ "Test that Skip does not fail on last test case (Bug#76839)."
+ (ert-test-erts-file (ert-resource-file "erts-skip-last.erts")
+ (lambda () ())))
+
(provide 'ert-tests)
;;; ert-tests.el ends here
--
2.48.1
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#76839; Package emacs.
Full text available.Received: (at 76839) by debbugs.gnu.org; 8 Mar 2025 09:57:13 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Mar 08 04:57:13 2025 Received: from localhost ([127.0.0.1]:52908 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tqqvg-0005Y6-UT for submit <at> debbugs.gnu.org; Sat, 08 Mar 2025 04:57:13 -0500 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]:49510) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1tqqvf-0005Xt-8j for 76839 <at> debbugs.gnu.org; Sat, 08 Mar 2025 04:57:11 -0500 Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-5e058ca6806so5175878a12.3 for <76839 <at> debbugs.gnu.org>; Sat, 08 Mar 2025 01:57:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741427825; x=1742032625; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date:message-id:reply-to; bh=4RcPhA87mD9yq4Hql5Juw9ijvXg1RwwVmvqdZpeWXoo=; b=A9c53jfOsdcrnGs0b8pCbo8Lpc4222/0uvtNS+MOQQmtJfC8rPynDmh6hs2vWvNrY0 jqVDdu1oxxtXTlVHLW6OSWAt7v7EM8qOzttVcWFrF+e3ou03Rz7VuMNL0yhwABQhXRB8 swR9qqP0Rj9QeiwVCj8VPyL25iCmGbriAcvzIftpv28D4NyP087Fd5lY3VnpwCmMSTlx nnWQspzco+TnhoFYuk2biioUGCQ8jf/ik98YRDf2ZsYDOYdO7oBFzSrq4u2e+we3uDkO xZMHmrlF9oOGbFPgzzkOoM1Nd87DVxAGDpIc+R4bNkLShwEEq5fWIP1LWhvNwyaNRrd0 Uscg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741427825; x=1742032625; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4RcPhA87mD9yq4Hql5Juw9ijvXg1RwwVmvqdZpeWXoo=; b=thKenl00BxdY2zvTUAjbzMJKYxlxntfJnwLWEj9f1MHmlRLSxwbIJIT1lTQabOJ/xM eUnAP6dpI7WS7bXUKjDleMBE1YXoKnlLMr8X4eZG+5ymfr5npWzaDJojlyFGxtqqqNLP Mn479vKSzaQNZRHGw3pzMgafOJL63ZRO88CHVcqLQ63y6aPsFubjpbgkSboLRasP0Qau XmNEXklWlNoUJIN6IaGsyEp3YQ41zzI86ig4YrpcZz+p8swbTocLfjFk1+5PDuo3oSXc oDZj0FpDFXZwupg+aMrKaMobQp5gI+cLk7WcMSaDkUko1s+8Z5sv+NBTNWPRcXi1Bhu7 Qv0Q== X-Forwarded-Encrypted: i=1; AJvYcCWisqFSsZgLtncMcL5H8PPlE32d7jy3608F4zIEQOExEI6nyMUJmkc8u0wNkSJRKakrB7iIAA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzEsuJ7pAoatDZD0eSWzt0xECZGk3StVc+WOEJe0qxDA1R8ONWn aGsvgTF5OZ6bzXtCPZ2//CQ0uVmlDUqN34YwPP3LWp0D8Q1Ee0r0gyFBzbJdYfQcYyr0LEZ6jX8 tURA2jeR+UC9lmRAtyohrnNMVVVvxEhPOOAE= X-Gm-Gg: ASbGncs07+DU2fC2jlwA8d3aaTCk61bX/rA4j/YPTsnh55YaS/7lN5tZttqgWOUFWsZ zm0kVcNokdJ/tM5H5fkA3MMTICYWgv4PbvihAm3fppO+IbLL8O+ea0pyigjQbwffcFKvyxpCU5X Gh6w6+7vf1DnWeZgT2PAw1iuv0MA== X-Google-Smtp-Source: AGHT+IGik9s9WhGO3Lst32+tcPBUu8WRI4Ps9/l3VKJExbF/j3SvzHTN5DLPO5SM+IEv57BXn/69FykDV7YyRHu3p+E= X-Received: by 2002:a05:6402:5207:b0:5e4:d13b:e65 with SMTP id 4fb4d7f45d1cf-5e5e22bf1admr7463222a12.9.1741427824925; Sat, 08 Mar 2025 01:57:04 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 8 Mar 2025 09:57:04 +0000 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <87senov34i.fsf@HIDDEN> References: <871pv9rkjj.fsf@HIDDEN> <CADwFkmni55dmzN-Ai8miQbhXig_SqfY5ESVdhmw23gj1FdkutQ@HIDDEN> <87jz908pe1.fsf@HIDDEN> <CADwFkmmB+9FUvtk6p34cnpZEZVpAHj2AXzf+jQOQb4wMOSjsfA@HIDDEN> <87senov34i.fsf@HIDDEN> MIME-Version: 1.0 Date: Sat, 8 Mar 2025 09:57:04 +0000 X-Gm-Features: AQ5f1JqvhsLRN6Ve0sIE2gABSj5B3lG5GbBBfIfD_Qu5wZPLxi8jKub5wFe2rzQ Message-ID: <CADwFkmmsifOtcyY6+m4BLVFo5xwkaH9MW7b8G1bV8F5DpVGQ2g@HIDDEN> Subject: Re: bug#76839: [Roi Martin] [PATCH] Fix 'Skip' behavior in erts files To: Roi Martin <jroi.martin@HIDDEN>, 76839 <at> debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76839 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Roi Martin <jroi.martin@HIDDEN> writes: > Stefan Kangas <stefankangas@HIDDEN> writes: > >>> +(ert-deftest ert-test-erts-skip-one () >>> + "Test that Skip does not affect subsequent test cases (Bug#76839)." >>> + :expected-result :failed >> >> I think this should be avoided, because a test can fail for any reason. >> >> Can we turn the condition around, so that this test always passes? > > The thing is that I need to determine that the test case following the > skipped one in the erts file has been executed. If I know that the test > will fail, it is easy to identify that, which is why I use > ':expected-result :failed'. However, If we expect `ert-test-erts-file' > to succeed, how can I confirm that the second test case has passed > instead of being skipped as well? > > I guess I could handle the `ert-test-failed' error signaled by > `ert-test-erts-file' when it calls `ert-fail', but is it much better? I think it's better, because then you reduce the scope to just that one error. The test could also fail for any other reason, including that some form couldn't be read, an incorrect erts file, and so on. We would want such things to be flagged, in case they happen. Does that make sense? Could you propose an updated patch along these lines?
bug-gnu-emacs@HIDDEN:bug#76839; Package emacs.
Full text available.Received: (at 76839) by debbugs.gnu.org; 7 Mar 2025 23:21:35 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Mar 07 18:21:35 2025 Received: from localhost ([127.0.0.1]:51072 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tqh0Z-0001Bv-EN for submit <at> debbugs.gnu.org; Fri, 07 Mar 2025 18:21:35 -0500 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]:44359) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <jroi.martin@HIDDEN>) id 1tqh0X-0001Bg-PE for 76839 <at> debbugs.gnu.org; Fri, 07 Mar 2025 18:21:34 -0500 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-39129017bbbso1043809f8f.1 for <76839 <at> debbugs.gnu.org>; Fri, 07 Mar 2025 15:21:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741389687; x=1741994487; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :from:to:cc:subject:date:message-id:reply-to; bh=iFKXkubsGN5tCRbAit0s3JBn4vO6/ma7zTySo+QdXH8=; b=Q94vUVA/rKFMJljAehU76CnB5hi2vcyDhJ8LCSTituVUoVwlE2nzmIydwtWP7rEF3L 3js09cuQRWhEDp6apqBXmYz9omVgf56Kd2mfcdT66RxYcIvIgFJWfmsUbZZTnkuP+Z0T fg4bCRHylZKOyrujMFUD5PuOvnmxOsBR1Iir/f7ILr3ee4xdo0ewUFF94UOwytQVFFN6 PwKMvcgOBn2o+78cUJ1QyJoHNp+NVZCt6g3YoebxqJ9tpBHj+RyvEmCz+gWHAIhdtECO Mwma2FNIAGDuXgcTVh7VfLoV3/zmHdKD6ySoOO2xFnn/FpQQcqpZfT/5Kec6iKg3U4Ho OlVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741389687; x=1741994487; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iFKXkubsGN5tCRbAit0s3JBn4vO6/ma7zTySo+QdXH8=; b=YhuuCar71zBHpegxYGXqYHKM3gS+7FfZFBK8tt5MfwCcUQncLIgY2B/Js5JgATsmce 01pm0TN5/E1/DzuYHz70sJeQaFo2etGFL/dWZcu6kIMFc2Nf3WDp205DKdAXECoHMlIH LkyYjtq9HLxuYWrawwq7Znvqc9Ypb5Qw6vj1YpMzBP9omH00/bxZUAtEbgAjEHrIxIXB 3CDkjJ7DztIrc0Q67GueAu6KPaKQ687gO9Qars57dxatdHi2gFjvRgwPh0mDp5YcTmE0 TK6Ig9+qQDcFFYmPDGfP2Z106v9cq1QLobCO+AT0qfq084k7JPZWPJP9LKMZ4fsWF5bX oDBA== X-Forwarded-Encrypted: i=1; AJvYcCWxwH1DyEPpVUtjLXtUh6xOCfOppb+F4i3sBnDuW6mIj/HpACoOaqcRvxAvl+evdi7bXMRnVA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyN/1pKxV57wSYRasETzS9R4MawkHXF0CBUPYv2xwFxohWKpjzQ 9r5y8zXk8Ylz6T2VD66GepLoLdIXHniqZojs5N6R5YPIhndshmz/ X-Gm-Gg: ASbGncuppHErLx6mqidFXBvo+lVMeu8XoJXDGbXJ0IA2F7yzxiZEHSJnCnuN1JcGzNN Lz7ZQS+0X5K6PP4w1NyUngVFCJCP5IaaBh6FkYLXlljlcPFGXK5+X3yWD8c506R3fz9qUt9TPzc TFqTSZOyD3X8sbsQLLRhXq1g4fdjesZruVjsJ+xWQVjOI8OAlEzXVBwoJj1TmFIrU6+Z062sjYN JjlwPC0xLpyUETPMjg5Nt0hFp0rVLiFt15GUBaSC/UXjo1QMVXHdbw7k5gwmsM6NTIXMXwyBmmm C8VEpIyD9Ez7xssF0uY3m+2GFyVOFrTgchGaxW2vNuI= X-Google-Smtp-Source: AGHT+IFlqIDv+rw/Q6xK9I5dguMuyIVlRh1fUVC+H7qt60ibcSyhcu5hBniU/5EmxMQpWNu99n6LsQ== X-Received: by 2002:a5d:648f:0:b0:38f:2b77:a9f3 with SMTP id ffacd0b85a97d-39132dd6934mr3900079f8f.43.1741389686792; Fri, 07 Mar 2025 15:21:26 -0800 (PST) Received: from localhost ([84.79.205.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3912bfdfba9sm6931673f8f.39.2025.03.07.15.21.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Mar 2025 15:21:26 -0800 (PST) From: Roi Martin <jroi.martin@HIDDEN> To: Stefan Kangas <stefankangas@HIDDEN>, 76839 <at> debbugs.gnu.org Subject: Re: bug#76839: [Roi Martin] [PATCH] Fix 'Skip' behavior in erts files In-Reply-To: <CADwFkmmB+9FUvtk6p34cnpZEZVpAHj2AXzf+jQOQb4wMOSjsfA@HIDDEN> References: <871pv9rkjj.fsf@HIDDEN> <CADwFkmni55dmzN-Ai8miQbhXig_SqfY5ESVdhmw23gj1FdkutQ@HIDDEN> <87jz908pe1.fsf@HIDDEN> <CADwFkmmB+9FUvtk6p34cnpZEZVpAHj2AXzf+jQOQb4wMOSjsfA@HIDDEN> Date: Sat, 08 Mar 2025 00:21:17 +0100 Message-ID: <87senov34i.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76839 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Stefan Kangas <stefankangas@HIDDEN> writes: >> +(ert-deftest ert-test-erts-skip-one () >> + "Test that Skip does not affect subsequent test cases (Bug#76839)." >> + :expected-result :failed > > I think this should be avoided, because a test can fail for any reason. > > Can we turn the condition around, so that this test always passes? The thing is that I need to determine that the test case following the skipped one in the erts file has been executed. If I know that the test will fail, it is easy to identify that, which is why I use ':expected-result :failed'. However, If we expect `ert-test-erts-file' to succeed, how can I confirm that the second test case has passed instead of being skipped as well? I guess I could handle the `ert-test-failed' error signaled by `ert-test-erts-file' when it calls `ert-fail', but is it much better? Are there any other alternatives? Thanks!
bug-gnu-emacs@HIDDEN:bug#76839; Package emacs.
Full text available.Received: (at 76839) by debbugs.gnu.org; 7 Mar 2025 22:18:31 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Mar 07 17:18:31 2025 Received: from localhost ([127.0.0.1]:50993 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tqg1W-0006qY-JL for submit <at> debbugs.gnu.org; Fri, 07 Mar 2025 17:18:31 -0500 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]:55371) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1tqg1T-0006qF-Ne for 76839 <at> debbugs.gnu.org; Fri, 07 Mar 2025 17:18:28 -0500 Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-5e6194e9d2cso122399a12.2 for <76839 <at> debbugs.gnu.org>; Fri, 07 Mar 2025 14:18:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741385901; x=1741990701; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date:message-id:reply-to; bh=YV//Sly11v6E0S8pp6hjno19Lx2TaO1sK1TqGaCVpVs=; b=I8CIpZYiJbFnknNo/KNLTzUsZOXUBmQaE++kDCBBJpBcyALKuk63hAJzu1C+8wN1tq JJwqC4tJMeteSkc8ZNzm5/Pfw5EsikyZFAT5MWgUlfIQWyiAhEK124rRV6TtKA7NUwhJ 8kpr6G8WFd+iJU8i54Ixi5946L1lKKPghh15jDNF7fOLcBRIg/Oe4ApqVmTw6/gsgy86 dHr0v+ALupI6vkV3xRWP9LwZspRs4EKz7XP80mQRuBOiNFskyIUTvvzNwy7rubS55xrb En6+Fi+Ce8TY+GCI5fyqkWJFdY9wt/VQqIu/UVGFGZY/qkjxuflqhMSK1GIZGTcg3gT/ jglg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741385901; x=1741990701; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YV//Sly11v6E0S8pp6hjno19Lx2TaO1sK1TqGaCVpVs=; b=rTpv1eJaCUf8XeLE9WeJc+ipTEX4ZjSi0yt6cwEsroa3kvMPChz7D8eYhfvcBh+dMB HjhA94z2XRrXU0O5r6b6QYZax+7oFklvowj+1PD40ALOhFroJyomj4b/srexaW0bU0Rn T5jjzmqOB7pda9ptJ6DN1ApST3G5sYIO+bBVswaTCoPVCE8OGF0+wch6C8BJxiMt4kaD mFeNnQtN0RFfkXEbcl/JALbnzo5iKPj1H8LWkvyjB4wFF5+Q4dbTQGOMbOoGRapSCC0/ 0wXaQSKeyojj90lA2u6umKk7IwOewLWUxB55rxn/Fx1YP/gdvoP6ZMlinl1WO8Oiaoj3 ov6w== X-Forwarded-Encrypted: i=1; AJvYcCVw5mIUOEdFoybzmI2Sb85XNKQ2CLy5rPbI0WBUzZx70nhPFw75Pyrz0IEEVfK95hwX0TkKhw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwMTv5BjPriYOMgusqKrTf6Yeg9XGwt0VoobhHxbLUKNbcnN/AQ 8A5XZ1dG3qRDgUgt7tkCxkLYsegVpV5P/Glg/xc1EwVlBXCXiALVL68i0KlkYoTCFPBTtDukdiG m57xLLxNItaRkkgYavA+S82WO/ac= X-Gm-Gg: ASbGncv/gcXR1ypI8Hn5lc7ogmjmRT5jbQtpPkOJjinkNLm7Vl1zIvcYc0acPx9rqx2 /Ti/7lYbj4IHqFKmMReNWfndxTc5gTpaGvfe+gr1EEiTgoYAmZnke4eScf023qvgxDiSwFL2R70 Kt9FqMIe48JoJX/isffZxPg/KyKA== X-Google-Smtp-Source: AGHT+IFFSCBX8oTYV6okVb2gUeKKw4IvSNkpdL4ZrBuzguis2VAJzF46UPlf80ABO52uTxN0JoD0nXyYIbJDbTEe97c= X-Received: by 2002:a05:6402:3496:b0:5e5:bde4:7575 with SMTP id 4fb4d7f45d1cf-5e5e22bf9c2mr4718581a12.1.1741385901120; Fri, 07 Mar 2025 14:18:21 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 7 Mar 2025 14:18:20 -0800 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <87jz908pe1.fsf@HIDDEN> References: <871pv9rkjj.fsf@HIDDEN> <CADwFkmni55dmzN-Ai8miQbhXig_SqfY5ESVdhmw23gj1FdkutQ@HIDDEN> <87jz908pe1.fsf@HIDDEN> MIME-Version: 1.0 Date: Fri, 7 Mar 2025 14:18:20 -0800 X-Gm-Features: AQ5f1JoORjn84VZTAT-KSXVKgzH_ECkYqqryeiNeg_LsI6eg_6nxNSsNxqth_Dg Message-ID: <CADwFkmmB+9FUvtk6p34cnpZEZVpAHj2AXzf+jQOQb4wMOSjsfA@HIDDEN> Subject: Re: bug#76839: [Roi Martin] [PATCH] Fix 'Skip' behavior in erts files To: Roi Martin <jroi.martin@HIDDEN>, 76839 <at> debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 76839 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Roi Martin <jroi.martin@HIDDEN> writes: > This is a second version of the patch that adds tests for this bug. I > also rebased it onto master. > > From 870eed35b5b1fa20a5e038abb8bf32827e56fefa Mon Sep 17 00:00:00 2001 > From: Roi Martin <jroi.martin@HIDDEN> > Date: Thu, 6 Mar 2025 20:26:46 +0100 > Subject: [PATCH] Fix 'Skip' behavior in erts files (Bug#76839) > > * lisp/emacs-lisp/ert.el (ert-test--erts-test): Fix 'Skip' behavior in > erts files, so only the test case where it is specified is skipped. > * test/lisp/emacs-lisp/ert-tests.el (ert-test-erts-skip-one) > (ert-test-erts-skip-last): Add test cases. > --- > lisp/emacs-lisp/ert.el | 2 +- > .../emacs-lisp/ert-resources/erts-skip-last.erts | 8 ++++++++ > .../emacs-lisp/ert-resources/erts-skip-one.erts | 16 ++++++++++++++++ > test/lisp/emacs-lisp/ert-tests.el | 12 ++++++++++++ > 4 files changed, 37 insertions(+), 1 deletion(-) > create mode 100644 test/lisp/emacs-lisp/ert-resources/erts-skip-last.erts > create mode 100644 test/lisp/emacs-lisp/ert-resources/erts-skip-one.erts > > diff --git a/lisp/emacs-lisp/ert.el b/lisp/emacs-lisp/ert.el > index c57bd0a69e2f..eedff982940f 100644 > --- a/lisp/emacs-lisp/ert.el > +++ b/lisp/emacs-lisp/ert.el > @@ -2901,7 +2901,7 @@ ert-test--erts-test > (if (and skip > (eval (car (read-from-string skip)))) > ;; Skipping this test. > - () > + (goto-char end-after) > ;; Do the test. > (goto-char end-after) > ;; We have a separate after section. > diff --git a/test/lisp/emacs-lisp/ert-resources/erts-skip-last.erts b/test/lisp/emacs-lisp/ert-resources/erts-skip-last.erts > new file mode 100644 > index 000000000000..fd39efcaaa6c > --- /dev/null > +++ b/test/lisp/emacs-lisp/ert-resources/erts-skip-last.erts > @@ -0,0 +1,8 @@ > +Name: last > +Skip: t > + > +=-= > +FOO > +=-= > +BAR > +=-=-= > diff --git a/test/lisp/emacs-lisp/ert-resources/erts-skip-one.erts b/test/lisp/emacs-lisp/ert-resources/erts-skip-one.erts > new file mode 100644 > index 000000000000..3b35081c4148 > --- /dev/null > +++ b/test/lisp/emacs-lisp/ert-resources/erts-skip-one.erts > @@ -0,0 +1,16 @@ > +Name: first > +Skip: t > + > +=-= > +FOO > +=-= > +FOO > +=-=-= > + > +Name: second > + > +=-= > +FOO > +=-= > +BAR > +=-=-= > diff --git a/test/lisp/emacs-lisp/ert-tests.el b/test/lisp/emacs-lisp/ert-tests.el > index aec2c92ba811..85b94c8d1a1e 100644 > --- a/test/lisp/emacs-lisp/ert-tests.el > +++ b/test/lisp/emacs-lisp/ert-tests.el > @@ -28,6 +28,7 @@ > > (require 'cl-lib) > (require 'ert) > +(require 'ert-x) > > ;;; Self-test that doesn't rely on ERT, for bootstrapping. > > @@ -1021,6 +1022,17 @@ ert-test-with-test-buffer-selected/buffer-name > (ert-with-test-buffer (:name "foo" :selected t) > (buffer-name))))) > > +(ert-deftest ert-test-erts-skip-one () > + "Test that Skip does not affect subsequent test cases (Bug#76839)." > + :expected-result :failed I think this should be avoided, because a test can fail for any reason. Can we turn the condition around, so that this test always passes? > + (ert-test-erts-file (ert-resource-file "erts-skip-one.erts") > + (lambda () ()))) > + > +(ert-deftest ert-test-erts-skip-last () > + "Test that Skip does not fail on last test case (Bug#76839)." > + (ert-test-erts-file (ert-resource-file "erts-skip-last.erts") > + (lambda () ()))) > + > (provide 'ert-tests) > > ;;; ert-tests.el ends here > -- > 2.48.1
bug-gnu-emacs@HIDDEN:bug#76839; Package emacs.
Full text available.
Received: (at 76839) by debbugs.gnu.org; 7 Mar 2025 22:09:09 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Mar 07 17:09:09 2025
Received: from localhost ([127.0.0.1]:50963 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tqfsS-0006P8-V8
for submit <at> debbugs.gnu.org; Fri, 07 Mar 2025 17:09:09 -0500
Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]:55435)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <jroi.martin@HIDDEN>)
id 1tqfsQ-0006OX-0i
for 76839 <at> debbugs.gnu.org; Fri, 07 Mar 2025 17:09:06 -0500
Received: by mail-wr1-x42a.google.com with SMTP id
ffacd0b85a97d-3912e96c8e8so1276923f8f.2
for <76839 <at> debbugs.gnu.org>; Fri, 07 Mar 2025 14:09:05 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1741385340; x=1741990140; darn=debbugs.gnu.org;
h=mime-version:message-id:date:references:in-reply-to:subject:to:from
:from:to:cc:subject:date:message-id:reply-to;
bh=DS8V+p/Fk7XYgrwMyIduWkwO9LztAdPJ7L4bSc3eZ+s=;
b=dD32n+dc8UsQQS1s0/B292HqidajtH7ebZKbDCgRYBueRYQtsYkxBuIyI2uPB3adKj
8opaeyZ5Y7ceRQ3evj+weC0Poo8XdfIFN0L0p+6WTwap28Xxym8tpJPcafP4TWx5GXNA
P1uVoDKUGXB0Z5P71fC+4z15ACGqxV6snqtNCEqpnMvNMtY9T7ujztQwD8PeLsXsTbyZ
WHqvXSRVujgHVR5FOO62GE/ibcb4x0FuAsHW0pUgzkoAECUcaE8lMVEzPDBdS9k4FMdR
g4FKIndUoargIC5/XG9+solXMm12bCyafLA/jL3Vhe4W8e4KWGaVJEnbi6i6B6O271Z2
V4bQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1741385340; x=1741990140;
h=mime-version:message-id:date:references:in-reply-to:subject:to:from
:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=DS8V+p/Fk7XYgrwMyIduWkwO9LztAdPJ7L4bSc3eZ+s=;
b=ASvAyA6uqDEvQtuINQyKUC2fYyOLKEKDfIwPy9wGX/RpLADHt0dN8vxVYAy9llIvnI
+U2Y9Ck6LiTnAn2QwiocJluzw+vwa8CLHImylYQ2d6wXWJP05+z4ehZWfzqkWFMOrFJb
xrpgTc9T3Om96MEjFusSNZ0IVwhBvL7bfnHZjgh4HY6DnEG2o9CZuzhPASro+JEdaNSC
Z6MnMVHeY+3qRVlB7ThxT8rk7XbSRrn6aLQdSCRxBDZSVJxJsvYNdOpkusa3UtITkIL2
MlybgBKyu46FOHWSdc3kfGBaz/rkhoeyU31b4POAavid9/tUXP+C3xYy2L6vy5pNIlj3
WtJg==
X-Forwarded-Encrypted: i=1;
AJvYcCVDR+uzJuCH5uIQhALW98JPjTXymgKbsKhFGWmKgqH5H6xG1F8QGnOhsPOdJ1Vu9suH9Phw5w==@debbugs.gnu.org
X-Gm-Message-State: AOJu0YzT3Q9/KAr72fl/hl4DbSMiMg3R3Nw5MVarQG7eFgqtbb8n4gSi
IiFZE7oSzU594RGeKcxVD7uApRF6PTf2reC47JQlnhOuv52kod31Nj46eg==
X-Gm-Gg: ASbGncsGEZeJLRq7q/reMA1GDH25+TCkajWvFRLguiENe3C2/hgIFDHxQzQSMQMirCv
44pABc8Ka6KRVYySYZFjEClw/rODs7vBzetVzeklTZhCUAnSo8EbCuU9hNy+TxTZTQICC/k9Wr3
f0KuHLHRTMAk5FqTN9ps1qcz0rZLS+EwEA8jqhE2XBX/KY+M2tI92Bf8cjIqfTmEYh9VIGYMNXp
aUR1I+AedV4Ncu2XvTP6AsBMq4diwa0KvqHyXqxllCZKR+j+tonEUlJGV2j9mzjlciWk05NoagY
QKXz+7OPF1PN7hlVwtqQ2PQLUTOIuz8RZo6C4SSn8CI=
X-Google-Smtp-Source: AGHT+IFQLe0S0l+40vcLCt1tWXdFuTBSpvkBSjGnd+r1ky2MSqh2Mzh6tfSYcfLBojmNB6g7QcJ0MQ==
X-Received: by 2002:a05:6000:144f:b0:390:f902:f96f with SMTP id
ffacd0b85a97d-39132d52e4bmr3608651f8f.22.1741385339448;
Fri, 07 Mar 2025 14:08:59 -0800 (PST)
Received: from localhost ([84.79.205.209]) by smtp.gmail.com with ESMTPSA id
ffacd0b85a97d-3912c102db1sm6599124f8f.95.2025.03.07.14.08.58
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 07 Mar 2025 14:08:58 -0800 (PST)
From: Roi Martin <jroi.martin@HIDDEN>
To: Stefan Kangas <stefankangas@HIDDEN>, 76839 <at> debbugs.gnu.org
Subject: Re: bug#76839: [Roi Martin] [PATCH] Fix 'Skip' behavior in erts files
In-Reply-To: <CADwFkmni55dmzN-Ai8miQbhXig_SqfY5ESVdhmw23gj1FdkutQ@HIDDEN>
References: <871pv9rkjj.fsf@HIDDEN>
<CADwFkmni55dmzN-Ai8miQbhXig_SqfY5ESVdhmw23gj1FdkutQ@HIDDEN>
Date: Fri, 07 Mar 2025 23:08:54 +0100
Message-ID: <87jz908pe1.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 76839
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-=-=
Content-Type: text/plain
This is a second version of the patch that adds tests for this bug. I
also rebased it onto master.
--=-=-=
Content-Type: text/plain
Content-Disposition: attachment;
filename=0001-Fix-Skip-behavior-in-erts-files-Bug-76839.patch
From 870eed35b5b1fa20a5e038abb8bf32827e56fefa Mon Sep 17 00:00:00 2001
From: Roi Martin <jroi.martin@HIDDEN>
Date: Thu, 6 Mar 2025 20:26:46 +0100
Subject: [PATCH] Fix 'Skip' behavior in erts files (Bug#76839)
* lisp/emacs-lisp/ert.el (ert-test--erts-test): Fix 'Skip' behavior in
erts files, so only the test case where it is specified is skipped.
* test/lisp/emacs-lisp/ert-tests.el (ert-test-erts-skip-one)
(ert-test-erts-skip-last): Add test cases.
---
lisp/emacs-lisp/ert.el | 2 +-
.../emacs-lisp/ert-resources/erts-skip-last.erts | 8 ++++++++
.../emacs-lisp/ert-resources/erts-skip-one.erts | 16 ++++++++++++++++
test/lisp/emacs-lisp/ert-tests.el | 12 ++++++++++++
4 files changed, 37 insertions(+), 1 deletion(-)
create mode 100644 test/lisp/emacs-lisp/ert-resources/erts-skip-last.erts
create mode 100644 test/lisp/emacs-lisp/ert-resources/erts-skip-one.erts
diff --git a/lisp/emacs-lisp/ert.el b/lisp/emacs-lisp/ert.el
index c57bd0a69e2f..eedff982940f 100644
--- a/lisp/emacs-lisp/ert.el
+++ b/lisp/emacs-lisp/ert.el
@@ -2901,7 +2901,7 @@ ert-test--erts-test
(if (and skip
(eval (car (read-from-string skip))))
;; Skipping this test.
- ()
+ (goto-char end-after)
;; Do the test.
(goto-char end-after)
;; We have a separate after section.
diff --git a/test/lisp/emacs-lisp/ert-resources/erts-skip-last.erts b/test/lisp/emacs-lisp/ert-resources/erts-skip-last.erts
new file mode 100644
index 000000000000..fd39efcaaa6c
--- /dev/null
+++ b/test/lisp/emacs-lisp/ert-resources/erts-skip-last.erts
@@ -0,0 +1,8 @@
+Name: last
+Skip: t
+
+=-=
+FOO
+=-=
+BAR
+=-=-=
diff --git a/test/lisp/emacs-lisp/ert-resources/erts-skip-one.erts b/test/lisp/emacs-lisp/ert-resources/erts-skip-one.erts
new file mode 100644
index 000000000000..3b35081c4148
--- /dev/null
+++ b/test/lisp/emacs-lisp/ert-resources/erts-skip-one.erts
@@ -0,0 +1,16 @@
+Name: first
+Skip: t
+
+=-=
+FOO
+=-=
+FOO
+=-=-=
+
+Name: second
+
+=-=
+FOO
+=-=
+BAR
+=-=-=
diff --git a/test/lisp/emacs-lisp/ert-tests.el b/test/lisp/emacs-lisp/ert-tests.el
index aec2c92ba811..85b94c8d1a1e 100644
--- a/test/lisp/emacs-lisp/ert-tests.el
+++ b/test/lisp/emacs-lisp/ert-tests.el
@@ -28,6 +28,7 @@
(require 'cl-lib)
(require 'ert)
+(require 'ert-x)
;;; Self-test that doesn't rely on ERT, for bootstrapping.
@@ -1021,6 +1022,17 @@ ert-test-with-test-buffer-selected/buffer-name
(ert-with-test-buffer (:name "foo" :selected t)
(buffer-name)))))
+(ert-deftest ert-test-erts-skip-one ()
+ "Test that Skip does not affect subsequent test cases (Bug#76839)."
+ :expected-result :failed
+ (ert-test-erts-file (ert-resource-file "erts-skip-one.erts")
+ (lambda () ())))
+
+(ert-deftest ert-test-erts-skip-last ()
+ "Test that Skip does not fail on last test case (Bug#76839)."
+ (ert-test-erts-file (ert-resource-file "erts-skip-last.erts")
+ (lambda () ())))
+
(provide 'ert-tests)
;;; ert-tests.el ends here
--
2.48.1
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#76839; Package emacs.
Full text available.Stefan Kangas <stefankangas@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at submit) by debbugs.gnu.org; 7 Mar 2025 19:38:06 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Mar 07 14:38:05 2025 Received: from localhost ([127.0.0.1]:50628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tqdWH-0007Gv-Dt for submit <at> debbugs.gnu.org; Fri, 07 Mar 2025 14:38:05 -0500 Received: from lists.gnu.org ([2001:470:142::17]:46428) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1tqdWF-0007FW-2Q for submit <at> debbugs.gnu.org; Fri, 07 Mar 2025 14:38:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <stefankangas@HIDDEN>) id 1tqdVn-0000v6-29 for bug-gnu-emacs@HIDDEN; Fri, 07 Mar 2025 14:37:38 -0500 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <stefankangas@HIDDEN>) id 1tqdVl-0007Xj-G6 for bug-gnu-emacs@HIDDEN; Fri, 07 Mar 2025 14:37:34 -0500 Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-5e5e22e6ed2so2140673a12.3 for <bug-gnu-emacs@HIDDEN>; Fri, 07 Mar 2025 11:37:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741376252; x=1741981052; darn=gnu.org; h=to:subject:message-id:date:mime-version:references:from:from:to:cc :subject:date:message-id:reply-to; bh=cyi/wPCDeY7J7PbeayCpN53KrLq3jHes8HwcYVs65+I=; b=XwVj0L5pR1Nfj8zShnw6jP+6WbS6eTjhrDlatSCOyp3UxgAnPv30tOMYGXDgEcwySg j6g3tQ7eiLvjgJ2kgSOJ8uRDK7+A2KirHshWyeAjkvfp4ufPegdpcs/+N4UF8ybs297C G43CkizfdYMSwYjVTg4lHYKe63vVOetPdv83+QI2be9/6oTXm/BwIr8boOjxhCLK/V0c nLeCNHcOeqTBzftiqjx25NRwLbJzpiptGdLsuFP1A51BlDXAjEeM52uy7PYizw50m/QY wHwEfL0Q3ylJQxSXYa391s89i1afUkkv45KgTS2AFpShCh2oA4pyZrpvZPQ7N+VjcPMh 5XKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741376252; x=1741981052; h=to:subject:message-id:date:mime-version:references:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cyi/wPCDeY7J7PbeayCpN53KrLq3jHes8HwcYVs65+I=; b=sVbwRnBAbJl1ZeKZrSBgV6m2r48QRBE6oz5eWVZgNPwP3sCGg4UTBbG3WnmPUQVBKA LRHmmOENrvQ04KEj+2NP1eoXXiLvv1hVqvoWLG6FWLHzXR7k/Acf1fqOt+2Gbs+Pb7hy 7gUYCUMTgHRPyqdc0HFJlICGDfExdn87TKtqpEuVnFlyzOAGxuK294i2NtDMmDiYEVmn M1GqlSM3yzqxK9PLDmw5iK64PdqH5tqIJ7IhxpgW0AbxlGYgtBzPEceNgcSx2/F0ICN7 0w2ZfE5iZRjF+VHpeWuW161HZWoUCr1XXHJ/3IZHhQzchcphky068Akvrqo80/uEXJrV lKAg== X-Gm-Message-State: AOJu0YxGUg0ADMWREv+caZo1hv2lwncB+rxZSPqNKkLSzX7u+7LKfhyN +kbjhZpx38y4c208F+exa6HA25WNd61Lk+HyK9/4BLgfw9/X1WzMEJ48a1HnYzVUAUJr/HLkL1R iCaxlWtOYGfe94PewbUlR0611chh8xdpH X-Gm-Gg: ASbGnctfwtTcK04kyIE+G2WP/xsLnZfFL+9/q4UP9J/adB3yqJkq9UjTGKRkKlaDYGq Kn3CQljHQ/sJHZ/KIz6sADpw2fhdzDk820AZI74uxEkOUByaSLuI7cLhymMxka3PjwKpRjM301D 1PxM2e+PI3trcqIBWWiygHvIk8Gw== X-Google-Smtp-Source: AGHT+IHUv/IkX3e9HUwYE7R2mkBLS5/qFDZEllRjPKNQUK1MZYn4ic+J84ocxPILtupVmhe33/i4BP087o23i6T3FbY= X-Received: by 2002:a05:6402:4405:b0:5e5:2c0a:448e with SMTP id 4fb4d7f45d1cf-5e5e22c0718mr4970200a12.6.1741376251517; Fri, 07 Mar 2025 11:37:31 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 7 Mar 2025 19:37:30 +0000 From: Stefan Kangas <stefankangas@HIDDEN> References: <871pv9rkjj.fsf@HIDDEN> X-Debbugs-CC: Roi Martin <jroi.martin@HIDDEN> MIME-Version: 1.0 Date: Fri, 7 Mar 2025 19:37:30 +0000 X-Gm-Features: AQ5f1JrymoDV4Edyv5WoMSB7pgcp19Rw6ljk4D2RcsyqSx6caOIgGDeawz2G5AU Message-ID: <CADwFkmni55dmzN-Ai8miQbhXig_SqfY5ESVdhmw23gj1FdkutQ@HIDDEN> Subject: [Roi Martin] [PATCH] Fix 'Skip' behavior in erts files To: bug-gnu-emacs@HIDDEN Content-Type: multipart/mixed; boundary="000000000000e49599062fc5c045" Received-SPF: pass client-ip=2a00:1450:4864:20::52e; envelope-from=stefankangas@HIDDEN; helo=mail-ed1-x52e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) --000000000000e49599062fc5c045 Content-Type: text/plain; charset="UTF-8" Forwarding this so that we don't lose track of it. -------------------- Start of forwarded message -------------------- From: Roi Martin <jroi.martin@HIDDEN> To: emacs-devel@HIDDEN Subject: [PATCH] Fix 'Skip' behavior in erts files Date: Thu, 06 Mar 2025 21:06:24 +0100 --000000000000e49599062fc5c045 Content-Type: text/plain; charset="US-ASCII" Content-Disposition: attachment Content-Transfer-Encoding: base64 X-Attachment-Id: fe729a4e046b731d_0.1.0 KiBsaXNwL2VtYWNzLWxpc3AvZXJ0LmVsIChlcnQtdGVzdC0tZXJ0cy10ZXN0KTogRml4ICdTa2lw JyBiZWhhdmlvciBpbgplcnRzIGZpbGVzLCBzbyBvbmx5IHRoZSB0ZXN0IGNhc2Ugd2hlcmUgaXQg aXMgc3BlY2lmaWVkIGlzIHNraXBwZWQuCgpUaGUgZm9sbG93aW5nIHJlcHJvZHVjZXIgbWlnaHQg YmUgdXNlZnVsIHRvIHRlc3QgdGhlIHBhdGNoLgoKZXJ0cy1yZXByby10ZXN0cy5lbDoKCgkocmVx dWlyZSAnZXJ0KQoJKHJlcXVpcmUgJ2VydC14KQoJCgkoZXJ0LWRlZnRlc3QgZXJ0cy1za2lwLXRl c3QgKCkKCSAgIlNraXAgZXJ0cyB0ZXN0IGNhc2UuIgoJICAoZXJ0LXRlc3QtZXJ0cy1maWxlIChl cnQtcmVzb3VyY2UtZmlsZSAiZXJ0cy1za2lwLmVydHMiKQoJICAgICAgICAgICAgICAgICAgICAg IChsYW1iZGEgKCkgKCkpKSkKCnJlc291cmNlcy9lcnRzLXNraXAuZXJ0czoKCglOYW1lOiBmaXJz dAoJU2tpcDogdAoJCgk9LT0KCVhYWAoJPS09CglYWFgKCT0tPS09CgkKCU5hbWU6IHNlY29uZAoJ Cgk9LT0KCVhYWAoJPS09CglZWVkKCT0tPS09CgkKCU5hbWU6IHRoaXJkCgkKCT0tPQoJWFhYCgk9 LT0KCVlZWQoJPS09LT0KCkJlZm9yZSB0aGUgZml4LCB0aGUgdGVzdCBjYXNlIG5hbWVkICJzZWNv bmQiIGlzIGFsc28gc2tpcHBlZC4gIEFsdGhvdWdoLAp0aGlyZCBpcyBydW4uICBBbHNvLCBpZiB0 aGUgbGFzdCB0ZXN0IGNhc2Ugb2YgYW4gZXJ0cyBmaWxlIGlzIHNraXBwZWQsCnRoZSBmb2xsb3dp bmcgZXJyb3IgaXMgcmVwb3J0ZWQ6CgoJRiBlcnRzLXNraXAtdGVzdAoJICAgIFNraXAgZXJ0cyB0 ZXN0IGNhc2UuCgkgICAgKHNlYXJjaC1mYWlsZWQgIl49LT0tPVxuIikKClRoaXMgbXkgZmlyc3Qg Y29udHJpYnV0aW9uIHRvIEdOVSBFbWFjcyBhbmQgSSBoYXZlIG5vdCBzaWduZWQgdGhlCkNvcHly aWdodCBBc3NpZ25tZW50IHBhcGVyd29yay4gIEhvd2V2ZXIsIGdpdmVuIHRoYXQgaXQgaXMgYSBv bmUtbGluZQpwYXRjaCwgSSB0aGluayBpdCBpcyBmaW5lIHRvIGFkZDoKCiAgICAgICAgQ29weXJp Z2h0LXBhcGVyd29yay1leGVtcHQ6IHllcwoKUmVnYXJkcywKCiAgICAgICAgUm9pCgo= --000000000000e49599062fc5c045 Content-Type: text/plain; charset="US-ASCII"; name="0001-Fix-Skip-behavior-in-erts-files.patch" Content-Disposition: attachment; filename="0001-Fix-Skip-behavior-in-erts-files.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: fe729a4e046b731d_0.1.1 RnJvbSBlYTM3N2EyNjFhZjZlZGZkNWNlMTI0MThhMjM4NzJiZjhkYmNjMGQ2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSb2kgTWFydGluIDxqcm9pLm1hcnRpbkBnbWFpbC5jb20+CkRh dGU6IFRodSwgNiBNYXIgMjAyNSAyMDoyNjo0NiArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIEZpeCAn U2tpcCcgYmVoYXZpb3IgaW4gZXJ0cyBmaWxlcwoKKiBsaXNwL2VtYWNzLWxpc3AvZXJ0LmVsIChl cnQtdGVzdC0tZXJ0cy10ZXN0KTogRml4ICdTa2lwJyBiZWhhdmlvciBpbgplcnRzIGZpbGVzLCBz byBvbmx5IHRoZSB0ZXN0IGNhc2Ugd2hlcmUgaXQgaXMgc3BlY2lmaWVkIGlzIHNraXBwZWQuCgpD b3B5cmlnaHQtcGFwZXJ3b3JrLWV4ZW1wdDogeWVzCi0tLQogbGlzcC9lbWFjcy1saXNwL2VydC5l bCB8IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQoK ZGlmZiAtLWdpdCBhL2xpc3AvZW1hY3MtbGlzcC9lcnQuZWwgYi9saXNwL2VtYWNzLWxpc3AvZXJ0 LmVsCmluZGV4IGM1N2JkMGE2OWUyZi4uZWVkZmY5ODI5NDBmIDEwMDY0NAotLS0gYS9saXNwL2Vt YWNzLWxpc3AvZXJ0LmVsCisrKyBiL2xpc3AvZW1hY3MtbGlzcC9lcnQuZWwKQEAgLTI5MDEsNyAr MjkwMSw3IEBAIGVydC10ZXN0LS1lcnRzLXRlc3QKICAgICAoaWYgKGFuZCBza2lwCiAgICAgICAg ICAgICAgKGV2YWwgKGNhciAocmVhZC1mcm9tLXN0cmluZyBza2lwKSkpKQogICAgICAgICA7OyBT a2lwcGluZyB0aGlzIHRlc3QuCi0gICAgICAgICgpCisgICAgICAgIChnb3RvLWNoYXIgZW5kLWFm dGVyKQogICAgICAgOzsgRG8gdGhlIHRlc3QuCiAgICAgICAoZ290by1jaGFyIGVuZC1hZnRlcikK ICAgICAgIDs7IFdlIGhhdmUgYSBzZXBhcmF0ZSBhZnRlciBzZWN0aW9uLgotLSAKMi40OC4xCgo= --000000000000e49599062fc5c045 Content-Type: text/plain; charset="US-ASCII" Content-Disposition: attachment Content-Transfer-Encoding: base64 X-Attachment-Id: fe729a4e046b731d_0.2 LS0tLS0tLS0tLS0tLS0tLS0tLS0gRW5kIG9mIGZvcndhcmRlZCBtZXNzYWdlIC0tLS0tLS0tLS0t LS0tLS0tLS0tCg== --000000000000e49599062fc5c045--
Stefan Kangas <stefankangas@HIDDEN>:jroi.martin@HIDDEN, bug-gnu-emacs@HIDDEN.
Full text available.jroi.martin@HIDDEN, bug-gnu-emacs@HIDDEN:bug#76839; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.