GNU logs - #76851, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#76851: 29.4; cperl-mode builtin fcn indent bug and fix
Resent-From: John Ciolfi <ciolfi@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 08 Mar 2025 06:10:02 +0000
Resent-Message-ID: <handler.76851.B.17414141755013 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 76851 <at> debbugs.gnu.org
From: John Ciolfi <ciolfi@HIDDEN>
Date: Sat, 8 Mar 2025 01:07:24 -0500
Message-ID: <r9y0xgys0z.fsf@HIDDEN>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ZAUrzqk2qmghaoN6P/YPP/+jOIbu7AA5k77kDvyL/zzjGiO2mbnHbpdGprzcsqX8A1bSNAR8njipk7WI9DmlGEI2p+IAX2mjSqNL44eLmvbB6we53ztY3DT3lOX1L3Qopacujo1Nmb9fdTxbgB7zgGJiO/0LScXgacxxaqFBLm57zk2ncBjGbxAPX1GJx5568miMlZkVhoHNUDIBOSFxjRqbsdXkidtSpRs4Rum36xqzWCi7Pt1/RBdh3JrKoFvB4jM0/G/Fj7s36jTCfypWh6UiHyN3/BUtlBsVYZ2xn2+buVtUDTzHfv0aQB6/IJsl+iBiDKKUaL9gMFK2lv6VTRdsf1NKbdCPE3TsEoc/bII8SKyDmGHi0bBAvX9qcv99gWa5L+M9SgTNIpklWLNF/AbPvAXvz0V0I9kWG3p+Bvr61HS1WEarBBpxpHW5wQClb/cT8gr20ty9NYkIzVpd2jFrvJGL1f4tclYwhzmESVWZ4IQKI2u7cVC0rjPleqOPQ2gCef/l5UE5sdni+IknMi3oHd7mXs0V/At+mRV7fgbTMgTSV7vZl3sR6qB/RObwrt3PWvA/P4ZomPAXPATICBRXQbvG9gmvteXsCNTKKHA=
X-OriginatorOrg: mathworks.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2025 06:07:25.5082 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 047a7f3d-16e4-4794-e1e9-08dd5e077fc2
X-MS-Exchange-CrossTenant-Id: 99dd3a11-4348-4468-9bdd-e5072b1dc1e6
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=99dd3a11-4348-4468-9bdd-e5072b1dc1e6; Ip=[144.212.100.35];
 Helo=[exedge.mathworks.com]
X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000A672E.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR05MB9280
X-Mimecast-Spam-Score: 0
X-Mimecast-MFC-PROC-ID: Ixwls0h0jdVbQ4OZcoM-3jdVH4AH8FvJA8U4AcV0NTU_1741414050
X-Mimecast-Originator: mathworks.com
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=170.10.129.120; envelope-from=ciolfi@HIDDEN;
 helo=us-smtp-delivery-120.mimecast.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,
 RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

--=-=-=
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable


Hi

Given this perl file:

    sub test {
        exec '/bin/echo',
            'Your arguments are: ', @ARGV;
    }
   =20
    sub exec_fcn {
    }
   =20
        sub other {
        }

The 'sub other' is indented incorrectly (and all code following it).

The fix is in cperl-after-block-and-statement-beg to not match exec_, i.e. =
we should
not treat exec_fcn as a builtin. Attached is the fix.

Thanks,
John


--=-=-=
Content-Type: text/x-diff; name=cperl-mode-builtin-fix.patch; 
	charset=WINDOWS-1252
Content-Disposition: inline; filename="cperl-mode-builtin-fix.patch"
Content-Description: cperl-mode-builtin-fix.patch
Content-Transfer-Encoding: quoted-printable

--- a/cperl-mode.el
+++ b/cperl-mode.el
@@ -5606,8 +5606,16 @@ Do not look before LIM."
 =09 (progn
 =09   (forward-sexp -1)
 =09   (not
+            ;; Used to indent functions like:
+            ;;    exec 'prog',
+            ;;        @ARGS;
+            ;; [[:space:]] means we will not match exec_fcn and 'sub other=
' is indented correctly:
+            ;;    sub exec_fcn {
+            ;;    }
+            ;;    sub other {
+            ;;    }
 =09    (looking-at
-=09     "\\(map\\|grep\\|say\\|printf?\\|system\\|exec\\|tr\\|s\\)\\>"))))=
)))
+=09     "\\(map\\|grep\\|say\\|printf?\\|system\\|exec\\|tr\\|s\\)[[:space=
:]]")))))))
=20
 =0C
 (defun cperl-indent-exp ()

--=-=-=
Content-Type: text/plain; name=ATT00001; charset=WINDOWS-1252
Content-Description: ATT00001
Content-Disposition: attachment; filename="ATT00001"
Content-Transfer-Encoding: quoted-printable


In GNU Emacs 29.4 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38,
 cairo version 1.16.0) of 2024-07-22, modified by Debian built on
 x86-ubc-01
Windowing system distributor 'The X.Org Foundation', version 11.0.12101006
System Description: Debian GNU/Linux 12 (bookworm)

Configured using:
 'configure --build x86_64-linux-gnu --prefix=3D/usr
 --sharedstatedir=3D/var/lib --libexecdir=3D/usr/libexec
 --localstatedir=3D/var/lib --infodir=3D/usr/share/info
 --mandir=3D/usr/share/man --with-libsystemd --with-pop=3Dyes
 --enable-locallisppath=3D/etc/emacs:/usr/local/share/emacs/29.4/site-lisp:=
/usr/local/share/emacs/site-lisp:/usr/share/emacs/29.4/site-lisp:/usr/share=
/emacs/site-lisp
 --with-sound=3Dalsa --without-gconf --with-mailutils
 --with-native-compilation --build x86_64-linux-gnu --prefix=3D/usr
 --sharedstatedir=3D/var/lib --libexecdir=3D/usr/libexec
 --localstatedir=3D/var/lib --infodir=3D/usr/share/info
 --mandir=3D/usr/share/man --with-libsystemd --with-pop=3Dyes
 --enable-locallisppath=3D/etc/emacs:/usr/local/share/emacs/29.4/site-lisp:=
/usr/local/share/emacs/site-lisp:/usr/share/emacs/29.4/site-lisp:/usr/share=
/emacs/site-lisp
 --with-sound=3Dalsa --without-gconf --with-mailutils
 --with-native-compilation --with-cairo --with-x=3Dyes
 --with-x-toolkit=3Dgtk3 --with-toolkit-scroll-bars 'CFLAGS=3D-g -O2
 -ffile-prefix-map=3D/build/reproducible-path/emacs-29.4+1=3D. -fstack-prot=
ector-strong
 -Wformat -Werror=3Dformat-security -Wall' 'CPPFLAGS=3D-Wdate-time
 -D_FORTIFY_SOURCE=3D2' LDFLAGS=3D-Wl,-z,relro'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES
NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3
THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINPUT2
XPM GTK3 ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Fundamental

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  blink-cursor-mode: t
  buffer-read-only: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message mailcap yank-media puny dired
dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068
epg-config gnus-util text-property-search time-date mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail
rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils comp comp-cstr
warnings subr-x rx cl-seq cl-macs gv cl-extra help-mode bytecomp
byte-compile cus-edit pp cus-start cus-load icons wid-edit cl-loaddefs
cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify
ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode lisp-mode prog-mode register
page tab-bar menu-bar rfn-eshadow isearch easymenu timer select
scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors
frame minibuffer nadvice seq simple cl-generic indonesian philippine
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite emoji-zwj charscript
charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure
cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp
files window text-properties overlay sha1 md5 base64 format env
code-pages mule custom widget keymap hashtable-print-readable backquote
threads dbusbind inotify lcms2 dynamic-setting system-font-setting
font-render-setting cairo move-toolbar gtk x-toolkit xinput2 x multi-tty
make-network-process native-compile emacs)

Memory information:
((conses 16 105675 8530)
 (symbols 48 8853 7)
 (strings 32 23487 2243)
 (string-bytes 1 691014)
 (vectors 16 17555)
 (vector-slots 8 353713 18074)
 (floats 8 39 42)
 (intervals 56 579 2)
 (buffers 984 14))

--=-=-=--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: John Ciolfi <ciolfi@HIDDEN>
Subject: bug#76851: Acknowledgement (29.4; cperl-mode builtin fcn indent
 bug and fix)
Message-ID: <handler.76851.B.17414141755013.ack <at> debbugs.gnu.org>
References: <r9y0xgys0z.fsf@HIDDEN>
X-Gnu-PR-Message: ack 76851
X-Gnu-PR-Package: emacs
Reply-To: 76851 <at> debbugs.gnu.org
Date: Sat, 08 Mar 2025 06:10:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 76851 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
76851: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D76851
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 8 Mar 2025 08:00:32 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Mar 08 03:00:32 2025
Received: from localhost ([127.0.0.1]:52621 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tqp6m-0007Jh-1K
	for submit <at> debbugs.gnu.org; Sat, 08 Mar 2025 03:00:32 -0500
Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]:46182)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
 id 1tqp6k-0007JL-He
 for control <at> debbugs.gnu.org; Sat, 08 Mar 2025 03:00:30 -0500
Received: by mail-ed1-x530.google.com with SMTP id
 4fb4d7f45d1cf-5e5e7fd051bso1784941a12.0
 for <control <at> debbugs.gnu.org>; Sat, 08 Mar 2025 00:00:30 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1741420824; x=1742025624; darn=debbugs.gnu.org;
 h=to:subject:message-id:date:mime-version:from:from:to:cc:subject
 :date:message-id:reply-to;
 bh=GXGNQwBgz9e8STRF1qVcmjCFnQi3kpCbRnuLuGb/2NQ=;
 b=GX0EidyVbiUTnRNfPZ62zL3iXU4WWa98FPurE4wQ5SOXjCH1X82l3EAp+FQ+cHJ732
 Od6rSb0urUeIA2kL/8hrGa0Onap2Q9jap54lRTc6PJBV7HSm4boBLnQz+BRxodR7KP0l
 FWDpd/YlZXlxZwbZmuPnbzouPyqTWZ1ERk5lWnsGDdJwzQfB+bISPCj5c70WQoIv2/Z5
 O67T/yrq5ZRZCk35g5bJRGuTxGy3B/1axe/LW1rZRz1LtKfzbMIEQiLbPMTOlVixcgZl
 y7666a983eoRbNbxt0eAE9miIHptVbT6drbScNcagXvZGN/raU+wT7/w8X2ufu+3mviQ
 56vA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1741420824; x=1742025624;
 h=to:subject:message-id:date:mime-version:from:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=GXGNQwBgz9e8STRF1qVcmjCFnQi3kpCbRnuLuGb/2NQ=;
 b=Ic3HXJCNZvssnPJh6a7Oi5tUzW834eYOZVk3TGcjZrXe8RevON3oqo2f7Azpo/mhXB
 rjGkeV66Jrbygw3LNNtFV9JXR/xjWi/upWCR5si+1uqsglIH1bf2JvAlOVBuUmefM3YK
 e52hI+SMeDYXXqfJzE0R8s6PHoB10760iF+BcLE6jCD5wQyObi3i61keHC8B95NMQjF3
 tYOalOADlqtT3A6OgbfgbcP2Q+QSTbG4QVFSXQPsHw+rG9cLS/Xkx27OECSrVyOiOhId
 K/Gk0e1gwKa7OiIpmx0b8/tYKz5L754xGxM2C4UNlVuyk4uxLux/AmLPG/8fgjtVoe8y
 INhg==
X-Gm-Message-State: AOJu0YzipbhQG48bJ2kcQKY7GR9SnagDB/KIJ6kZf7EyIVv7hsGra3jA
 Pfu0EwjU7qPdthdfuFYWygz50RKh4Wz83v3KBwP8aWV8GXGqzYv6wXUsydYKq3Xx1Ggav0o/bUD
 /+bmKkqK/4X1CFG09PuJKYlMRl2jr7LSZDSY=
X-Gm-Gg: ASbGncvHlZOusZQbL6o5MhwU2ojFtzM+Z+VUkIp20/uV0WaIi3EXm4xhawlwf1Ltenn
 5M75VMNTjMSkqPgKfX5ey97Ao5ZGAjKuvXUWz1KEjPfAy0lPf8KeU3Z0ioIAfNu9TM/crQWCNPu
 Hi1IgRCryi+nObi1GVAcvWjZWF9w==
X-Google-Smtp-Source: AGHT+IEBPoqz/BIWwJDNItEcpGVLWaZeyvOqgq2RWo8dz/F3sILPJKiIxe969KkRkTyoga5ctP2w1Qj3hE/aGk6eI3c=
X-Received: by 2002:a05:6402:34ce:b0:5de:c9d0:6742 with SMTP id
 4fb4d7f45d1cf-5e5e22bf528mr6521787a12.9.1741420823703; Sat, 08 Mar 2025
 00:00:23 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Sat, 8 Mar 2025 08:00:23 +0000
From: Stefan Kangas <stefankangas@HIDDEN>
MIME-Version: 1.0
Date: Sat, 8 Mar 2025 08:00:23 +0000
X-Gm-Features: AQ5f1JrTgMbUoV9XWZ2L5gW4NEa3XTUZzas5mpmSOJhYOpSEZInKbKRQg_U4scc
Message-ID: <CADwFkmk=+=nuv2eT9NHxOFpBCVbvhw3nvLdUYVQkBnY+XL1mEQ@HIDDEN>
Subject: control message for bug #76851
To: control <at> debbugs.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

tags 76851 + patch
quit

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#76851: 29.4; cperl-mode builtin fcn indent bug and fix
Resent-From: Stefan Kangas <stefankangas@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 08 Mar 2025 08:02:02 +0000
Resent-Message-ID: <handler.76851.B76851.174142090928324 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: John Ciolfi <ciolfi@HIDDEN>, 76851 <at> debbugs.gnu.org
Cc: Harald =?UTF-8?Q?J=C3=B6rg?= <haj@HIDDEN>
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <r9y0xgys0z.fsf@HIDDEN>
References: <r9y0xgys0z.fsf@HIDDEN>
MIME-Version: 1.0
Date: Sat, 8 Mar 2025 08:01:36 +0000
Message-ID: <CADwFkm=vdaX1iJxv5ODw-GuhQ5YFpCbYfkm++W5e==bw3v9X1A@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

John Ciolfi via "Bug reports for GNU Emacs, the Swiss army knife of text
editors" <bug-gnu-emacs@HIDDEN> writes:

> Hi
>
> Given this perl file:
>
>     sub test {
>         exec '/bin/echo',
>             'Your arguments are: ', @ARGV;
>     }
>
>     sub exec_fcn {
>     }
>
>         sub other {
>         }
>
> The 'sub other' is indented incorrectly (and all code following it).
>
> The fix is in cperl-after-block-and-statement-beg to not match exec_, i.e=
. we should
> not treat exec_fcn as a builtin. Attached is the fix.

Harald, any comments on this patch?

>
> Thanks,
> John
>
> --- a/cperl-mode.el
> +++ b/cperl-mode.el
> @@ -5606,8 +5606,16 @@ Do not look before LIM."
>  	 (progn
>  	   (forward-sexp -1)
>  	   (not
> +            ;; Used to indent functions like:
> +            ;;    exec 'prog',
> +            ;;        @ARGS;
> +            ;; [[:space:]] means we will not match exec_fcn and 'sub oth=
er' is indented correctly:
> +            ;;    sub exec_fcn {
> +            ;;    }
> +            ;;    sub other {
> +            ;;    }
>  	    (looking-at
> -	     "\\(map\\|grep\\|say\\|printf?\\|system\\|exec\\|tr\\|s\\)\\>"))))=
)))
> +	     "\\(map\\|grep\\|say\\|printf?\\|system\\|exec\\|tr\\|s\\)[[:space=
:]]")))))))
>
>  =0C
>  (defun cperl-indent-exp ()
>
> In GNU Emacs 29.4 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38,
>  cairo version 1.16.0) of 2024-07-22, modified by Debian built on
>  x86-ubc-01
> Windowing system distributor 'The X.Org Foundation', version 11.0.1210100=
6
> System Description: Debian GNU/Linux 12 (bookworm)
>
> Configured using:
>  'configure --build x86_64-linux-gnu --prefix=3D/usr
>  --sharedstatedir=3D/var/lib --libexecdir=3D/usr/libexec
>  --localstatedir=3D/var/lib --infodir=3D/usr/share/info
>  --mandir=3D/usr/share/man --with-libsystemd --with-pop=3Dyes
>  --enable-locallisppath=3D/etc/emacs:/usr/local/share/emacs/29.4/site-lis=
p:/usr/local/share/emacs/site-lisp:/usr/share/emacs/29.4/site-lisp:/usr/sha=
re/emacs/site-lisp
>  --with-sound=3Dalsa --without-gconf --with-mailutils
>  --with-native-compilation --build x86_64-linux-gnu --prefix=3D/usr
>  --sharedstatedir=3D/var/lib --libexecdir=3D/usr/libexec
>  --localstatedir=3D/var/lib --infodir=3D/usr/share/info
>  --mandir=3D/usr/share/man --with-libsystemd --with-pop=3Dyes
>  --enable-locallisppath=3D/etc/emacs:/usr/local/share/emacs/29.4/site-lis=
p:/usr/local/share/emacs/site-lisp:/usr/share/emacs/29.4/site-lisp:/usr/sha=
re/emacs/site-lisp
>  --with-sound=3Dalsa --without-gconf --with-mailutils
>  --with-native-compilation --with-cairo --with-x=3Dyes
>  --with-x-toolkit=3Dgtk3 --with-toolkit-scroll-bars 'CFLAGS=3D-g -O2
>  -ffile-prefix-map=3D/build/reproducible-path/emacs-29.4+1=3D. -fstack-pr=
otector-strong
>  -Wformat -Werror=3Dformat-security -Wall' 'CPPFLAGS=3D-Wdate-time
>  -D_FORTIFY_SOURCE=3D2' LDFLAGS=3D-Wl,-z,relro'
>
> Configured features:
> ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
> JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES
> NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3
> THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINPUT2
> XPM GTK3 ZLIB
>
> Important settings:
>   value of $LANG: en_US.UTF-8
>   locale-coding-system: utf-8-unix
>
> Major mode: Fundamental
>
> Minor modes in effect:
>   tooltip-mode: t
>   global-eldoc-mode: t
>   show-paren-mode: t
>   electric-indent-mode: t
>   mouse-wheel-mode: t
>   tool-bar-mode: t
>   menu-bar-mode: t
>   file-name-shadow-mode: t
>   global-font-lock-mode: t
>   blink-cursor-mode: t
>   buffer-read-only: t
>   line-number-mode: t
>   indent-tabs-mode: t
>   transient-mark-mode: t
>   auto-composition-mode: t
>   auto-encryption-mode: t
>   auto-compression-mode: t
>
> Load-path shadows:
> None found.
>
> Features:
> (shadow sort mail-extr emacsbug message mailcap yank-media puny dired
> dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068
> epg-config gnus-util text-property-search time-date mm-decode mm-bodies
> mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail
> rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils comp comp-cstr
> warnings subr-x rx cl-seq cl-macs gv cl-extra help-mode bytecomp
> byte-compile cus-edit pp cus-start cus-load icons wid-edit cl-loaddefs
> cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify
> ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win
> term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
> tabulated-list replace newcomment text-mode lisp-mode prog-mode register
> page tab-bar menu-bar rfn-eshadow isearch easymenu timer select
> scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors
> frame minibuffer nadvice seq simple cl-generic indonesian philippine
> cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
> korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
> european ethiopic indian cyrillic chinese composite emoji-zwj charscript
> charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure
> cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp
> files window text-properties overlay sha1 md5 base64 format env
> code-pages mule custom widget keymap hashtable-print-readable backquote
> threads dbusbind inotify lcms2 dynamic-setting system-font-setting
> font-render-setting cairo move-toolbar gtk x-toolkit xinput2 x multi-tty
> make-network-process native-compile emacs)
>
> Memory information:
> ((conses 16 105675 8530)
>  (symbols 48 8853 7)
>  (strings 32 23487 2243)
>  (string-bytes 1 691014)
>  (vectors 16 17555)
>  (vector-slots 8 353713 18074)
>  (floats 8 39 42)
>  (intervals 56 579 2)
>  (buffers 984 14))

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#76851: 29.4; cperl-mode builtin fcn indent bug and fix
Resent-From: Harald =?UTF-8?Q?J=C3=B6rg?= <haj@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 08 Mar 2025 09:49:02 +0000
Resent-Message-ID: <handler.76851.B76851.174142733019631 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 76851
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Stefan Kangas <stefankangas@HIDDEN>
Cc: John Ciolfi <ciolfi@HIDDEN>, 76851 <at> debbugs.gnu.org
Received: via spool by 76851-submit <at> debbugs.gnu.org id=B76851.174142733019631
          (code B ref 76851); Sat, 08 Mar 2025 09:49:02 +0000
Received: (at 76851) by debbugs.gnu.org; 8 Mar 2025 09:48:50 +0000
Received: from localhost ([127.0.0.1]:52885 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tqqna-00056W-5H
	for submit <at> debbugs.gnu.org; Sat, 08 Mar 2025 04:48:50 -0500
Received: from mout01.posteo.de ([185.67.36.65]:35827)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <haj@HIDDEN>) id 1tqqnU-00056C-7c
 for 76851 <at> debbugs.gnu.org; Sat, 08 Mar 2025 04:48:47 -0500
Received: from submission (posteo.de [185.67.36.169]) 
 by mout01.posteo.de (Postfix) with ESMTPS id 73307240027
 for <76851 <at> debbugs.gnu.org>; Sat,  8 Mar 2025 10:48:36 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017;
 t=1741427316; bh=pFl7xJg3dHdqqw/TBkqkz1HJES2jLeL7iXwySFu78ek=;
 h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type:
 From;
 b=S3Ma5KUewZvT+I4gZ8Irun8X7LuJmdg1i1sgvsB1E/Nw+d5fKw/AznYGrY6kMnpdU
 d00bNsVb3xTCXoII/ckDb59L/WCmjC6AtWRKCNXSu384aK4/Wr2b1bg2EaGCu7L5Wh
 SGI4W6UCOSAmsSZvi4jkrVNoR8ybsJL/bdMHwdY7+UsFo9ZDp8yRlPxBH0mByySQ8R
 Kv/sqWgJC2Xm5uOCFQrboTKxQdeHna68wSdH07Qd527uEg/UCJcqZBjXNKtC4RZaAY
 4tPrQMAIRoQvGQfUMLXiyeOj6kEYZtRiS8ppBEyLMHScURXeCr86uyR4d8VCtRZMcs
 GAWD0enJ1PqfA==
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 4Z8yyq4qPFz6typ;
 Sat,  8 Mar 2025 10:48:35 +0100 (CET)
From: Harald =?UTF-8?Q?J=C3=B6rg?= <haj@HIDDEN>
In-Reply-To: <CADwFkm=vdaX1iJxv5ODw-GuhQ5YFpCbYfkm++W5e==bw3v9X1A@HIDDEN>
 (Stefan Kangas's message of "Sat, 8 Mar 2025 08:01:36 +0000")
References: <r9y0xgys0z.fsf@HIDDEN>
 <CADwFkm=vdaX1iJxv5ODw-GuhQ5YFpCbYfkm++W5e==bw3v9X1A@HIDDEN>
Date: Sat, 08 Mar 2025 09:48:35 +0000
Message-ID: <87zfhvetu4.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Stefan Kangas <stefankangas@HIDDEN> writes:

> John Ciolfi via "Bug reports for GNU Emacs, the Swiss army knife of text
> editors" <bug-gnu-emacs@HIDDEN> writes:
>
>> Hi
>>
>> Given this perl file:
>>
>>     sub test {
>>         exec '/bin/echo',
>>             'Your arguments are: ', @ARGV;
>>     }
>>
>>     sub exec_fcn {
>>     }
>>
>>         sub other {
>>         }
>>
>> The 'sub other' is indented incorrectly (and all code following it).
>>
>> The fix is in cperl-after-block-and-statement-beg to not match exec_, i.e. we should
>> not treat exec_fcn as a builtin. Attached is the fix.
>
> Harald, any comments on this patch?

Yes :)

I confirm this is a bug, and one of those nasty ones which affect all
following code.

I suggest a slightly improved patch.  Instead of replacing \> (end of
word) by [[:space:]] it should be replaced by \_> (end of symbol).
A space is not required after the keywords in the list.  In the case of
exec, this is handled elsewhere, but there are keywords in the list
where it matters.

With [[:space:]], the following indentation happens:

    my %h = map{$_=>1}
    @ARGV;

With \_>, @ARGV is correctly indented as a continuation line:

    my %h = map{$_=>1}
        @ARGV;

This is less severe than the bug reported because it does not affect
following code, but still should not happen.

>
>>
>> Thanks,
>> John
>>
>> --- a/cperl-mode.el
>> +++ b/cperl-mode.el
>> @@ -5606,8 +5606,16 @@ Do not look before LIM."
>>  	 (progn
>>  	   (forward-sexp -1)
>>  	   (not
>> +            ;; Used to indent functions like:
>> +            ;;    exec 'prog',
>> +            ;;        @ARGS;
>> +            ;; [[:space:]] means we will not match exec_fcn and 'sub other' is indented correctly:
>> +            ;;    sub exec_fcn {
>> +            ;;    }
>> +            ;;    sub other {
>> +            ;;    }
>>  	    (looking-at
>> -	     "\\(map\\|grep\\|say\\|printf?\\|system\\|exec\\|tr\\|s\\)\\>")))))))
>> +	     "\\(map\\|grep\\|say\\|printf?\\|system\\|exec\\|tr\\|s\\)[[:space:]]")))))))
>>
>>  
>>  (defun cperl-indent-exp ()
>>
>> In GNU Emacs 29.4 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38,
>>  cairo version 1.16.0) of 2024-07-22, modified by Debian built on
>>  x86-ubc-01
>> Windowing system distributor 'The X.Org Foundation', version 11.0.12101006
>> System Description: Debian GNU/Linux 12 (bookworm)
>>
>> Configured using:
>>  'configure --build x86_64-linux-gnu --prefix=/usr
>>  --sharedstatedir=/var/lib --libexecdir=/usr/libexec
>>  --localstatedir=/var/lib --infodir=/usr/share/info
>>  --mandir=/usr/share/man --with-libsystemd --with-pop=yes
>>  --enable-locallisppath=/etc/emacs:/usr/local/share/emacs/29.4/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/29.4/site-lisp:/usr/share/emacs/site-lisp
>>  --with-sound=alsa --without-gconf --with-mailutils
>>  --with-native-compilation --build x86_64-linux-gnu --prefix=/usr
>>  --sharedstatedir=/var/lib --libexecdir=/usr/libexec
>>  --localstatedir=/var/lib --infodir=/usr/share/info
>>  --mandir=/usr/share/man --with-libsystemd --with-pop=yes
>>  --enable-locallisppath=/etc/emacs:/usr/local/share/emacs/29.4/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/29.4/site-lisp:/usr/share/emacs/site-lisp
>>  --with-sound=alsa --without-gconf --with-mailutils
>>  --with-native-compilation --with-cairo --with-x=yes
>>  --with-x-toolkit=gtk3 --with-toolkit-scroll-bars 'CFLAGS=-g -O2
>>  -ffile-prefix-map=/build/reproducible-path/emacs-29.4+1=. -fstack-protector-strong
>>  -Wformat -Werror=format-security -Wall' 'CPPFLAGS=-Wdate-time
>>  -D_FORTIFY_SOURCE=2' LDFLAGS=-Wl,-z,relro'
>>
>> Configured features:
>> ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
>> JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES
>> NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3
>> THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINPUT2
>> XPM GTK3 ZLIB
>>
>> Important settings:
>>   value of $LANG: en_US.UTF-8
>>   locale-coding-system: utf-8-unix
>>
>> Major mode: Fundamental
>>
>> Minor modes in effect:
>>   tooltip-mode: t
>>   global-eldoc-mode: t
>>   show-paren-mode: t
>>   electric-indent-mode: t
>>   mouse-wheel-mode: t
>>   tool-bar-mode: t
>>   menu-bar-mode: t
>>   file-name-shadow-mode: t
>>   global-font-lock-mode: t
>>   blink-cursor-mode: t
>>   buffer-read-only: t
>>   line-number-mode: t
>>   indent-tabs-mode: t
>>   transient-mark-mode: t
>>   auto-composition-mode: t
>>   auto-encryption-mode: t
>>   auto-compression-mode: t
>>
>> Load-path shadows:
>> None found.
>>
>> Features:
>> (shadow sort mail-extr emacsbug message mailcap yank-media puny dired
>> dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068
>> epg-config gnus-util text-property-search time-date mm-decode mm-bodies
>> mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail
>> rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils comp comp-cstr
>> warnings subr-x rx cl-seq cl-macs gv cl-extra help-mode bytecomp
>> byte-compile cus-edit pp cus-start cus-load icons wid-edit cl-loaddefs
>> cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify
>> ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win
>> term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
>> tabulated-list replace newcomment text-mode lisp-mode prog-mode register
>> page tab-bar menu-bar rfn-eshadow isearch easymenu timer select
>> scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors
>> frame minibuffer nadvice seq simple cl-generic indonesian philippine
>> cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
>> korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
>> european ethiopic indian cyrillic chinese composite emoji-zwj charscript
>> charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure
>> cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp
>> files window text-properties overlay sha1 md5 base64 format env
>> code-pages mule custom widget keymap hashtable-print-readable backquote
>> threads dbusbind inotify lcms2 dynamic-setting system-font-setting
>> font-render-setting cairo move-toolbar gtk x-toolkit xinput2 x multi-tty
>> make-network-process native-compile emacs)
>>
>> Memory information:
>> ((conses 16 105675 8530)
>>  (symbols 48 8853 7)
>>  (strings 32 23487 2243)
>>  (string-bytes 1 691014)
>>  (vectors 16 17555)
>>  (vector-slots 8 353713 18074)
>>  (floats 8 39 42)
>>  (intervals 56 579 2)
>>  (buffers 984 14))

-- 
Cheers,
haj

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#76851: 29.4; cperl-mode builtin fcn indent bug and fix
Resent-From: Stefan Kangas <stefankangas@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 08 Mar 2025 09:52:02 +0000
Resent-Message-ID: <handler.76851.B76851.174142750720349 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 76851
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Harald =?UTF-8?Q?J=C3=B6rg?= <haj@HIDDEN>
Cc: John Ciolfi <ciolfi@HIDDEN>, 76851 <at> debbugs.gnu.org
Received: via spool by 76851-submit <at> debbugs.gnu.org id=B76851.174142750720349
          (code B ref 76851); Sat, 08 Mar 2025 09:52:02 +0000
Received: (at 76851) by debbugs.gnu.org; 8 Mar 2025 09:51:47 +0000
Received: from localhost ([127.0.0.1]:52897 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tqqqR-0005I9-5X
	for submit <at> debbugs.gnu.org; Sat, 08 Mar 2025 04:51:47 -0500
Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]:47236)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
 id 1tqqqO-0005Ht-Dg
 for 76851 <at> debbugs.gnu.org; Sat, 08 Mar 2025 04:51:45 -0500
Received: by mail-ed1-x535.google.com with SMTP id
 4fb4d7f45d1cf-5e60cfef9cfso1568037a12.2
 for <76851 <at> debbugs.gnu.org>; Sat, 08 Mar 2025 01:51:44 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1741427498; x=1742032298; darn=debbugs.gnu.org;
 h=content-transfer-encoding:cc:to:subject:message-id:date
 :mime-version:references:in-reply-to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=HYiyK9VNwAsNuPY3ZuY2TE4zMqKN6RCOTuX5if3y3oY=;
 b=BvBdPzknSX8biid9NByQkBSLoOigoFI6mVFhuD88MT5lqZ2tbFw9xNSDqOisxUC1kx
 y0ZDzaoXGObUR4Yjo4G8mFISWF4iSf+4uLy1ljfg3SwDg2a3Oe4vB2JJ7QkLMcH4EzGz
 ZSvjULMVa6OQV0mehbNXrKsdDIlSYaQ9DxdiuG3VPU9hBht76dY4Z+cSOxeN1ibaeKfm
 vTXgseB6fQYnQfB3A1ihAk9wvsFX3Yg1VQvUuH8BYIaFb8by3ZXjZ3zTxOZACBWsd/Go
 uWW2GHYHiBLt8Z7knbysXqbSauPblmU4ZzT8tgq0gCyPx2gYvIpG8MkEevk4rz0XNa5c
 A6UA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1741427498; x=1742032298;
 h=content-transfer-encoding:cc:to:subject:message-id:date
 :mime-version:references:in-reply-to:from:x-gm-message-state:from:to
 :cc:subject:date:message-id:reply-to;
 bh=HYiyK9VNwAsNuPY3ZuY2TE4zMqKN6RCOTuX5if3y3oY=;
 b=Yjtjx07bzxmJPekBd+S27JW3QxrcocBWXZs3lYV71qaPbHM1z8bKBGxuQ3vKKCPuhB
 V7SuRo4xRlMYB6+jMX++C1F41PhyZsNbluRBLVxhdDg120DkwuhRDVxO7xJIQHcy8yXH
 mw7ob42gujMsUHKO1Utdg8Gkx+44Gc5mC3a6OuNrLrktgVvo59X5eKyDb8GtXi7lXzq0
 vpjzQdcOYAto/ehN2/ClTEgWjyHBy2fsMTp9h2VoCy8C/aFnns2dOvRR47Ha/yhCwsqK
 MmyYVA6odumxCCEVTF/k2SEN58GHy6C9lZEbnv2qVtxmmXX79addRzvNaWEZLN1apt7Z
 1fWg==
X-Forwarded-Encrypted: i=1;
 AJvYcCWPDGyMupiiuaRBDMuDW7serkEEg82IV+1narGv3tzTEvARfcEAvFOMuUL7KDB7ZZwBUQEp2Q==@debbugs.gnu.org
X-Gm-Message-State: AOJu0Yz/4gtWnMNx0jzhd7AbrGwRNQl+0tzv4D1cyg4dujDFf6JHn44D
 ZJEE5FLQ89RyLp9iITpCmE5Iu4FMtBJF8wRixIm+vdS1JlnlbTd6XDav9RdnYaqUzKd8CG1cvlK
 zEDRrTDcxTlaH9lJc5Yf/IbVutSI=
X-Gm-Gg: ASbGnct3exB1XYI87sa42B9lCZWwC2xCR/cz/Ug2ntZ1XpnMl2ETfSI4j6AIm/apFR1
 i3au0tGg5fq4Yb8Yxo5MPQVSTwSd2FE+5sQf67BHKOKmHMd/5mZA03lAxjYDes32urCupEtBBKM
 7zNyR5toGjJagrbc3OSqvbK6D3vg==
X-Google-Smtp-Source: AGHT+IH+MvUtfdwx+ROI2Zr9P6L6yzMDm3nDWrj6UHHcfVSP7H8PASu6/y6uy74WwDwVWAK+RSQYvI54huwPPbzkbdk=
X-Received: by 2002:a05:6402:2546:b0:5e5:c637:b69 with SMTP id
 4fb4d7f45d1cf-5e5e22a929bmr6348606a12.6.1741427498035; Sat, 08 Mar 2025
 01:51:38 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Sat, 8 Mar 2025 09:51:37 +0000
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <87zfhvetu4.fsf@HIDDEN>
References: <r9y0xgys0z.fsf@HIDDEN>
 <CADwFkm=vdaX1iJxv5ODw-GuhQ5YFpCbYfkm++W5e==bw3v9X1A@HIDDEN>
 <87zfhvetu4.fsf@HIDDEN>
MIME-Version: 1.0
Date: Sat, 8 Mar 2025 09:51:37 +0000
X-Gm-Features: AQ5f1JpU6oJbPn6d5gG8wapwXiPUUPpH58dN45dyvB9r3VmfiwCQE6HX2E_uG1Q
Message-ID: <CADwFkmnCoeOX2kiJXNg++WfGOdjpv+4BPD1Gt-etLD50CZYh+g@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Harald J=C3=B6rg <haj@HIDDEN> writes:

> Stefan Kangas <stefankangas@HIDDEN> writes:
>
>> John Ciolfi via "Bug reports for GNU Emacs, the Swiss army knife of text
>> editors" <bug-gnu-emacs@HIDDEN> writes:
>>
>>> Hi
>>>
>>> Given this perl file:
>>>
>>>     sub test {
>>>         exec '/bin/echo',
>>>             'Your arguments are: ', @ARGV;
>>>     }
>>>
>>>     sub exec_fcn {
>>>     }
>>>
>>>         sub other {
>>>         }
>>>
>>> The 'sub other' is indented incorrectly (and all code following it).
>>>
>>> The fix is in cperl-after-block-and-statement-beg to not match exec_, i=
.e. we should
>>> not treat exec_fcn as a builtin. Attached is the fix.
>>
>> Harald, any comments on this patch?
>
> Yes :)
>
> I confirm this is a bug, and one of those nasty ones which affect all
> following code.
>
> I suggest a slightly improved patch.  Instead of replacing \> (end of
> word) by [[:space:]] it should be replaced by \_> (end of symbol).
> A space is not required after the keywords in the list.  In the case of
> exec, this is handled elsewhere, but there are keywords in the list
> where it matters.
>
> With [[:space:]], the following indentation happens:
>
>     my %h =3D map{$_=3D>1}
>     @ARGV;
>
> With \_>, @ARGV is correctly indented as a continuation line:
>
>     my %h =3D map{$_=3D>1}
>         @ARGV;
>
> This is less severe than the bug reported because it does not affect
> following code, but still should not happen.

I recommend adding tests for the above.  I think we already have good
erts tests in cperl-indents.erts, that could easily be expanded.

Last modified: Sat, 8 Mar 2025 10:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.