GNU logs - #77079, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#77079: 31.0.50; Re-parenting tty child frame leaves two instances on display
Resent-From: martin rudalics <rudalics@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 17 Mar 2025 18:53:05 +0000
Resent-Message-ID: <handler.77079.B.174223757831936 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 77079 <at> debbugs.gnu.org
Cc: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
Message-ID: <d72b2adb-8ad2-4bbb-93bb-31f90bb047ca@HIDDEN>
Date: Mon, 17 Mar 2025 19:52:41 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
From: martin rudalics <rudalics@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
UI-OutboundReport: notjunk:1;M01:P0:JvCU6jnCEH0=;uJeh4U73ndmFIPDKEEmVYhSnIAc
 E79XGVwkJOdgVw6SBV+2x6c9NsGr1mzN01TYH2/oI12iHFXvp78of6KgN3pz+Y+2mDRqCJF0Z
 rITR761TgDuzJhkRKvU0W04/olZVivTY71Lq0QFaqNhvXoCXAOjcTm739ts9ZSxheL+ZoDrup
 RoUFs7udO7U4y3N66R2p1F94v6tRT+OGXlcpOtvYM1KkhrS2tlE5msVl2GZUE8RgL4fiA7nLx
 TAAIejX48aHuRGfM1kzNGqh2+y6kIv+WbNEWofkZjxItDlbhhoYRF21i0B4U8lYKoVBLLuOk3
 U7t3H3fSi900aAVfDbNx9gnuFUkPJMGgbW1ve8b3wY1CWNEWZAQWhlDlXOC6yuUitT5wnxCsl
 bo5F1Pdhyk1VeVJdRNvef7tVSrsfN3Hckc5pxoX/cJxKf2Djjq4jn7fZlL3tpUFBRob67lDpy
 iMEM+9SPbu0ySGuP+C4zJ1bQqsVxUpCjeR2fSNU9KayVd9j9s012KyCkqdihczO5fNdNfUZ5l
 2/WnoE2fipS5f+Ypf8i6b0wIWdZSvIwNbfMh8Os1PqKpWiK3v5QVOwloMyM0m7NSt03vrwEvz
 rWrPuyzI/mpdN3MjL+F+dxhjGpSWwjz1Lb0m8jdaff5CWgt5jLAIgyBn04vDsELZMDI7fpBqJ
 si8IohdIXEk+N1lgLnamb5OY6TdbUX9r9/cSLZYANvKTPyGvn1SXowIZFgkL5K32Vc6xqYebl
 tgtHmcfHo6AitFkLMpNqC0+PS18HXj8auEuPopEzvsNIklgj5jlXrT2OW7jdB4IzMkCP/Pm/+
 vr67LlIvyd5geu1bOR7mrSCsffuXrVZp41L8HtpriGgcperJF+eKrY+6G3UDpl8Kb8QZEiOg+
 Map0SRjakMfpxa2q0viAer6ufKMhpEHB+8SJoShyFCuffBa/Bo35q5dxe0uD+0vC2BX6PhRNZ
 8EOzHJ/SsB1wIccxGcY4a7FyH0A8Jqw4AYw5SUncb6i1EbUZLY7AUvdC/Lj+KDjCinfN/3Q1e
 jTEE7qHCRJysHHnTUkBXmb77LFa3/A9WZC/iTnBgTTKzid0EyGCEQ7y0FrT9f67vg9ZPzxWbs
 jxOCRjRIJaWoRwmA+FoDgxoa46ffLYEPi5LR7f/hixhOM5oey+iws4mtgXiFpact9mzFTVrmd
 h3sbFhfs32sAijHRMBCIebPpEw4bBJxnI64Dlr9qIdOXNMOv/M9ySYq79EOEyDMMHglQwgOKt
 Tw920RwIfnwkTBrP2AbQmIgmsw/ORrG80PWdiHPkPw6el/b8YxC1ydr8PEU/UPuRWuFCwz8r8
 3VtiC+O74l4DJaNGHqlW6RHJBVZJ4Xl8f44sqMhYKbe1WqpzHcdXQ/X8GMSQoQjgQi5LDELSQ
 82GkxnZOymathwzHLWd3Db1Y2SeNdG0Y/QKXXm0p7ihs7hjj806ps3n8kiibHtuZED1f6E+pv
 Ch+FXDNb3awsb0rEQNXdT2231Kd0=
Received-SPF: pass client-ip=212.227.15.18; envelope-from=rudalics@HIDDEN;
 helo=mout.gmx.net
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=0.001,
 RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

I think we need the following change

diff --git a/src/frame.c b/src/frame.c
index c1ef26e5dd4..9a4ca7d0682 100644
--- a/src/frame.c
+++ b/src/frame.c
@@ -3706,6 +3706,7 @@ store_frame_param (struct frame *f, Lisp_Object prop, Lisp_Object val)
        if (NILP (f->parent_frame) != NILP (val))
  	error ("Making a root frame a child or vice versa is not supported");
        f->parent_frame = val;
+      SET_FRAME_GARBAGED (root_frame (f));
      }

    /* The tty color needed to be set before the frame's parameter

since otherwise re-parenting a child frame, for example, using

(set-frame-parameter tty-3 'parent-frame tty-1)

from my earlier tty-child-frames.el leaves one with two instances of the
child frame on display.

martin

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: martin rudalics <rudalics@HIDDEN>
Subject: bug#77079: Acknowledgement (31.0.50; Re-parenting tty child frame
 leaves two instances on display)
Message-ID: <handler.77079.B.174223757831936.ack <at> debbugs.gnu.org>
References: <d72b2adb-8ad2-4bbb-93bb-31f90bb047ca@HIDDEN>
X-Gnu-PR-Message: ack 77079
X-Gnu-PR-Package: emacs
Reply-To: 77079 <at> debbugs.gnu.org
Date: Mon, 17 Mar 2025 18:53:06 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 77079 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
77079: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D77079
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#77079: 31.0.50; Re-parenting tty child frame leaves two instances on display
Resent-From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 17 Mar 2025 19:52:02 +0000
Resent-Message-ID: <handler.77079.B.174224110117560 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: martin rudalics <rudalics@HIDDEN>
Cc: 77079 <at> debbugs.gnu.org
From: Gerd =?UTF-8?Q?M=C3=B6llmann?= <gerd.moellmann@HIDDEN>
In-Reply-To: <d72b2adb-8ad2-4bbb-93bb-31f90bb047ca@HIDDEN>
References: <d72b2adb-8ad2-4bbb-93bb-31f90bb047ca@HIDDEN>
Date: Mon, 17 Mar 2025 20:50:52 +0100
Message-ID: <m21puvsag3.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=2a00:1450:4864:20::331;
 envelope-from=gerd.moellmann@HIDDEN; helo=mail-wm1-x331.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

martin rudalics <rudalics@HIDDEN> writes:

> I think we need the following change
>
> diff --git a/src/frame.c b/src/frame.c
> index c1ef26e5dd4..9a4ca7d0682 100644
> --- a/src/frame.c
> +++ b/src/frame.c
> @@ -3706,6 +3706,7 @@ store_frame_param (struct frame *f, Lisp_Object prop, Lisp_Object val)
>         if (NILP (f->parent_frame) != NILP (val))
>   	error ("Making a root frame a child or vice versa is not supported");
>         f->parent_frame = val;
> +      SET_FRAME_GARBAGED (root_frame (f));
>       }
>
>     /* The tty color needed to be set before the frame's parameter
>
> since otherwise re-parenting a child frame, for example, using
>
> (set-frame-parameter tty-3 'parent-frame tty-1)
>
> from my earlier tty-child-frames.el leaves one with two instances of the
> child frame on display.
>
> martin

Yep, for sure.

Last modified: Mon, 17 Mar 2025 20:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.