GNU bug report logs - #77143
30.1; package--description-file handles some packages wrong

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Package: emacs; Reported by: Lin Jian <me@HIDDEN>; Keywords: patch; dated Fri, 21 Mar 2025 01:12:03 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.
Added tag(s) patch. Request was from Stefan Kangas <stefankangas@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 77143 <at> debbugs.gnu.org:


Received: (at 77143) by debbugs.gnu.org; 21 Mar 2025 03:51:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Mar 20 23:51:06 2025
Received: from localhost ([127.0.0.1]:32884 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tvTPV-0001JM-Ui
	for submit <at> debbugs.gnu.org; Thu, 20 Mar 2025 23:51:06 -0400
Received: from mail.linj.tech ([5.255.109.209]:42042)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <me@HIDDEN>) id 1tvTPP-0001IE-I9
 for 77143 <at> debbugs.gnu.org; Thu, 20 Mar 2025 23:51:03 -0400
From: Lin Jian <me@HIDDEN>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linj.tech; s=mail;
 t=1742529053; bh=DRR7Ca10DnIefMUvRBvILyPKRcZAHbunClLTpoEI15k=;
 h=From:To:Subject:In-Reply-To:References:Date;
 b=ciwKFf5KpaCgVIOATR6dWCCEaphqHtTAnynxISW1DbfNYDPgJ8B2dzUjYDwl0L1aT
 pWGyfQHWVklHNqUfPmPBPc9JIOivFKTKXX0Z2lnCJiYuGP+my1T9q3Vj0eOOGVENyi
 9frmfavifCVMyjTs3bXDCsCtqngmVgNMoW7E27zaqlLLCBy41Ge0O3g8+NYLd4D9w4
 TT09EAxVnMAj3l8izo9bdRoyubBMoPPE5nPOcjAyvHYwvJQOWAnZ1KTyIUexgXYn9f
 US6KvJT9jGJ/+cSJ9u1aTjkfLXBjxY+sibmFx/C9zsWSTSO7CL38x2OILrkzpQ4Sfo
 1FdsFStmdd8qA==
To: 77143 <at> debbugs.gnu.org
Subject: Re: 30.1; package--description-file handles some packages wrong
In-Reply-To: <87y0wzt9n1.fsf@HIDDEN> (Lin Jian's message of "Fri, 21 Mar
 2025 10:12:02 +0800")
References: <877c4jur1d.fsf@HIDDEN>
 <handler.77143.B.174251948516377.ack <at> debbugs.gnu.org>
 <87y0wzt9n1.fsf@HIDDEN>
Date: Fri, 21 Mar 2025 11:50:42 +0800
Message-ID: <87sen7t52l.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 77143
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Lin Jian <me@HIDDEN> writes:

> I also notice that the version part of the regex can be improved because
> it does not take `version-regexp-alist' into consideration.  But that is
> out of the scope of this bug.

I tested the above patch with all elisp packages from (Non)GNU(-devel)
ELPA and MELPA.  All 7 packages from my initial post are fixed.  At the
same time, I find only one package vm[0] is "broken" by my patch.

Without my patch, the result is right.
(package--description-file "vm-8.3.0snapshot0.20250208.60553")
  =E2=87=92 "vm-pkg.el"

With my patch, the result is wrong.
(package--description-file "vm-8.3.0snapshot0.20250208.60553")
  =E2=87=92 "vm-8.3.0snapshot0.20250208.60553-pkg.el"

A quick fix is to add snapshot to the regex version part.

A proper fix is to make the regex version part know
`version-regexp-alist'.

[0]: https://elpa.nongnu.org/nongnu-devel/vm.html
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#77143; Package emacs. Full text available.

Message received at 77143 <at> debbugs.gnu.org:


Received: (at 77143) by debbugs.gnu.org; 21 Mar 2025 02:12:17 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Mar 20 22:12:17 2025
Received: from localhost ([127.0.0.1]:60258 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tvRrp-00045L-An
	for submit <at> debbugs.gnu.org; Thu, 20 Mar 2025 22:12:17 -0400
Received: from mail.linj.tech ([5.255.109.209]:50934)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <me@HIDDEN>) id 1tvRrj-00044V-5d
 for 77143 <at> debbugs.gnu.org; Thu, 20 Mar 2025 22:12:11 -0400
From: Lin Jian <me@HIDDEN>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linj.tech; s=mail;
 t=1742523125; bh=Cckzf6/KxL6Kw9gLD8VzOHbZJj5Wi4l963k3PmHrZTc=;
 h=From:To:Subject:In-Reply-To:References:Date;
 b=HuKi8BbbSlJ/xLbLO8ko1gB7AtIIVSkjEncTswPo7Xrm4mg0HFPxUHx1qXbGhXG6H
 4IbNaq+Dlgy1UCgQ+M2YC/6GtoaVMTRp6bJA6Dg28NEKWk8RYeLDDsMX0r9aiAfBFu
 BE+9Cie8W8OhOgSQ/cUAKudVFEAqkI8yGOpSk7OihPDgRiKiwpor2nvahtWIDUSHEC
 +jxqngqEc2T1CaIZL7RSsZpRXjE2GhDbkG5HNYrFwfZHAvaLS+IX6C588x16awDUW2
 Lar1//z/EhbZ62GRlmzciWbD7XbtpOdbMMXTg1cnGj2TwQWlG4PurYCGHyXKiQG2RM
 K27pFt2YQbFQg==
To: 77143 <at> debbugs.gnu.org
Subject: Re: 30.1; package--description-file handles some packages wrong
In-Reply-To: <handler.77143.B.174251948516377.ack <at> debbugs.gnu.org> (GNU bug
 Tracking System's message of "Fri, 21 Mar 2025 01:12:05 +0000")
References: <877c4jur1d.fsf@HIDDEN>
 <handler.77143.B.174251948516377.ack <at> debbugs.gnu.org>
Date: Fri, 21 Mar 2025 10:12:02 +0800
Message-ID: <87y0wzt9n1.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 77143
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain

I made a patch to fix this.

I also notice that the version part of the regex can be improved because
it does not take `version-regexp-alist' into consideration.  But that is
out of the scope of this bug.

--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
 filename=0001-Fix-pkg-description-file-name-when-pkg-name-has-numb.patch

From 5ab9c353659b853ca64e33f1af9000cc3c6d9d02 Mon Sep 17 00:00:00 2001
From: Lin Jian <me@HIDDEN>
Date: Fri, 21 Mar 2025 09:35:07 +0800
Subject: [PATCH] Fix pkg description file name when pkg name has numbers
 (Bug#77143)

* lisp/subr.el (package--description-file): Match end of string.

Copyright-paperwork-exempt: yes
---
 lisp/subr.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/subr.el b/lisp/subr.el
index 10b7da3535b..c49fcd5bf01 100644
--- a/lisp/subr.el
+++ b/lisp/subr.el
@@ -7247,7 +7247,7 @@ as a list.")
   "Return package description file name for package DIR."
   (concat (let ((subdir (file-name-nondirectory
                          (directory-file-name dir))))
-            (if (string-match "\\([^.].*?\\)-\\([0-9]+\\(?:[.][0-9]+\\|\\(?:pre\\|beta\\|alpha\\)[0-9]+\\)*\\)" subdir)
+            (if (string-match "\\([^.].*?\\)-\\([0-9]+\\(?:[.][0-9]+\\|\\(?:pre\\|beta\\|alpha\\)[0-9]+\\)*\\)\\'" subdir)
                 (match-string 1 subdir) subdir))
           "-pkg.el"))
 
-- 
2.47.1


--=-=-=--
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#77143; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 21 Mar 2025 01:11:25 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Mar 20 21:11:25 2025
Received: from localhost ([127.0.0.1]:59887 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tvQuy-0004G5-GM
	for submit <at> debbugs.gnu.org; Thu, 20 Mar 2025 21:11:24 -0400
Received: from lists.gnu.org ([2001:470:142::17]:35886)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <me@HIDDEN>) id 1tvQur-0004Eo-1V
 for submit <at> debbugs.gnu.org; Thu, 20 Mar 2025 21:11:21 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <me@HIDDEN>) id 1tvQul-0001rc-9L
 for bug-gnu-emacs@HIDDEN; Thu, 20 Mar 2025 21:11:11 -0400
Received: from mail.linj.tech ([5.255.109.209])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <me@HIDDEN>) id 1tvQui-0000rn-AR
 for bug-gnu-emacs@HIDDEN; Thu, 20 Mar 2025 21:11:11 -0400
From: Lin Jian <me@HIDDEN>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linj.tech; s=mail;
 t=1742519463; bh=oHz9UZp5WIlhaEgzMkN4n3N3UhobXDJx453dDhC29mQ=;
 h=From:To:Subject:Date;
 b=u8z7y7ag5qqC0xY1idzQaMzHSIQ4r7CeszzNeGvJ3I9REa4b+8S+z+JmRtnCE55Wv
 aQh31kZRsx58hYiGZOH1nhdxHMFhcAqR1hbzD+VDvIZLkmo9wfWDj8JbJ/7GHkK1aR
 lXLc6N2IzWBJbcs7BB9Vg/3qdgDZ/BvjGIVEEvtcPzPomdCG6+iSXhgq6Nbcoq7YrV
 anFVx4Q5mZDFXlWfloubIJrBtWWDq8btex6KZXcc6d86VGUqWgiAoUfZ0iUeUnXx0k
 RRtk7AxrweU9rurQeZxyEgNUIxXZ84ZcSfcHepcnwMljyyX4KXTBWX2EUNdiCIkFbC
 e3ehTLp8+PsFQ==
To: bug-gnu-emacs@HIDDEN
Subject: 30.1; package--description-file handles some packages wrong
X-Debbugs-Cc: 
Date: Fri, 21 Mar 2025 09:10:54 +0800
Message-ID: <877c4jur1d.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass client-ip=5.255.109.209; envelope-from=me@HIDDEN;
 helo=mail.linj.tech
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.9 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)


Actual result:
(package--description-file "/some/path/p4-16-mode-0.3")
  =E2=87=92 "p4-pkg.el"

Expected result:
(package--description-file "/some/path/p4-16-mode-0.3")
  =E2=87=92 "p4-16-mode-pkg.el"

This example is for p4-16-mode[0].  There are a few other packages
having this issue, such as auth-source-1password[1], comment-dwim-2[2],
cyberpunk-2019-theme[3], iso-639[4], ox-750words[5] and
tango-2-theme[6].

[0]: https://elpa.nongnu.org/nongnu/p4-16-mode.html
[1]: https://github.com/dlobraico/auth-source-1password
[2]: https://github.com/remyferre/comment-dwim-2
[3]: https://github.com/the-frey/cyberpunk-2019
[4]: https://codeberg.org/tomenzgg/emacs-iso-639
[5]: https://github.com/zzamboni/750words-client
[6]: https://gist.github.com/developernotes/2024464
Acknowledgement sent to Lin Jian <me@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#77143; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Sat, 22 Mar 2025 12:00:03 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.