GNU bug report logs - #77157
[PATCH] 'uniquify' user option setters and automatic buffer refresh

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Reported by: Ship Mints <shipmints@HIDDEN>; Keywords: patch; Done: Eli Zaretskii <eliz@HIDDEN>; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 77157-done <at> debbugs.gnu.org:

Received: (at 77157-done) by debbugs.gnu.org; 29 Mar 2025 12:08:17 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Mar 29 08:08:17 2025
Received: from localhost ([127.0.0.1]:57385 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tyUz3-0007fa-5P
	for submit <at> debbugs.gnu.org; Sat, 29 Mar 2025 08:08:17 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:59784)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tyUyR-0007dv-GS
 for 77157-done <at> debbugs.gnu.org; Sat, 29 Mar 2025 08:07:39 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1tyUyM-0000g4-72; Sat, 29 Mar 2025 08:07:34 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=/KvHfBzfVQf4KD48efIaed1bUa/hpC46SpkC1NuPn34=; b=Hw4rew5a/6Yurh1vVinx
 vI7pV9OjiF0ieAX1LkxPPAm2XCXqWNhy4WXtsQX1ZatWmxD/QLGhOgo5/S3G+TLx08NGARIfOnGck
 3eQPtY7PyDurc/2gc9ZnHhxsN5BxFRIofjiCVONViRRQAWoUEpZJpyPY1Cpy9RS8gktMe5dDkcC52
 AwUWgKcD5/sFPGy3Wv6K0nty5leTmCKoqhDHav/VkqcwsvIQmNLFhcW3Azq2gjgKp4HAjZAivr/5+
 Fw8lD6ago8UrgmMEr+x8h1qXURJ6hB3YYG3HeVDC6mhXGEnMVmBqjkD7FMmTmXICyYqbuxskr12b5
 mS9spWW7A5y6Mg==;
Date: Sat, 29 Mar 2025 15:07:31 +0300
Message-Id: <86ikns6nwc.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Ship Mints <shipmints@HIDDEN>
In-Reply-To: <CAN+1HbrQo-OQR6BMHXnHtzsLcMsNqrxB-x-qAy5EwL-sMxTeAg@HIDDEN>
 (message from Ship Mints on Sat, 22 Mar 2025 08:09:18 -0400)
Subject: Re: bug#77157: [PATCH] 'uniquify' user option setters and automatic
 buffer refresh
References: <CAN+1HboXKhaeEPMQGgfVL4herydwuUYm+PPmgsceooCxNJHJYA@HIDDEN>
 <864izmkvrx.fsf@HIDDEN>
 <CAN+1HbqrhL87uDsSx-hyd=H5zxT4VAu67jcZmxU7Dc5hsZJMDQ@HIDDEN>
 <861puplfst.fsf@HIDDEN>
 <CAN+1Hbq7gz_xhrEFK3gbcZ-928vZ-qH2MNMNxLphkOw0eFZOpA@HIDDEN>
 <CAN+1HbrABdQ1JvGj29izNWrU7mjrzd9MzacZVioXqjd_SV9xiQ@HIDDEN>
 <86h63ljowh.fsf@HIDDEN>
 <CAN+1Hbq_RN=AEiMevT4JCpANWr8-B1YvFo==zOw=ypZjNr_otQ@HIDDEN>
 <CAN+1HbrQo-OQR6BMHXnHtzsLcMsNqrxB-x-qAy5EwL-sMxTeAg@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 77157-done
Cc: 77157-done <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Ship Mints <shipmints@HIDDEN>
> Date: Sat, 22 Mar 2025 08:09:18 -0400
> Cc: 77157 <at> debbugs.gnu.org
> 
> On Sat, Mar 22, 2025 at 7:40 AM Ship Mints <shipmints@HIDDEN> wrote:
> 
>  On Sat, Mar 22, 2025 at 7:17 AM Eli Zaretskii <eliz@HIDDEN> wrote:
> 
>  > From: Ship Mints <shipmints@HIDDEN>
>  > Date: Sat, 22 Mar 2025 07:04:08 -0400
>  > Cc: 77157 <at> debbugs.gnu.org
>  > 
>  >  We usually use the following style for such variables:
>  > 
>  >    Setting this variable directly will not usually take effect;
>  >    use either \\[customize] or `setopt', or call `uniquify--set-option'
>  >    or restart `uniquify-mode' after setting the variable directly.
>  > 
>  >  I'll adapt this language.  Uniquify isn't implemented as a mode.  It's a rename buffer hook in
>  buffer.c
>  >  and depends on 'uniquify-buffer-name-style' to have a defined style.
>  > 
>  >  Even the function 'uniquify-unload-function' doesn't attempt to remove the hook (it probably
>  should set
>  >  'uniquify-buffer-name-style' to nil as part of its business).  It's not even clear if unload ever
>  gets called
>  >  by anyone.  Perhaps a candidate to obsolete.
>  > 
>  > The following seems more precise.  Okay with you?
>  > 
>  > Setting this variable directly will not usually take effect; use either
>  > \\[customize] or `setopt', or call `uniquify--set-option'; otherwise
>  > reload your buffers, or restart Emacs.
> 
>  Yes, but I'd omit the "restart Emacs" alternative, as too far-fetched
>  (we are talking about the ways to make the change take effect in the
>  same session).
> 
>  Thanks.
> 
>  Revised patch attached.  It's my pleasure.
> 
> With bug# added to commit log...

Thanks, installed on the master branch, and closing the bug.

Notification sent to Ship Mints <shipmints@HIDDEN>:
bug acknowledged by developer. Full text available.

Reply sent to Eli Zaretskii <eliz@HIDDEN>:
You have taken responsibility. Full text available.