GNU logs - #77171, boring messages

Message sent to cpardo@HIDDEN, bug-gnu-emacs@HIDDEN:

Subject: bug#77171: 31.0.50; Some lines in etc/HELLO display with large height on MS-Windows
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: cpardo@HIDDEN, bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 22 Mar 2025 10:37:01 +0000
Resent-Message-ID: <handler.77171.B.17426398197966 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 77171 <at> debbugs.gnu.org
Cc: Cecilio Pardo <cpardo@HIDDEN>
Date: Sat, 22 Mar 2025 12:36:45 +0200
Message-Id: <86pli9jqrm.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

To reproduce:

  emacs -Q
  M-: (w32-find-non-USB-fonts) RET
  C-h h

and observe how some lines are displayed with large whitespace above
and/or below them.  For example, the lines of the following scripts:

  Batak
  Cham
  Coptic
  Hanifi Rohingya
  Hanunoo
  Makasar

Bisection shows that this started when DirectWrite text drawing was
added to Emacs in commit edf37e811caf back in Oct 2024.

Cecilio, could you please look into this?  I'm guessing that the code
we now use to return the metrics of character glyphs somehow returns
different results from what was used before, in this particular
aspect.


In GNU Emacs 31.0.50 (build 782, i686-pc-mingw32) of 2025-03-22 built on
 ELIZ-PC
Repository revision: cf7fdd374ac96ddd53a026bda2aa2b7211e5ee70
Repository branch: master
Windowing system distributor 'Microsoft Corp.', version 10.0.26100
System Description: Microsoft Windows 10 Enterprise (v10.0.2009.26100.3476)

Configured using:
 'configure -C --prefix=/d/usr --with-wide-int
 --without-native-compilation --enable-checking=yes,glyphs 'CFLAGS=-O0
 -gdwarf-4 -g3''

Configured features:
ACL GIF GMP GNUTLS HARFBUZZ JPEG LCMS2 LIBXML2 MODULES NOTIFY W32NOTIFY
PDUMPER PNG RSVG SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS
TREE_SITTER WEBP XPM ZLIB

Important settings:
  value of $LANG: ENU
  locale-coding-system: cp1252

Major mode: Fundamental

Minor modes in effect:
  enriched-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  use-hard-newlines: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  minibuffer-regexp-mode: t
  buffer-read-only: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  view-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug lisp-mnt message mailcap yank-media puny
dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg
rfc6068 epg-config gnus-util text-property-search time-date subr-x
mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils
mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr
mail-utils thai-util thai-word mule-util lao-util vc-git diff-mode
track-changes easy-mmode files-x vc-dispatcher cl-loaddefs cl-lib
enriched facemenu view rmc iso-transl tooltip cconv eldoc paren electric
uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel
touch-screen dos-w32 ls-lisp term/w32-nt disp-table term/w32-win w32-win
w32-vars term/common-win tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode lisp-mode prog-mode register
page tab-bar menu-bar rfn-eshadow isearch easymenu timer select
scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors
frame minibuffer nadvice seq simple cl-generic indonesian philippine
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite emoji-zwj charscript
charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure
cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp
files window text-properties overlay sha1 md5 base64 format env
code-pages mule custom widget keymap hashtable-print-readable backquote
threads w32notify w32 lcms2 multi-tty move-toolbar make-network-process
tty-child-frames emacs)

Memory information:
((conses 16 199535 13089) (symbols 48 7733 0) (strings 16 21122 3511)
 (string-bytes 1 478810) (vectors 16 19762)
 (vector-slots 8 348637 11993) (floats 8 32 65) (intervals 40 389 136)
 (buffers 896 12))

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Eli Zaretskii <eliz@HIDDEN>
Subject: bug#77171: Acknowledgement (31.0.50; Some lines in etc/HELLO
 display with large height on MS-Windows)
Message-ID: <handler.77171.B.17426398197966.ack <at> debbugs.gnu.org>
References: <86pli9jqrm.fsf@HIDDEN>
X-Gnu-PR-Message: ack 77171
X-Gnu-PR-Package: emacs
Reply-To: 77171 <at> debbugs.gnu.org
Date: Sat, 22 Mar 2025 10:37:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

As you requested using X-Debbugs-CC, your message was also forwarded to
  Cecilio Pardo <cpardo@HIDDEN>
(after having been given a bug report number, if it did not have one).

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 77171 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
77171: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D77171
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#77171: 31.0.50; Some lines in etc/HELLO display with large height on MS-Windows
Resent-From: Cecilio Pardo <cpardo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 22 Mar 2025 14:13:02 +0000
Resent-Message-ID: <handler.77171.B77171.174265277111721 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Eli Zaretskii <eliz@HIDDEN>, 77171 <at> debbugs.gnu.org
Received-SPF: pass (zealous-pike.82-223-54-191.plesk.page: connection is
 authenticated)
Message-ID: <7cd6ace4-eadc-494f-aded-5ccd93915cec@HIDDEN>
Date: Sat, 22 Mar 2025 15:12:39 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
References: <86pli9jqrm.fsf@HIDDEN>
Content-Language: es-ES
From: Cecilio Pardo <cpardo@HIDDEN>
In-Reply-To: <86pli9jqrm.fsf@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

On 22/03/2025 11:36, Eli Zaretskii wrote:
> Cecilio, could you please look into this?  I'm guessing that the code
> we now use to return the metrics of character glyphs somehow returns
> different results from what was used before, in this particular
> aspect.

Yes, I'm on it.

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#77171: 31.0.50; Some lines in etc/HELLO display with large height on MS-Windows
Resent-From: Cecilio Pardo <cpardo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 27 Mar 2025 21:31:01 +0000
Resent-Message-ID: <handler.77171.B77171.174311106115008 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Eli Zaretskii <eliz@HIDDEN>, 77171 <at> debbugs.gnu.org
Received-SPF: pass (zealous-pike.82-223-54-191.plesk.page: connection is
 authenticated)
Message-ID: <26654c9b-b8f5-4073-afdc-70466e245b56@HIDDEN>
Date: Thu, 27 Mar 2025 22:30:48 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From: Cecilio Pardo <cpardo@HIDDEN>
References: <86pli9jqrm.fsf@HIDDEN>
 <7cd6ace4-eadc-494f-aded-5ccd93915cec@HIDDEN>
Content-Language: es-ES
In-Reply-To: <7cd6ace4-eadc-494f-aded-5ccd93915cec@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

On 22/03/2025 15:12, Cecilio Pardo wrote:
> On 22/03/2025 11:36, Eli Zaretskii wrote:
>> Cecilio, could you please look into this?  I'm guessing that the code
>> we now use to return the metrics of character glyphs somehow returns
>> different results from what was used before, in this particular
>> aspect.

Just reporting status.

The problematic font here is "Sans serif collection", which gives very 
big ascent and descent values for glyphs. Not even Windows own tools, 
such as charmap or the font selection dialog, render this font correctly.

Emacs' code without directwrite directly inspects the glyph outlines to 
get metrics. I'm looking for a way to do the same with directwrite, or 
find another solution.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#77171: 31.0.50; Some lines in etc/HELLO display with large height on MS-Windows
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 28 Mar 2025 07:22:01 +0000
Resent-Message-ID: <handler.77171.B77171.17431465216809 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 77171
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Cecilio Pardo <cpardo@HIDDEN>
Cc: 77171 <at> debbugs.gnu.org
Received: via spool by 77171-submit <at> debbugs.gnu.org id=B77171.17431465216809
          (code B ref 77171); Fri, 28 Mar 2025 07:22:01 +0000
Received: (at 77171) by debbugs.gnu.org; 28 Mar 2025 07:22:01 +0000
Received: from localhost ([127.0.0.1]:52591 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ty42S-0001lk-O4
	for submit <at> debbugs.gnu.org; Fri, 28 Mar 2025 03:22:01 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:58330)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1ty42Q-0001lS-Dg
 for 77171 <at> debbugs.gnu.org; Fri, 28 Mar 2025 03:21:59 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1ty42K-0001ZK-Ul; Fri, 28 Mar 2025 03:21:53 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=ib1/lQlae/E2FPXPGilXijVwFtw3IRoW3oiDHT/FdO8=; b=Tj85xvGHEbLc0m2tnsZV
 pdh1bZgZxYCv4BCsDjfZNMqcgyi6gdsf1udanc9eh96lIGEgoUHIn/VnR4BDAMc7eyWCcJWYhWbIg
 TNxxXGHLArcq62WZLZ3GkpZI2UdcG92I9Kwep+tvbELP0BWPy9CVWEeXau7qgcZUK6hcoWGYSTXSW
 CdOrvf5919ZQD8P5BhaYHa7MqNgNKFc3PjqUMurri30cnqGi/fANMErmlNsRUkTU8vLaQ7Ux1Cutg
 Arn6ULvZc1zGPsSvXumqgAWl6Aqp6kifNrrqPy8CkgYSP7uG8UU5dY/C5gDVveR3FYvdYDSQMHDzt
 pRpvPf9PcsXB6w==;
Date: Fri, 28 Mar 2025 10:21:24 +0300
Message-Id: <867c49boy3.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <26654c9b-b8f5-4073-afdc-70466e245b56@HIDDEN> (message from
 Cecilio Pardo on Thu, 27 Mar 2025 22:30:48 +0100)
References: <86pli9jqrm.fsf@HIDDEN>
 <7cd6ace4-eadc-494f-aded-5ccd93915cec@HIDDEN>
 <26654c9b-b8f5-4073-afdc-70466e245b56@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Thu, 27 Mar 2025 22:30:48 +0100
> From: Cecilio Pardo <cpardo@HIDDEN>
> 
> On 22/03/2025 15:12, Cecilio Pardo wrote:
> > On 22/03/2025 11:36, Eli Zaretskii wrote:
> >> Cecilio, could you please look into this?  I'm guessing that the code
> >> we now use to return the metrics of character glyphs somehow returns
> >> different results from what was used before, in this particular
> >> aspect.
> 
> Just reporting status.
> 
> The problematic font here is "Sans serif collection", which gives very 
> big ascent and descent values for glyphs. Not even Windows own tools, 
> such as charmap or the font selection dialog, render this font correctly.
> 
> Emacs' code without directwrite directly inspects the glyph outlines to 
> get metrics. I'm looking for a way to do the same with directwrite, or 
> find another solution.

Thanks for working on this.  Sans serif collection is an important
font collection on Windows, since it supports a lot of scripts.  So it
would be good for Emacs to support it in a reasonably good fashion.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#77171: 31.0.50; Some lines in etc/HELLO display with large height on MS-Windows
Resent-From: Cecilio Pardo <cpardo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 01 Apr 2025 08:48:03 +0000
Resent-Message-ID: <handler.77171.B77171.174349724623129 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 77171
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>, 77171 <at> debbugs.gnu.org
Received: via spool by 77171-submit <at> debbugs.gnu.org id=B77171.174349724623129
          (code B ref 77171); Tue, 01 Apr 2025 08:48:03 +0000
Received: (at 77171) by debbugs.gnu.org; 1 Apr 2025 08:47:26 +0000
Received: from localhost ([127.0.0.1]:45615 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tzXHJ-00060y-T7
	for submit <at> debbugs.gnu.org; Tue, 01 Apr 2025 04:47:26 -0400
Received: from mail.imayhem.com ([82.223.54.191]:51081
 helo=zealous-pike.82-223-54-191.plesk.page)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <cpardo@HIDDEN>)
 id 1tzXHH-00060m-Fl
 for 77171 <at> debbugs.gnu.org; Tue, 01 Apr 2025 04:47:24 -0400
Received: from [10.0.12.229] (66.red-2-136-43.staticip.rima-tde.net
 [2.136.43.66])
 by zealous-pike.82-223-54-191.plesk.page (Postfix) with ESMTPSA id B3FE880196; 
 Tue,  1 Apr 2025 08:47:12 +0000 (UTC)
Authentication-Results: zealous-pike.82-223-54-191.plesk.page;
 spf=pass (sender IP is 2.136.43.66) smtp.mailfrom=cpardo@HIDDEN
 smtp.helo=[10.0.12.229]
Received-SPF: pass (zealous-pike.82-223-54-191.plesk.page: connection is
 authenticated)
Content-Type: multipart/mixed; boundary="------------0cpI14QPugXTTpxK0y0cRtmy"
Message-ID: <7b26d293-0577-4bd6-bcce-57364c758e58@HIDDEN>
Date: Tue, 1 Apr 2025 10:47:11 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From: Cecilio Pardo <cpardo@HIDDEN>
References: <86pli9jqrm.fsf@HIDDEN>
 <7cd6ace4-eadc-494f-aded-5ccd93915cec@HIDDEN>
Content-Language: es-ES
In-Reply-To: <7cd6ace4-eadc-494f-aded-5ccd93915cec@HIDDEN>
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

This is a multi-part message in MIME format.
--------------0cpI14QPugXTTpxK0y0cRtmy
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 22/03/2025 11:36, Eli Zaretskii wrote:

> Cecilio, could you please look into this?  I'm guessing that the code
> we now use to return the metrics of character glyphs somehow returns
> different results from what was used before, in this particular
> aspect. 

The attached patch fixes this by using the GDI measurement for the 
vertical size of text.

Doing the same with DirectWrite would be too expensive, and would imply 
using the "layout" parts of DirectWrite, to get the same results most of 
the time.

Horizontal extents is different, we need to keep using DirectWrite for that.


--------------0cpI14QPugXTTpxK0y0cRtmy
Content-Type: text/plain; charset=UTF-8;
 name="0001-w32-fix-problem-with-font-vertical-measurement-for-d.patch"
Content-Disposition: attachment;
 filename*0="0001-w32-fix-problem-with-font-vertical-measurement-for-d.pa";
 filename*1="tch"
Content-Transfer-Encoding: base64

RnJvbSA2MDE2NTVhNGVmZmM3YjY4NDQ4ZTgwYjdiNzk4YTczOGQ2NmM3Y2IxIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBDZWNpbGlvIFBhcmRvIDxjcGFyZG9AaW1heWhlbS5j
b20+CkRhdGU6IFR1ZSwgMSBBcHIgMjAyNSAxMDoxODoxNCArMDIwMApTdWJqZWN0OiBbUEFU
Q0hdIHczMjogZml4IHByb2JsZW0gd2l0aCBmb250IHZlcnRpY2FsIG1lYXN1cmVtZW50IGZv
ciBkd3JpdGUKCkdseXBoIGJ5IGdseXBoIG1lYXN1cmVtZW50IG9mIHZlcnRpY2FsIHNpemUg
aXMgdG9vIGV4cGVuc2l2ZSB3aXRoCkRpcmVjdFdyaXRlLiAgR0RJIG1lYXN1cmVtZW50IGZv
ciB2ZXJ0aWNhbCBzaXplIGlzIGdvb2QgZm9yIERpcmVjdFdyaXRlCnRvby4KCiogc3JjL3cz
MmR3cml0ZS5jICh3MzJfZHdyaXRlX3RleHRfZXh0ZW50cyk6IFVzZSB0aGUgdmVydGljYWwK
bWVhc3VyZW1lbnQgZnJvbSBHREkuCiogc3JjL3czMmZvbnQuYyAodzMyZm9udF90ZXh0X2V4
dGVudHMpOiBXaGVuIERpcmVjdFdyaXRlIGlzIGFjdGl2ZSwKbWVhc3VyZSB0ZXN0IHVzaW5n
IEdESSBjb2RlIGJlZm9yZSBjYWxsaW5nIHczMl9kd3JpdGVfdGV4dF9leHRlbnRzLgotLS0K
IHNyYy93MzJkd3JpdGUuYyB8IDQgKy0tLQogc3JjL3czMmZvbnQuYyAgIHwgNiArKy0tLS0K
IDIgZmlsZXMgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQoKZGlm
ZiAtLWdpdCBhL3NyYy93MzJkd3JpdGUuYyBiL3NyYy93MzJkd3JpdGUuYwppbmRleCAxMGFm
ODU0NWExMS4uYmMzNzljZDczOTUgMTAwNjQ0Ci0tLSBhL3NyYy93MzJkd3JpdGUuYworKysg
Yi9zcmMvdzMyZHdyaXRlLmMKQEAgLTY3OCw2ICs2NzgsNyBAQCB3MzJfZHdyaXRlX2VuY29k
ZV9jaGFyIChzdHJ1Y3QgZm9udCAqZm9udCwgaW50IGMpCiAgIHJldHVybiBGT05UX0lOVkFM
SURfQ09ERTsKIH0KIAorLyogRG9lcyBub3QgZmlsbCBpbiB0aGUgYXNjZW50IGFuZCBkZXNj
ZW50IGZpZWxkcyBvZiBtZXRyaWNzLiAgKi8KIGJvb2wKIHczMl9kd3JpdGVfdGV4dF9leHRl
bnRzIChzdHJ1Y3QgZm9udCAqZm9udCwgY29uc3QgdW5zaWduZWQgKmNvZGUsIGludCBuZ2x5
cGhzLAogCQkJIHN0cnVjdCBmb250X21ldHJpY3MgKm1ldHJpY3MpCkBAIC02OTQsOSArNjk1
LDYgQEAgdzMyX2R3cml0ZV90ZXh0X2V4dGVudHMgKHN0cnVjdCBmb250ICpmb250LCBjb25z
dCB1bnNpZ25lZCAqY29kZSwgaW50IG5nbHlwaHMsCiAgIGlmIChmb250X3NpemUgPD0gMC4w
ZikKICAgICBmb250X3NpemUgPSBGUkFNRV9MSU5FX0hFSUdIVCAoU0VMRUNURURfRlJBTUUg
KCkpOwogCi0gIG1ldHJpY3MtPmFzY2VudCA9IGZvbnQtPmFzY2VudDsKLSAgbWV0cmljcy0+
ZGVzY2VudCA9IGZvbnQtPmRlc2NlbnQ7Ci0KICAgcmV0dXJuIHRleHRfZXh0ZW50c19pbnRl
cm5hbCAoZHdyaXRlX2ZvbnRfZmFjZSwgZm9udF9zaXplLCBjb2RlLCBuZ2x5cGhzLAogCQkJ
CW1ldHJpY3MpOwogfQpkaWZmIC0tZ2l0IGEvc3JjL3czMmZvbnQuYyBiL3NyYy93MzJmb250
LmMKaW5kZXggZjQ0YTdjMTI0YzkuLjdmNTRkNmM2OGYxIDEwMDY0NAotLS0gYS9zcmMvdzMy
Zm9udC5jCisrKyBiL3NyYy93MzJmb250LmMKQEAgLTQ0NCwxMCArNDQ0LDYgQEAgdzMyZm9u
dF90ZXh0X2V4dGVudHMgKHN0cnVjdCBmb250ICpmb250LCBjb25zdCB1bnNpZ25lZCAqY29k
ZSwKIAogICBtZW1zZXQgKG1ldHJpY3MsIDAsIHNpemVvZiAoc3RydWN0IGZvbnRfbWV0cmlj
cykpOwogCi0gIGlmICh3MzJfdXNlX2RpcmVjdF93cml0ZSAodzMyX2ZvbnQpCi0gICAgICAm
JiB3MzJfZHdyaXRlX3RleHRfZXh0ZW50cyAoZm9udCwgY29kZSwgbmdseXBocywgbWV0cmlj
cykpCi0gICAgcmV0dXJuOwotCiAgIGZvciAoaSA9IDAsIGZpcnN0ID0gdHJ1ZTsgaSA8IG5n
bHlwaHM7IGkrKykKICAgICB7CiAgICAgICBzdHJ1Y3QgdzMyX21ldHJpY19jYWNoZSAqY2hh
cl9tZXRyaWM7CkBAIC01MzAsNiArNTI2LDggQEAgdzMyZm9udF90ZXh0X2V4dGVudHMgKHN0
cnVjdCBmb250ICpmb250LCBjb25zdCB1bnNpZ25lZCAqY29kZSwKICAgLyogSWYgd2UgZ290
IHRocm91Z2ggZXZlcnl0aGluZywgcmV0dXJuLiAgKi8KICAgaWYgKGkgPT0gbmdseXBocykK
ICAgICB7CisgICAgICBpZiAodzMyX3VzZV9kaXJlY3Rfd3JpdGUgKHczMl9mb250KSkKKwl3
MzJfZHdyaXRlX3RleHRfZXh0ZW50cyAoZm9udCwgY29kZSwgbmdseXBocywgbWV0cmljcyk7
CiAgICAgICBpZiAoZGMgIT0gTlVMTCkKIAl7CiAJICAvKiBSZXN0b3JlIHN0YXRlIGFuZCBy
ZWxlYXNlIERDLiAgKi8KLS0gCjIuMzUuMS53aW5kb3dzLjIKCg==

--------------0cpI14QPugXTTpxK0y0cRtmy--

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#77171: 31.0.50; Some lines in etc/HELLO display with large height on MS-Windows
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 03 Apr 2025 05:33:01 +0000
Resent-Message-ID: <handler.77171.B77171.17436583755640 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 77171
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Cecilio Pardo <cpardo@HIDDEN>
Cc: 77171 <at> debbugs.gnu.org
Received: via spool by 77171-submit <at> debbugs.gnu.org id=B77171.17436583755640
          (code B ref 77171); Thu, 03 Apr 2025 05:33:01 +0000
Received: (at 77171) by debbugs.gnu.org; 3 Apr 2025 05:32:55 +0000
Received: from localhost ([127.0.0.1]:60455 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1u0DCB-0001Su-3o
	for submit <at> debbugs.gnu.org; Thu, 03 Apr 2025 01:32:55 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:51100)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1u0DC9-0001Sg-F6
 for 77171 <at> debbugs.gnu.org; Thu, 03 Apr 2025 01:32:54 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1u0DC3-0005mv-K8; Thu, 03 Apr 2025 01:32:47 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=JM5XQQVUOhEt1g1IjzEyLCUX0cV0AbJ9ku8Dp5ZchOk=; b=e1DMNqC+UzIG
 vGSKnGlSn3e5/VN1S9wgntwexvvaiRsV8SMbRCUQl+KLnnxufgyWioCfx61XMjQgxOlmI0eh7Yj0L
 NPCYgbjsLttnA6urf3FeVXv9Sbke48TVrt9x7lSRL9DVY6bZ0gTixhFY0shAYw4pV4BjPbsbjCXje
 Bv08fVK99PVIYkineXzCNRvLPe7NkOKrlNKmARtKQYOF79LkHNRuXAs1Ymg0bzQQgYrfmAp96QVL1
 r141U4xCnmsKanNZMwtAfdeAP1dKGsYOJA103tePu52L0PoZZW19TqnUo9ZCXggh1+N4kuyiLAImn
 jW3NHg1diOPTh0JoCFybiw==;
Date: Thu, 03 Apr 2025 08:32:43 +0300
Message-Id: <86wmc1zu6c.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <7b26d293-0577-4bd6-bcce-57364c758e58@HIDDEN> (message from
 Cecilio Pardo on Tue, 1 Apr 2025 10:47:11 +0200)
References: <86pli9jqrm.fsf@HIDDEN>
 <7cd6ace4-eadc-494f-aded-5ccd93915cec@HIDDEN>
 <7b26d293-0577-4bd6-bcce-57364c758e58@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Tue, 1 Apr 2025 10:47:11 +0200
> From: Cecilio Pardo <cpardo@HIDDEN>
> 
> On 22/03/2025 11:36, Eli Zaretskii wrote:
> 
> > Cecilio, could you please look into this?  I'm guessing that the code
> > we now use to return the metrics of character glyphs somehow returns
> > different results from what was used before, in this particular
> > aspect. 
> 
> The attached patch fixes this by using the GDI measurement for the 
> vertical size of text.
> 
> Doing the same with DirectWrite would be too expensive, and would imply 
> using the "layout" parts of DirectWrite, to get the same results most of 
> the time.

Hmm... are we sure the GDI measurement will work always for the fonts
for which we must use DirectWrite?  For example, the color fonts?

If GDI might fail for some fonts, perhaps leaving the metrics code in
w32_dwrite_text_extents, and then _overriding_ that by GDI values if
available, would be safer?

Thanks.

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 3 Apr 2025 07:35:23 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Apr 03 03:35:23 2025
Received: from localhost ([127.0.0.1]:60751 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1u0F6h-00075J-B8
	for submit <at> debbugs.gnu.org; Thu, 03 Apr 2025 03:35:23 -0400
Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]:53562)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
 id 1u0F6e-00072Y-6o
 for control <at> debbugs.gnu.org; Thu, 03 Apr 2025 03:35:20 -0400
Received: by mail-ed1-x536.google.com with SMTP id
 4fb4d7f45d1cf-5ed1ac116e3so1051006a12.3
 for <control <at> debbugs.gnu.org>; Thu, 03 Apr 2025 00:35:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1743665714; x=1744270514; darn=debbugs.gnu.org;
 h=to:subject:message-id:date:mime-version:from:from:to:cc:subject
 :date:message-id:reply-to;
 bh=8LU7eA5l9nY79fE6L/8h3jUtbjPAZ+KdEwcuHKl4pyo=;
 b=knwr1bwRoiY6/oBYF+hiF/Z8h869YyOJpAYhWuDM0Vz4ek8LyKMTD1uFiH9uRma/Bx
 lG9glNQ77PvYV/FD7rB3egPqp+vu9k4esFY3L7u+vPm+sL3vli2K/uf/jufbOlTtfxsd
 WZiGyz/73b8ukK/LQSLN4I1wy746jqzTAiW7b4dAlGuYoeHlImBZoexz339In7/2LG01
 A74KywozWTuDd9vNTYPoe01cSzdEc/GIw6gVi08VudqbIRxHdkx6UeP+YG02bh9LPdFf
 VYzfHKSWjhA5COlIR4xvL5EdvaBaHqco9v0mfQS8eSovhxbeirOaERPEiHcpuDmNqPYy
 BmxQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1743665714; x=1744270514;
 h=to:subject:message-id:date:mime-version:from:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=8LU7eA5l9nY79fE6L/8h3jUtbjPAZ+KdEwcuHKl4pyo=;
 b=gQvw2c4nWz3d/T+8RpLVmEJZ+ZsKh/kglzxY0zo0QisgElvd6yO7YmAUlbSsmpk8aC
 kLeojFxWmQSXYu9xqzCf7i+EmutwtrOuPDeK6iheLy0L2A5eILf4pNLGe5T4NypYTH9p
 S+QI5kWmelFrzVtzTjUkTAQleKkow8+bQgnGPvUXJFKqhBh1cRg8vXt3LawojwfJdk/z
 lNaCNWwD7zGKiIRSITUTjUNDxttcLVT2oKj4lKz3RxsE6lqUn5zqbc/R3ukhe7Cfxe3Z
 lds5kh4I1uNdivmMltBMm/BF+o5VD0i1AmRJ4MTloKG7z6Vz3XU6vkJcAv3RyIiySl/Q
 7w5w==
X-Gm-Message-State: AOJu0Yy3kxofAimoRINpCvtD6xDu1EL6CMqrcoomCctwkjFptpfH9KVt
 Uhaqw6BeKd1qK64pP/MAbr3SHNQVArYYTmhWnDUArtau7+ZlDhfamBTZtx0hQSrNE43i5e1XYcR
 yVwLuQA5BS0FOudlGLsLaBJluJPUylS6yRvk=
X-Gm-Gg: ASbGncv2/Qe6Dxo15eEB3g8TndGZSjVj6bGTJ+KQoCP/5Hv0WhVgWwyqoeZH3qgHJPN
 ILUCXApMp6qGcZTbkvQmmrCBGlt/vykhu/EEe4dN8HLzarfAn4h7Ft9Ezafu8deUi7Z7U9hrbpb
 hKy9LEUQGhH/qsaTZ4aYTZ6tHDCOns
X-Google-Smtp-Source: AGHT+IFhkZ7RT+FCLxdtpLio2hw6JQxfEuW72t82cVWvjuNNosode9KpRAdupr6No+5kUljuQDgOaRKcMudCA3758lw=
X-Received: by 2002:a05:6402:5cd:b0:5ed:1d5a:7ec1 with SMTP id
 4fb4d7f45d1cf-5f08722193amr1265292a12.31.1743665713713; Thu, 03 Apr 2025
 00:35:13 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Thu, 3 Apr 2025 00:35:13 -0700
From: Stefan Kangas <stefankangas@HIDDEN>
MIME-Version: 1.0
Date: Thu, 3 Apr 2025 00:35:13 -0700
X-Gm-Features: ATxdqUGmD5ntWt-AltqObwVZmSv7Eim-85BZi82T0RegEiqeyS9rrs7Gd13UCKk
Message-ID: <CADwFkmk9rTh1bXtRc0bnUfX07ZgTTmuHBr=DgBQtGqu60tEt=Q@HIDDEN>
Subject: control message for bug #77171
To: control <at> debbugs.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

tags 77171 + patch
quit

Last modified: Thu, 3 Apr 2025 07:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.