X-Loop: help-debbugs@HIDDEN
Subject: bug#77213: go-ts-mode trying to treesit-ready-p gomod without quiet
Resent-From: Gergely =?UTF-8?Q?Risk=C3=B3?= <gergely.risko@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 23 Mar 2025 17:46:02 +0000
Resent-Message-ID: <handler.77213.B.174275195424845 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: report 77213
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords:
To: 77213 <at> debbugs.gnu.org
X-Debbugs-Original-To: bug-gnu-emacs@HIDDEN
Received: via spool by submit <at> debbugs.gnu.org id=B.174275195424845
(code B ref -1); Sun, 23 Mar 2025 17:46:02 +0000
Received: (at submit) by debbugs.gnu.org; 23 Mar 2025 17:45:54 +0000
Received: from localhost ([127.0.0.1]:52477 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1twPOT-0006Se-Ao
for submit <at> debbugs.gnu.org; Sun, 23 Mar 2025 13:45:53 -0400
Received: from lists.gnu.org ([2001:470:142::17]:43038)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <gergely.risko@HIDDEN>)
id 1twNgv-0002js-1N
for submit <at> debbugs.gnu.org; Sun, 23 Mar 2025 11:56:50 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <gergely.risko@HIDDEN>)
id 1twNgm-0006Lr-MF
for bug-gnu-emacs@HIDDEN; Sun, 23 Mar 2025 11:56:41 -0400
Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <gergely.risko@HIDDEN>)
id 1twNgk-0000AN-Bk
for bug-gnu-emacs@HIDDEN; Sun, 23 Mar 2025 11:56:40 -0400
Received: by mail-pj1-x102a.google.com with SMTP id
98e67ed59e1d1-3014cb646ecso4426245a91.1
for <bug-gnu-emacs@HIDDEN>; Sun, 23 Mar 2025 08:56:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1742745396; x=1743350196; darn=gnu.org;
h=to:subject:message-id:date:from:mime-version:from:to:cc:subject
:date:message-id:reply-to;
bh=5YV7u4ArePgpkJODje11VFhSrkXCjtTRIZpy8A7shOY=;
b=b3mKGtFhdWxel0+1yN6R4/cQ15Cyv3YpvwiLqdPOnRIDY7iSTsbWsdjMbuylwD8EY5
cgA8ABTxOfW659DtPCYnOt2wDIm8Iax4Jgqy+lfKLVEMY+j5qBgMcCxZam5yjiSE0wUc
QwcyRqTSOTJ91/jPGJSxWAAQ73CdJkDuCbGwYQKqVUbfxfs2ca+HKPpHkRDoPPrSK2JY
W6XAf9xs05W6sR/1vI9obh8GxC6kNhSwePvpGCAetFceunHOomZB/2u8i1hS2lHgdHGU
PoPI8V/7VY6xwhwi4xldtFgEfyAchDt9f/L1gewz0CuOsbs9ysAq1miKvalIP9Cgi8kI
Yxaw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1742745396; x=1743350196;
h=to:subject:message-id:date:from:mime-version:x-gm-message-state
:from:to:cc:subject:date:message-id:reply-to;
bh=5YV7u4ArePgpkJODje11VFhSrkXCjtTRIZpy8A7shOY=;
b=u453X9EMgTCcqKIjWcjWGr/O9n0yIp/LK0VDmJWmma6wkh6j4EE14RdKn0kVtfuTLt
NGKXHo5SrAgxC+QJU3uanwW3Hy7cDiOlHToFSF499HzIsaLuoHoFonCqG9JewbWNcdWg
tFehXt6ZamiXwxkCYg+rn0QtRwIIUr6+zHpEdaze8oHvYOqbdlLvJygLdJtUlskL13Df
cidjm6yfRu1kdJRgvVa0xYa2J4EQNZHnq5+gJx720FHESqxDCje+U3+nHE63MN91rDyc
ZeYLAX/XLKu5LjDIZScNgogonSsQzSRaOPAwClKw13msnAEw/YxaFWgfRVaCzZ+JhArh
H4UA==
X-Gm-Message-State: AOJu0Yy96AsFUfKU8ApP2htrMsL4s+Ei4ZK33AxVDYbG8ApLYjFsbSno
kDX0RuF3ZOauSjmllHsKKjKIlu16rsbZ3Vp1nA1/+B93k+sSWmCjk/3g7gElezn/TJxpyasWkP7
VeqYFkKeYjLXwmHSDA9cB8s6tjWgzMtj5
X-Gm-Gg: ASbGnctk5qC8vwGdS3Qgw1ZXd+z7alnIHTYlR3k9tsX5KxxMNi7Z8hdFvSHSSLjIYnS
UQ7QrP1RtcDM4ah+0jicYXRn2wKz0Q4PQ5rbr7bLzWwn08aQRVugE3XTb/PfpdQpJtar00eb3U+
tzw1llYXuJsrIH3YDsTdWu/Kjij2x2gQ==
X-Google-Smtp-Source: AGHT+IE1Z9n6bg6Y4XlsC5BSxzTN1d0Ar3uYvXrd404Dct0O/uN/gftuR0ag8MGbfHZ9+XTRB2C8Y9E4lqJ0nsTiH0E=
X-Received: by 2002:a17:90b:1a87:b0:2ee:ed1c:e451 with SMTP id
98e67ed59e1d1-3030fe94750mr16244274a91.15.1742745395608; Sun, 23 Mar 2025
08:56:35 -0700 (PDT)
MIME-Version: 1.0
From: Gergely =?UTF-8?Q?Risk=C3=B3?= <gergely.risko@HIDDEN>
Date: Sun, 23 Mar 2025 16:56:24 +0100
X-Gm-Features: AQ5f1Jolka6QD8QCb_u9PMEsiy55RRv6fbmynbiGUL3Mn8fQn5MvX5trPYu4tf4
Message-ID: <CAMhZOOx=W4UjAUqvunAXGowUSpB6yYvKvNygE03oguo23Ejm+g@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Received-SPF: pass client-ip=2607:f8b0:4864:20::102a;
envelope-from=gergely.risko@HIDDEN; helo=mail-pj1-x102a.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Mailman-Approved-At: Sun, 23 Mar 2025 13:45:52 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
Hey,
In the last 2 lines of go-ts-mode.el we have this:
(if (treesit-ready-p 'gomod)
(add-to-list 'auto-mode-alist '("/go\\.mod\\'" . go-mod-ts-mode)))
This is problematic, because the treesitter go shared library can be
available when the gomod shared library is not. (E.g. the official
treesit bundle behaves like that.)
Now, this call to treesit-ready-p without the quiet flag causes a
warning, that might frighten the user and might send the message that
even their go configuration is somehow broken (and it's not).
The easy fix would be to just add the quiet flag here, and I think
that should be done as soon a possible.
But conceptually speaking, I'm not 100% sure that it's a good idea
that gomod and go are so tightly coupled in the same file. Editing go
files is much more frequent while programming than editing gomod
files. If there are any issues with gomod (like now), it would be
cool to be able to just turn it off (e.g. removing from
auto-mode-alist), instead of it being force-loaded just because it's
the same file as go-mode.
Cheers,
Gergely
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Gergely =?UTF-8?Q?Risk=C3=B3?= <gergely.risko@HIDDEN> Subject: bug#77213: Acknowledgement (go-ts-mode trying to treesit-ready-p gomod without quiet) Message-ID: <handler.77213.B.174275195424845.ack <at> debbugs.gnu.org> References: <CAMhZOOx=W4UjAUqvunAXGowUSpB6yYvKvNygE03oguo23Ejm+g@HIDDEN> X-Gnu-PR-Message: ack 77213 X-Gnu-PR-Package: emacs Reply-To: 77213 <at> debbugs.gnu.org Date: Sun, 23 Mar 2025 17:46:02 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): bug-gnu-emacs@HIDDEN If you wish to submit further information on this problem, please send it to 77213 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 77213: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D77213 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.