Received: (at 77306) by debbugs.gnu.org; 3 Apr 2025 16:53:03 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Apr 03 12:53:03 2025 Received: from localhost ([127.0.0.1]:35443 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u0NoN-0003oL-9R for submit <at> debbugs.gnu.org; Thu, 03 Apr 2025 12:53:03 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:46524) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <monnier@HIDDEN>) id 1u0NoK-0003np-Ht for 77306 <at> debbugs.gnu.org; Thu, 03 Apr 2025 12:53:01 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 9A5FF807B7; Thu, 3 Apr 2025 12:52:53 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1743699172; bh=Xa8qCcAv57x7iQUOtiiyKBM1ruKDG0oADeAoOBhfK98=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=nZ8ZSKD/9gHHWWL05h4KvsSyfNPnWkZgXQ6cbyrnHbJYNLfbBfk0EAheJpFhehkUv DrOI+LbOEF9K6LQvvquGS9I9F0bXE0Wj3f+qNkS6XY5FWokR51cdycSR0nGmWP73fb USYkIM0JBQce1ChwpAEV8CIbRvVzeVpJ7ch4eX4GTWxqU+xBnWTRE8QKsmSP52oEEM 0IdiG12Q6Z76RQNciUcKjkti+wo2YyLk5775ie49q/ShjYqv6JZcZ0IlWTQtPgGpIc qJDTzEzHAzoeBCwHPxUYm0bG2nlQmk2mfxC4CnNcn4pe8V85dTrXi2OzL2im6AZqDg oo7OBD7IypeAw== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id D0E3B8014E; Thu, 3 Apr 2025 12:52:52 -0400 (EDT) Received: from pastel (unknown [104.247.242.5]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 8A4C9120223; Thu, 3 Apr 2025 12:52:52 -0400 (EDT) From: Stefan Monnier <monnier@HIDDEN> To: Robert Pluim <rpluim@HIDDEN> Subject: Re: bug#77306: 31.0.50; C-x v L from *vc-change-log* buffer leaves wrong default-directory In-Reply-To: <87wmc1fllb.fsf@HIDDEN> Message-ID: <jwvfrip1976.fsf-monnier+emacs@HIDDEN> References: <87iknuhgkb.fsf@HIDDEN> <7a3ddbb6-a0f6-44f6-b62e-64f92496bfda@HIDDEN> <87wmc1fllb.fsf@HIDDEN> Date: Thu, 03 Apr 2025 12:52:51 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.415 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain GAPPY_SUBJECT 0.1 Subject: contains G.a.p.p.y-T.e.x.t X-SPAM-LEVEL: X-Spam-Score: -2.2 (--) X-Debbugs-Envelope-To: 77306 Cc: Dmitry Gutov <dmitry@HIDDEN>, 77306 <at> debbugs.gnu.org, Sean Whitton <spwhitton@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.2 (---) > Dmitry> Yeah, I don't have a better suggestion. > Doe `setq-local' not adjust the buffer-local value? What am I missing? It does, but the `let` is also currently affecting just that buffer-local value. IOW, it's a `setq-local` within a `let-local`, which thus behaves just like a normal `setq` within a normal `let`: the effect of the `setq` disappears when we exit the `let`.
bug-gnu-emacs@HIDDEN:bug#77306; Package emacs.
Full text available.
Received: (at 77306) by debbugs.gnu.org; 3 Apr 2025 15:47:47 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Apr 03 11:47:47 2025
Received: from localhost ([127.0.0.1]:35292 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1u0MnD-0006I9-DJ
for submit <at> debbugs.gnu.org; Thu, 03 Apr 2025 11:47:47 -0400
Received: from mail-qk1-x730.google.com ([2607:f8b0:4864:20::730]:61926)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <rpluim@HIDDEN>) id 1u0MnB-0006Hw-Dd
for 77306 <at> debbugs.gnu.org; Thu, 03 Apr 2025 11:47:45 -0400
Received: by mail-qk1-x730.google.com with SMTP id
af79cd13be357-7c592764e54so124953785a.3
for <77306 <at> debbugs.gnu.org>; Thu, 03 Apr 2025 08:47:45 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1743695259; x=1744300059; darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:message-id:date:references
:in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id
:reply-to; bh=NlWWuOA82uYyGDYGbzsGKrNI+TAXQw7gD3UHX71E+9M=;
b=bxA/dSeZBVgxc5srYdLz8T6yfybdKWIZQ2lahwsFtGiO98MlTWEgrogy23OvovF0sd
pLnTTTY7dd4IA4+FT3AscA7odSdmN3MwfHS5F5bAdLk76t77adcA6k1GBXdGkSivY+UO
JjiKlnJTviXXmWuVZ8qkJlJ/ks3jVtAfzpQ6DqugqgUInve+B+KWVkKtwOXSXbZuHcSi
8NiOQvabRBUMD5qL80DHdV9kSH4OIWHS+kigsapT99lXNKGfbGwsacDFmLC68kGi7LaY
T6+Fem9FIbPrk9XLS0z7MuU+h08oZcPCo5CJZWJ0eQyndhlM5WsSOJAWn2qqlHLJVL/Y
8VKA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1743695259; x=1744300059;
h=content-transfer-encoding:mime-version:message-id:date:references
:in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=NlWWuOA82uYyGDYGbzsGKrNI+TAXQw7gD3UHX71E+9M=;
b=J71Z1RY0+IhQGiy6ivJn89UDjlsIAC3VUjJc5t19s3n258YFbjLQ/a2548/qW5Ah31
09B6YQHwStAwndy/6A6qljqUNrz8nGWVBPPx3M4gRX6UTG8lv2QPa4XfDUikJnOSdnWY
9esfyMhAOb2SmRTdMv6tTJ60Ujr8NB+9ix5ZvyDtuML1BrK7ijDb7mJ0Rcym36NoN3Dl
LWXORHSbsb84vPvFhQXgJu7eDiOyJHVmwqwD/eDyzl8bjrlETJLIzKPuwrfJp6o4DACC
RzD/AS6G1TQt7WvZOs31KpLiL4VwblmM2Rzq48jBHHo34PYNTEfjDM7Pp8VCzRhxuRXe
4tAA==
X-Forwarded-Encrypted: i=1;
AJvYcCWWV/LKLr3rKg2fXQosmxMS24SH1Zj8EC6sqEe7iTk8HRTNQpRaiUi8BXObpdj1ETbvp9jQfA==@debbugs.gnu.org
X-Gm-Message-State: AOJu0Yxjb0nmo3BOStEZxsExr/QQzfURD2Q0/45Nca7QwryJLRZxpExL
CtahByvl4aM86yBh+3Pll4rnE2zGkNXfiA0iB6igjJn44v/q5lBN
X-Gm-Gg: ASbGnctnSknS+O4eTFNNL5od6Ks2ftP2zN6SlyVXPbg7VOWPvQnSl9yRIR95ecie4VG
8VPh6jUZgNiQZ0RCobPdcybBd8NS6iBELN/N8jIMUyxKxS0ql6JaaY7L3TKG8O5plNtheS9ioJG
1/Ab8W/n0KbgWIlnJR7FVqNc5VSshvZzaqxcxZnLu0eTtnIMA0zgY933a79IQh3a9JD41a86rEv
xEBLKljwg5MquNHiPAipU4i+r0VWIBw0yJTdhBgmXunapPc0tzsB/kMYMNhmTFeIO8xHIy1+wW2
olRME8JHtA1/SVKm5KgvRiVB7FGe8Dc=
X-Google-Smtp-Source: AGHT+IEidcVXJB52qtxwEK3ELHTN0dGzshrtYZZAOuAyrocI5Zvj/9Sn6rZssK0MhjNsF/Sb/YFkPA==
X-Received: by 2002:a05:620a:2589:b0:7c5:4b91:6a3d with SMTP id
af79cd13be357-7c690875443mr3117598485a.42.1743695259538;
Thu, 03 Apr 2025 08:47:39 -0700 (PDT)
Received: from rltb ([2a01:e0a:3f3:fb51:544e:f2f9:7d90:1a3])
by smtp.gmail.com with ESMTPSA id
af79cd13be357-7c76ea905cfsm90465585a.113.2025.04.03.08.47.38
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Thu, 03 Apr 2025 08:47:39 -0700 (PDT)
From: Robert Pluim <rpluim@HIDDEN>
To: Sean Whitton <spwhitton@HIDDEN>
Subject: Re: bug#77306: 31.0.50; C-x v L from *vc-change-log* buffer leaves
wrong default-directory
In-Reply-To: <87wmc1tipo.fsf@HIDDEN>
References: <87iknuhgkb.fsf@HIDDEN>
<7a3ddbb6-a0f6-44f6-b62e-64f92496bfda@HIDDEN>
<87wmc1fllb.fsf@HIDDEN> <87wmc1tipo.fsf@HIDDEN>
Date: Thu, 03 Apr 2025 17:47:36 +0200
Message-ID: <87sempfdrb.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.1 (/)
X-Debbugs-Envelope-To: 77306
Cc: Dmitry Gutov <dmitry@HIDDEN>, 77306 <at> debbugs.gnu.org,
monnier@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.9 (/)
>>>>> On Thu, 03 Apr 2025 22:36:51 +0800, Sean Whitton <spwhitton@spwhitton=
.name> said:
Sean> Hello,
Sean> On Thu 03 Apr 2025 at 02:58pm +02, Robert Pluim wrote:
>> Does `setq-local' not adjust the buffer-local value? What am I missi=
ng?
Sean> Indeed it does not.
You=CA=BCre right, but I don=CA=BCt understand why you=CA=BCre right, which=
means my
model of buffer-local variables is wrong. Oh well.
Robert
--=20
bug-gnu-emacs@HIDDEN:bug#77306; Package emacs.
Full text available.Received: (at 77306) by debbugs.gnu.org; 3 Apr 2025 14:37:07 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Apr 03 10:37:06 2025 Received: from localhost ([127.0.0.1]:35115 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u0Lgo-0002vJ-M0 for submit <at> debbugs.gnu.org; Thu, 03 Apr 2025 10:37:06 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:49792) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <spwhitton@HIDDEN>) id 1u0Lgl-0002un-0k for 77306 <at> debbugs.gnu.org; Thu, 03 Apr 2025 10:37:04 -0400 DKIM-Signature: a=rsa-sha256; b=NxkB8d7emc2tuJTC+KVcl/7dhvyrrjpAe7GncKhI1ND/hWQvLytuZqgtdD5WwWIHtXf1M9w8hvbfyuLAhv+N5/2MvyboqRQZ6CENFOag+uaA6v6LRpiK8HtbObYAY09jOKSi2QxkdjRCWuc+lNaIKPc9dn0pqLLzQ0IP8cAc7bUUFqjSn9jfCV0q5bskCI0A4ggzO1eNKt7pbYl4voOMVYYPnI/JBg2uwY3cwIYmhY6/GOvdnpbTj/gj/mDNx0BTpEwobTcVv8m2yQnHo6c06rBTQXFOfZv7YnK0Zz9Do3OH2g+KaWSiozTWwGsHL0QbD+oxdvrR2SxDOGv43QG6SQ==; s=purelymail1; d=spwhitton.name; v=1; bh=+ULPQlxXVdM0PiKLIYUD9nH5EE3vFMpNBe1ZBxPpLx4=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=Hm88DDJ1mB398otlD9pzXQ00o6qofHYyPLv70XbRLHdrVDEx9Rh65DYsuZWMATQUOA4r5kJrxJ9uAYwuvd5VkPJ/PRUcbeMVmQHPniDKUx7yKoTzmwqpTBNcdINC9/nm2BuZs+6n0T3W2ogDzvW9fPR1Y3GcRY+NB26pHrfwWPS+HYFhvu5jj4t2hHbXPrRY99YZSDltwv9iyVTC+v9iYXxQQ9+rdSvIF7Unx4MtGzjwws6thOO4EyLtR+y1CLlrUp4q+idtjgqYF+SFbHWWRcuxDdhUVAko9fkSbYuomkPPRHkzNY7g5hOqEoao1s+OHW+5Lxp2BWk4KKIlskSG/A==; s=purelymail1; d=purelymail.com; v=1; bh=+ULPQlxXVdM0PiKLIYUD9nH5EE3vFMpNBe1ZBxPpLx4=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 77306 <at> debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -1102725388; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Thu, 03 Apr 2025 14:36:56 +0000 (UTC) Received: by melete.silentflame.com (Postfix, from userid 1000) id 52DFE7EAC1D; Thu, 03 Apr 2025 22:36:51 +0800 (CST) From: Sean Whitton <spwhitton@HIDDEN> To: Robert Pluim <rpluim@HIDDEN> Subject: Re: bug#77306: 31.0.50; C-x v L from *vc-change-log* buffer leaves wrong default-directory In-Reply-To: <87wmc1fllb.fsf@HIDDEN> References: <87iknuhgkb.fsf@HIDDEN> <7a3ddbb6-a0f6-44f6-b62e-64f92496bfda@HIDDEN> <87wmc1fllb.fsf@HIDDEN> Date: Thu, 03 Apr 2025 22:36:51 +0800 Message-ID: <87wmc1tipo.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 77306 Cc: Dmitry Gutov <dmitry@HIDDEN>, 77306 <at> debbugs.gnu.org, monnier@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.9 (/) Hello, On Thu 03 Apr 2025 at 02:58pm +02, Robert Pluim wrote: > Does `setq-local' not adjust the buffer-local value? What am I missing? Indeed it does not. -- Sean Whitton
bug-gnu-emacs@HIDDEN:bug#77306; Package emacs.
Full text available.
Received: (at 77306) by debbugs.gnu.org; 3 Apr 2025 12:58:35 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Apr 03 08:58:35 2025
Received: from localhost ([127.0.0.1]:33243 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1u0K9T-0000Ez-7o
for submit <at> debbugs.gnu.org; Thu, 03 Apr 2025 08:58:35 -0400
Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]:43402)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <rpluim@HIDDEN>) id 1u0K9Q-0000Eg-AH
for 77306 <at> debbugs.gnu.org; Thu, 03 Apr 2025 08:58:33 -0400
Received: by mail-wm1-x32a.google.com with SMTP id
5b1f17b1804b1-43cf628cb14so14088965e9.1
for <77306 <at> debbugs.gnu.org>; Thu, 03 Apr 2025 05:58:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1743685106; x=1744289906; darn=debbugs.gnu.org;
h=mime-version:message-id:date:references:in-reply-to:subject:cc:to
:from:from:to:cc:subject:date:message-id:reply-to;
bh=h4m7cKeHamPO8PMmJvkfFlwoc5B/wcOwan7l2RISGzc=;
b=PsVag5SFrqRMqs+YEpHQ9D6/pnJZkg9ZbZ37tjLVbvQnhoBOlQNhhOKRhZe25iOMxp
TMynLemtXkUFD8Ztmh+9wttFkk11i7ISn61E5tVRsD1GWCKW5FlBrKK6QtkUA+eG7mF4
5fquDUsIQj5RtuiLzBObmzx851osWiuD7b/V35dolEuoJKt0OLCfgLCOL8NdhMdBlyg5
mMT6GCSP09KnTyw6Alt89j4Q9LQQ/Mr1rtgObouBcQLojsZy9h2k+Q4uDms7aK1DbyWi
xyFy0F2wyQwUVnowkUZcgi5PDWRVA+Y6xqfAkDfBhcgAGTTPT9dVbD+QRWas5Q8UocKk
a+lw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1743685106; x=1744289906;
h=mime-version:message-id:date:references:in-reply-to:subject:cc:to
:from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=h4m7cKeHamPO8PMmJvkfFlwoc5B/wcOwan7l2RISGzc=;
b=sViTPk/yhBwllYeCyE8UswlqOe9cj7Ni4VWcjopBVGpoJXHajpZsG25yb4jdOGTLsv
rNDGtX7IcITZntRCo3TUdbDC0S+mkRohO42HpkyUBzRucw5/umzZ8DXoWGf3/ZGYyR7Z
uddH+smJYRkt58nKHrFPb+oTB3jjn86bLKGMKJz6IUlX0/21lA30dQBM/6bl0RX+tn1/
VlcfxbWGrXrU2vdG1R890ceBp5tdaBd5cKDr4FD1gHejX9tICRFCcDQurcbOPifbx0oo
cgt6+EDRCKoddeWwvnP2tT0SVic+0BBzAyM6h4xTWMon53E6kgC+wfDrmSQRQkVLY4cz
729g==
X-Forwarded-Encrypted: i=1;
AJvYcCUm0k/CSugcDcJeoD8pCTqPm92N3qIrTGtXLG2b9e/D5o3Mrb7edVi1t5/h0PDAsHNP+1Byxw==@debbugs.gnu.org
X-Gm-Message-State: AOJu0YxwmwEiQQfauKakpK1hkh6Vm800UOExEweeKkWU91hfEF16zUS7
Hj4DXxjcThd/ZtDWpey3ViKO2jKn30h6Lp3/7oVKAHilLt8idHAA
X-Gm-Gg: ASbGnctb4MHaz+s1fVg7pXp07eLey33h/gkTaB6pMf6kEaqVAUKrMsf7JHCkY9NdLE8
wsUATdWUless5nt7QpJhGdpBZizipstsr//G+xqebL8qYbWySNsBVzmg09ErOX3RCFMvYmcorc4
XWwfnR+lej3BkR0AfqawoIVMp1bPsYKJv8y2u1SHyfoVL4rJXyxz5uLevI+O1kNJJ396ZbDnk2x
IPAp7osdKPfPXy8hsz/4kaZIldCnlnqCcLa/SlWndPQqBnAceSIZzl53nXzzNJUS3Wh4OEODb1q
PP+jTokY2M8sA3Nkic2uly1SDIhx7sg=
X-Google-Smtp-Source: AGHT+IFS5Sog0rIHoAv6ZA0sRcbnUBAm/I/01jAX/iQ6HKAo2cfZFjj3CWWlNaV//SEVMyiBKNoLAA==
X-Received: by 2002:a05:6000:1842:b0:391:1218:d5f4 with SMTP id
ffacd0b85a97d-39c2e63062emr2993138f8f.23.1743685105762;
Thu, 03 Apr 2025 05:58:25 -0700 (PDT)
Received: from rltb ([2a01:e0a:3f3:fb51:544e:f2f9:7d90:1a3])
by smtp.gmail.com with ESMTPSA id
ffacd0b85a97d-39c301a6608sm1733889f8f.23.2025.04.03.05.58.24
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Thu, 03 Apr 2025 05:58:25 -0700 (PDT)
From: Robert Pluim <rpluim@HIDDEN>
To: Dmitry Gutov <dmitry@HIDDEN>
Subject: Re: bug#77306: 31.0.50; C-x v L from *vc-change-log* buffer leaves
wrong default-directory
In-Reply-To: <7a3ddbb6-a0f6-44f6-b62e-64f92496bfda@HIDDEN>
References: <87iknuhgkb.fsf@HIDDEN>
<7a3ddbb6-a0f6-44f6-b62e-64f92496bfda@HIDDEN>
Date: Thu, 03 Apr 2025 14:58:24 +0200
Message-ID: <87wmc1fllb.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.1 (/)
X-Debbugs-Envelope-To: 77306
Cc: 77306 <at> debbugs.gnu.org, monnier@HIDDEN,
Sean Whitton <spwhitton@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.9 (/)
>>>>> On Thu, 3 Apr 2025 15:14:28 +0300, Dmitry Gutov <dmitry@HIDDEN> said:
Dmitry> On 27/03/2025 13:13, Sean Whitton wrote:
>> This problem is caused by the let binding of default-directory
>> established by vc-print-root-log. vc-setup-buffer wants to set
>> default-directory in the*vc-change-log* buffer to the new repository's
>> root, but ends up just adjusting the let binding's value.
>> The same thing probably occurs with C-x v D.
>> Could we reformulate the command definitions so that they didn't
>> need to
>> bind default-directory? Should vc-setup-buffer use the same
>> run-with-timer trick implemented in xref--ensure-default-directory?
Dmitry> Yeah, I don't have a better suggestion.
Doe `setq-local' not adjust the buffer-local value? What am I missing?
Robert
--
bug-gnu-emacs@HIDDEN:bug#77306; Package emacs.
Full text available.Received: (at 77306) by debbugs.gnu.org; 3 Apr 2025 12:14:42 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Apr 03 08:14:42 2025 Received: from localhost ([127.0.0.1]:33168 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u0JT0-0003j4-Bj for submit <at> debbugs.gnu.org; Thu, 03 Apr 2025 08:14:42 -0400 Received: from fhigh-a8-smtp.messagingengine.com ([103.168.172.159]:59121) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <dmitry@HIDDEN>) id 1u0JSx-0003ip-0M for 77306 <at> debbugs.gnu.org; Thu, 03 Apr 2025 08:14:39 -0400 Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfhigh.phl.internal (Postfix) with ESMTP id 51507114019E; Thu, 3 Apr 2025 08:14:33 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-10.internal (MEProxy); Thu, 03 Apr 2025 08:14:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1743682473; x=1743768873; bh=szhc0e+BegP5NIJneLB5Wh4zgd6Inmwi8FYPIobdwrY=; b= D9GqERHgF1qsBx414c/Xm13K3rPLgW0ApXShXoQH0ny2QTdTFwZc5GM87j6ZPQB8 Q9uKF0Osr1VLcmBR6KYbs5O7TDK0OYt5pjas/RE1aoiSm+O75qJIyufFz2fO/5uV 55FzwjfcL50xbANkzqSvDrFtsFpa/TD0aL3ZCLW8ie0zh7A9CFyHxIKvnVeEX1Fp 5mkVzBplG/MwyAF6pJ6YtPdmBhYuzSt/xpyGEhBXGVg7sY+owcvQdIDuNYCrDqmx YyxHNjgOUv7iEgLW9l9MwDUR10SjhwxUZLox4mG6JNGhJRXMjnrPzmJ7HYj2OpE/ QDQhLRXb8XUtLHDJoK4MGA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1743682473; x= 1743768873; bh=szhc0e+BegP5NIJneLB5Wh4zgd6Inmwi8FYPIobdwrY=; b=s sOWT1Z4MegplH0GTy/mv7RHTJt9tx6SsbF99eReZpqFqWt7QpJJgdEon9XtlpHu8 UNNgNXGRaZd7we/C0UWKQLEc550obyPS8BYfC2PQlddIObqayw4yfpNecMhM+mhs /kwEN72sMcDX1umMjpD1uIfN+N/yDUnu7LsQb6n9Othuc/AMfnSA4JVxx8HQo/TT SqFsXqPiDG2vPR2G2LZlCndzMjznP6rvHP/YSTIACoq1oeFEmuhTZ4xPJjulNpoa Ay5wqpdw0NmNLl8vMHirKgBN9OYWAA/jrx3J9u6nr6393AxAhkYU/ddr3CTciJss DkHB/+evPm2NFndDH0vnA== X-ME-Sender: <xms:qHvuZ5T_JEBrx1UVJFw8iIpt_Ir8xQp14-RDCilPVCq18o1lyQrHfQ> <xme:qHvuZyzmxclZfi4b6O05_h4lppWuYplKDq0IpP39Ruvzyt6HX2tFAffdSMcrOJ5XW lfVnFBRK7Vw73jp0fA> X-ME-Received: <xmr:qHvuZ-3g_gWRWibAO1mNQJeM__GF7VzaFnvkdnhEF-qtshlv67Kcz2djZgwwc39lEA> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddukeekheefucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddt vdejnecuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovh druggvvheqnecuggftrfgrthhtvghrnhepteduleejgeehtefgheegjeekueehvdevieek ueeftddvtdevfefhvdevgedujeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghvpdhnsggprhgtphht thhopeefpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehsphifhhhithhtohhnse hsphifhhhithhtohhnrdhnrghmvgdprhgtphhtthhopeejjeeftdeiseguvggssghughhs rdhgnhhurdhorhhgpdhrtghpthhtohepmhhonhhnihgvrhesihhrohdruhhmohhnthhrvg grlhdrtggr X-ME-Proxy: <xmx:qXvuZxAf-rBhGHQZ-Ef0cRw1lvBYbPg9UId9gjZoHiIwIolmJBa-Xg> <xmx:qXvuZyhea9EUxXm5Nc57yizzL_1T0Ar9688jOyeaeqjP4V8yJ8jaQQ> <xmx:qXvuZ1qjFZ8oNoqOyzkSjI5fYUy6_pcORthBMDLgMf5_oV_FaO5oWQ> <xmx:qXvuZ9j6jkLJeZ_FvSewVzlkb9PU9V005M3bTy0NfsCXG9DkG6tfCQ> <xmx:qXvuZ7Rv8YpoPX1oCdh88tuhWWceKBLpBw4Hyr6kZcWMZ2jST2ArauBo> Feedback-ID: i07de48aa:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 3 Apr 2025 08:14:31 -0400 (EDT) Message-ID: <7a3ddbb6-a0f6-44f6-b62e-64f92496bfda@HIDDEN> Date: Thu, 3 Apr 2025 15:14:28 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#77306: 31.0.50; C-x v L from *vc-change-log* buffer leaves wrong default-directory To: Sean Whitton <spwhitton@HIDDEN>, 77306 <at> debbugs.gnu.org References: <87iknuhgkb.fsf@HIDDEN> Content-Language: en-US From: Dmitry Gutov <dmitry@HIDDEN> In-Reply-To: <87iknuhgkb.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 77306 Cc: monnier@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.6 (-) On 27/03/2025 13:13, Sean Whitton wrote: > This problem is caused by the let binding of default-directory > established by vc-print-root-log. vc-setup-buffer wants to set > default-directory in the*vc-change-log* buffer to the new repository's > root, but ends up just adjusting the let binding's value. > > The same thing probably occurs with C-x v D. > > Could we reformulate the command definitions so that they didn't need to > bind default-directory? Should vc-setup-buffer use the same > run-with-timer trick implemented in xref--ensure-default-directory? Yeah, I don't have a better suggestion. The key here seem to be that the buffer already exists and is selected when the command is invoked. Perhaps we could recreate the buffer instead of reusing it? But then we'd also need to put it in the same window, fixup the buffer list to use the same position, and etc...
bug-gnu-emacs@HIDDEN:bug#77306; Package emacs.
Full text available.Received: (at 77306-done) by debbugs.gnu.org; 3 Apr 2025 08:35:46 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Apr 03 04:35:46 2025 Received: from localhost ([127.0.0.1]:60998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u0G37-0007gO-Sf for submit <at> debbugs.gnu.org; Thu, 03 Apr 2025 04:35:46 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:47308) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <spwhitton@HIDDEN>) id 1u0G33-0007fl-BH for 77306-done <at> debbugs.gnu.org; Thu, 03 Apr 2025 04:35:42 -0400 DKIM-Signature: a=rsa-sha256; b=xmIutr+Vzlo6K7J0ZWR3vW7kIkB/ZbZ+Usl+nAga5ZWcDU+5smnllOJrxsCmaQXmpYMX529vEbMTW8Vtk7sESnyBBqDb/b6EKORUq10dZHoDA+qECiIkASvDtx+0VtDYkp9QsH4gzrEiNNVQcMorA3RwExAnrwObDNztutWwXqIVLGrrfkmv7jQ/xjg9ezpQdQ4dM6WGVuJ1hmns2s2nv4rtvYyHAt1fgkCGmeNwW2W2EQn3QGrH0yRjluLcxPKsxBCVVX5HLF9f9Ezd7VJabt9nCHjX6Ov0G7zXFO9+uWEpCjdRDgm+AUZlU0wSoJPCHq4jafhc2R7M5nxEkHYMrw==; s=purelymail1; d=spwhitton.name; v=1; bh=I3ExkWG0aOCGT/8G7Unj0QEv9+HphiM6UWu91AvazcM=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=FHe7LHUDUBYKbwuE6YUO2wAS2XjOqkZIYIS5SbH6OZxO8fMJZPSV04ULw2O/OfjM7HsD8fRYAjyEvAc/mDSFjZMBNTAoBaB5p8UqqcM6BwrBHthTjHUypaBvPsl9l/mVYAs0NG2M9094QpPkHbc5juu9QnkCwAhvqVxPwOojZDwWob2T7HHdJ41hKB6dAekvyV+E2nNjn5XxghQ9I3QHVuZaPymw0gGRv6toaBBO/mssrB9aPrbXDQRe+IhaD01oq7KFOwodJERp+8Clpl4Wo8c6K3vR0YYKr2U8WecL/3bS6wHpCOXzopWOMOPIlMNhKQv53cdNqXO9vucGyWz99g==; s=purelymail1; d=purelymail.com; v=1; bh=I3ExkWG0aOCGT/8G7Unj0QEv9+HphiM6UWu91AvazcM=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 77306-done <at> debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 1479312776; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Thu, 03 Apr 2025 08:35:33 +0000 (UTC) Received: by melete.silentflame.com (Postfix, from userid 1000) id BB2BD7EAC26; Thu, 03 Apr 2025 16:35:25 +0800 (CST) From: Sean Whitton <spwhitton@HIDDEN> To: 77306-done <at> debbugs.gnu.org Subject: Re: bug#77306: 31.0.50; C-x v L from *vc-change-log* buffer leaves wrong default-directory In-Reply-To: <87iknuhgkb.fsf@HIDDEN> References: <87iknuhgkb.fsf@HIDDEN> Date: Thu, 03 Apr 2025 16:35:25 +0800 Message-ID: <87ecy9ve0i.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 77306-done Cc: dmitry@HIDDEN, monnier@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.9 (/) Version: 31.1 Hello, No-one has had any better ideas yet here so I've installed another run-with-timer workaround, with an explanatory comment. Hopefully we can improve on this, but the bug is worth fixing now -- I run into it daily, somehow. -- Sean Whitton
Sean Whitton <spwhitton@HIDDEN>:Sean Whitton <spwhitton@HIDDEN>:Received: (at submit) by debbugs.gnu.org; 27 Mar 2025 11:14:31 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Mar 27 07:14:30 2025 Received: from localhost ([127.0.0.1]:47778 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1txlBs-0003n6-R0 for submit <at> debbugs.gnu.org; Thu, 27 Mar 2025 07:14:30 -0400 Received: from lists.gnu.org ([2001:470:142::17]:59650) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <spwhitton@HIDDEN>) id 1txlBM-0003i3-LT for submit <at> debbugs.gnu.org; Thu, 27 Mar 2025 07:13:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <spwhitton@HIDDEN>) id 1txlBG-0005bX-BY for bug-gnu-emacs@HIDDEN; Thu, 27 Mar 2025 07:13:50 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <spwhitton@HIDDEN>) id 1txlBD-0004IM-RA for bug-gnu-emacs@HIDDEN; Thu, 27 Mar 2025 07:13:50 -0400 DKIM-Signature: a=rsa-sha256; b=nCyEvMTZSpt512pPN+AUc6/8dMLSXSo3J8DjiS6Gq72CUChSBlAZgRJZWOwdE8wJBuqHNPggwhui555BWm1raaRr9wuzWHbbRYpfriYqR+ffI1eSwdK/iDoWDLYsrrhmHsMciUZehHZVatAtRT8kVZmF4GR75RG8NLDtmeSHgpd27f9a/tg7qvXnngV66BZhCt+TW4FBd8xx9xjMQLCZ1lDSsesDbAE4dwvty62y91VHsWwL5zpxCmvR5j2q1H9GVmxqMxTV2zPVwYqozgO0CwVM/VtRO6Ig2zSrTFX50FLq9GIeWvaOpdtDXIZ6skw1+jYVofjPB1iFZapBNnFpgg==; s=purelymail3; d=spwhitton.name; v=1; bh=OmboJJiUVKQfM9uFteWbdacDTz9ONGlLDkdBqfLUik8=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=Xt74Y3bf7Mcpm8vA/4UW5pCPlPUSa3P4IVH7nH486GeOTCWcMe8HOg4M1fotanC+bmfNCokH8tbyjXvB+OSQN5GcLxx0YpNUPXIMun7/YYa3p9aBKDbW2FoxXzl4pFbM/ebk8TMS2Ge73Kd7D4A78CENOKUB5bS7pqX3f4InhoYwkgb/jquA0fbVwCQqK8DpHvnobBURmJxYgLcXvV4KPjqpZyjqhtTf9wl5dvph3ziNFDqf/wV6zgJsawnYQQE7ALNHYgxkEpdu5lUmFyIz+JLhaoQQRQK9zWGY0dbhWjKNAJ523HE5FSqb9PK3bP/rR6/In3eVwIpWmVkTCAWXvw==; s=purelymail3; d=purelymail.com; v=1; bh=OmboJJiUVKQfM9uFteWbdacDTz9ONGlLDkdBqfLUik8=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: bug-gnu-emacs@HIDDEN Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 1369490460 for <bug-gnu-emacs@HIDDEN> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Thu, 27 Mar 2025 11:13:45 +0000 (UTC) Received: by melete.silentflame.com (Postfix, from userid 1000) id 6B38B7E8FA8; Thu, 27 Mar 2025 19:13:40 +0800 (CST) From: Sean Whitton <spwhitton@HIDDEN> To: bug-gnu-emacs@HIDDEN Subject: 31.0.50; C-x v L from *vc-change-log* buffer leaves wrong default-directory Date: Thu, 27 Mar 2025 19:13:40 +0800 Message-ID: <87iknuhgkb.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=34.202.193.197; envelope-from=spwhitton@HIDDEN; helo=sendmail.purelymail.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, GAPPY_SUBJECT=0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: X-debbugs-cc: dmitry@HIDDEN, monnier@HIDDEN A similar problem to #53626 crops up with C-x v L, too. 1. emacs -q 2. Visit a version controlled file. 3. C-x v L 4. Without switching buffer, C-x p p ~/some/other/repo RET o C-x v L 5. RET to toggle display of the log message. Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2001:470:142:0:0:0:0:17 listed in] [list.dnswl.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.1 GAPPY_SUBJECT Subject: contains G.a.p.p.y-T.e.x.t X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.1 (/) X-debbugs-cc: dmitry@HIDDEN, monnier@HIDDEN A similar problem to #53626 crops up with C-x v L, too. 1. emacs -q 2. Visit a version controlled file. 3. C-x v L 4. Without switching buffer, C-x p p ~/some/other/repo RET o C-x v L 5. RET to toggle display of the log message. Result, in the case of git, is "fatal: bad revision" because default-directory is still the first VC repository's root. This problem is caused by the let binding of default-directory established by vc-print-root-log. vc-setup-buffer wants to set default-directory in the *vc-change-log* buffer to the new repository's root, but ends up just adjusting the let binding's value. The same thing probably occurs with C-x v D. Could we reformulate the command definitions so that they didn't need to bind default-directory? Should vc-setup-buffer use the same run-with-timer trick implemented in xref--ensure-default-directory? CCing Stefan since this is a dynamic binding issue. -- Sean Whitton
Sean Whitton <spwhitton@HIDDEN>:dmitry@HIDDEN, monnier@HIDDEN, bug-gnu-emacs@HIDDEN.
Full text available.dmitry@HIDDEN, monnier@HIDDEN, bug-gnu-emacs@HIDDEN:bug#77306; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.