GNU bug report logs - #77306
31.0.50; C-x v L from *vc-change-log* buffer leaves wrong default-directory

Message received at submit <at> debbugs.gnu.org:

Received: (at submit) by debbugs.gnu.org; 27 Mar 2025 11:14:31 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Mar 27 07:14:30 2025
Received: from localhost ([127.0.0.1]:47778 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1txlBs-0003n6-R0
	for submit <at> debbugs.gnu.org; Thu, 27 Mar 2025 07:14:30 -0400
Received: from lists.gnu.org ([2001:470:142::17]:59650)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <spwhitton@HIDDEN>)
 id 1txlBM-0003i3-LT
 for submit <at> debbugs.gnu.org; Thu, 27 Mar 2025 07:13:58 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <spwhitton@HIDDEN>)
 id 1txlBG-0005bX-BY
 for bug-gnu-emacs@HIDDEN; Thu, 27 Mar 2025 07:13:50 -0400
Received: from sendmail.purelymail.com ([34.202.193.197])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <spwhitton@HIDDEN>)
 id 1txlBD-0004IM-RA
 for bug-gnu-emacs@HIDDEN; Thu, 27 Mar 2025 07:13:50 -0400
DKIM-Signature: a=rsa-sha256;
 b=nCyEvMTZSpt512pPN+AUc6/8dMLSXSo3J8DjiS6Gq72CUChSBlAZgRJZWOwdE8wJBuqHNPggwhui555BWm1raaRr9wuzWHbbRYpfriYqR+ffI1eSwdK/iDoWDLYsrrhmHsMciUZehHZVatAtRT8kVZmF4GR75RG8NLDtmeSHgpd27f9a/tg7qvXnngV66BZhCt+TW4FBd8xx9xjMQLCZ1lDSsesDbAE4dwvty62y91VHsWwL5zpxCmvR5j2q1H9GVmxqMxTV2zPVwYqozgO0CwVM/VtRO6Ig2zSrTFX50FLq9GIeWvaOpdtDXIZ6skw1+jYVofjPB1iFZapBNnFpgg==;
 s=purelymail3; d=spwhitton.name; v=1;
 bh=OmboJJiUVKQfM9uFteWbdacDTz9ONGlLDkdBqfLUik8=;
 h=Received:Received:From:To:Subject:Date; 
DKIM-Signature: a=rsa-sha256;
 b=Xt74Y3bf7Mcpm8vA/4UW5pCPlPUSa3P4IVH7nH486GeOTCWcMe8HOg4M1fotanC+bmfNCokH8tbyjXvB+OSQN5GcLxx0YpNUPXIMun7/YYa3p9aBKDbW2FoxXzl4pFbM/ebk8TMS2Ge73Kd7D4A78CENOKUB5bS7pqX3f4InhoYwkgb/jquA0fbVwCQqK8DpHvnobBURmJxYgLcXvV4KPjqpZyjqhtTf9wl5dvph3ziNFDqf/wV6zgJsawnYQQE7ALNHYgxkEpdu5lUmFyIz+JLhaoQQRQK9zWGY0dbhWjKNAJ523HE5FSqb9PK3bP/rR6/In3eVwIpWmVkTCAWXvw==;
 s=purelymail3; d=purelymail.com; v=1;
 bh=OmboJJiUVKQfM9uFteWbdacDTz9ONGlLDkdBqfLUik8=;
 h=Feedback-ID:Received:Received:From:To:Subject:Date; 
Feedback-ID: 20115:3760:null:purelymail
X-Pm-Original-To: bug-gnu-emacs@HIDDEN
Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 1369490460
 for <bug-gnu-emacs@HIDDEN>
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384);
 Thu, 27 Mar 2025 11:13:45 +0000 (UTC)
Received: by melete.silentflame.com (Postfix, from userid 1000)
 id 6B38B7E8FA8; Thu, 27 Mar 2025 19:13:40 +0800 (CST)
From: Sean Whitton <spwhitton@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 31.0.50; C-x v L from *vc-change-log* buffer leaves wrong
 default-directory
Date: Thu, 27 Mar 2025 19:13:40 +0800
Message-ID: <87iknuhgkb.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=34.202.193.197;
 envelope-from=spwhitton@HIDDEN; helo=sendmail.purelymail.com
X-Spam_score_int: -19
X-Spam_score: -2.0
X-Spam_bar: --
X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, GAPPY_SUBJECT=0.1,
 RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,
 SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.1 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview:  X-debbugs-cc: dmitry@HIDDEN, monnier@HIDDEN A
 similar problem to #53626 crops up with C-x v L, too. 1. emacs -q 2. Visit
 a version controlled file. 3. C-x v L 4. Without switching buffer, C-x p
 p ~/some/other/repo RET o C-x v L 5. RET to toggle display of the log message.
 Content analysis details:   (1.1 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -0.0 RCVD_IN_DNSWL_NONE     RBL: Sender listed at https://www.dnswl.org/,
 no trust [2001:470:142:0:0:0:0:17 listed in] [list.dnswl.org]
 1.0 SPF_SOFTFAIL           SPF: sender does not match SPF record (softfail)
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
 0.1 GAPPY_SUBJECT          Subject: contains G.a.p.p.y-T.e.x.t
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.1 (/)

X-debbugs-cc: dmitry@HIDDEN, monnier@HIDDEN

A similar problem to #53626 crops up with C-x v L, too.

1. emacs -q
2. Visit a version controlled file.
3. C-x v L
4. Without switching buffer, C-x p p ~/some/other/repo RET o C-x v L
5. RET to toggle display of the log message.

Result, in the case of git, is "fatal: bad revision" because
default-directory is still the first VC repository's root.

This problem is caused by the let binding of default-directory
established by vc-print-root-log.  vc-setup-buffer wants to set
default-directory in the *vc-change-log* buffer to the new repository's
root, but ends up just adjusting the let binding's value.

The same thing probably occurs with C-x v D.

Could we reformulate the command definitions so that they didn't need to
bind default-directory?  Should vc-setup-buffer use the same
run-with-timer trick implemented in xref--ensure-default-directory?

CCing Stefan since this is a dynamic binding issue.

-- 
Sean Whitton