André Batista <nandre@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 77964) by debbugs.gnu.org; 24 Apr 2025 21:43:35 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Apr 24 17:43:35 2025 Received: from localhost ([127.0.0.1]:42201 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u84M3-0007Eg-4W for submit <at> debbugs.gnu.org; Thu, 24 Apr 2025 17:43:35 -0400 Received: from mx1.riseup.net ([198.252.153.129]:47808) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <nandre@HIDDEN>) id 1u84M0-0007EO-Dh for 77964 <at> debbugs.gnu.org; Thu, 24 Apr 2025 17:43:33 -0400 Received: from fews02-sea.riseup.net (fews02-sea-pn.riseup.net [10.0.1.112]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx1.riseup.net (Postfix) with ESMTPS id 4Zk8by2p6czDqJ6; Thu, 24 Apr 2025 21:43:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1745531006; bh=hxb29IygWDq2LbNWOuERbsplaHIbvMp3qHQ7Dq1TDvM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=X2eQsdiAtqiQ7f6af0vc4xOkCCDWDhIEROkoa9mXM3GW/ZbyP/2YyWuYY4k5o9QSw 96aeaC+D9tk8WUGhJQdc2Ddlxox+XbD+WixSJ2hzm6Izc6FHS1kTRaSnddF0Iwv4dW kOOXkmZub0PT0fIvOyx3+CMOK48rImItKk4E2dfI= X-Riseup-User-ID: 27B342918C9CE6038B7DE860266E740EE7AF3AE1DE3A5A82EA8E308B3F15924E Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews02-sea.riseup.net (Postfix) with ESMTPSA id 4Zk8bx1xc4zFw3N; Thu, 24 Apr 2025 21:43:24 +0000 (UTC) Date: Thu, 24 Apr 2025 18:43:04 -0300 From: =?iso-8859-1?Q?Andr=E9?= Batista <nandre@HIDDEN> To: Greg Hogan <code@HIDDEN> Subject: Re: bug#77964: [PATCH sysadmin-team 2/2] gnu: spdlog: Unbundle fmt dependency. Message-ID: <aAqwaPsKamYK36gd@andel> References: <cover.1745417760.git.code@HIDDEN> <492fbc7057c75858dfbbfa7381418f549c1c46db.1745417760.git.code@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <492fbc7057c75858dfbbfa7381418f549c1c46db.1745417760.git.code@HIDDEN> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77964 Cc: 77964 <at> debbugs.gnu.org, Sharlatan Hellseher <sharlatanus@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Hi Greg, qua 23 abr 2025 às 14:39:57 (1745429997), code@HIDDEN enviou: > (...) > > diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm > index fee7e02d6e..18f1a19ff9 100644 > --- a/gnu/packages/xdisorg.scm > +++ b/gnu/packages/xdisorg.scm > @@ -3538,7 +3538,7 @@ (define-public j4-dmenu-desktop > (build-system meson-build-system) > (native-inputs > (list catch2-3 pkg-config)) > - (inputs (list spdlog fmt-11)) > + (inputs (list spdlog-1.15)) > (arguments > (list > #:configure-flags > Kodi is also affected by the bug this patch series solves[1]. Could you send a new version of this patch series removing 'fmt' from the list of inputs to kodi as you did for xdisorg? Other than that, LGTM. Cheers! 1. https://issues.guix.gnu.org/77911
bug-guix@HIDDEN:bug#77964; Package guix.
Full text available.
Received: (at 77964) by debbugs.gnu.org; 23 Apr 2025 14:43:42 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 23 10:43:41 2025
Received: from localhost ([127.0.0.1]:58242 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1u7bK4-00045s-U0
for submit <at> debbugs.gnu.org; Wed, 23 Apr 2025 10:43:40 -0400
Received: from mail-qk1-x72e.google.com ([2607:f8b0:4864:20::72e]:56339)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <code@HIDDEN>)
id 1u7bJo-00042c-Ho
for 77964 <at> debbugs.gnu.org; Wed, 23 Apr 2025 10:43:21 -0400
Received: by mail-qk1-x72e.google.com with SMTP id
af79cd13be357-7c5b8d13f73so691424485a.0
for <77964 <at> debbugs.gnu.org>; Wed, 23 Apr 2025 07:43:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=greghogan-com.20230601.gappssmtp.com; s=20230601; t=1745419393; x=1746024193;
darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=/dvBhDG+kCFTgGAAnIb+QZbQv4vN+ycd3o2G5vapzDo=;
b=N3JHGYxMSOLiRQcMLvZA7BbzAi5hlWJXIVX0DOx08BlTXH3CpIUzcv59lhXvEEvszR
SRB5hEXf5ddUmeUmUOJ5gQiY/P42bQqkwm51I5Z5c8gmAHYn3C6BIqLRFkUb/5ght5Ne
VzWyzJGflARBjFV5QzgFws6ORMVdaEcanG7NuBMvDnkMTWfmKuaDchPuVE2DCn6Ig4Df
QgigkmqOmLsxfRNTmnAqvdjp1OUq+3DnMmyZTiBVMyzI0xRYJLYpJ4bYpt9eOwAH4/OX
WkbWBtgSMV7RGaG6Vodq2m6s2dx1jcXePhzu00It/ATr5ASIdwaaYXz6sZpTbLhgLnFu
IIOg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1745419393; x=1746024193;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=/dvBhDG+kCFTgGAAnIb+QZbQv4vN+ycd3o2G5vapzDo=;
b=UdEyU6H37gSvxUGommGEvhOgH9IiD0Xk7eqVvC0jYadraTdKe8heFdjTWeqotkpcwl
Icd6qxcTjCWUqgyk5ONV5HpsC+nvPiRjXVuU3q/ibpxXxjzfZQWdNg2GgNNRxxnwEIMZ
9zd6g3GqnCtC2A7L0OVl8WiCozc268OsTjCkZPdCAxqdJ7HXhZzvDV2KqvwmfmIvxfdv
xQZwWqabKDSCDvsBdVWJmh7OlkrWBhBfAMUinNssSuAjEQCVgzb3FeNKQrgIa/PTZZUC
AiJvrw9p7b5Gtl872W/BHChw0bZ1JG/OkReotV7wdLo46HGB0lVjy3J52Fe4USckSAfm
TtBw==
X-Gm-Message-State: AOJu0Yzvn0QIeensZHzUKPBdY++KudSjJsPp5AblBoFZNXx2BnhCmPwo
3IoF5ly8HifpcaqiCEZj0KY77pYEZ+fjtLwZ3d2LZFFfzKUJAKAV+JFFh7t/KopQPisN7WDh/yt
N
X-Gm-Gg: ASbGncuHjjWh4IDpleb5jRSt8vbirV9+tJh0u8rry7pNezwXGm1/420XCZfYnHMpTvN
AMDDRiDfokdXA5UGj/8LQuG615OzLHj7xKHWARsRGbXlkc8c3I6X4zS4ELmWrFqs3U2mRoH3unb
Hps6hOBpwH8IusnJffy+wTTU9jUB2No4jFFpL9hnKKQOBVWbrDivvMn5g7mg/EA1qPW5PhSPWNO
tGyIMBCKLUtTzYkH2eXAKi1bYffVWW/pCXvDcoMi+vNS/3KdHfsVNtm2xiyZdjA5EZIi6duHuzR
aAKfztSd6ApmG1SIczLKMyjlZ/PXVmXwU5I+OBPnLngEpTyWWSHuw/zhtyB7lCc/OV/ux/k3yYR
ribfTmq/gcX5ewX5YoEfYT+Oy478DPESz05nOF8lj45aUs4I2zHk=
X-Google-Smtp-Source: AGHT+IH6cHkLZ+uuE/BkiiWLFz5vf+4PhpK9V24JkW8f1lEDTLvJh05z+PyvI91UJYo9iW8GxqXipA==
X-Received: by 2002:a05:620a:319d:b0:7c5:4c49:76a5 with SMTP id
af79cd13be357-7c927f59296mr2564262585a.12.1745419393052;
Wed, 23 Apr 2025 07:43:13 -0700 (PDT)
Received: from ip-10-117-149-49.evoforge.org
(ec2-52-70-167-183.compute-1.amazonaws.com. [52.70.167.183])
by smtp.gmail.com with ESMTPSA id
af79cd13be357-7c925a6eb31sm692026285a.3.2025.04.23.07.43.12
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 23 Apr 2025 07:43:12 -0700 (PDT)
From: Greg Hogan <code@HIDDEN>
To: 77964 <at> debbugs.gnu.org
Subject: [PATCH sysadmin-team 2/2] gnu: spdlog: Unbundle fmt dependency.
Date: Wed, 23 Apr 2025 14:39:57 +0000
Message-ID: <492fbc7057c75858dfbbfa7381418f549c1c46db.1745417760.git.code@HIDDEN>
X-Mailer: git-send-email 2.49.0
In-Reply-To: <cover.1745417760.git.code@HIDDEN>
References: <cover.1745417760.git.code@HIDDEN>
MIME-Version: 1.0
X-Debbugs-Cc: Sharlatan Hellseher <sharlatanus@HIDDEN>
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 77964
Cc: Greg Hogan <code@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
* gnu/packages/logging.scm (spdlog-1.15, spdlog-1.13, spdlog-1.10)
[source]: Remove bundled fmt ...
[propagated-inputs]: ... and add corresponding fmt.
[arguments]<#:configure-flags>: Use system fmt.
[license]: Remove fmt license.
(spdlog): Pin to spdlog-1.13.
* gnu/packages/xdisorg.scm (j4-dmenu-desktop)[inputs]: Replace spdlog
with spdlog-1.15 and remove fmt-11.
Change-Id: I8bea1e6a0cb375eaaeb8fdf0843a62d86d9fc4fd
---
gnu/packages/logging.scm | 28 +++++++++++++++++++++-------
gnu/packages/pretty-print.scm | 2 +-
gnu/packages/xdisorg.scm | 2 +-
3 files changed, 23 insertions(+), 9 deletions(-)
diff --git a/gnu/packages/logging.scm b/gnu/packages/logging.scm
index a764fee5be..26525e5fc8 100644
--- a/gnu/packages/logging.scm
+++ b/gnu/packages/logging.scm
@@ -52,6 +52,7 @@ (define-module (gnu packages logging)
#:use-module (gnu packages networking)
#:use-module (gnu packages perl)
#:use-module (gnu packages pkg-config)
+ #:use-module (gnu packages pretty-print)
#:use-module (gnu packages python)
#:use-module (gnu packages python-build)
#:use-module (gnu packages python-check)
@@ -248,7 +249,9 @@ (define-public spdlog-1.15
(commit (string-append "v" version))))
(file-name (git-file-name name version))
(sha256
- (base32 "1drpbn7b6iikypdlsvzpcjwyls0rqzl7sz7f7xjbn3d7ic55a1p1"))))
+ (base32 "1drpbn7b6iikypdlsvzpcjwyls0rqzl7sz7f7xjbn3d7ic55a1p1"))
+ (modules '((guix build utils)))
+ (snippet #~(delete-file-recursively "include/spdlog/fmt/bundled"))))
(build-system cmake-build-system)
;; TODO run benchmark. Currently not possible, as adding
;; (gnu packages benchmark) forms a dependency cycle
@@ -256,17 +259,17 @@ (define-public spdlog-1.15
(list #:configure-flags
#~(list "-DSPDLOG_BUILD_BENCH=OFF"
"-DSPDLOG_BUILD_SHARED=ON"
+ "-DSPDLOG_FMT_EXTERNAL=ON"
#$@(if (%current-target-system)
'()
'("-DSPDLOG_BUILD_TESTS=ON")))))
(native-inputs (list catch2-3))
+ (propagated-inputs (list fmt-11))
(home-page "https://github.com/gabime/spdlog")
(synopsis "Fast C++ logging library")
(description "Spdlog is a very fast header-only/compiled C++ logging
library.")
- ;; spdlog is under Expat license, but the bundled fmt library in
- ;; "include/spdlog/fmt/bundled" is under BSD 2 clause license.
- (license (list license:expat license:bsd-2))))
+ (license license:expat)))
(define-public spdlog-1.13
(package/inherit spdlog-1.15
@@ -279,7 +282,12 @@ (define-public spdlog-1.13
(commit (string-append "v" version))))
(file-name (git-file-name (package-name spdlog-1.15) version))
(sha256
- (base32 "0zgdmdgnp2y36jrlk85d4fiyjkjd6anly8pambyc3f3v6sg02zyy"))))))
+ (base32 "0zgdmdgnp2y36jrlk85d4fiyjkjd6anly8pambyc3f3v6sg02zyy"))
+ (modules '((guix build utils)))
+ (snippet #~(delete-file-recursively "include/spdlog/fmt/bundled"))))
+ (propagated-inputs
+ (modify-inputs (package-propagated-inputs spdlog-1.15)
+ (replace "fmt" fmt-9)))))
(define-public spdlog-1.10
(package
@@ -293,9 +301,15 @@ (define-public spdlog-1.10
(commit (string-append "v" version))))
(file-name (git-file-name "spdlog" version))
(sha256
- (base32 "02xz017ba9fssm1rp1fcfld7h79awbr6fqai9dxaqp02akp3davk"))))))
+ (base32 "02xz017ba9fssm1rp1fcfld7h79awbr6fqai9dxaqp02akp3davk"))
+ (modules '((guix build utils)))
+ (snippet #~(delete-file-recursively "include/spdlog/fmt/bundled"))))
+ (propagated-inputs
+ (modify-inputs (package-propagated-inputs spdlog-1.15)
+ (replace "fmt" fmt-8)))))
-(define-public spdlog spdlog-1.15)
+;; Update when changing the pinned version of fmt.
+(define-public spdlog spdlog-1.13)
(define-public rsyslog
(package
diff --git a/gnu/packages/pretty-print.scm b/gnu/packages/pretty-print.scm
index fb676539b2..cd42582dc9 100644
--- a/gnu/packages/pretty-print.scm
+++ b/gnu/packages/pretty-print.scm
@@ -299,7 +299,7 @@ (define-public fmt-6
("clang" ,clang-6)))))
;; Note: Updating fmt causes some 1000s of rebuilds, so let's have a pinned
-;; version.
+;; version. When changing also update the pinned version of spdlog.
(define-public fmt fmt-9)
(define-public source-highlight
diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
index fee7e02d6e..18f1a19ff9 100644
--- a/gnu/packages/xdisorg.scm
+++ b/gnu/packages/xdisorg.scm
@@ -3538,7 +3538,7 @@ (define-public j4-dmenu-desktop
(build-system meson-build-system)
(native-inputs
(list catch2-3 pkg-config))
- (inputs (list spdlog fmt-11))
+ (inputs (list spdlog-1.15))
(arguments
(list
#:configure-flags
--
2.49.0
sharlatanus@HIDDEN, bug-guix@HIDDEN:bug#77964; Package guix.
Full text available.
Received: (at 77964) by debbugs.gnu.org; 23 Apr 2025 14:43:34 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 23 10:43:33 2025
Received: from localhost ([127.0.0.1]:58240 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1u7bK0-000457-3G
for submit <at> debbugs.gnu.org; Wed, 23 Apr 2025 10:43:33 -0400
Received: from mail-qk1-x72b.google.com ([2607:f8b0:4864:20::72b]:59636)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <code@HIDDEN>)
id 1u7bJm-00042Z-CA
for 77964 <at> debbugs.gnu.org; Wed, 23 Apr 2025 10:43:22 -0400
Received: by mail-qk1-x72b.google.com with SMTP id
af79cd13be357-7c08f9d0ef3so338071285a.2
for <77964 <at> debbugs.gnu.org>; Wed, 23 Apr 2025 07:43:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=greghogan-com.20230601.gappssmtp.com; s=20230601; t=1745419392; x=1746024192;
darn=debbugs.gnu.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=5vz6gFU9DkEOP4Tv2cZoIShooo5xhnzf02NrABm9WPs=;
b=DoZ1K+CMUJjrnTngOS3vGbG8cOCQEFmROJPpuDi2A9fYyHEjKewbJcWRzZj4WyrcN1
LEXcv2XS/96nPHIhSc/zDQDxxfZQiA8LgekgXc5x9hljOg4B9UKaBe2BRJvdYDRWqvxe
PZCB7wb0avnefDNqHWlrr02nmrKMifA/CBEQZMYN+na8dbUAmNJ2hMbPr2XEbp67kLfD
yB/NzP3d59i+D1CViXqkJOEkQhQvuYAHDive/ZYTmhOp4xZoR1sy821Z4RG3GFBEQadf
CzVh5uF9Y4BSyZ6neOFt1vjLdEpTk67y6Vi/lKfKS92lRidme5md1zPCnNJJyzCrUw80
XsvA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1745419392; x=1746024192;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=5vz6gFU9DkEOP4Tv2cZoIShooo5xhnzf02NrABm9WPs=;
b=Ro019UZfwfuq7VEO6jD5+aDNUYmzw9s3lYGmjSehFnl1+X2Tcx8dkvozI1VZPHuXP0
T9rmtEqFLf5SB+NpvXbVBbLtKI/6cgH6bvz3D005NlJE/YaGBvEwsIEH36WyJbJqBI0S
gjh906nG+Ks+Ba9QHzgFCyye1QQsjq0lGRTVUFBbZKBfxscLDYn60gKRNxuZlHt/Y9FD
U0HvB4BPdLo39pK/cAiB1dpdtlUI+KmfJy0IJrKSgT+cmKaXe6uU/lkZ2UgCKm9Jq/Pa
RpsYAcba337Wx1dSVZiYx1b/VEHPHF2NKtIlyU2PYaJUu3yqBRfOJprXQuQh/fzYtImS
aBTA==
X-Gm-Message-State: AOJu0YxOQvPMxdGm+mInvZ3+ePlO30GFA9NtvZbi/m64R2PVDez0M7D0
RZLOOvDiJEvbwqGBQXMJliMwn9zoTr4+xxFZU+up3wSlRYqyuLKRkjOC0UjLOd+mU4AZ6/hIdr3
3
X-Gm-Gg: ASbGncvlot8ztK+FyncXtnAkTpg7vYt3MBoC5BQ4PrE0ZyvmXvxuuTK0ZSmyfjZB9FV
OMwcTpJLt6mCPKrru2uPAGoX4F6oanCL5bR28xsxqkzqzDrcbYM+VPNiQ3G0cNm6AwZ23p+K6YB
qhjTRbjYz3Bud4lf5dbzEmi98Bt6V3p/QD7IiEGxdwxiWGJXuUU7i+uScQMnpmOGIEIMh5DGigY
B8Yex9ZBkdqp2/O5ijA8AIiy6vF3GW4OvOcFe7HyU5QDP8nfcAOyv4+dIQ4hxk5MDPV77yRShAi
ylBtnSWWc3FSHFbbJ7sIhc/fKmDxgXsf17dVcrLiShYeF28RHH4KrBBJ9ACuvm9YVSPoKgAVAyW
SVrEj91BtWi0O4Ql+mVdhrGUc+WkJypxHHTztXlOk
X-Google-Smtp-Source: AGHT+IHQjexiuFwHAXz7BNbVXw+tkGR6f7toxl0+03QMxPsoDsf/HP2q+sqnh69tTnZ7us/RmpnKBQ==
X-Received: by 2002:a05:620a:4587:b0:7c5:464b:6718 with SMTP id
af79cd13be357-7c928049899mr4047764785a.54.1745419392244;
Wed, 23 Apr 2025 07:43:12 -0700 (PDT)
Received: from ip-10-117-149-49.evoforge.org
(ec2-52-70-167-183.compute-1.amazonaws.com. [52.70.167.183])
by smtp.gmail.com with ESMTPSA id
af79cd13be357-7c925a6eb31sm692026285a.3.2025.04.23.07.43.11
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 23 Apr 2025 07:43:11 -0700 (PDT)
From: Greg Hogan <code@HIDDEN>
To: 77964 <at> debbugs.gnu.org
Subject: [PATCH sysadmin-team 1/2] gnu: spdlog: Pin version
Date: Wed, 23 Apr 2025 14:39:56 +0000
Message-ID: <d458432419ff7d47da1dac2e1591de13feebca2f.1745417760.git.code@HIDDEN>
X-Mailer: git-send-email 2.49.0
In-Reply-To: <cover.1745417760.git.code@HIDDEN>
References: <cover.1745417760.git.code@HIDDEN>
MIME-Version: 1.0
X-Debbugs-Cc: Sharlatan Hellseher <sharlatanus@HIDDEN>
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 77964
Cc: Greg Hogan <code@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
* gnu/packages/logging.scm (spdlog): Rename to ...
(spdlog-1.15): ... this.
(spdlog-1.13, spdlog-1.10): Inherit from spdlog-1.15.
(spdlog): Pin to spdlog-1.15.
Change-Id: I7b907cf2bbfa079bec28d4264a1dfc7f58037cd6
---
gnu/packages/logging.scm | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/gnu/packages/logging.scm b/gnu/packages/logging.scm
index b5431566fe..a764fee5be 100644
--- a/gnu/packages/logging.scm
+++ b/gnu/packages/logging.scm
@@ -236,7 +236,7 @@ (define-public multitail
output in multiple windows in a terminal.")
(license license:gpl2+)))
-(define-public spdlog
+(define-public spdlog-1.15
(package
(name "spdlog")
(version "1.15.1")
@@ -269,7 +269,7 @@ (define-public spdlog
(license (list license:expat license:bsd-2))))
(define-public spdlog-1.13
- (package/inherit spdlog
+ (package/inherit spdlog-1.15
(version "1.13.0")
(source
(origin
@@ -277,13 +277,13 @@ (define-public spdlog-1.13
(uri (git-reference
(url "https://github.com/gabime/spdlog")
(commit (string-append "v" version))))
- (file-name (git-file-name (package-name spdlog) version))
+ (file-name (git-file-name (package-name spdlog-1.15) version))
(sha256
(base32 "0zgdmdgnp2y36jrlk85d4fiyjkjd6anly8pambyc3f3v6sg02zyy"))))))
(define-public spdlog-1.10
(package
- (inherit spdlog)
+ (inherit spdlog-1.15)
(version "1.10.0")
(source
(origin
@@ -295,6 +295,8 @@ (define-public spdlog-1.10
(sha256
(base32 "02xz017ba9fssm1rp1fcfld7h79awbr6fqai9dxaqp02akp3davk"))))))
+(define-public spdlog spdlog-1.15)
+
(define-public rsyslog
(package
(name "rsyslog")
--
2.49.0
sharlatanus@HIDDEN, bug-guix@HIDDEN:bug#77964; Package guix.
Full text available.Received: (at 77964) by debbugs.gnu.org; 23 Apr 2025 14:43:26 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 23 10:43:25 2025 Received: from localhost ([127.0.0.1]:58238 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u7bJr-00043s-Mg for submit <at> debbugs.gnu.org; Wed, 23 Apr 2025 10:43:25 -0400 Received: from mail-qk1-x72b.google.com ([2607:f8b0:4864:20::72b]:54506) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from <code@HIDDEN>) id 1u7bJl-00042P-Mm for 77964 <at> debbugs.gnu.org; Wed, 23 Apr 2025 10:43:18 -0400 Received: by mail-qk1-x72b.google.com with SMTP id af79cd13be357-7c5ba363f1aso865180085a.0 for <77964 <at> debbugs.gnu.org>; Wed, 23 Apr 2025 07:43:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=greghogan-com.20230601.gappssmtp.com; s=20230601; t=1745419391; x=1746024191; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=T+0y5i5enMfIGRBYDhP8PzeIZQm5n5DIuy9woIEBrLI=; b=LOZPZRFEsSUtxgPNnKQnrBScKYjxXTXYuqD+ilrAFs3lut+PargAR1dabN4Hpnw/Vv W4Oyh/bCewW5wfOMH0j1tJ6G59yuN6ddtcCItEf51uEsVQmFAErnqJkAzJSf4G+0/hxC Dmj2P+Yx5Okz6kvFcuIB39ODypgWqZ9l/gL4shH0jZJDMJch/1+P68x8+MHF6bbpSzuk EN15oWQbCtl8ngufFWDC49C5oUjINP1VMoekImklIcT+M06QvChJupJ4ocih0kjWAY6f I+2TiT/lUDHvrC2jx3IN42AZ2EzXj84V5NTMV3TEsFgOhClgqF5JT2KJeJ/Tgb+qwCA/ mDPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745419391; x=1746024191; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=T+0y5i5enMfIGRBYDhP8PzeIZQm5n5DIuy9woIEBrLI=; b=tTdKBb+37sbifD6LbD4A2i2XWz949aTYdicyDO3aI7LgGqLcymb2Sws07kWDo1Ci52 dJef54GdnD6JByqig6+VNjDMFRsSw7feXdqOcPW2kINXeMJb3TSBvHctJCicBszv2Js5 Y3OWI3R/cTsgmD27/jlXGTMfWK0kNgP38RZp2RldI2i4JDMQM3Y1R/IOpFjk6PDuWcHU GnKzMlDiSL/QE4NZP3TSQth4pR8WEaAqxoxn2vE9cIYwrhRngnNXa6SbzQp24moYK/zr m5g59ejImspryMysidfHjY1HNP57OfjoelctHJyYNclZjmJOkj49wdywIGo58nQVU/Bk 268w== X-Gm-Message-State: AOJu0YzcGgTa1ScnvhedmjZZ6Qq+MYBICoUu7+ico2gahinWB176fEnp vUuPPW5a2mfJ7R7vvD4c22CCa47ZLfJgHros/XhEH9ju4d3F5uBEWj8GRT5qOy5YNP3ZLsEtrNm r X-Gm-Gg: ASbGncvw+svkIV+yex4nEXxuuLNU0+Ge4kpkcpXqPzx5DP6xtcufLMvQdNYfb374hn3 KER33V5RMR/oVnX+nQOP/TyH0VFReOCCJSXE1sIuSKPqYf4vIXJHvPnzZITAWlpWTlEJ30+vcCS Mk3z8cijb8gUz2IyCRZf2Sufd6ljWW/SDm8C2bwikCM+7iJnfn77wS/OSzCxGaPh8Zy7GirKPBl Gf7V0qlrQdn8n8IHEM6LMUwp4EE/uPK4OiMdjwNuccc2HE1y/meMa4zN3IZ0BC7yCGWnBkKzQfP YJgkCRbfXs3Tvqkv35vgEIcdChaTlNyCUr+oHrYL+L+4wCvjckDnxfZ2yp0s1jfFsQnPQ0xi5E7 3FIvlsjsmu1juHbz0nt7CYfIClPEictrqnBiylCE8 X-Google-Smtp-Source: AGHT+IE+HTaz+fkcT7NR3lRQhbPtoKL5y6kKvr7nIVXHtppfN/oMddT0gvSICSVU07wbMGbjLbbUbQ== X-Received: by 2002:a05:620a:4156:b0:7c5:562d:ccfa with SMTP id af79cd13be357-7c9280167a6mr3687481585a.36.1745419391448; Wed, 23 Apr 2025 07:43:11 -0700 (PDT) Received: from ip-10-117-149-49.evoforge.org (ec2-52-70-167-183.compute-1.amazonaws.com. [52.70.167.183]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c925a6eb31sm692026285a.3.2025.04.23.07.43.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 07:43:11 -0700 (PDT) From: Greg Hogan <code@HIDDEN> To: 77964 <at> debbugs.gnu.org Subject: [PATCH sysadmin-team 0/2] spdlog unbundle fmt. Date: Wed, 23 Apr 2025 14:39:55 +0000 Message-ID: <cover.1745417760.git.code@HIDDEN> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-Debbugs-Cc: Sharlatan Hellseher <sharlatanus@HIDDEN> Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77964 Cc: Greg Hogan <code@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) As reported by Dariqq, the "spdlog" and "fmt" packages should play well together. This patchset adds a pinned version of spdlog to track the pinned version of fmt. We also unbundle spdlog's fmt dependency. Greg Hogan (2): gnu: spdlog: Pin version gnu: spdlog: Unbundle dependency. gnu/packages/logging.scm | 36 +++++++++++++++++++++++++---------- gnu/packages/pretty-print.scm | 2 +- gnu/packages/xdisorg.scm | 2 +- 3 files changed, 28 insertions(+), 12 deletions(-) base-commit: 699ce22ed812cf8cfcdd8d0341829f8fac2c864a -- 2.49.0
sharlatanus@HIDDEN, bug-guix@HIDDEN:bug#77964; Package guix.
Full text available.Received: (at submit) by debbugs.gnu.org; 21 Apr 2025 15:59:03 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 21 11:59:03 2025 Received: from localhost ([127.0.0.1]:37063 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1u6tXz-0003Cr-FN for submit <at> debbugs.gnu.org; Mon, 21 Apr 2025 11:59:03 -0400 Received: from lists.gnu.org ([2001:470:142::17]:41962) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <dariqq@HIDDEN>) id 1u6tXu-0003BP-UT for submit <at> debbugs.gnu.org; Mon, 21 Apr 2025 11:59:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <dariqq@HIDDEN>) id 1u6tXl-0002Dz-Cs for bug-guix@HIDDEN; Mon, 21 Apr 2025 11:58:49 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <dariqq@HIDDEN>) id 1u6tXj-0007S4-By for bug-guix@HIDDEN; Mon, 21 Apr 2025 11:58:49 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 505BD240101 for <bug-guix@HIDDEN>; Mon, 21 Apr 2025 17:58:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1745251122; bh=wazMkIV48iE9dUoQxMHMkvZ1+m2aYuUUJ/qdEhlAUFw=; h=Message-ID:Date:MIME-Version:To:From:Subject:Content-Type: Content-Transfer-Encoding:From; b=LWGuCNHCsbwYuaT9XBcKyzivkxrEM3VUrh2RozTkApd22IUIIal3vocdcUHVWkeyM 47+d523vkTjIqNz4Kv5dQE1N0q2HQwIFRgBS44CAo7GkErb629LF6DQzI0yKoCP1uW zFczTPKFnc3R+tWFgairCXLSlWLKBY+MkperSfR6OHNLLSUQntARdCmz0mcqTDVbTb cND5RXUssBE0sf/elKFXyYH9rgug03x2JzRf/Yew3egGSNgt/djhPpAXAo3nreZBgX PyE5hwLeyqaSYw/F2QXD0Xs26rtLwNPMksaOkwV1QZl6rXPqaky4L3yK56UYKuARCH W+j93S4n4osaQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Zh95Y4PvKz9rxD for <bug-guix@HIDDEN>; Mon, 21 Apr 2025 17:58:40 +0200 (CEST) Message-ID: <62a79e30-6c5e-4f58-91d3-7032b23b1841@HIDDEN> Date: Mon, 21 Apr 2025 15:58:28 +0000 MIME-Version: 1.0 Content-Language: en-US To: bug-guix@HIDDEN From: Dariqq <dariqq@HIDDEN> Subject: spdlog is bundling fmt Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=185.67.36.66; envelope-from=dariqq@HIDDEN; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) Hello, Today I tried to rebuild a package in my channel which uses both fmt and spdlog. The build failed with a linking error with undefined references for some spdlog code. Recently the spdlog symbol got updated to 1.15, when I downgrade to using spdlog 1.13 the error went away. After looking around online for similar issues I found that the reason could be a version mismatch with the fmt package and the fmt bundled with spdlog. If I use fmt-11 instead of fmt-9 (the fmt symbol) the issue went away. I think Guix generally tries to unbundle things if possible and looking at some build recipes in other distributions (debian, gentoo, fedora) all of them add the -DSPDLOG_FMT_EXTERNAL=ON flag (usually with an additional patch to force the unbundled fmt) Thanks.
Dariqq <dariqq@HIDDEN>:bug-guix@HIDDEN.
Full text available.bug-guix@HIDDEN:bug#77964; Package guix.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.