GNU logs - #77967, boring messages

Message sent to larsi@HIDDEN, bug-gnu-emacs@HIDDEN:

Subject: bug#77967: [PATCH] Fallback `eww-switch-to-buffer' to `eww'
Resent-From: Manuel Giraud <manuel@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: larsi@HIDDEN, bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 21 Apr 2025 17:45:03 +0000
Resent-Message-ID: <handler.77967.B.174525745512299 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 77967 <at> debbugs.gnu.org
Cc: Lars Magne Ingebrigtsen <larsi@HIDDEN>
From: Manuel Giraud <manuel@HIDDEN>
Date: Mon, 21 Apr 2025 19:43:47 +0200
Message-ID: <87jz7d1kbw.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Received-SPF: pass client-ip=51.159.28.247; envelope-from=manuel@HIDDEN;
 helo=ledu-giraud.fr
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,
 SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.9 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)

--=-=-=
Content-Type: text/plain

Tags: patch

Hi,

The following patch calls `eww' interactively from
`eww-switch-to-buffer' when there is no EWW buffers.  Then, one can set
a global shortcut on `eww-switch-to-buffer' and always be able to launch
EWW.

Thanks,


In GNU Emacs 31.0.50 (build 5, x86_64-unknown-openbsd7.7, X toolkit) of
 2025-04-20 built on computer
Repository revision: b38fd553eb3291f140801ca158f6ab245496fa69
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101016
System Description: OpenBSD computer 7.7 GENERIC.MP#625 amd64

Configured using:
 'configure CC=egcc CPPFLAGS=-I/usr/local/include
 LDFLAGS=-L/usr/local/lib MAKEINFO=gmakeinfo --prefix=/home/manuel/emacs
 --bindir=/home/manuel/bin --with-x-toolkit=lucid
 --with-toolkit-scroll-bars=no --without-cairo
 --without-compress-install'


--=-=-=
Content-Type: text/patch
Content-Disposition: attachment;
 filename=0001-Fallback-eww-switch-to-buffer-to-eww.patch

From d63d4cacdd6bf9b9cbfff43cb07d3268f969bd25 Mon Sep 17 00:00:00 2001
From: Manuel Giraud <manuel@HIDDEN>
Date: Mon, 21 Apr 2025 19:01:25 +0200
Subject: [PATCH] Fallback `eww-switch-to-buffer' to `eww'

* lisp/net/eww.el (eww-switch-to-buffer): When no EWW buffers
exist, call `eww' instead.
---
 lisp/net/eww.el | 28 ++++++++++++++++------------
 1 file changed, 16 insertions(+), 12 deletions(-)

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 7edd1acbcf9..63425882583 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -2321,25 +2321,29 @@ eww-set-character-encoding
     (eww-reload nil charset)))
 
 (defun eww-switch-to-buffer ()
-  "Prompt for an EWW buffer to display in the selected window."
+  "Prompt for an EWW buffer to display in the selected window.  If no such
+buffer exist, fallback to calling `eww'."
   (interactive nil eww-mode)
   (let ((completion-extra-properties
          `(:annotation-function
            ,(lambda (buf)
               (with-current-buffer buf
                 (format " %s" (eww-current-url))))))
-        (curbuf (current-buffer)))
-    (pop-to-buffer-same-window
-     (read-buffer "Switch to EWW buffer: "
-                  (cl-loop for buf in (nreverse (buffer-list))
+        (curbuf (current-buffer))
+        (list (cl-loop for buf in (nreverse (buffer-list))
                            if (with-current-buffer buf (derived-mode-p 'eww-mode))
-                           return buf)
-                  t
-                  (lambda (bufn)
-                    (setq bufn (if (consp bufn) (cdr bufn) (get-buffer bufn)))
-                    (and (with-current-buffer bufn
-                           (derived-mode-p 'eww-mode))
-                         (not (eq bufn curbuf))))))))
+                           return buf)))
+    (if list
+        (pop-to-buffer-same-window
+         (read-buffer "Switch to EWW buffer: "
+                      list
+                      t
+                      (lambda (bufn)
+                        (setq bufn (if (consp bufn) (cdr bufn) (get-buffer bufn)))
+                        (and (with-current-buffer bufn
+                               (derived-mode-p 'eww-mode))
+                             (not (eq bufn curbuf))))))
+      (call-interactively 'eww))))
 
 (defun eww-toggle-fonts ()
   "Toggle whether to use monospaced or font-enabled layouts."
-- 
2.49.0


--=-=-=
Content-Type: text/plain


-- 
Manuel Giraud

--=-=-=--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Manuel Giraud <manuel@HIDDEN>
Subject: bug#77967: Acknowledgement ([PATCH] Fallback `eww-switch-to-buffer'
 to `eww')
Message-ID: <handler.77967.B.174525745512299.ack <at> debbugs.gnu.org>
References: <87jz7d1kbw.fsf@HIDDEN>
X-Gnu-PR-Message: ack 77967
X-Gnu-PR-Package: emacs
X-Gnu-PR-Keywords: patch
Reply-To: 77967 <at> debbugs.gnu.org
Date: Mon, 21 Apr 2025 17:45:05 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

As you requested using X-Debbugs-CC, your message was also forwarded to
  Lars Magne Ingebrigtsen <larsi@HIDDEN>
(after having been given a bug report number, if it did not have one).

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 77967 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
77967: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D77967
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#77967: [PATCH] Fallback `eww-switch-to-buffer' to `eww'
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 26 Apr 2025 13:03:01 +0000
Resent-Message-ID: <handler.77967.B77967.174567254217655 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Manuel Giraud <manuel@HIDDEN>
Cc: 77967 <at> debbugs.gnu.org, larsi@HIDDEN
Date: Sat, 26 Apr 2025 16:02:08 +0300
Message-Id: <86r01ft6sv.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <87jz7d1kbw.fsf@HIDDEN> (message from Manuel Giraud on
 Mon, 21 Apr 2025 19:43:47 +0200)
References: <87jz7d1kbw.fsf@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> Cc: Lars Magne Ingebrigtsen <larsi@HIDDEN>
> From: Manuel Giraud <manuel@HIDDEN>
> Date: Mon, 21 Apr 2025 19:43:47 +0200
> 
> The following patch calls `eww' interactively from
> `eww-switch-to-buffer' when there is no EWW buffers.  Then, one can set
> a global shortcut on `eww-switch-to-buffer' and always be able to launch
> EWW.

Thanks.

>  (defun eww-switch-to-buffer ()
> -  "Prompt for an EWW buffer to display in the selected window."
> +  "Prompt for an EWW buffer to display in the selected window.  If no such
> +buffer exist, fallback to calling `eww'."

The first line of a doc string should be a single complete sentence.

Doesn't this change warrant a NEWS entry, and a suitable change to the
EWW manual?

Last modified: Sat, 26 Apr 2025 13:15:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.