GNU logs - #78011, boring messages

Message sent to csantosb@HIDDEN, ekaitz@HIDDEN, maxim.cournoyer@HIDDEN, guix-patches@HIDDEN:

Subject: [bug#78011] [PATCH electronics-team] gnu: Add opensta.
Resent-From: Cayetano Santos <csantosb@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: csantosb@HIDDEN, ekaitz@HIDDEN, maxim.cournoyer@HIDDEN, guix-patches@HIDDEN
Resent-Date: Wed, 23 Apr 2025 13:19:02 +0000
Resent-Message-ID: <handler.78011.B.174541428913986 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 78011 <at> debbugs.gnu.org
Cc: Cayetano Santos <csantosb@HIDDEN>, Cayetano Santos <csantosb@HIDDEN>, Ekaitz Zarraga <ekaitz@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>
From: Cayetano Santos <csantosb@HIDDEN>
Date: Wed, 23 Apr 2025 15:14:20 +0200
Message-ID: <683e72f593c47e23a4d0afbab49940bbbea65da7.1745414060.git.csantosb@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=2c0f:f930:0:4::108;
 envelope-from=csantosb@HIDDEN; helo=devianza.investici.org
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.9 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.1 (/)

* gnu/packages/electronics.scm (opensta): New variable.

Change-Id: If753078958535971c8ab3fd7c934d19d24f0a2f7
---
 gnu/packages/electronics.scm | 41 ++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/gnu/packages/electronics.scm b/gnu/packages/electronics.scm
index 12e44f234a..1b733a5a1f 100644
--- a/gnu/packages/electronics.scm
+++ b/gnu/packages/electronics.scm
@@ -38,6 +38,7 @@ (define-module (gnu packages electronics)
   #:use-module (gnu packages algebra)
   #:use-module (gnu packages autotools)
   #:use-module (gnu packages base)
+  #:use-module (gnu packages bison)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages c)
   #:use-module (gnu packages check)
@@ -45,6 +46,7 @@ (define-module (gnu packages electronics)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages documentation)
   #:use-module (gnu packages embedded)
+  #:use-module (gnu packages flex)
   #:use-module (gnu packages fontutils)
   #:use-module (gnu packages gl)
   #:use-module (gnu packages glib)
@@ -53,6 +55,7 @@ (define-module (gnu packages electronics)
   #:use-module (gnu packages libftdi)
   #:use-module (gnu packages libusb)
   #:use-module (gnu packages linux)
+  #:use-module (gnu packages maths)
   #:use-module (gnu packages m4)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages python)
@@ -65,6 +68,7 @@ (define-module (gnu packages electronics)
   #:use-module (gnu packages sqlite)
   #:use-module (gnu packages stb)
   #:use-module (gnu packages swig)
+  #:use-module (gnu packages tcl)
   #:use-module (gnu packages tls)
   #:use-module (gnu packages toolkits)
   #:use-module (gnu packages version-control))
@@ -415,6 +419,43 @@ (define-public openboardview
 @end itemize")
     (license license:expat)))

+(define-public opensta
+  (let ((commit "400c473fe384773a4788ee8378238462b4291fe3")
+        (revision "0"))
+    (package
+      (name "opensta")
+      (version (git-version "2.6.2" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/parallaxsw/OpenSTA/")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "091np9jnhfzggc7f5q9kx7kfa1fxjrj7d1mnw6q4gniqbs5hwrg5"))))
+      (build-system cmake-build-system)
+      (arguments
+       (list
+        #:tests? #f ; no tests
+        #:out-of-source? #t
+        #:configure-flags
+        #~(list
+           (string-append "-DCUDD_DIR=" #$cudd)
+           (string-append "-DCMAKE_INSTALL_PREFIX=" #$output))
+        #:make-flags
+        #~(list (string-append "CC=" #$(cc-for-target))
+                (string-append "CXX=" #$(cxx-for-target))
+                (string-append "PREFIX=" #$output))))
+      (native-inputs (list swig bison flex))
+      (inputs (list tcl tcllib zlib cudd eigen))
+      (synopsis "Parallax Static Timing Analyzer")
+      (description
+       "OpenSTA is a gate level static timing verifier.  As a stand-alone executable
+it can be used to verify the timing of a design using standard file formats.")
+      (home-page "https://github.com/parallaxsw/OpenSTA/")
+      (license license:gpl3+))))
+
 (define-public pulseview
   (package
     (name "pulseview")

base-commit: 699ce22ed812cf8cfcdd8d0341829f8fac2c864a
-- 
2.49.0

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Cayetano Santos <csantosb@HIDDEN>
Subject: bug#78011: Acknowledgement ([PATCH electronics-team] gnu: Add
 opensta.)
Message-ID: <handler.78011.B.174541428913986.ack <at> debbugs.gnu.org>
References: <683e72f593c47e23a4d0afbab49940bbbea65da7.1745414060.git.csantosb@HIDDEN>
X-Gnu-PR-Message: ack 78011
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 78011 <at> debbugs.gnu.org
Date: Wed, 23 Apr 2025 13:19:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

As you requested using X-Debbugs-CC, your message was also forwarded to
  Cayetano Santos <csantosb@HIDDEN>, Ekaitz Zarraga <ekaitz@HIDDEN=
ch>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>
(after having been given a bug report number, if it did not have one).

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 78011 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
78011: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D78011
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to guix-patches@HIDDEN:

Subject: [bug#78011] [PATCH electronics-team] gnu: Add opensta.
Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 25 Apr 2025 03:00:03 +0000
Resent-Message-ID: <handler.78011.B78011.174554995016843 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Cayetano Santos <csantosb@HIDDEN>
Cc: 78011 <at> debbugs.gnu.org, Ekaitz Zarraga <ekaitz@HIDDEN>
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
In-Reply-To: <683e72f593c47e23a4d0afbab49940bbbea65da7.1745414060.git.csantosb@HIDDEN>
 (Cayetano Santos's message of "Wed, 23 Apr 2025 15:14:20 +0200")
References: <683e72f593c47e23a4d0afbab49940bbbea65da7.1745414060.git.csantosb@HIDDEN>
Date: Fri, 25 Apr 2025 11:58:51 +0900
Message-ID: <87frhxrlp0.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hi!

Cayetano Santos <csantosb@HIDDEN> writes:

> * gnu/packages/electronics.scm (opensta): New variable.
>
> Change-Id: If753078958535971c8ab3fd7c934d19d24f0a2f7
> ---

[...]

> +(define-public opensta

It's good to include a comment about why a precise commit is used,
e.g. "Use the latest commit as they included unreleased fixes."
> +  (let ((commit "400c473fe384773a4788ee8378238462b4291fe3")
> +        (revision "0"))
> +    (package
> +      (name "opensta")
> +      (version (git-version "2.6.2" revision commit))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/parallaxsw/OpenSTA/")
> +               (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32 "091np9jnhfzggc7f5q9kx7kfa1fxjrj7d1mnw6q4gniqbs5hwrg5"))))
> +      (build-system cmake-build-system)
> +      (arguments
> +       (list
> +        #:tests? #f ; no tests

There are tests; their Jenkinsfile runs them via the 'test/regression'
script.  You'll need to override the check phase as it's not registered
as a CMake test target.

> +        #:out-of-source? #t

No need to explicit this; it's the default for cmake-build-system.

> +        #:configure-flags
> +        #~(list
> +           (string-append "-DCUDD_DIR=" #$cudd)

It'd be better if this referred to the same cudd package that is
provided as an input (otherwise it cannot be rewritten via package
transformations).  You can refer to it within this gexp with

#$(this-package-input "cudd")

> +           (string-append "-DCMAKE_INSTALL_PREFIX=" #$output))

No need for this, as it's also the default.

> +        #:make-flags
> +        #~(list (string-append "CC=" #$(cc-for-target))
> +                (string-append "CXX=" #$(cxx-for-target))
> +                (string-append "PREFIX=" #$output))))

I doubt these are needed; our cmake build system should know how to
cross-compile without this being manually set.

> +      (native-inputs (list swig bison flex))
> +      (inputs (list tcl tcllib zlib cudd eigen))
> +      (synopsis "Parallax Static Timing Analyzer")
> +      (description
> +       "OpenSTA is a gate level static timing verifier.  As a stand-alone executable

Please fold your paragraphs so they stay within < 80 columns, our coding
style guideline (M-q in Emacs).

> +it can be used to verify the timing of a design using standard file formats.")
> +      (home-page "https://github.com/parallaxsw/OpenSTA/")
> +      (license license:gpl3+))))

Otherwise it LGTM.  Could you please send a v2 with the above comments
taken into account?

-- 
Thanks,
Maxim

Message sent to guix-patches@HIDDEN:

Subject: [bug#78011] [PATCH electronics-team] gnu: Add opensta.
Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 25 Apr 2025 03:32:01 +0000
Resent-Message-ID: <handler.78011.B78011.17455518768660 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Cayetano Santos <csantosb@HIDDEN>
Cc: 78011 <at> debbugs.gnu.org, Ekaitz Zarraga <ekaitz@HIDDEN>
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
In-Reply-To: <87frhxrlp0.fsf@HIDDEN> (Maxim Cournoyer's message of "Fri, 25
 Apr 2025 11:58:51 +0900")
References: <683e72f593c47e23a4d0afbab49940bbbea65da7.1745414060.git.csantosb@HIDDEN>
 <87frhxrlp0.fsf@HIDDEN>
Date: Fri, 25 Apr 2025 12:30:58 +0900
Message-ID: <878qnosyrx.fsf_-_@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hi,

Something like this:

--8<---------------cut here---------------start------------->8---
1 file changed, 11 insertions(+), 10 deletions(-)
gnu/packages/electronics.scm | 21 +++++++++++----------

modified   gnu/packages/electronics.scm
@@ -423,10 +423,12 @@ (define-public openboardview
     (license license:expat)))

 (define-public opensta
+  ;; There are no releases; use the latest commit.
   (let ((commit "400c473fe384773a4788ee8378238462b4291fe3")
         (revision "0"))
     (package
       (name "opensta")
+      ;; The version string is taken from the CMakeLists.txt.
       (version (git-version "2.6.2" revision commit))
       (source
        (origin
@@ -440,18 +442,17 @@ (define-public opensta
       (build-system cmake-build-system)
       (arguments
        (list
-        #:tests? #f ; no tests
-        #:out-of-source? #t
         #:configure-flags
         #~(list
-           (string-append "-DCUDD_DIR=" #$cudd)
-           (string-append "-DCMAKE_INSTALL_PREFIX=" #$output))
-        #:make-flags
-        #~(list (string-append "CC=" #$(cc-for-target))
-                (string-append "CXX=" #$(cxx-for-target))
-                (string-append "PREFIX=" #$output))))
-      (native-inputs (list swig bison flex))
-      (inputs (list tcl tcllib zlib cudd eigen))
+           (string-append "-DCUDD_DIR=" #$(this-package-input "cudd"))
+           (string-append "-DBUILD_SHARED_LIBS=YES"))
+        #:phases #~(modify-phases %standard-phases
+                     (replace 'check
+                       (lambda* (#:key tests? #:allow-other-keys)
+                         (when tests?
+                           (invoke "../source/test/regression")))))))
+      (native-inputs (list bison flex swig))
+      (inputs (list cudd eigen tcl tcllib zlib))
       (synopsis "Parallax Static Timing Analyzer")
       (description
        "OpenSTA is a gate level static timing verifier.  As a stand-alone executable
--8<---------------cut here---------------end--------------->8---

I note that the package doesn't cross-build currently due to a problem
finding flex, but that's not the above definition's fault.

The BUILD_SHARED_LIBS=YES builds a .so library which cuts the space used
by half about.

The inputs are sorted lexicographically and some comments are added,
with the extraneous flags/arguments pruned.

Hope that helps,

-- 
Thanks,
Maxim

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#78011] [PATCH electronics-team] gnu: Add opensta.
Resent-From: Cayetano Santos <csantosb@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 25 Apr 2025 12:48:02 +0000
Resent-Message-ID: <handler.78011.B78011.17455852514211 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 78011
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Cc: 78011 <at> debbugs.gnu.org, Ekaitz Zarraga <ekaitz@HIDDEN>
Received: via spool by 78011-submit <at> debbugs.gnu.org id=B78011.17455852514211
          (code B ref 78011); Fri, 25 Apr 2025 12:48:02 +0000
Received: (at 78011) by debbugs.gnu.org; 25 Apr 2025 12:47:31 +0000
Received: from localhost ([127.0.0.1]:48664 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1u8ISo-00015q-IL
	for submit <at> debbugs.gnu.org; Fri, 25 Apr 2025 08:47:30 -0400
Received: from latitanza.investici.org ([82.94.249.234]:38273)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <csantosb@HIDDEN>)
 id 1u8ISk-00015f-Ha
 for 78011 <at> debbugs.gnu.org; Fri, 25 Apr 2025 08:47:27 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inventati.org;
 s=stigmate; t=1745585244;
 bh=mllzsHBwZMRw1tbwAN9EBkqiYArGvKLNOxgrK1Ux4vc=;
 h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
 b=IjZ6dI28AdSUsi2AnfN+RjCatzS5ieAfZ60y0bxKeq+brJtn0ah1S9JTyLfsNLgAl
 JJ0QTw1kUoivsWGGMNiXji0/weBexHjS/nBaQ7hNNFNcl/ZMTIDlqSeLH8Ae/UOZOs
 bepu81JtKknQNR6GcuG1EMh6RV26Zsc/Dc6J7eCQ=
Received: from mx3.investici.org (unknown [127.0.0.1])
 by latitanza.investici.org (Postfix) with ESMTP id 4ZkXg01NWHzGp3p;
 Fri, 25 Apr 2025 12:47:24 +0000 (UTC)
Received: from [82.94.249.234] (mx3.investici.org [82.94.249.234])
 (Authenticated sender: cayetano.santos@HIDDEN) by localhost (Postfix)
 with ESMTPSA id 4ZkXfz6b03zGp3n; 
 Fri, 25 Apr 2025 12:47:23 +0000 (UTC)
From: Cayetano Santos <csantosb@HIDDEN>
In-Reply-To: <87frhxrlp0.fsf@HIDDEN> (Maxim Cournoyer's message of "Fri, 25
 Apr 2025 11:58:51 +0900")
References: <683e72f593c47e23a4d0afbab49940bbbea65da7.1745414060.git.csantosb@HIDDEN>
 <87frhxrlp0.fsf@HIDDEN>
User-Agent: mu4e 1.12.9; emacs 29.4
Date: Fri, 25 Apr 2025 14:47:22 +0200
Message-ID: <87selwqug5.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

--=-=-=
Content-Type: text/plain


>ven. 25 avril 2025 at 11:58, Maxim Cournoyer <maxim.cournoyer@HIDDEN> wrote:

Hi Maxim,

> Please fold your paragraphs so they stay within < 80 columns, our coding
> style guideline (M-q in Emacs).

The .editorconfig file in guix states "max_line_length = 85", which the
corresponding emacs package honors. Is this correct ?

C.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iI0EARYKADUWIQTMuBhC+dcFjs1nN3q/XN9N9r9mggUCaAuEWhccY3NhbnRvc2JA
aW52ZW50YXRpLm9yZwAKCRC/XN9N9r9mgjI/AQCSqvZFQaI/Bka1ucScOyaiGsnW
mQF5+bDv5E8Yilo/rgD/VfRIW5gAmJF29VqLEWvjAtMDmWxTUP0RNDrVcp5dtwE=
=vpUK
-----END PGP SIGNATURE-----
--=-=-=--

Message sent to csantosb@HIDDEN, ekaitz@HIDDEN, maxim.cournoyer@HIDDEN, guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#78011] [PATCH v2] gnu: Add opensta.
References: <683e72f593c47e23a4d0afbab49940bbbea65da7.1745414060.git.csantosb@HIDDEN>
In-Reply-To: <683e72f593c47e23a4d0afbab49940bbbea65da7.1745414060.git.csantosb@HIDDEN>
Resent-From: Cayetano Santos <csantosb@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: csantosb@HIDDEN, ekaitz@HIDDEN, maxim.cournoyer@HIDDEN, guix-patches@HIDDEN
Resent-Date: Fri, 25 Apr 2025 13:27:02 +0000
Resent-Message-ID: <handler.78011.B78011.174558756814920 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 78011
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 78011 <at> debbugs.gnu.org
Cc: Cayetano Santos <csantosb@HIDDEN>, Cayetano Santos <csantosb@HIDDEN>, Ekaitz Zarraga <ekaitz@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>
X-Debbugs-Original-Xcc: Cayetano Santos <csantosb@HIDDEN>, Ekaitz Zarraga <ekaitz@HIDDEN>, Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Received: via spool by 78011-submit <at> debbugs.gnu.org id=B78011.174558756814920
          (code B ref 78011); Fri, 25 Apr 2025 13:27:02 +0000
Received: (at 78011) by debbugs.gnu.org; 25 Apr 2025 13:26:08 +0000
Received: from localhost ([127.0.0.1]:48877 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1u8J4C-0003sZ-9r
	for submit <at> debbugs.gnu.org; Fri, 25 Apr 2025 09:26:08 -0400
Received: from devianza.investici.org ([198.167.222.108]:43337)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <csantosb@HIDDEN>)
 id 1u8J47-0003sH-BP
 for 78011 <at> debbugs.gnu.org; Fri, 25 Apr 2025 09:26:05 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inventati.org;
 s=stigmate; t=1745587561;
 bh=E13LoT1HrwjruAPjd9AxYUcr1qFikPeQefuGQtnaNCc=;
 h=From:To:Cc:Subject:Date:From;
 b=ctbFsUxU7gLHCdzm/bCowhWk07xdmiky5eSRhx875tYf+USlS0EMo8m9EAAIngM7E
 dc5cclWEg9KyKb45g8Gsu0Fn6TsuJFbtT7DSjZpkgPBdskyRlhvSNSH4788/5wRBuS
 a1+FtsLKYJq2vDnHauxWaMH9r/8hdHW4r92bS0Uk=
Received: from mx2.investici.org (unknown [127.0.0.1])
 by devianza.investici.org (Postfix) with ESMTP id 4ZkYWY5NQzz6vNZ;
 Fri, 25 Apr 2025 13:26:01 +0000 (UTC)
Received: from [198.167.222.108] (mx2.investici.org [198.167.222.108])
 (Authenticated sender: cayetano.santos@HIDDEN) by localhost (Postfix)
 with ESMTPSA id 4ZkYWY1fJ7z6vLc; 
 Fri, 25 Apr 2025 13:26:01 +0000 (UTC)
From: Cayetano Santos <csantosb@HIDDEN>
Date: Fri, 25 Apr 2025 15:24:30 +0200
Message-ID: <2bf33bae3435d88a889a40e212102e9604af51ed.1745587470.git.csantosb@HIDDEN>
X-Mailer: git-send-email 2.49.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

* gnu/packages/electronics.scm (opensta): New variable.

Change-Id: If753078958535971c8ab3fd7c934d19d24f0a2f7

---
 gnu/packages/electronics.scm | 41 ++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/gnu/packages/electronics.scm b/gnu/packages/electronics.scm
index 12e44f234a..63782661ee 100644
--- a/gnu/packages/electronics.scm
+++ b/gnu/packages/electronics.scm
@@ -38,6 +38,7 @@ (define-module (gnu packages electronics)
   #:use-module (gnu packages algebra)
   #:use-module (gnu packages autotools)
   #:use-module (gnu packages base)
+  #:use-module (gnu packages bison)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages c)
   #:use-module (gnu packages check)
@@ -45,6 +46,7 @@ (define-module (gnu packages electronics)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages documentation)
   #:use-module (gnu packages embedded)
+  #:use-module (gnu packages flex)
   #:use-module (gnu packages fontutils)
   #:use-module (gnu packages gl)
   #:use-module (gnu packages glib)
@@ -53,6 +55,7 @@ (define-module (gnu packages electronics)
   #:use-module (gnu packages libftdi)
   #:use-module (gnu packages libusb)
   #:use-module (gnu packages linux)
+  #:use-module (gnu packages maths)
   #:use-module (gnu packages m4)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages python)
@@ -65,6 +68,7 @@ (define-module (gnu packages electronics)
   #:use-module (gnu packages sqlite)
   #:use-module (gnu packages stb)
   #:use-module (gnu packages swig)
+  #:use-module (gnu packages tcl)
   #:use-module (gnu packages tls)
   #:use-module (gnu packages toolkits)
   #:use-module (gnu packages version-control))
@@ -415,6 +419,43 @@ (define-public openboardview
 @end itemize")
     (license license:expat)))
 
+(define-public opensta
+  ;; There are no releases, we use last commit.
+  (let ((commit "eb8d39a7dd81b5ca2582ad9bbce0fb6e094b3e0f")
+        (revision "0"))
+    (package
+      (name "opensta")
+      (version (git-version "2.6.2" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/parallaxsw/OpenSTA/")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "0bpc7fj4pd5713yny2vrh542jbag1kj20g0ji01c9scqb9av5qw5"))))
+      (build-system cmake-build-system)
+      (arguments
+       (list
+        #:phases
+        #~(modify-phases %standard-phases
+            (replace 'check
+              (lambda* (#:key (tests? #t) #:allow-other-keys)
+                (when tests?
+                  (invoke "../source/test/regression")))))
+        #:configure-flags
+        #~(list
+           (string-append "-DCUDD_DIR=" #$(this-package-input "cudd")))))
+      (native-inputs (list swig bison flex))
+      (inputs (list tcl tcllib zlib cudd eigen))
+      (synopsis "Parallax Static Timing Analyzer")
+      (description
+       "OpenSTA is a gate level static timing verifier.  As a stand-alone executable
+it can be used to verify the timing of a design using standard file formats.")
+      (home-page "https://github.com/parallaxsw/OpenSTA/")
+      (license license:gpl3))))
+
 (define-public pulseview
   (package
     (name "pulseview")

base-commit: 501a9603f5e3cda07f3be8e7fecac31f7af5ce52
--
2.49.0

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#78011] [PATCH electronics-team] gnu: Add opensta.
Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 26 Apr 2025 12:27:01 +0000
Resent-Message-ID: <handler.78011.B78011.174567037029961 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 78011
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Cayetano Santos <csantosb@HIDDEN>
Cc: 78011 <at> debbugs.gnu.org, Ekaitz Zarraga <ekaitz@HIDDEN>
Received: via spool by 78011-submit <at> debbugs.gnu.org id=B78011.174567037029961
          (code B ref 78011); Sat, 26 Apr 2025 12:27:01 +0000
Received: (at 78011) by debbugs.gnu.org; 26 Apr 2025 12:26:10 +0000
Received: from localhost ([127.0.0.1]:59129 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1u8ebh-0007n9-K9
	for submit <at> debbugs.gnu.org; Sat, 26 Apr 2025 08:26:10 -0400
Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]:53339)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>)
 id 1u8ebd-0007mO-BJ
 for 78011 <at> debbugs.gnu.org; Sat, 26 Apr 2025 08:26:06 -0400
Received: by mail-pj1-x1031.google.com with SMTP id
 98e67ed59e1d1-3012a0c8496so2509575a91.2
 for <78011 <at> debbugs.gnu.org>; Sat, 26 Apr 2025 05:26:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1745670359; x=1746275159; darn=debbugs.gnu.org;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=18eoQnHs9Sm9WVbyCqEVHrUrEgbAln6nRtaDCSuUcu0=;
 b=aYV++8FuskwYaZfi+Wg9k5FQFZRlRW7OUacW8VfberM6LVrpecJk25jNPZoeU55a0f
 qX6UIMUZD7ePnJ/bURAOvd65fjJE0kslZSDTHN8EjfAQFxIfySo1AY/UnYyBLO5pBDQS
 d3VtfP0ICmFR+MPceXQyi4H9OONWuwQbx+AeFF3lxSjHuzGdaj+cIuBFbzWknBj3xfw5
 ul1x2fkeQcvAYI+quLhcU8hvEiDb6vPnSWaIK4JaN5w+epQPEkiDt2lB9aEDJBbj+o48
 6jXxZzkYK10EoyrUCHgM7ThbwmpobTfvgTM9YgWoK+Clkw8/+beL2jlFOjmwGh0rXe8k
 i+Ug==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1745670359; x=1746275159;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=18eoQnHs9Sm9WVbyCqEVHrUrEgbAln6nRtaDCSuUcu0=;
 b=qo15eJGMa3IJmREyNMm5k7zgpvZM1U97CvPPFOh5MU1Xq1cZ9gYaTXu27xHqc+rgxG
 BVZsLJ3ugcCGHkeK31RC/o6lQ48spzFHEMDe8Ym0w5GS5nUML47gQc2dNhFVWDPPZ0IG
 oVrmYfTCf2dhLDETJxeiKcZkJsK27aE4NgWmUePXX3u+YhD1pczSLvOmFulECfBACDS/
 Y5R0ppgNe4dys13s10VwQ3cCYApJEeQE/eRtXvhQW9jYy1W3BEvd9SZueMT+s0yAvURd
 4bBxbBe9z8XX5xm/7KanX5dMWn8hlF542BnAhoOcXjV52+HhhTaC3IAlnJTCanlc4A/9
 cnRw==
X-Gm-Message-State: AOJu0YxtgDV5tn/lyoLa7VcaQgnoxEBHXIL2rfBh8V/HRciyKrpa0VnO
 p/2O5FlvFrRRtxM3g9kujrgmqBVgDHbUPzICxAZwtFXhnhiDYClV
X-Gm-Gg: ASbGncuPm8l9tLrkgNF/xNN1zJdEdDPSibnHm8RQfJeQe9cs1rZLsAYM1dwW34hmlBi
 D09wqF8Sr/WDlCmMsb8OmGO2t2ytAYJXpJ7+Sdsd5/XrAmGoV7hPHeO7icoRQ45pArE+sIssABN
 52WoyZYzQuDEfPw6Vi2PVH7mlu3WWnugaLW/vuEWWG8L/Zplm1s9b9mTuTK9bCtxdnpKMwiOo35
 8zeJ9jTHyoSsby5aFZzNVqiffxu1Ga5OnuPDQwh3vif1ZHBsyDgMGc0rqKC5A9Wri+ITkEsbikG
 1cOEy1OmapkUHgFrw6sTCu0uw0PbdGQw98oIy6Q=
X-Google-Smtp-Source: AGHT+IEVQT1BoFnxNxnWQbeDS5qWpHqX436CsN3nGMKnq1SSUgnP0xYh1IZ9u51gdfeukuVDrWdgmA==
X-Received: by 2002:a17:90b:4b4e:b0:301:1d03:93cd with SMTP id
 98e67ed59e1d1-30a013988efmr4669533a91.24.1745670359122; 
 Sat, 26 Apr 2025 05:25:59 -0700 (PDT)
Received: from terra ([2405:6586:be0:0:83c8:d31d:2cec:f542])
 by smtp.gmail.com with ESMTPSA id
 98e67ed59e1d1-309f784ac3fsm3429044a91.45.2025.04.26.05.25.57
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 26 Apr 2025 05:25:58 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
In-Reply-To: <87selwqug5.fsf@HIDDEN> (Cayetano Santos's message of
 "Fri, 25 Apr 2025 14:47:22 +0200")
References: <683e72f593c47e23a4d0afbab49940bbbea65da7.1745414060.git.csantosb@HIDDEN>
 <87frhxrlp0.fsf@HIDDEN> <87selwqug5.fsf@HIDDEN>
Date: Sat, 26 Apr 2025 21:25:55 +0900
Message-ID: <875xirds8c.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi,

Cayetano Santos <csantosb@HIDDEN> writes:

>>ven. 25 avril 2025 at 11:58, Maxim Cournoyer <maxim.cournoyer@HIDDEN> wrote:
>
> Hi Maxim,
>
>> Please fold your paragraphs so they stay within < 80 columns, our coding
>> style guideline (M-q in Emacs).
>
> The .editorconfig file in guix states "max_line_length = 85", which the
> corresponding emacs package honors. Is this correct ?

It was not.  It should be 80.  Fixed in commit e018fb6f61a.

-- 
Thanks,
Maxim

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#78011] [PATCH electronics-team] gnu: Add opensta.
Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 26 Apr 2025 12:45:02 +0000
Resent-Message-ID: <handler.78011.B78011.17456714672022 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 78011
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Cayetano Santos <csantosb@HIDDEN>
Cc: 78011 <at> debbugs.gnu.org, Ekaitz Zarraga <ekaitz@HIDDEN>
Received: via spool by 78011-submit <at> debbugs.gnu.org id=B78011.17456714672022
          (code B ref 78011); Sat, 26 Apr 2025 12:45:02 +0000
Received: (at 78011) by debbugs.gnu.org; 26 Apr 2025 12:44:27 +0000
Received: from localhost ([127.0.0.1]:59235 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1u8etO-0000WY-Kr
	for submit <at> debbugs.gnu.org; Sat, 26 Apr 2025 08:44:26 -0400
Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]:55668)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>)
 id 1u8etL-0000WI-Dm
 for 78011 <at> debbugs.gnu.org; Sat, 26 Apr 2025 08:44:24 -0400
Received: by mail-pj1-x102a.google.com with SMTP id
 98e67ed59e1d1-309f3bf23b8so3103889a91.3
 for <78011 <at> debbugs.gnu.org>; Sat, 26 Apr 2025 05:44:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1745671457; x=1746276257; darn=debbugs.gnu.org;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=qh4CARRhoyLlyM3rIKEhWOVcuXZLSkF80hDZ4nTQvDo=;
 b=ibpDotihgSs/2f0YgAtbUAurLa7nJsMJTNisMF/CDKitrAgOdUaU+K8XMyNxEQCUHZ
 Mm4inM7hzDuaTOW0eQ5AnGq+DmKSaJPf+WmrUCkINDTuhb7jruqHAOdVaRjXwsQ7W+f4
 WberQgPP1SeH/Niu887rik37OGoojLIJTrcYDQ2lA+mCe6C15Mm1YCrqOYiQ5qBhzE74
 B3gOiYPfrUWTscAYRqihLypac4aHFeWdItModO2+2mC06zvzfVxUHOewuiePy2lDyCn1
 hU9vC1KeJ+zD7O3740KPoY8u9XXLd5x/7bH4qDbGdV+OReWqrsgHevsgP2j0yW3RhVD2
 uU0g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1745671457; x=1746276257;
 h=mime-version:user-agent:message-id:date:references:in-reply-to
 :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
 :message-id:reply-to;
 bh=qh4CARRhoyLlyM3rIKEhWOVcuXZLSkF80hDZ4nTQvDo=;
 b=oQ+ktWShitCzhmyMcAMIVc/yLHXmVZWUvWOmTqmANA73nUa4FY5zsL/MKbEJsjOs3F
 OvpwnoAD+A8Torc6Li5EK2NUcp+k6ZYkI4Nj/qKzYgtn27mwBthic87cmcvjY6AXDUod
 JunlQW+a2IWY0n03znGm59inWA5AV0SSto9hqvBEf4AsW2FCE6N4YDu7Fx4cHInq59tt
 OX7Ro9YpOcXEy+EMgpNPaKqx/oJBkzwGi0CSa5HQpMcCT9sQGUW640wg4Cs9wsuE5hyw
 TooLm+1iHS3ybWd87ImOkgwPDqOLyI/Va0OINin95dqmS7+HMN/H/UzS7Ee6OH3Qpr6O
 JR5A==
X-Gm-Message-State: AOJu0YxBD1wdURmLjeebS48Tk/ZdVooBCABLPJLEuLwA0RJW7MV5lQfV
 oDj7xnrYGz/VeDixHeMTBVermfGXbYKZ9/mW6vXWe10fjoF4+biI
X-Gm-Gg: ASbGnct8RsVSdPcXKPwX7+/d8ZO/dOWblXqb6e03iXpoNJKZIPXVBeeodDH3CVUnq5+
 RT71cT8CrhxPkEPRIkzDIw4Bj/AwN6oF0PA1+G8INgLC+dzOU+omgcxOijw1ynV5kZXiWPAWEyf
 LzDQdYfNIl+Txxjqggz6NMby3RtI0OXwHLHpCDpG86dRMxO6j9EDVcYvmRfGFTdhCBz7nq1Qw4J
 7pB0VWu+xcu7DeC4BC2ywAskDXRg7uqg91qM2Rlh+ukMjjYThe2o+PBrZxUc8E3oA62J85ywJ2a
 TBclBNaT2O7wykT4dRjs1f8jZdYS4Lc7hOPu8rIAntoie7cXIw==
X-Google-Smtp-Source: AGHT+IEThQmiQTNmMd5NYKXUiigml+Mv149zCaqxTJb9q+Am/hn5tYaKXY+ceXobjPrcj2K/xXkgVQ==
X-Received: by 2002:a17:90b:57e8:b0:2ff:58b8:5c46 with SMTP id
 98e67ed59e1d1-30a013275a8mr3955656a91.8.1745671457187; 
 Sat, 26 Apr 2025 05:44:17 -0700 (PDT)
Received: from terra ([2405:6586:be0:0:83c8:d31d:2cec:f542])
 by smtp.gmail.com with ESMTPSA id
 98e67ed59e1d1-309ef03c806sm5243557a91.8.2025.04.26.05.44.15
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 26 Apr 2025 05:44:16 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
In-Reply-To: <2bf33bae3435d88a889a40e212102e9604af51ed.1745587470.git.csantosb@HIDDEN>
 (Cayetano Santos's message of "Fri, 25 Apr 2025 15:24:30 +0200")
References: <683e72f593c47e23a4d0afbab49940bbbea65da7.1745414060.git.csantosb@HIDDEN>
 <2bf33bae3435d88a889a40e212102e9604af51ed.1745587470.git.csantosb@HIDDEN>
Date: Sat, 26 Apr 2025 21:44:14 +0900
Message-ID: <871ptfdrdt.fsf_-_@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi,

Cayetano Santos <csantosb@HIDDEN> writes:

[...]

> +(define-public opensta
> +  ;; There are no releases, we use last commit.
> +  (let ((commit "eb8d39a7dd81b5ca2582ad9bbce0fb6e094b3e0f")
> +        (revision "0"))
> +    (package
> +      (name "opensta")
> +      (version (git-version "2.6.2" revision commit))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/parallaxsw/OpenSTA/")
> +               (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32 "0bpc7fj4pd5713yny2vrh542jbag1kj20g0ji01c9scqb9av5qw5"))))
> +      (build-system cmake-build-system)
> +      (arguments
> +       (list

Please use the -DBUILD_SHARED_LIBRARY=ON #:configure-flags I suggested
to reduce the output size, as suggested in my original review.

> +        #:phases
> +        #~(modify-phases %standard-phases
> +            (replace 'check
> +              (lambda* (#:key (tests? #t) #:allow-other-keys)

Please do not set default values for arguments to this anonymous
procedure; it just clutters the view (#:tests? is always passed by the
build system -- it is it which holds the default value).

> +                (when tests?
> +                  (invoke "../source/test/regression")))))
> +        #:configure-flags
> +        #~(list
> +           (string-append "-DCUDD_DIR=" #$(this-package-input "cudd")))))
> +      (native-inputs (list swig bison flex))
> +      (inputs (list tcl tcllib zlib cudd eigen))

It looks like you overlooked my suggestion to sort the
native-inputs/inputs.

> +      (synopsis "Parallax Static Timing Analyzer")
> +      (description
> +       "OpenSTA is a gate level static timing verifier.  As a stand-alone executable
> +it can be used to verify the timing of a design using standard file formats.")
> +      (home-page "https://github.com/parallaxsw/OpenSTA/")
> +      (license license:gpl3))))

Why the license change from gpl3+ to gpl3?  The former was correct.

Otherwise, LGTM.

Could you send a v3?

-- 
Thanks,
Maxim

Last modified: Sat, 26 Apr 2025 13:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.