GNU logs - #69914, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#69914: comint-strip-ctrl-m doesn't function as documentation states
Resent-From: Jonathan <public@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 20 Mar 2024 14:21:01 +0000
Resent-Message-ID: <handler.69914.B.171094444610251 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 69914 <at> debbugs.gnu.org
Date: Wed, 20 Mar 2024 14:15:39 +0000
From: Jonathan <public@HIDDEN>
Message-ID: <kWMjSzKANkjXjPs49Bb449174wXkfwg1AhbKEp-6Gi9eTpRRLlpt70_FIR0WnhBzYf3fh-uJ2BzoHE7L3kV7mvYAMdnK8VSVnzhCYs_IIhM=@jds.work>
Feedback-ID: 104505699:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass client-ip=185.70.40.136; envelope-from=public@HIDDEN;
 helo=mail-40136.proton.ch
X-Spam_score_int: 4
X-Spam_score: 0.4
X-Spam_bar: /
X-Spam_report: (0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1,
 DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_SUSPICIOUS_NTLD=0.499,
 FROM_SUSPICIOUS_NTLD_FP=1.999, RCVD_IN_MSPIKE_H4=0.001,
 RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001,
 T_PDS_OTHER_BAD_TLD=0.01,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.2 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview:  Hey folks,
 There appears to either be a bug or just inaccurate
 documentation of =comint-strip-ctrl-m=. At the very bottom, I've included
 some context about my use case by which I discovered this bug that may or
 [...] Content analysis details:   (1.2 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -2.3 RCVD_IN_DNSWL_MED      RBL: Sender listed at https://www.dnswl.org/,
 medium trust [209.51.188.17 listed in list.dnswl.org]
 1.0 SPF_SOFTFAIL           SPF: sender does not match SPF record (softfail)
 0.0 T_PDS_OTHER_BAD_TLD    Untrustworthy TLDs
 [URI: jds.work (work)]
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
 2.0 FROM_SUSPICIOUS_NTLD_FP From abused NTLD
 0.5 FROM_SUSPICIOUS_NTLD   From abused NTLD
 -0.0 T_SCC_BODY_TEXT_LINE   No description available.
X-Mailman-Approved-At: Wed, 20 Mar 2024 10:20:38 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.8 (-)

Hey folks,

There appears to either be a bug or just inaccurate documentation of =3Dcom=
int-strip-ctrl-m=3D. At the very bottom, I've included some context about m=
y use case by which I discovered this bug that may or may not be relevant t=
o you. The documentation for that function states:

#+begin_quote
Strip trailing ^M characters from the current output group.

This function could be on comint-output-filter-functions or bound to a key.
#+end_quote

=3Dcomint-output-filter-functions=3D states the following:

#+begin_quote
...These functions get one argument, a string containing the text as origin=
ally
inserted.  Note that this might not be the same as the buffer contents betw=
een
comint-last-output-start and the buffer's process-mark, if other filter
functions have already modified the buffer.
#+end_quote

Looking at the implementation of =3Dcomint-strip-ctrl-m=3D it appears that =
it completely ignores the =3Dstring=3D argument and instead uses =3D(get-bu=
ffer-process (current-buffer))=3D in direct contradiction to the documentat=
ion.

#+begin_src emacs-lisp
(defun comint-strip-ctrl-m (&optional _string interactive)
  "Strip trailing `^M' characters from the current output group.
This function could be on `comint-output-filter-functions' or bound to a ke=
y."
  (interactive (list nil t))
  (let ((process (get-buffer-process (current-buffer))))
    (if (not process)
        ;; This function may be used in
        ;; `comint-output-filter-functions', and in that case, if
        ;; there's no process, then we should do nothing.  If
        ;; interactive, report an error.
        (when interactive
          (error "No process in the current buffer"))
      ;;; rest omitted for brevity
      )))
#+end_src

This represents unexpected and undocumented behavior, as you anticipate =3D=
comint-strip-ctrl-m=3D to behave like any other comint output filter functi=
ons. I'd like to propose 3 different possible solutions for a patch and wou=
ld like input on which is preferred as this code was originally introduced =
in 1994. I can submit a patch once a solution has been determined.

1. Update the documentation and leave as is. This is the simplest solution =
and would just require doc-string updates to indicate that =3Dcomint-strip-=
ctrl-m=3D is a "unique" filter function among the other filter functions th=
at exist. This does not seem preferable to me.

2. Update the implementation of =3Dcomint-strip-ctrl-m=3D itself to conform=
 it to the documented API. This would mean anything currently depending on =
it reading the =3Dcurrent-buffer=3D would break, and since there are plenty=
 of unknowns in that regard, this also does not seem preferable.

3. Add a new version of the function with a different name that conforms to=
 the documented API =3Dcomint-strip-ctrl-m-output=3D or something similar a=
nd deprecate the original.

If we do decide to deprecate the original, I'm happy to include a deprecati=
on warning and keep an eye on it popping up in core to ensure that we handl=
e those issues over time.

Any guidance would be useful. Thank you all for your hard work.

- Jonathan

PS: Additional Context as promised:

I was developing a package that runs SQL queries in a "hidden" SQLi buffer =
and so I needed to strip carriage return characters out of the output. Usin=
g this filter I had thought it would perform the task, but it did not. So d=
igging through the documentation I discovered this error. I think it's pret=
ty reasonable that filter functions conform to the documented api or should=
 at least be noted otherwise.

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Jonathan <public@HIDDEN>
Subject: bug#69914: Acknowledgement (comint-strip-ctrl-m doesn't function
 as documentation states)
Message-ID: <handler.69914.B.171094444610251.ack <at> debbugs.gnu.org>
References: <kWMjSzKANkjXjPs49Bb449174wXkfwg1AhbKEp-6Gi9eTpRRLlpt70_FIR0WnhBzYf3fh-uJ2BzoHE7L3kV7mvYAMdnK8VSVnzhCYs_IIhM=@jds.work>
X-Gnu-PR-Message: ack 69914
X-Gnu-PR-Package: emacs
Reply-To: 69914 <at> debbugs.gnu.org
Date: Wed, 20 Mar 2024 14:21:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 69914 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
69914: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D69914
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#69914: comint-strip-ctrl-m doesn't function as documentation states
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 23 Mar 2024 08:11:01 +0000
Resent-Message-ID: <handler.69914.B69914.171118142417762 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Jonathan <public@HIDDEN>
Cc: 69914 <at> debbugs.gnu.org
Date: Sat, 23 Mar 2024 09:30:16 +0200
Message-Id: <86il1dz9pz.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <kWMjSzKANkjXjPs49Bb449174wXkfwg1AhbKEp-6Gi9eTpRRLlpt70_FIR0WnhBzYf3fh-uJ2BzoHE7L3kV7mvYAMdnK8VSVnzhCYs_IIhM=@jds.work>
 (bug-gnu-emacs@HIDDEN)
References: <kWMjSzKANkjXjPs49Bb449174wXkfwg1AhbKEp-6Gi9eTpRRLlpt70_FIR0WnhBzYf3fh-uJ2BzoHE7L3kV7mvYAMdnK8VSVnzhCYs_IIhM=@jds.work>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> Date: Wed, 20 Mar 2024 14:15:39 +0000
> From:  Jonathan via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
> 
> There appears to either be a bug or just inaccurate documentation of =comint-strip-ctrl-m=. At the very bottom, I've included some context about my use case by which I discovered this bug that may or may not be relevant to you. The documentation for that function states:
> 
> #+begin_quote
> Strip trailing ^M characters from the current output group.
> 
> This function could be on comint-output-filter-functions or bound to a key.
> #+end_quote
> 
> =comint-output-filter-functions= states the following:
> 
> #+begin_quote
> ...These functions get one argument, a string containing the text as originally
> inserted.  Note that this might not be the same as the buffer contents between
> comint-last-output-start and the buffer's process-mark, if other filter
> functions have already modified the buffer.
> #+end_quote
> 
> Looking at the implementation of =comint-strip-ctrl-m= it appears that it completely ignores the =string= argument and instead uses =(get-buffer-process (current-buffer))= in direct contradiction to the documentation.

Actually, AFAICT, almost all of the filtering functions intended for
comint-output-filter-functions ignore its string argument.  Isn't that
so?

> #+begin_src emacs-lisp
> (defun comint-strip-ctrl-m (&optional _string interactive)
>   "Strip trailing `^M' characters from the current output group.
> This function could be on `comint-output-filter-functions' or bound to a key."
>   (interactive (list nil t))
>   (let ((process (get-buffer-process (current-buffer))))
>     (if (not process)
>         ;; This function may be used in
>         ;; `comint-output-filter-functions', and in that case, if
>         ;; there's no process, then we should do nothing.  If
>         ;; interactive, report an error.
>         (when interactive
>           (error "No process in the current buffer"))
>       ;;; rest omitted for brevity
>       )))
> #+end_src
> 
> This represents unexpected and undocumented behavior, as you anticipate =comint-strip-ctrl-m= to behave like any other comint output filter functions. I'd like to propose 3 different possible solutions for a patch and would like input on which is preferred as this code was originally introduced in 1994. I can submit a patch once a solution has been determined.

Given that almost all the filter functions behave the same (unless you
disagree), it sounds like ignoring the string is a de-facto standard
behavior.  So we should document that, and I guess adding a new
function, without deprecating the existing one, is the most reasonable
way ahead?

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#69914: comint-strip-ctrl-m doesn't function as documentation states
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 06 Apr 2024 09:00:02 +0000
Resent-Message-ID: <handler.69914.B69914.171239394926706 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: public@HIDDEN
Cc: 69914 <at> debbugs.gnu.org
Date: Sat, 06 Apr 2024 11:58:51 +0300
Message-Id: <865xwu50l0.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <86il1dz9pz.fsf@HIDDEN> (message from Eli Zaretskii on Sat, 23
 Mar 2024 09:30:16 +0200)
References: <kWMjSzKANkjXjPs49Bb449174wXkfwg1AhbKEp-6Gi9eTpRRLlpt70_FIR0WnhBzYf3fh-uJ2BzoHE7L3kV7mvYAMdnK8VSVnzhCYs_IIhM=@jds.work>
 <86il1dz9pz.fsf@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Ping! Could you please answer my questions below?

> Cc: 69914 <at> debbugs.gnu.org
> Date: Sat, 23 Mar 2024 09:30:16 +0200
> From: Eli Zaretskii <eliz@HIDDEN>
> 
> > Date: Wed, 20 Mar 2024 14:15:39 +0000
> > From:  Jonathan via "Bug reports for GNU Emacs,
> >  the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
> > 
> > There appears to either be a bug or just inaccurate documentation of =comint-strip-ctrl-m=. At the very bottom, I've included some context about my use case by which I discovered this bug that may or may not be relevant to you. The documentation for that function states:
> > 
> > #+begin_quote
> > Strip trailing ^M characters from the current output group.
> > 
> > This function could be on comint-output-filter-functions or bound to a key.
> > #+end_quote
> > 
> > =comint-output-filter-functions= states the following:
> > 
> > #+begin_quote
> > ...These functions get one argument, a string containing the text as originally
> > inserted.  Note that this might not be the same as the buffer contents between
> > comint-last-output-start and the buffer's process-mark, if other filter
> > functions have already modified the buffer.
> > #+end_quote
> > 
> > Looking at the implementation of =comint-strip-ctrl-m= it appears that it completely ignores the =string= argument and instead uses =(get-buffer-process (current-buffer))= in direct contradiction to the documentation.
> 
> Actually, AFAICT, almost all of the filtering functions intended for
> comint-output-filter-functions ignore its string argument.  Isn't that
> so?
> 
> > #+begin_src emacs-lisp
> > (defun comint-strip-ctrl-m (&optional _string interactive)
> >   "Strip trailing `^M' characters from the current output group.
> > This function could be on `comint-output-filter-functions' or bound to a key."
> >   (interactive (list nil t))
> >   (let ((process (get-buffer-process (current-buffer))))
> >     (if (not process)
> >         ;; This function may be used in
> >         ;; `comint-output-filter-functions', and in that case, if
> >         ;; there's no process, then we should do nothing.  If
> >         ;; interactive, report an error.
> >         (when interactive
> >           (error "No process in the current buffer"))
> >       ;;; rest omitted for brevity
> >       )))
> > #+end_src
> > 
> > This represents unexpected and undocumented behavior, as you anticipate =comint-strip-ctrl-m= to behave like any other comint output filter functions. I'd like to propose 3 different possible solutions for a patch and would like input on which is preferred as this code was originally introduced in 1994. I can submit a patch once a solution has been determined.
> 
> Given that almost all the filter functions behave the same (unless you
> disagree), it sounds like ignoring the string is a de-facto standard
> behavior.  So we should document that, and I guess adding a new
> function, without deprecating the existing one, is the most reasonable
> way ahead?
> 
> 
> 
>

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#69914: comint-strip-ctrl-m doesn't function as documentation states
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 18 Apr 2024 09:02:04 +0000
Resent-Message-ID: <handler.69914.B69914.171343091331413 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 69914
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: public@HIDDEN
Cc: 69914 <at> debbugs.gnu.org
Received: via spool by 69914-submit <at> debbugs.gnu.org id=B69914.171343091331413
          (code B ref 69914); Thu, 18 Apr 2024 09:02:04 +0000
Received: (at 69914) by debbugs.gnu.org; 18 Apr 2024 09:01:53 +0000
Received: from localhost ([127.0.0.1]:51170 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rxNeN-00089n-MD
	for submit <at> debbugs.gnu.org; Thu, 18 Apr 2024 05:01:52 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:60582)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1rxNeH-000883-N4
 for 69914 <at> debbugs.gnu.org; Thu, 18 Apr 2024 05:01:46 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1rxNdy-0000Sz-V2; Thu, 18 Apr 2024 05:01:22 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=aESb7rh+zgsQ/y0oogZTfFvqQ2joNNF117UBDDkfUZM=; b=NB/E6P3zJCmQ
 meY2ED6IKxhBOJN68q1W4Voae56PshBo/FJkIbeCP1wiaABxWF1lD9LI4mE3hqvxQkSxVJWPPfT15
 fMAu3Ax/5kwaslfpISC9IgNg01wdftM3Ggvf6vO8VmPrk8rS02I+UC8NB3Riid8IGT5RDtP4rJ5jz
 oDe7SDHRxSgtVwMFC1Dh/9dcNAXSLtkJeEZd7sMR5w2sbZmy6xMtMsu32/qnHpTYyGW8pI2fucE+f
 0y1SGaYQgGS5Tn9Xbv0K4O7hzYfreV31CUrxYa1itF7iIIYq7rG7s7EGv4X7e3I2EC4wabtPz6HTY
 IHpkrS0xKH1zy/fp75hh8A==;
Date: Thu, 18 Apr 2024 12:01:18 +0300
Message-Id: <86a5lrf3j5.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <865xwu50l0.fsf@HIDDEN> (message from Eli Zaretskii on Sat, 06
 Apr 2024 11:58:51 +0300)
References: <kWMjSzKANkjXjPs49Bb449174wXkfwg1AhbKEp-6Gi9eTpRRLlpt70_FIR0WnhBzYf3fh-uJ2BzoHE7L3kV7mvYAMdnK8VSVnzhCYs_IIhM=@jds.work>
 <86il1dz9pz.fsf@HIDDEN> <865xwu50l0.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Ping! Ping!  Any interest in pursuing this issue further?  If so,
could you please answer my questions below?

> Cc: 69914 <at> debbugs.gnu.org
> Date: Sat, 06 Apr 2024 11:58:51 +0300
> From: Eli Zaretskii <eliz@HIDDEN>
> 
> Ping! Could you please answer my questions below?
> 
> > Cc: 69914 <at> debbugs.gnu.org
> > Date: Sat, 23 Mar 2024 09:30:16 +0200
> > From: Eli Zaretskii <eliz@HIDDEN>
> > 
> > > Date: Wed, 20 Mar 2024 14:15:39 +0000
> > > From:  Jonathan via "Bug reports for GNU Emacs,
> > >  the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN>
> > > 
> > > There appears to either be a bug or just inaccurate documentation of =comint-strip-ctrl-m=. At the very bottom, I've included some context about my use case by which I discovered this bug that may or may not be relevant to you. The documentation for that function states:
> > > 
> > > #+begin_quote
> > > Strip trailing ^M characters from the current output group.
> > > 
> > > This function could be on comint-output-filter-functions or bound to a key.
> > > #+end_quote
> > > 
> > > =comint-output-filter-functions= states the following:
> > > 
> > > #+begin_quote
> > > ...These functions get one argument, a string containing the text as originally
> > > inserted.  Note that this might not be the same as the buffer contents between
> > > comint-last-output-start and the buffer's process-mark, if other filter
> > > functions have already modified the buffer.
> > > #+end_quote
> > > 
> > > Looking at the implementation of =comint-strip-ctrl-m= it appears that it completely ignores the =string= argument and instead uses =(get-buffer-process (current-buffer))= in direct contradiction to the documentation.
> > 
> > Actually, AFAICT, almost all of the filtering functions intended for
> > comint-output-filter-functions ignore its string argument.  Isn't that
> > so?
> > 
> > > #+begin_src emacs-lisp
> > > (defun comint-strip-ctrl-m (&optional _string interactive)
> > >   "Strip trailing `^M' characters from the current output group.
> > > This function could be on `comint-output-filter-functions' or bound to a key."
> > >   (interactive (list nil t))
> > >   (let ((process (get-buffer-process (current-buffer))))
> > >     (if (not process)
> > >         ;; This function may be used in
> > >         ;; `comint-output-filter-functions', and in that case, if
> > >         ;; there's no process, then we should do nothing.  If
> > >         ;; interactive, report an error.
> > >         (when interactive
> > >           (error "No process in the current buffer"))
> > >       ;;; rest omitted for brevity
> > >       )))
> > > #+end_src
> > > 
> > > This represents unexpected and undocumented behavior, as you anticipate =comint-strip-ctrl-m= to behave like any other comint output filter functions. I'd like to propose 3 different possible solutions for a patch and would like input on which is preferred as this code was originally introduced in 1994. I can submit a patch once a solution has been determined.
> > 
> > Given that almost all the filter functions behave the same (unless you
> > disagree), it sounds like ignoring the string is a de-facto standard
> > behavior.  So we should document that, and I guess adding a new
> > function, without deprecating the existing one, is the most reasonable
> > way ahead?
> > 
> > 
> > 
> > 
> 
> 
> 
>

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#69914: comint-strip-ctrl-m doesn't function as documentation states
Resent-From: Jonathan <public@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 03 Nov 2024 02:55:02 +0000
Resent-Message-ID: <handler.69914.B69914.173060247012044 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 69914
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 69914 <at> debbugs.gnu.org
Received: via spool by 69914-submit <at> debbugs.gnu.org id=B69914.173060247012044
          (code B ref 69914); Sun, 03 Nov 2024 02:55:02 +0000
Received: (at 69914) by debbugs.gnu.org; 3 Nov 2024 02:54:30 +0000
Received: from localhost ([127.0.0.1]:57267 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1t7Ql3-00038B-N3
	for submit <at> debbugs.gnu.org; Sat, 02 Nov 2024 22:54:30 -0400
Received: from mail-4317.proton.ch ([185.70.43.17]:59245)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <public@HIDDEN>) id 1t7Qkz-000380-7J
 for 69914 <at> debbugs.gnu.org; Sat, 02 Nov 2024 22:54:27 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jds.work;
 s=protonmail2; t=1730602458; x=1730861658;
 bh=+iMzmxbY2zqJjAMBc4F7w1LiVoN4XDJPj8VP7z92tRg=;
 h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
 Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
 Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;
 b=O2h24BXqTBJ1139O0MqSRXa7/gjYc+Wd5s80kDGJh95aj18Gw0Fzz0KHYUol2YEAq
 fSxa/uCnDTdb3dVGaIuDM5jacLVg5/wLXyyEAJTAqT2JHW/8baZS2/7V2bI5kNHvod
 pmHBtf6btxqFWXnA5gwb9uPR+3PSHTvY1lG492X7WpJgUPl4ZJecw92idNE5PWfiY+
 qJcCA1cIXc1DgEgTW3XWZtHe9jjlaHgds7KZCKtlgh9/ZUTvKWwLdSJUUCfK9L8zYv
 sDvsNy5dt3ULeBp0L9G0In1Fm5qcW2OERuEplxQlA7tCQPZLJgpxv2If7056RvWpqP
 /jpjBvSkNFqMA==
Date: Sun, 03 Nov 2024 02:54:14 +0000
From: Jonathan <public@HIDDEN>
Message-ID: <a8hHrnxxOCOEJTucfjfjuQozR9OpqVje730jyo89QdycLgBGJEDUM_X_QUrSaUEtDRmmQFuwKZwp6Zr7hmYVcdK3mFNr_adPNwLd2XTmbzQ=@jds.work>
In-Reply-To: <86a5lrf3j5.fsf@HIDDEN>
References: <kWMjSzKANkjXjPs49Bb449174wXkfwg1AhbKEp-6Gi9eTpRRLlpt70_FIR0WnhBzYf3fh-uJ2BzoHE7L3kV7mvYAMdnK8VSVnzhCYs_IIhM=@jds.work>
 <86il1dz9pz.fsf@HIDDEN> <865xwu50l0.fsf@HIDDEN> <86a5lrf3j5.fsf@HIDDEN>
Feedback-ID: 104505699:user:proton
X-Pm-Message-ID: e5f2ccd72eb48ec925d70096b438b8565caa53ce
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 2.5 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview: My apologies. This completely dropped off my radar as a few
 life events took precedence over the past few months and took me away from
 this. Things are more settled now though. I do agree this appears to be a
 common trend among the comint filter functions. I will get together a patch
 including a new version of =comint-strip-ctrl-m= named something different
 of course, and up [...] 
 Content analysis details:   (2.5 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 2.0 PDS_OTHER_BAD_TLD      Untrustworthy TLDs
 [URI: jds.work (work)]
 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The
 query to Validity was blocked.  See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243
 for more information.
 [185.70.43.17 listed in sa-accredit.habeas.com]
 0.0 RCVD_IN_MSPIKE_H4      RBL: Very Good reputation (+4)
 [185.70.43.17 listed in wl.mailspike.net]
 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The
 query to Validity was blocked.  See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243
 for more information.
 [185.70.43.17 listed in bl.score.senderscore.com]
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
 -0.0 SPF_PASS               SPF: sender matches SPF record
 0.5 FROM_SUSPICIOUS_NTLD   From abused NTLD
 0.0 RCVD_IN_MSPIKE_WL      Mailspike good senders
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 2.5 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 
 Content preview:  My apologies. This completely dropped off my radar as a few
    life events took precedence over the past few months and took me away from
    this. Things are more settled now though. I do agree this appears to be a
    common trend among the comint filter functions. I will get together a patch
    including a new version of =comint-strip-ctrl-m= named something different
    of course, and up [...] 
 
 Content analysis details:   (2.5 points, 10.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
  0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The
                             query to Validity was blocked.  See
                             https://knowledge.validity.com/hc/en-us/articles/20961730681243
                              for more information.
                             [185.70.43.17 listed in sa-accredit.habeas.com]
  0.0 RCVD_IN_MSPIKE_H4      RBL: Very Good reputation (+4)
                             [185.70.43.17 listed in wl.mailspike.net]
  0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The
                             query to Validity was blocked.  See
                             https://knowledge.validity.com/hc/en-us/articles/20961730681243
                              for more information.
                             [185.70.43.17 listed in bl.score.senderscore.com]
  2.0 PDS_OTHER_BAD_TLD      Untrustworthy TLDs
                             [URI: jds.work (work)]
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
 -0.0 SPF_PASS               SPF: sender matches SPF record
  0.5 FROM_SUSPICIOUS_NTLD   From abused NTLD
  0.0 RCVD_IN_MSPIKE_WL      Mailspike good senders
  1.0 BULK_RE_SUSP_NTLD      Precedence bulk and RE: from a suspicious TLD
 -1.0 MAILING_LIST_MULTI     Multiple indicators imply a widely-seen list
                             manager

My apologies. This completely dropped off my radar as a few life events too=
k precedence over the past few months and took me away from this. Things ar=
e more settled now though.

I do agree this appears to be a common trend among the comint filter functi=
ons. I will get together a patch including a new version of =3Dcomint-strip=
-ctrl-m=3D named something different of course, and updating the documentat=
ion that I can track down.

I do just anticipate this to take a little time as this would be my first c=
ontribution to the project and I'm still learning my way around. If all thi=
s is amenable to you I'll move forward with my solution and get a patch sen=
t in soon.=20


On Thursday, April 18th, 2024 at 4:01 AM, Eli Zaretskii <eliz@HIDDEN> wrot=
e:

>=20
>=20
> Ping! Ping! Any interest in pursuing this issue further? If so,
> could you please answer my questions below?
>=20
> > Cc: 69914 <at> debbugs.gnu.org
> > Date: Sat, 06 Apr 2024 11:58:51 +0300
> > From: Eli Zaretskii eliz@HIDDEN
> >=20
> > Ping! Could you please answer my questions below?
> >=20
> > > Cc: 69914 <at> debbugs.gnu.org
> > > Date: Sat, 23 Mar 2024 09:30:16 +0200
> > > From: Eli Zaretskii eliz@HIDDEN
> > >=20
> > > > Date: Wed, 20 Mar 2024 14:15:39 +0000
> > > > From: Jonathan via "Bug reports for GNU Emacs,
> > > > the Swiss army knife of text editors" bug-gnu-emacs@HIDDEN
> > > >=20
> > > > There appears to either be a bug or just inaccurate documentation o=
f =3Dcomint-strip-ctrl-m=3D. At the very bottom, I've included some context=
 about my use case by which I discovered this bug that may or may not be re=
levant to you. The documentation for that function states:
> > > >=20
> > > > #+begin_quote
> > > > Strip trailing ^M characters from the current output group.
> > > >=20
> > > > This function could be on comint-output-filter-functions or bound t=
o a key.
> > > > #+end_quote
> > > >=20
> > > > =3Dcomint-output-filter-functions=3D states the following:
> > > >=20
> > > > #+begin_quote
> > > > ...These functions get one argument, a string containing the text a=
s originally
> > > > inserted. Note that this might not be the same as the buffer conten=
ts between
> > > > comint-last-output-start and the buffer's process-mark, if other fi=
lter
> > > > functions have already modified the buffer.
> > > > #+end_quote
> > > >=20
> > > > Looking at the implementation of =3Dcomint-strip-ctrl-m=3D it appea=
rs that it completely ignores the =3Dstring=3D argument and instead uses =
=3D(get-buffer-process (current-buffer))=3D in direct contradiction to the =
documentation.
> > >=20
> > > Actually, AFAICT, almost all of the filtering functions intended for
> > > comint-output-filter-functions ignore its string argument. Isn't that
> > > so?
> > >=20
> > > > #+begin_src emacs-lisp
> > > > (defun comint-strip-ctrl-m (&optional _string interactive)
> > > > "Strip trailing `^M' characters from the current output group. This=
 function could be on` comint-output-filter-functions' or bound to a key."
> > > > (interactive (list nil t))
> > > > (let ((process (get-buffer-process (current-buffer))))
> > > > (if (not process)
> > > > ;; This function may be used in
> > > > ;; `comint-output-filter-functions', and in that case, if
> > > > ;; there's no process, then we should do nothing. If
> > > > ;; interactive, report an error.
> > > > (when interactive
> > > > (error "No process in the current buffer"))
> > > > ;;; rest omitted for brevity
> > > > )))
> > > > #+end_src
> > > >=20
> > > > This represents unexpected and undocumented behavior, as you antici=
pate =3Dcomint-strip-ctrl-m=3D to behave like any other comint output filte=
r functions. I'd like to propose 3 different possible solutions for a patch=
 and would like input on which is preferred as this code was originally int=
roduced in 1994. I can submit a patch once a solution has been determined.
> > >=20
> > > Given that almost all the filter functions behave the same (unless yo=
u
> > > disagree), it sounds like ignoring the string is a de-facto standard
> > > behavior. So we should document that, and I guess adding a new
> > > function, without deprecating the existing one, is the most reasonabl=
e
> > > way ahead?

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#69914: comint-strip-ctrl-m doesn't function as documentation states
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 14 Nov 2024 08:57:01 +0000
Resent-Message-ID: <handler.69914.B69914.17315745898961 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 69914
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Jonathan <public@HIDDEN>
Cc: 69914 <at> debbugs.gnu.org
Received: via spool by 69914-submit <at> debbugs.gnu.org id=B69914.17315745898961
          (code B ref 69914); Thu, 14 Nov 2024 08:57:01 +0000
Received: (at 69914) by debbugs.gnu.org; 14 Nov 2024 08:56:29 +0000
Received: from localhost ([127.0.0.1]:44974 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tBVeP-0002KS-Af
	for submit <at> debbugs.gnu.org; Thu, 14 Nov 2024 03:56:29 -0500
Received: from eggs.gnu.org ([209.51.188.92]:45722)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1tBVeN-0002KE-61
 for 69914 <at> debbugs.gnu.org; Thu, 14 Nov 2024 03:56:27 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1tBVeH-0003LS-RX; Thu, 14 Nov 2024 03:56:21 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=3BgJ/FSPxuMkV/fWhsFSyFhZUl4aZCuEguTJFqrJsI4=; b=jKlVxFOE0oQb
 Cd/Ztz0e+JZB3TxCaHJ9I2UMez27SGNevqt7dQxNCtPA7ExM0J+Y8ev3XdrTWyklgyEMYScY1kQmn
 35P4cTDPhf9ox7s++5/Ig/swwj5ND/yQAbQwP1FXLF+rLL9bOHxxdDvyvY/i2dQUA/YMW9yncJ2xQ
 K7ys6a3U7gdJvhn/+3dgxgEmMI/B6rvd2A7bJJ5NIQrIUqpjcSh7vcqVaUhRJEG4zdQUocfGWsORM
 4NuGhsNWW8keElXPT6kEISBNxTb+pefsc/WKh3xY0+EbUXSqaSxAr1lixxUsMAfzyg2HvG2lmzIH2
 HhUAgNcxR5HXx0dwLEweXg==;
Date: Thu, 14 Nov 2024 10:55:58 +0200
Message-Id: <86ttcajish.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <a8hHrnxxOCOEJTucfjfjuQozR9OpqVje730jyo89QdycLgBGJEDUM_X_QUrSaUEtDRmmQFuwKZwp6Zr7hmYVcdK3mFNr_adPNwLd2XTmbzQ=@jds.work>
 (message from Jonathan on Sun, 03 Nov 2024 02:54:14 +0000)
References: <kWMjSzKANkjXjPs49Bb449174wXkfwg1AhbKEp-6Gi9eTpRRLlpt70_FIR0WnhBzYf3fh-uJ2BzoHE7L3kV7mvYAMdnK8VSVnzhCYs_IIhM=@jds.work>
 <86il1dz9pz.fsf@HIDDEN> <865xwu50l0.fsf@HIDDEN> <86a5lrf3j5.fsf@HIDDEN>
 <a8hHrnxxOCOEJTucfjfjuQozR9OpqVje730jyo89QdycLgBGJEDUM_X_QUrSaUEtDRmmQFuwKZwp6Zr7hmYVcdK3mFNr_adPNwLd2XTmbzQ=@jds.work>
X-Spam-Score: -0.3 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.3 (-)

> Date: Sun, 03 Nov 2024 02:54:14 +0000
> From: Jonathan <public@HIDDEN>
> Cc: 69914 <at> debbugs.gnu.org
> 
> My apologies. This completely dropped off my radar as a few life events took precedence over the past few months and took me away from this. Things are more settled now though.
> 
> I do agree this appears to be a common trend among the comint filter functions. I will get together a patch including a new version of =comint-strip-ctrl-m= named something different of course, and updating the documentation that I can track down.
> 
> I do just anticipate this to take a little time as this would be my first contribution to the project and I'm still learning my way around. If all this is amenable to you I'll move forward with my solution and get a patch sent in soon. 

Yes, please go ahead, and thanks.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#69914: comint-strip-ctrl-m doesn't function as documentation states
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 30 Nov 2024 09:48:01 +0000
Resent-Message-ID: <handler.69914.B69914.173296005424448 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 69914
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: public@HIDDEN
Cc: 69914 <at> debbugs.gnu.org
Received: via spool by 69914-submit <at> debbugs.gnu.org id=B69914.173296005424448
          (code B ref 69914); Sat, 30 Nov 2024 09:48:01 +0000
Received: (at 69914) by debbugs.gnu.org; 30 Nov 2024 09:47:34 +0000
Received: from localhost ([127.0.0.1]:45444 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tHK4c-0006MF-2G
	for submit <at> debbugs.gnu.org; Sat, 30 Nov 2024 04:47:34 -0500
Received: from eggs.gnu.org ([209.51.188.92]:35790)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1tHK4Z-0006Lr-Vn
 for 69914 <at> debbugs.gnu.org; Sat, 30 Nov 2024 04:47:32 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1tHK4T-0004VG-JP; Sat, 30 Nov 2024 04:47:26 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=tp0+GMUVnOfIFXbMEaBixK/4qNdY8MlS15RLE89Rqu8=; b=LfGbp/TlO6Jp
 V5ZJmeQLxv6qqlgrUyE8i2dSeOLvxk9iZ3xkERo1zQ69eNCbtKGZaaehaQfo4QvVQ1FY1Vhrno2Kr
 gtZBYs+Ac6ZveXC5JscUftjdfFSMnxvpbmYbEPVKnknxeJn8lyzMqQM36QnhB5n3CIibDDqvjbQyg
 M0qGWk9l43vSkghg68G5MZJLM8L7OS0vUndDpKqwj1EwZjiTvnpU4hr0QpURzr2vtec+dkrizz+Yz
 Q4V3ga56y12fi/NKgrY7edLQ7ovmSPZxXwqgU8SkKHI+Kxc/dktE/4rGnZ+ZlJnU3i+Xk2pIGGRa7
 ZSUT4lSrvwdcfHMNiMHhPg==;
Date: Sat, 30 Nov 2024 11:47:22 +0200
Message-Id: <86a5dh9hp1.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <86ttcajish.fsf@HIDDEN> (message from Eli Zaretskii on Thu, 14
 Nov 2024 10:55:58 +0200)
References: <kWMjSzKANkjXjPs49Bb449174wXkfwg1AhbKEp-6Gi9eTpRRLlpt70_FIR0WnhBzYf3fh-uJ2BzoHE7L3kV7mvYAMdnK8VSVnzhCYs_IIhM=@jds.work>
 <86il1dz9pz.fsf@HIDDEN> <865xwu50l0.fsf@HIDDEN> <86a5lrf3j5.fsf@HIDDEN>
 <a8hHrnxxOCOEJTucfjfjuQozR9OpqVje730jyo89QdycLgBGJEDUM_X_QUrSaUEtDRmmQFuwKZwp6Zr7hmYVcdK3mFNr_adPNwLd2XTmbzQ=@jds.work>
 <86ttcajish.fsf@HIDDEN>
X-Spam-Score: -0.3 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.3 (-)

> Cc: 69914 <at> debbugs.gnu.org
> Date: Thu, 14 Nov 2024 10:55:58 +0200
> From: Eli Zaretskii <eliz@HIDDEN>
> 
> > Date: Sun, 03 Nov 2024 02:54:14 +0000
> > From: Jonathan <public@HIDDEN>
> > Cc: 69914 <at> debbugs.gnu.org
> > 
> > My apologies. This completely dropped off my radar as a few life events took precedence over the past few months and took me away from this. Things are more settled now though.
> > 
> > I do agree this appears to be a common trend among the comint filter functions. I will get together a patch including a new version of =comint-strip-ctrl-m= named something different of course, and updating the documentation that I can track down.
> > 
> > I do just anticipate this to take a little time as this would be my first contribution to the project and I'm still learning my way around. If all this is amenable to you I'll move forward with my solution and get a patch sent in soon. 
> 
> Yes, please go ahead, and thanks.

Did you have an opportunity to make some progress?

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#69914: comint-strip-ctrl-m doesn't function as documentation states
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 14 Dec 2024 09:34:02 +0000
Resent-Message-ID: <handler.69914.B69914.173416880125089 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 69914
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: public@HIDDEN
Cc: 69914 <at> debbugs.gnu.org
Received: via spool by 69914-submit <at> debbugs.gnu.org id=B69914.173416880125089
          (code B ref 69914); Sat, 14 Dec 2024 09:34:02 +0000
Received: (at 69914) by debbugs.gnu.org; 14 Dec 2024 09:33:21 +0000
Received: from localhost ([127.0.0.1]:45441 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tMOWS-0006WX-F1
	for submit <at> debbugs.gnu.org; Sat, 14 Dec 2024 04:33:20 -0500
Received: from eggs.gnu.org ([209.51.188.92]:35796)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1tMOWP-0006WH-74
 for 69914 <at> debbugs.gnu.org; Sat, 14 Dec 2024 04:33:14 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1tMOWJ-0008TJ-Vg; Sat, 14 Dec 2024 04:33:07 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=EDeRtszalhe6Gkr9RzKtW6DfORN/UvJbRxTN06F+Ccc=; b=GTfNi5WUntDA
 f/JiC1n6/5mMZJBnw3i81Mh6HGbXEJTS+SeyQatxdgsBKI+q+ZCYfqTUp9jGAt4Ca7AcoPpFZ1saQ
 GMhod1LmlXo+QqvoLJnGUVgIYrCMREeViR1SVd1BKBluGPB7cXUsVEl6/Zgic/NVJb0J3p9oBOfVy
 WYfZt0U39f5FnQRN/QGbWLbGBGjbbIjNk0IAjSz1A4o6tQAyYH48zKRuA+J0cGJIaqZQ/tM6TYJSq
 KBDJ4oGJbQNKefCNMbA4EPQlKtIQkzA6qXJoxR79K/9EcaaGgnr30g95yWoVkKZgTGFmEXfnDRLJJ
 JtVJARh2GLuzepiurY1ewg==;
Date: Sat, 14 Dec 2024 11:33:04 +0200
Message-Id: <865xnmwqwf.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <86a5dh9hp1.fsf@HIDDEN> (message from Eli Zaretskii on Sat, 30
 Nov 2024 11:47:22 +0200)
References: <kWMjSzKANkjXjPs49Bb449174wXkfwg1AhbKEp-6Gi9eTpRRLlpt70_FIR0WnhBzYf3fh-uJ2BzoHE7L3kV7mvYAMdnK8VSVnzhCYs_IIhM=@jds.work>
 <86il1dz9pz.fsf@HIDDEN> <865xwu50l0.fsf@HIDDEN> <86a5lrf3j5.fsf@HIDDEN>
 <a8hHrnxxOCOEJTucfjfjuQozR9OpqVje730jyo89QdycLgBGJEDUM_X_QUrSaUEtDRmmQFuwKZwp6Zr7hmYVcdK3mFNr_adPNwLd2XTmbzQ=@jds.work>
 <86ttcajish.fsf@HIDDEN> <86a5dh9hp1.fsf@HIDDEN>
X-Spam-Score: -0.3 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.3 (-)

Ping!

> Cc: 69914 <at> debbugs.gnu.org
> Date: Sat, 30 Nov 2024 11:47:22 +0200
> From: Eli Zaretskii <eliz@HIDDEN>
> 
> > Cc: 69914 <at> debbugs.gnu.org
> > Date: Thu, 14 Nov 2024 10:55:58 +0200
> > From: Eli Zaretskii <eliz@HIDDEN>
> > 
> > > Date: Sun, 03 Nov 2024 02:54:14 +0000
> > > From: Jonathan <public@HIDDEN>
> > > Cc: 69914 <at> debbugs.gnu.org
> > > 
> > > My apologies. This completely dropped off my radar as a few life events took precedence over the past few months and took me away from this. Things are more settled now though.
> > > 
> > > I do agree this appears to be a common trend among the comint filter functions. I will get together a patch including a new version of =comint-strip-ctrl-m= named something different of course, and updating the documentation that I can track down.
> > > 
> > > I do just anticipate this to take a little time as this would be my first contribution to the project and I'm still learning my way around. If all this is amenable to you I'll move forward with my solution and get a patch sent in soon. 
> > 
> > Yes, please go ahead, and thanks.
> 
> Did you have an opportunity to make some progress?
> 
> 
> 
>

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#69914: comint-strip-ctrl-m doesn't function as documentation states
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 28 Dec 2024 11:08:01 +0000
Resent-Message-ID: <handler.69914.B69914.173538406124494 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 69914
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: public@HIDDEN
Cc: 69914 <at> debbugs.gnu.org
Received: via spool by 69914-submit <at> debbugs.gnu.org id=B69914.173538406124494
          (code B ref 69914); Sat, 28 Dec 2024 11:08:01 +0000
Received: (at 69914) by debbugs.gnu.org; 28 Dec 2024 11:07:41 +0000
Received: from localhost ([127.0.0.1]:48943 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tRUfV-0006N0-GG
	for submit <at> debbugs.gnu.org; Sat, 28 Dec 2024 06:07:41 -0500
Received: from eggs.gnu.org ([209.51.188.92]:53590)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1tRUfT-0006Mn-O8
 for 69914 <at> debbugs.gnu.org; Sat, 28 Dec 2024 06:07:40 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1tRUfN-0005h9-3I; Sat, 28 Dec 2024 06:07:34 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=o+XxaZcm0qTeBDni71ZUGaC5vwvKLn+wboWIVV3L/7I=; b=WyoyYVboA2kI
 aHwPW+jiPiSi738uli0K0o6/UB2WGkYNKBB8TWIPycHGDxIduCqP1OzYyjv6UaPPMRMypo4fV26th
 /LVWT89zz3SP8BuM8aAUfFFQCQw7mUe4TT2ioE4QN2Mb2xl3ZPCHRDXJVHUqou0ig9bUrVPCQiVmY
 1b4+g1xhO91K6O1JIHwnhVtBFR+wVOw6EzXKRh/KdfEl1TM5NHxdySQjSCwWVY/hTFYlm7Q70om/l
 Rhl8D2YkxLGYSgpMk2rhVgJIEe4TW4faVvV347W850VjSijqEPj6Ww/ehDwgpBfDzJQp7nE13ZxFr
 ktrM//j+w2KfqDNN6KFu7g==;
Date: Sat, 28 Dec 2024 13:07:06 +0200
Message-Id: <86pllct6at.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <865xnmwqwf.fsf@HIDDEN> (message from Eli Zaretskii on Sat, 14
 Dec 2024 11:33:04 +0200)
References: <kWMjSzKANkjXjPs49Bb449174wXkfwg1AhbKEp-6Gi9eTpRRLlpt70_FIR0WnhBzYf3fh-uJ2BzoHE7L3kV7mvYAMdnK8VSVnzhCYs_IIhM=@jds.work>
 <86il1dz9pz.fsf@HIDDEN> <865xwu50l0.fsf@HIDDEN> <86a5lrf3j5.fsf@HIDDEN>
 <a8hHrnxxOCOEJTucfjfjuQozR9OpqVje730jyo89QdycLgBGJEDUM_X_QUrSaUEtDRmmQFuwKZwp6Zr7hmYVcdK3mFNr_adPNwLd2XTmbzQ=@jds.work>
 <86ttcajish.fsf@HIDDEN> <86a5dh9hp1.fsf@HIDDEN> <865xnmwqwf.fsf@HIDDEN>
X-Spam-Score: -0.3 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.3 (-)

Ping! Ping!

> Cc: 69914 <at> debbugs.gnu.org
> Date: Sat, 14 Dec 2024 11:33:04 +0200
> From: Eli Zaretskii <eliz@HIDDEN>
> 
> Ping!
> 
> > Cc: 69914 <at> debbugs.gnu.org
> > Date: Sat, 30 Nov 2024 11:47:22 +0200
> > From: Eli Zaretskii <eliz@HIDDEN>
> > 
> > > Cc: 69914 <at> debbugs.gnu.org
> > > Date: Thu, 14 Nov 2024 10:55:58 +0200
> > > From: Eli Zaretskii <eliz@HIDDEN>
> > > 
> > > > Date: Sun, 03 Nov 2024 02:54:14 +0000
> > > > From: Jonathan <public@HIDDEN>
> > > > Cc: 69914 <at> debbugs.gnu.org
> > > > 
> > > > My apologies. This completely dropped off my radar as a few life events took precedence over the past few months and took me away from this. Things are more settled now though.
> > > > 
> > > > I do agree this appears to be a common trend among the comint filter functions. I will get together a patch including a new version of =comint-strip-ctrl-m= named something different of course, and updating the documentation that I can track down.
> > > > 
> > > > I do just anticipate this to take a little time as this would be my first contribution to the project and I'm still learning my way around. If all this is amenable to you I'll move forward with my solution and get a patch sent in soon. 
> > > 
> > > Yes, please go ahead, and thanks.
> > 
> > Did you have an opportunity to make some progress?
> > 
> > 
> > 
> > 
> 
> 
> 
>

Last modified: Sun, 12 Jan 2025 05:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.