Received: (at 69914) by debbugs.gnu.org; 28 Dec 2024 11:07:41 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Dec 28 06:07:41 2024 Received: from localhost ([127.0.0.1]:48943 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tRUfV-0006N0-GG for submit <at> debbugs.gnu.org; Sat, 28 Dec 2024 06:07:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tRUfT-0006Mn-O8 for 69914 <at> debbugs.gnu.org; Sat, 28 Dec 2024 06:07:40 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1tRUfN-0005h9-3I; Sat, 28 Dec 2024 06:07:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=o+XxaZcm0qTeBDni71ZUGaC5vwvKLn+wboWIVV3L/7I=; b=WyoyYVboA2kI aHwPW+jiPiSi738uli0K0o6/UB2WGkYNKBB8TWIPycHGDxIduCqP1OzYyjv6UaPPMRMypo4fV26th /LVWT89zz3SP8BuM8aAUfFFQCQw7mUe4TT2ioE4QN2Mb2xl3ZPCHRDXJVHUqou0ig9bUrVPCQiVmY 1b4+g1xhO91K6O1JIHwnhVtBFR+wVOw6EzXKRh/KdfEl1TM5NHxdySQjSCwWVY/hTFYlm7Q70om/l Rhl8D2YkxLGYSgpMk2rhVgJIEe4TW4faVvV347W850VjSijqEPj6Ww/ehDwgpBfDzJQp7nE13ZxFr ktrM//j+w2KfqDNN6KFu7g==; Date: Sat, 28 Dec 2024 13:07:06 +0200 Message-Id: <86pllct6at.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: public@HIDDEN In-Reply-To: <865xnmwqwf.fsf@HIDDEN> (message from Eli Zaretskii on Sat, 14 Dec 2024 11:33:04 +0200) Subject: Re: bug#69914: comint-strip-ctrl-m doesn't function as documentation states References: <kWMjSzKANkjXjPs49Bb449174wXkfwg1AhbKEp-6Gi9eTpRRLlpt70_FIR0WnhBzYf3fh-uJ2BzoHE7L3kV7mvYAMdnK8VSVnzhCYs_IIhM=@jds.work> <86il1dz9pz.fsf@HIDDEN> <865xwu50l0.fsf@HIDDEN> <86a5lrf3j5.fsf@HIDDEN> <a8hHrnxxOCOEJTucfjfjuQozR9OpqVje730jyo89QdycLgBGJEDUM_X_QUrSaUEtDRmmQFuwKZwp6Zr7hmYVcdK3mFNr_adPNwLd2XTmbzQ=@jds.work> <86ttcajish.fsf@HIDDEN> <86a5dh9hp1.fsf@HIDDEN> <865xnmwqwf.fsf@HIDDEN> X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: 69914 Cc: 69914 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.3 (-) Ping! Ping! > Cc: 69914 <at> debbugs.gnu.org > Date: Sat, 14 Dec 2024 11:33:04 +0200 > From: Eli Zaretskii <eliz@HIDDEN> > > Ping! > > > Cc: 69914 <at> debbugs.gnu.org > > Date: Sat, 30 Nov 2024 11:47:22 +0200 > > From: Eli Zaretskii <eliz@HIDDEN> > > > > > Cc: 69914 <at> debbugs.gnu.org > > > Date: Thu, 14 Nov 2024 10:55:58 +0200 > > > From: Eli Zaretskii <eliz@HIDDEN> > > > > > > > Date: Sun, 03 Nov 2024 02:54:14 +0000 > > > > From: Jonathan <public@HIDDEN> > > > > Cc: 69914 <at> debbugs.gnu.org > > > > > > > > My apologies. This completely dropped off my radar as a few life events took precedence over the past few months and took me away from this. Things are more settled now though. > > > > > > > > I do agree this appears to be a common trend among the comint filter functions. I will get together a patch including a new version of =comint-strip-ctrl-m= named something different of course, and updating the documentation that I can track down. > > > > > > > > I do just anticipate this to take a little time as this would be my first contribution to the project and I'm still learning my way around. If all this is amenable to you I'll move forward with my solution and get a patch sent in soon. > > > > > > Yes, please go ahead, and thanks. > > > > Did you have an opportunity to make some progress? > > > > > > > > > > > >
bug-gnu-emacs@HIDDEN:bug#69914; Package emacs.
Full text available.Received: (at 69914) by debbugs.gnu.org; 14 Dec 2024 09:33:21 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Dec 14 04:33:21 2024 Received: from localhost ([127.0.0.1]:45441 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tMOWS-0006WX-F1 for submit <at> debbugs.gnu.org; Sat, 14 Dec 2024 04:33:20 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35796) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tMOWP-0006WH-74 for 69914 <at> debbugs.gnu.org; Sat, 14 Dec 2024 04:33:14 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1tMOWJ-0008TJ-Vg; Sat, 14 Dec 2024 04:33:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=EDeRtszalhe6Gkr9RzKtW6DfORN/UvJbRxTN06F+Ccc=; b=GTfNi5WUntDA f/JiC1n6/5mMZJBnw3i81Mh6HGbXEJTS+SeyQatxdgsBKI+q+ZCYfqTUp9jGAt4Ca7AcoPpFZ1saQ GMhod1LmlXo+QqvoLJnGUVgIYrCMREeViR1SVd1BKBluGPB7cXUsVEl6/Zgic/NVJb0J3p9oBOfVy WYfZt0U39f5FnQRN/QGbWLbGBGjbbIjNk0IAjSz1A4o6tQAyYH48zKRuA+J0cGJIaqZQ/tM6TYJSq KBDJ4oGJbQNKefCNMbA4EPQlKtIQkzA6qXJoxR79K/9EcaaGgnr30g95yWoVkKZgTGFmEXfnDRLJJ JtVJARh2GLuzepiurY1ewg==; Date: Sat, 14 Dec 2024 11:33:04 +0200 Message-Id: <865xnmwqwf.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: public@HIDDEN In-Reply-To: <86a5dh9hp1.fsf@HIDDEN> (message from Eli Zaretskii on Sat, 30 Nov 2024 11:47:22 +0200) Subject: Re: bug#69914: comint-strip-ctrl-m doesn't function as documentation states References: <kWMjSzKANkjXjPs49Bb449174wXkfwg1AhbKEp-6Gi9eTpRRLlpt70_FIR0WnhBzYf3fh-uJ2BzoHE7L3kV7mvYAMdnK8VSVnzhCYs_IIhM=@jds.work> <86il1dz9pz.fsf@HIDDEN> <865xwu50l0.fsf@HIDDEN> <86a5lrf3j5.fsf@HIDDEN> <a8hHrnxxOCOEJTucfjfjuQozR9OpqVje730jyo89QdycLgBGJEDUM_X_QUrSaUEtDRmmQFuwKZwp6Zr7hmYVcdK3mFNr_adPNwLd2XTmbzQ=@jds.work> <86ttcajish.fsf@HIDDEN> <86a5dh9hp1.fsf@HIDDEN> X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: 69914 Cc: 69914 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.3 (-) Ping! > Cc: 69914 <at> debbugs.gnu.org > Date: Sat, 30 Nov 2024 11:47:22 +0200 > From: Eli Zaretskii <eliz@HIDDEN> > > > Cc: 69914 <at> debbugs.gnu.org > > Date: Thu, 14 Nov 2024 10:55:58 +0200 > > From: Eli Zaretskii <eliz@HIDDEN> > > > > > Date: Sun, 03 Nov 2024 02:54:14 +0000 > > > From: Jonathan <public@HIDDEN> > > > Cc: 69914 <at> debbugs.gnu.org > > > > > > My apologies. This completely dropped off my radar as a few life events took precedence over the past few months and took me away from this. Things are more settled now though. > > > > > > I do agree this appears to be a common trend among the comint filter functions. I will get together a patch including a new version of =comint-strip-ctrl-m= named something different of course, and updating the documentation that I can track down. > > > > > > I do just anticipate this to take a little time as this would be my first contribution to the project and I'm still learning my way around. If all this is amenable to you I'll move forward with my solution and get a patch sent in soon. > > > > Yes, please go ahead, and thanks. > > Did you have an opportunity to make some progress? > > > >
bug-gnu-emacs@HIDDEN:bug#69914; Package emacs.
Full text available.Received: (at 69914) by debbugs.gnu.org; 30 Nov 2024 09:47:34 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 30 04:47:34 2024 Received: from localhost ([127.0.0.1]:45444 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tHK4c-0006MF-2G for submit <at> debbugs.gnu.org; Sat, 30 Nov 2024 04:47:34 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tHK4Z-0006Lr-Vn for 69914 <at> debbugs.gnu.org; Sat, 30 Nov 2024 04:47:32 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1tHK4T-0004VG-JP; Sat, 30 Nov 2024 04:47:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=tp0+GMUVnOfIFXbMEaBixK/4qNdY8MlS15RLE89Rqu8=; b=LfGbp/TlO6Jp V5ZJmeQLxv6qqlgrUyE8i2dSeOLvxk9iZ3xkERo1zQ69eNCbtKGZaaehaQfo4QvVQ1FY1Vhrno2Kr gtZBYs+Ac6ZveXC5JscUftjdfFSMnxvpbmYbEPVKnknxeJn8lyzMqQM36QnhB5n3CIibDDqvjbQyg M0qGWk9l43vSkghg68G5MZJLM8L7OS0vUndDpKqwj1EwZjiTvnpU4hr0QpURzr2vtec+dkrizz+Yz Q4V3ga56y12fi/NKgrY7edLQ7ovmSPZxXwqgU8SkKHI+Kxc/dktE/4rGnZ+ZlJnU3i+Xk2pIGGRa7 ZSUT4lSrvwdcfHMNiMHhPg==; Date: Sat, 30 Nov 2024 11:47:22 +0200 Message-Id: <86a5dh9hp1.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: public@HIDDEN In-Reply-To: <86ttcajish.fsf@HIDDEN> (message from Eli Zaretskii on Thu, 14 Nov 2024 10:55:58 +0200) Subject: Re: bug#69914: comint-strip-ctrl-m doesn't function as documentation states References: <kWMjSzKANkjXjPs49Bb449174wXkfwg1AhbKEp-6Gi9eTpRRLlpt70_FIR0WnhBzYf3fh-uJ2BzoHE7L3kV7mvYAMdnK8VSVnzhCYs_IIhM=@jds.work> <86il1dz9pz.fsf@HIDDEN> <865xwu50l0.fsf@HIDDEN> <86a5lrf3j5.fsf@HIDDEN> <a8hHrnxxOCOEJTucfjfjuQozR9OpqVje730jyo89QdycLgBGJEDUM_X_QUrSaUEtDRmmQFuwKZwp6Zr7hmYVcdK3mFNr_adPNwLd2XTmbzQ=@jds.work> <86ttcajish.fsf@HIDDEN> X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: 69914 Cc: 69914 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.3 (-) > Cc: 69914 <at> debbugs.gnu.org > Date: Thu, 14 Nov 2024 10:55:58 +0200 > From: Eli Zaretskii <eliz@HIDDEN> > > > Date: Sun, 03 Nov 2024 02:54:14 +0000 > > From: Jonathan <public@HIDDEN> > > Cc: 69914 <at> debbugs.gnu.org > > > > My apologies. This completely dropped off my radar as a few life events took precedence over the past few months and took me away from this. Things are more settled now though. > > > > I do agree this appears to be a common trend among the comint filter functions. I will get together a patch including a new version of =comint-strip-ctrl-m= named something different of course, and updating the documentation that I can track down. > > > > I do just anticipate this to take a little time as this would be my first contribution to the project and I'm still learning my way around. If all this is amenable to you I'll move forward with my solution and get a patch sent in soon. > > Yes, please go ahead, and thanks. Did you have an opportunity to make some progress?
bug-gnu-emacs@HIDDEN:bug#69914; Package emacs.
Full text available.Received: (at 69914) by debbugs.gnu.org; 14 Nov 2024 08:56:29 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 14 03:56:29 2024 Received: from localhost ([127.0.0.1]:44974 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tBVeP-0002KS-Af for submit <at> debbugs.gnu.org; Thu, 14 Nov 2024 03:56:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1tBVeN-0002KE-61 for 69914 <at> debbugs.gnu.org; Thu, 14 Nov 2024 03:56:27 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1tBVeH-0003LS-RX; Thu, 14 Nov 2024 03:56:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=3BgJ/FSPxuMkV/fWhsFSyFhZUl4aZCuEguTJFqrJsI4=; b=jKlVxFOE0oQb Cd/Ztz0e+JZB3TxCaHJ9I2UMez27SGNevqt7dQxNCtPA7ExM0J+Y8ev3XdrTWyklgyEMYScY1kQmn 35P4cTDPhf9ox7s++5/Ig/swwj5ND/yQAbQwP1FXLF+rLL9bOHxxdDvyvY/i2dQUA/YMW9yncJ2xQ K7ys6a3U7gdJvhn/+3dgxgEmMI/B6rvd2A7bJJ5NIQrIUqpjcSh7vcqVaUhRJEG4zdQUocfGWsORM 4NuGhsNWW8keElXPT6kEISBNxTb+pefsc/WKh3xY0+EbUXSqaSxAr1lixxUsMAfzyg2HvG2lmzIH2 HhUAgNcxR5HXx0dwLEweXg==; Date: Thu, 14 Nov 2024 10:55:58 +0200 Message-Id: <86ttcajish.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Jonathan <public@HIDDEN> In-Reply-To: <a8hHrnxxOCOEJTucfjfjuQozR9OpqVje730jyo89QdycLgBGJEDUM_X_QUrSaUEtDRmmQFuwKZwp6Zr7hmYVcdK3mFNr_adPNwLd2XTmbzQ=@jds.work> (message from Jonathan on Sun, 03 Nov 2024 02:54:14 +0000) Subject: Re: bug#69914: comint-strip-ctrl-m doesn't function as documentation states References: <kWMjSzKANkjXjPs49Bb449174wXkfwg1AhbKEp-6Gi9eTpRRLlpt70_FIR0WnhBzYf3fh-uJ2BzoHE7L3kV7mvYAMdnK8VSVnzhCYs_IIhM=@jds.work> <86il1dz9pz.fsf@HIDDEN> <865xwu50l0.fsf@HIDDEN> <86a5lrf3j5.fsf@HIDDEN> <a8hHrnxxOCOEJTucfjfjuQozR9OpqVje730jyo89QdycLgBGJEDUM_X_QUrSaUEtDRmmQFuwKZwp6Zr7hmYVcdK3mFNr_adPNwLd2XTmbzQ=@jds.work> X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: 69914 Cc: 69914 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.3 (-) > Date: Sun, 03 Nov 2024 02:54:14 +0000 > From: Jonathan <public@HIDDEN> > Cc: 69914 <at> debbugs.gnu.org > > My apologies. This completely dropped off my radar as a few life events took precedence over the past few months and took me away from this. Things are more settled now though. > > I do agree this appears to be a common trend among the comint filter functions. I will get together a patch including a new version of =comint-strip-ctrl-m= named something different of course, and updating the documentation that I can track down. > > I do just anticipate this to take a little time as this would be my first contribution to the project and I'm still learning my way around. If all this is amenable to you I'll move forward with my solution and get a patch sent in soon. Yes, please go ahead, and thanks.
bug-gnu-emacs@HIDDEN:bug#69914; Package emacs.
Full text available.
Received: (at 69914) by debbugs.gnu.org; 3 Nov 2024 02:54:30 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 02 22:54:30 2024
Received: from localhost ([127.0.0.1]:57267 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1t7Ql3-00038B-N3
for submit <at> debbugs.gnu.org; Sat, 02 Nov 2024 22:54:30 -0400
Received: from mail-4317.proton.ch ([185.70.43.17]:59245)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <public@HIDDEN>) id 1t7Qkz-000380-7J
for 69914 <at> debbugs.gnu.org; Sat, 02 Nov 2024 22:54:27 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jds.work;
s=protonmail2; t=1730602458; x=1730861658;
bh=+iMzmxbY2zqJjAMBc4F7w1LiVoN4XDJPj8VP7z92tRg=;
h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:
Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:
Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;
b=O2h24BXqTBJ1139O0MqSRXa7/gjYc+Wd5s80kDGJh95aj18Gw0Fzz0KHYUol2YEAq
fSxa/uCnDTdb3dVGaIuDM5jacLVg5/wLXyyEAJTAqT2JHW/8baZS2/7V2bI5kNHvod
pmHBtf6btxqFWXnA5gwb9uPR+3PSHTvY1lG492X7WpJgUPl4ZJecw92idNE5PWfiY+
qJcCA1cIXc1DgEgTW3XWZtHe9jjlaHgds7KZCKtlgh9/ZUTvKWwLdSJUUCfK9L8zYv
sDvsNy5dt3ULeBp0L9G0In1Fm5qcW2OERuEplxQlA7tCQPZLJgpxv2If7056RvWpqP
/jpjBvSkNFqMA==
Date: Sun, 03 Nov 2024 02:54:14 +0000
To: Eli Zaretskii <eliz@HIDDEN>
From: Jonathan <public@HIDDEN>
Subject: Re: bug#69914: comint-strip-ctrl-m doesn't function as documentation
states
Message-ID: <a8hHrnxxOCOEJTucfjfjuQozR9OpqVje730jyo89QdycLgBGJEDUM_X_QUrSaUEtDRmmQFuwKZwp6Zr7hmYVcdK3mFNr_adPNwLd2XTmbzQ=@jds.work>
In-Reply-To: <86a5lrf3j5.fsf@HIDDEN>
References: <kWMjSzKANkjXjPs49Bb449174wXkfwg1AhbKEp-6Gi9eTpRRLlpt70_FIR0WnhBzYf3fh-uJ2BzoHE7L3kV7mvYAMdnK8VSVnzhCYs_IIhM=@jds.work>
<86il1dz9pz.fsf@HIDDEN> <865xwu50l0.fsf@HIDDEN> <86a5lrf3j5.fsf@HIDDEN>
Feedback-ID: 104505699:user:proton
X-Pm-Message-ID: e5f2ccd72eb48ec925d70096b438b8565caa53ce
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 2.5 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: My apologies. This completely dropped off my radar as a few
life events took precedence over the past few months and took me away from
this. Things are more settled now though. I do agree this appears to be a
common trend among the comint filter functions. I will get together a patch
including a new version of =comint-strip-ctrl-m= named something different
of course, and up [...]
Content analysis details: (2.5 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs
[URI: jds.work (work)]
0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The
query to Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243
for more information.
[185.70.43.17 listed in sa-accredit.habeas.com]
0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4)
[185.70.43.17 listed in wl.mailspike.net]
0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The
query to Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243
for more information.
[185.70.43.17 listed in bl.score.senderscore.com]
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
-0.0 SPF_PASS SPF: sender matches SPF record
0.5 FROM_SUSPICIOUS_NTLD From abused NTLD
0.0 RCVD_IN_MSPIKE_WL Mailspike good senders
X-Debbugs-Envelope-To: 69914
Cc: 69914 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 2.5 (++)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: My apologies. This completely dropped off my radar as a few
life events took precedence over the past few months and took me away from
this. Things are more settled now though. I do agree this appears to be a
common trend among the comint filter functions. I will get together a patch
including a new version of =comint-strip-ctrl-m= named something different
of course, and up [...]
Content analysis details: (2.5 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The
query to Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243
for more information.
[185.70.43.17 listed in sa-accredit.habeas.com]
0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4)
[185.70.43.17 listed in wl.mailspike.net]
0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The
query to Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243
for more information.
[185.70.43.17 listed in bl.score.senderscore.com]
2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs
[URI: jds.work (work)]
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
-0.0 SPF_PASS SPF: sender matches SPF record
0.5 FROM_SUSPICIOUS_NTLD From abused NTLD
0.0 RCVD_IN_MSPIKE_WL Mailspike good senders
1.0 BULK_RE_SUSP_NTLD Precedence bulk and RE: from a suspicious TLD
-1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list
manager
My apologies. This completely dropped off my radar as a few life events too=
k precedence over the past few months and took me away from this. Things ar=
e more settled now though.
I do agree this appears to be a common trend among the comint filter functi=
ons. I will get together a patch including a new version of =3Dcomint-strip=
-ctrl-m=3D named something different of course, and updating the documentat=
ion that I can track down.
I do just anticipate this to take a little time as this would be my first c=
ontribution to the project and I'm still learning my way around. If all thi=
s is amenable to you I'll move forward with my solution and get a patch sen=
t in soon.=20
On Thursday, April 18th, 2024 at 4:01 AM, Eli Zaretskii <eliz@HIDDEN> wrot=
e:
>=20
>=20
> Ping! Ping! Any interest in pursuing this issue further? If so,
> could you please answer my questions below?
>=20
> > Cc: 69914 <at> debbugs.gnu.org
> > Date: Sat, 06 Apr 2024 11:58:51 +0300
> > From: Eli Zaretskii eliz@HIDDEN
> >=20
> > Ping! Could you please answer my questions below?
> >=20
> > > Cc: 69914 <at> debbugs.gnu.org
> > > Date: Sat, 23 Mar 2024 09:30:16 +0200
> > > From: Eli Zaretskii eliz@HIDDEN
> > >=20
> > > > Date: Wed, 20 Mar 2024 14:15:39 +0000
> > > > From: Jonathan via "Bug reports for GNU Emacs,
> > > > the Swiss army knife of text editors" bug-gnu-emacs@HIDDEN
> > > >=20
> > > > There appears to either be a bug or just inaccurate documentation o=
f =3Dcomint-strip-ctrl-m=3D. At the very bottom, I've included some context=
about my use case by which I discovered this bug that may or may not be re=
levant to you. The documentation for that function states:
> > > >=20
> > > > #+begin_quote
> > > > Strip trailing ^M characters from the current output group.
> > > >=20
> > > > This function could be on comint-output-filter-functions or bound t=
o a key.
> > > > #+end_quote
> > > >=20
> > > > =3Dcomint-output-filter-functions=3D states the following:
> > > >=20
> > > > #+begin_quote
> > > > ...These functions get one argument, a string containing the text a=
s originally
> > > > inserted. Note that this might not be the same as the buffer conten=
ts between
> > > > comint-last-output-start and the buffer's process-mark, if other fi=
lter
> > > > functions have already modified the buffer.
> > > > #+end_quote
> > > >=20
> > > > Looking at the implementation of =3Dcomint-strip-ctrl-m=3D it appea=
rs that it completely ignores the =3Dstring=3D argument and instead uses =
=3D(get-buffer-process (current-buffer))=3D in direct contradiction to the =
documentation.
> > >=20
> > > Actually, AFAICT, almost all of the filtering functions intended for
> > > comint-output-filter-functions ignore its string argument. Isn't that
> > > so?
> > >=20
> > > > #+begin_src emacs-lisp
> > > > (defun comint-strip-ctrl-m (&optional _string interactive)
> > > > "Strip trailing `^M' characters from the current output group. This=
function could be on` comint-output-filter-functions' or bound to a key."
> > > > (interactive (list nil t))
> > > > (let ((process (get-buffer-process (current-buffer))))
> > > > (if (not process)
> > > > ;; This function may be used in
> > > > ;; `comint-output-filter-functions', and in that case, if
> > > > ;; there's no process, then we should do nothing. If
> > > > ;; interactive, report an error.
> > > > (when interactive
> > > > (error "No process in the current buffer"))
> > > > ;;; rest omitted for brevity
> > > > )))
> > > > #+end_src
> > > >=20
> > > > This represents unexpected and undocumented behavior, as you antici=
pate =3Dcomint-strip-ctrl-m=3D to behave like any other comint output filte=
r functions. I'd like to propose 3 different possible solutions for a patch=
and would like input on which is preferred as this code was originally int=
roduced in 1994. I can submit a patch once a solution has been determined.
> > >=20
> > > Given that almost all the filter functions behave the same (unless yo=
u
> > > disagree), it sounds like ignoring the string is a de-facto standard
> > > behavior. So we should document that, and I guess adding a new
> > > function, without deprecating the existing one, is the most reasonabl=
e
> > > way ahead?
bug-gnu-emacs@HIDDEN:bug#69914; Package emacs.
Full text available.Received: (at 69914) by debbugs.gnu.org; 18 Apr 2024 09:01:53 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Apr 18 05:01:52 2024 Received: from localhost ([127.0.0.1]:51170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rxNeN-00089n-MD for submit <at> debbugs.gnu.org; Thu, 18 Apr 2024 05:01:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60582) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1rxNeH-000883-N4 for 69914 <at> debbugs.gnu.org; Thu, 18 Apr 2024 05:01:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1rxNdy-0000Sz-V2; Thu, 18 Apr 2024 05:01:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=aESb7rh+zgsQ/y0oogZTfFvqQ2joNNF117UBDDkfUZM=; b=NB/E6P3zJCmQ meY2ED6IKxhBOJN68q1W4Voae56PshBo/FJkIbeCP1wiaABxWF1lD9LI4mE3hqvxQkSxVJWPPfT15 fMAu3Ax/5kwaslfpISC9IgNg01wdftM3Ggvf6vO8VmPrk8rS02I+UC8NB3Riid8IGT5RDtP4rJ5jz oDe7SDHRxSgtVwMFC1Dh/9dcNAXSLtkJeEZd7sMR5w2sbZmy6xMtMsu32/qnHpTYyGW8pI2fucE+f 0y1SGaYQgGS5Tn9Xbv0K4O7hzYfreV31CUrxYa1itF7iIIYq7rG7s7EGv4X7e3I2EC4wabtPz6HTY IHpkrS0xKH1zy/fp75hh8A==; Date: Thu, 18 Apr 2024 12:01:18 +0300 Message-Id: <86a5lrf3j5.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: public@HIDDEN In-Reply-To: <865xwu50l0.fsf@HIDDEN> (message from Eli Zaretskii on Sat, 06 Apr 2024 11:58:51 +0300) Subject: Re: bug#69914: comint-strip-ctrl-m doesn't function as documentation states References: <kWMjSzKANkjXjPs49Bb449174wXkfwg1AhbKEp-6Gi9eTpRRLlpt70_FIR0WnhBzYf3fh-uJ2BzoHE7L3kV7mvYAMdnK8VSVnzhCYs_IIhM=@jds.work> <86il1dz9pz.fsf@HIDDEN> <865xwu50l0.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 69914 Cc: 69914 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Ping! Ping! Any interest in pursuing this issue further? If so, could you please answer my questions below? > Cc: 69914 <at> debbugs.gnu.org > Date: Sat, 06 Apr 2024 11:58:51 +0300 > From: Eli Zaretskii <eliz@HIDDEN> > > Ping! Could you please answer my questions below? > > > Cc: 69914 <at> debbugs.gnu.org > > Date: Sat, 23 Mar 2024 09:30:16 +0200 > > From: Eli Zaretskii <eliz@HIDDEN> > > > > > Date: Wed, 20 Mar 2024 14:15:39 +0000 > > > From: Jonathan via "Bug reports for GNU Emacs, > > > the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> > > > > > > There appears to either be a bug or just inaccurate documentation of =comint-strip-ctrl-m=. At the very bottom, I've included some context about my use case by which I discovered this bug that may or may not be relevant to you. The documentation for that function states: > > > > > > #+begin_quote > > > Strip trailing ^M characters from the current output group. > > > > > > This function could be on comint-output-filter-functions or bound to a key. > > > #+end_quote > > > > > > =comint-output-filter-functions= states the following: > > > > > > #+begin_quote > > > ...These functions get one argument, a string containing the text as originally > > > inserted. Note that this might not be the same as the buffer contents between > > > comint-last-output-start and the buffer's process-mark, if other filter > > > functions have already modified the buffer. > > > #+end_quote > > > > > > Looking at the implementation of =comint-strip-ctrl-m= it appears that it completely ignores the =string= argument and instead uses =(get-buffer-process (current-buffer))= in direct contradiction to the documentation. > > > > Actually, AFAICT, almost all of the filtering functions intended for > > comint-output-filter-functions ignore its string argument. Isn't that > > so? > > > > > #+begin_src emacs-lisp > > > (defun comint-strip-ctrl-m (&optional _string interactive) > > > "Strip trailing `^M' characters from the current output group. > > > This function could be on `comint-output-filter-functions' or bound to a key." > > > (interactive (list nil t)) > > > (let ((process (get-buffer-process (current-buffer)))) > > > (if (not process) > > > ;; This function may be used in > > > ;; `comint-output-filter-functions', and in that case, if > > > ;; there's no process, then we should do nothing. If > > > ;; interactive, report an error. > > > (when interactive > > > (error "No process in the current buffer")) > > > ;;; rest omitted for brevity > > > ))) > > > #+end_src > > > > > > This represents unexpected and undocumented behavior, as you anticipate =comint-strip-ctrl-m= to behave like any other comint output filter functions. I'd like to propose 3 different possible solutions for a patch and would like input on which is preferred as this code was originally introduced in 1994. I can submit a patch once a solution has been determined. > > > > Given that almost all the filter functions behave the same (unless you > > disagree), it sounds like ignoring the string is a de-facto standard > > behavior. So we should document that, and I guess adding a new > > function, without deprecating the existing one, is the most reasonable > > way ahead? > > > > > > > > > > > >
bug-gnu-emacs@HIDDEN:bug#69914; Package emacs.
Full text available.Received: (at 69914) by debbugs.gnu.org; 6 Apr 2024 08:59:09 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 06 04:59:09 2024 Received: from localhost ([127.0.0.1]:38242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rt1tF-0006wg-5H for submit <at> debbugs.gnu.org; Sat, 06 Apr 2024 04:59:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50356) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1rt1tD-0006wU-70 for 69914 <at> debbugs.gnu.org; Sat, 06 Apr 2024 04:59:07 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1rt1t1-0007nj-OW; Sat, 06 Apr 2024 04:58:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=y9qd6qi0WWHi976OiASI9Do7P+1qzH4bNavqiUaUTgo=; b=rQUf78/kkGE4 0oKO7OqCvA3TgAqf9TBiKuDdxmvgKeu0wKJsjKQJywtEGzwh2bbPXc6GUs7Yp4WOcRSlxraExKHW8 eQX6s0aooABGGxnNAbdckjkdlxzXL79hMNoMdnWEKsz3Vgwtd8W3akkXdihjwuEzdPeIPUTNHGyfN /gmDAoIEFQu/3Rc9FFo841oHRyoIcvd9d+/tV8xGU1t+wsU6I9/Jja/Bxcb712XLAOXROGdJOAf/y xdmc+/djQYj0B+emMiqPhc34uR9TgSkI6GjeNy3YMGjE41Br/3KKHifAO9TqE34DGKE2vnwXadr/i HswRS9mUx9uM0gOPXXYAdA==; Date: Sat, 06 Apr 2024 11:58:51 +0300 Message-Id: <865xwu50l0.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: public@HIDDEN In-Reply-To: <86il1dz9pz.fsf@HIDDEN> (message from Eli Zaretskii on Sat, 23 Mar 2024 09:30:16 +0200) Subject: Re: bug#69914: comint-strip-ctrl-m doesn't function as documentation states References: <kWMjSzKANkjXjPs49Bb449174wXkfwg1AhbKEp-6Gi9eTpRRLlpt70_FIR0WnhBzYf3fh-uJ2BzoHE7L3kV7mvYAMdnK8VSVnzhCYs_IIhM=@jds.work> <86il1dz9pz.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 69914 Cc: 69914 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Ping! Could you please answer my questions below? > Cc: 69914 <at> debbugs.gnu.org > Date: Sat, 23 Mar 2024 09:30:16 +0200 > From: Eli Zaretskii <eliz@HIDDEN> > > > Date: Wed, 20 Mar 2024 14:15:39 +0000 > > From: Jonathan via "Bug reports for GNU Emacs, > > the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> > > > > There appears to either be a bug or just inaccurate documentation of =comint-strip-ctrl-m=. At the very bottom, I've included some context about my use case by which I discovered this bug that may or may not be relevant to you. The documentation for that function states: > > > > #+begin_quote > > Strip trailing ^M characters from the current output group. > > > > This function could be on comint-output-filter-functions or bound to a key. > > #+end_quote > > > > =comint-output-filter-functions= states the following: > > > > #+begin_quote > > ...These functions get one argument, a string containing the text as originally > > inserted. Note that this might not be the same as the buffer contents between > > comint-last-output-start and the buffer's process-mark, if other filter > > functions have already modified the buffer. > > #+end_quote > > > > Looking at the implementation of =comint-strip-ctrl-m= it appears that it completely ignores the =string= argument and instead uses =(get-buffer-process (current-buffer))= in direct contradiction to the documentation. > > Actually, AFAICT, almost all of the filtering functions intended for > comint-output-filter-functions ignore its string argument. Isn't that > so? > > > #+begin_src emacs-lisp > > (defun comint-strip-ctrl-m (&optional _string interactive) > > "Strip trailing `^M' characters from the current output group. > > This function could be on `comint-output-filter-functions' or bound to a key." > > (interactive (list nil t)) > > (let ((process (get-buffer-process (current-buffer)))) > > (if (not process) > > ;; This function may be used in > > ;; `comint-output-filter-functions', and in that case, if > > ;; there's no process, then we should do nothing. If > > ;; interactive, report an error. > > (when interactive > > (error "No process in the current buffer")) > > ;;; rest omitted for brevity > > ))) > > #+end_src > > > > This represents unexpected and undocumented behavior, as you anticipate =comint-strip-ctrl-m= to behave like any other comint output filter functions. I'd like to propose 3 different possible solutions for a patch and would like input on which is preferred as this code was originally introduced in 1994. I can submit a patch once a solution has been determined. > > Given that almost all the filter functions behave the same (unless you > disagree), it sounds like ignoring the string is a de-facto standard > behavior. So we should document that, and I guess adding a new > function, without deprecating the existing one, is the most reasonable > way ahead? > > > >
bug-gnu-emacs@HIDDEN:bug#69914; Package emacs.
Full text available.Received: (at 69914) by debbugs.gnu.org; 23 Mar 2024 08:10:24 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Mar 23 04:10:24 2024 Received: from localhost ([127.0.0.1]:35100 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rnwSN-0004cO-Ka for submit <at> debbugs.gnu.org; Sat, 23 Mar 2024 04:10:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1rnw5C-0003Oq-U5 for 69914 <at> debbugs.gnu.org; Sat, 23 Mar 2024 03:46:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1rnvpZ-0003On-1V; Sat, 23 Mar 2024 03:30:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Ui/KA+vl200APlzNiWDagp4WJeEXwbprAg2XvWoLd7Q=; b=kM/+XnBMhVBb qBFIMvDbtGQpF9M0YE8TzLUyoWS6G8goF29mM055LeGYUVjxf27ZvzMDWLh/D1RFTt1GmNzOot74O 4cP3UiKQp1y/LmbaK9vWopDEOnqFT+npUogd67K64+C10pOwHkfz/6y+fGR42ywcJztONKidW3eE2 xkXOrVjoo6sBCb2zoGzJcuVR4dAatIXr5QQgADsQpELj6jiedTYoN4S1hTEGpix2Ud18WrYTzGlQ4 Kwcdp1aeTYthpHNaEChQRZEVhSB0jdBYRxjnjf2E9Ou52ze6CD6x9tn/0aVScnQWtv4x8miudozix N4CA2RtGkY5lx+dzCiUt3g==; Date: Sat, 23 Mar 2024 09:30:16 +0200 Message-Id: <86il1dz9pz.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Jonathan <public@HIDDEN> In-Reply-To: <kWMjSzKANkjXjPs49Bb449174wXkfwg1AhbKEp-6Gi9eTpRRLlpt70_FIR0WnhBzYf3fh-uJ2BzoHE7L3kV7mvYAMdnK8VSVnzhCYs_IIhM=@jds.work> (bug-gnu-emacs@HIDDEN) Subject: Re: bug#69914: comint-strip-ctrl-m doesn't function as documentation states References: <kWMjSzKANkjXjPs49Bb449174wXkfwg1AhbKEp-6Gi9eTpRRLlpt70_FIR0WnhBzYf3fh-uJ2BzoHE7L3kV7mvYAMdnK8VSVnzhCYs_IIhM=@jds.work> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 69914 Cc: 69914 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Wed, 20 Mar 2024 14:15:39 +0000 > From: Jonathan via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> > > There appears to either be a bug or just inaccurate documentation of =comint-strip-ctrl-m=. At the very bottom, I've included some context about my use case by which I discovered this bug that may or may not be relevant to you. The documentation for that function states: > > #+begin_quote > Strip trailing ^M characters from the current output group. > > This function could be on comint-output-filter-functions or bound to a key. > #+end_quote > > =comint-output-filter-functions= states the following: > > #+begin_quote > ...These functions get one argument, a string containing the text as originally > inserted. Note that this might not be the same as the buffer contents between > comint-last-output-start and the buffer's process-mark, if other filter > functions have already modified the buffer. > #+end_quote > > Looking at the implementation of =comint-strip-ctrl-m= it appears that it completely ignores the =string= argument and instead uses =(get-buffer-process (current-buffer))= in direct contradiction to the documentation. Actually, AFAICT, almost all of the filtering functions intended for comint-output-filter-functions ignore its string argument. Isn't that so? > #+begin_src emacs-lisp > (defun comint-strip-ctrl-m (&optional _string interactive) > "Strip trailing `^M' characters from the current output group. > This function could be on `comint-output-filter-functions' or bound to a key." > (interactive (list nil t)) > (let ((process (get-buffer-process (current-buffer)))) > (if (not process) > ;; This function may be used in > ;; `comint-output-filter-functions', and in that case, if > ;; there's no process, then we should do nothing. If > ;; interactive, report an error. > (when interactive > (error "No process in the current buffer")) > ;;; rest omitted for brevity > ))) > #+end_src > > This represents unexpected and undocumented behavior, as you anticipate =comint-strip-ctrl-m= to behave like any other comint output filter functions. I'd like to propose 3 different possible solutions for a patch and would like input on which is preferred as this code was originally introduced in 1994. I can submit a patch once a solution has been determined. Given that almost all the filter functions behave the same (unless you disagree), it sounds like ignoring the string is a de-facto standard behavior. So we should document that, and I guess adding a new function, without deprecating the existing one, is the most reasonable way ahead?
bug-gnu-emacs@HIDDEN:bug#69914; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 20 Mar 2024 14:20:46 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Mar 20 10:20:46 2024
Received: from localhost ([127.0.0.1]:47995 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rmwo4-0002ez-RX
for submit <at> debbugs.gnu.org; Wed, 20 Mar 2024 10:20:46 -0400
Received: from lists.gnu.org ([209.51.188.17]:46652)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <public@HIDDEN>) id 1rmwkR-0002W4-FU
for submit <at> debbugs.gnu.org; Wed, 20 Mar 2024 10:16:56 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <public@HIDDEN>) id 1rmwjn-0000gG-Km
for bug-gnu-emacs@HIDDEN; Wed, 20 Mar 2024 10:16:15 -0400
Received: from mail-40136.proton.ch ([185.70.40.136])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <public@HIDDEN>) id 1rmwjk-0005kP-Cb
for bug-gnu-emacs@HIDDEN; Wed, 20 Mar 2024 10:16:15 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jds.work;
s=protonmail; t=1710944169; x=1711203369;
bh=VN+Vlq2I1tRIu82vYvMnfPgX3Y8Rx+yh86aLEQMrZXw=;
h=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date:
Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector;
b=SniNoX3ZxTA+3Vij56Bo0I5zmVvHoCQh9Us42K/pE5+6s3U5j8SCQncgAsX7ChpGm
hBJj2V0tUZKrhPhsBH8iUZIVGKtLVHRR1VGBSeGSpw6jnumYFopnvUr9yxuXZ6gcRw
lPSGS7CadXEckwG12/oaKi0vyfnyq5TBAYy52r0SkCTP848wfbD4tzff24ofPw9Jcj
6Ucz24VXLadAN/mSpg4CYXV8bJ9A/Kc8Z4qzB7L1Dh8SZeXE29G4XquTSlC5PI+lXi
xCFy3NptEVIzOhK9KCRF0dg5pUc2rbUcG55vF1ldajrHhAicTn5LBRXXrvatvFqkF/
+s4sgeOI91f5g==
Date: Wed, 20 Mar 2024 14:15:39 +0000
To: "bug-gnu-emacs@HIDDEN" <bug-gnu-emacs@HIDDEN>
From: Jonathan <public@HIDDEN>
Subject: comint-strip-ctrl-m doesn't function as documentation states
Message-ID: <kWMjSzKANkjXjPs49Bb449174wXkfwg1AhbKEp-6Gi9eTpRRLlpt70_FIR0WnhBzYf3fh-uJ2BzoHE7L3kV7mvYAMdnK8VSVnzhCYs_IIhM=@jds.work>
Feedback-ID: 104505699:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass client-ip=185.70.40.136; envelope-from=public@HIDDEN;
helo=mail-40136.proton.ch
X-Spam_score_int: 4
X-Spam_score: 0.4
X-Spam_bar: /
X-Spam_report: (0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1,
DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_SUSPICIOUS_NTLD=0.499,
FROM_SUSPICIOUS_NTLD_FP=1.999, RCVD_IN_MSPIKE_H4=0.001,
RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001,
T_PDS_OTHER_BAD_TLD=0.01,
T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.2 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Hey folks,
There appears to either be a bug or just inaccurate
documentation of =comint-strip-ctrl-m=. At the very bottom, I've included
some context about my use case by which I discovered this bug that may or
[...] Content analysis details: (1.2 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/,
medium trust [209.51.188.17 listed in list.dnswl.org]
1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail)
0.0 T_PDS_OTHER_BAD_TLD Untrustworthy TLDs
[URI: jds.work (work)]
-0.0 SPF_HELO_PASS SPF: HELO matches SPF record
2.0 FROM_SUSPICIOUS_NTLD_FP From abused NTLD
0.5 FROM_SUSPICIOUS_NTLD From abused NTLD
-0.0 T_SCC_BODY_TEXT_LINE No description available.
X-Debbugs-Envelope-To: submit
X-Mailman-Approved-At: Wed, 20 Mar 2024 10:20:38 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.8 (-)
Hey folks,
There appears to either be a bug or just inaccurate documentation of =3Dcom=
int-strip-ctrl-m=3D. At the very bottom, I've included some context about m=
y use case by which I discovered this bug that may or may not be relevant t=
o you. The documentation for that function states:
#+begin_quote
Strip trailing ^M characters from the current output group.
This function could be on comint-output-filter-functions or bound to a key.
#+end_quote
=3Dcomint-output-filter-functions=3D states the following:
#+begin_quote
...These functions get one argument, a string containing the text as origin=
ally
inserted. Note that this might not be the same as the buffer contents betw=
een
comint-last-output-start and the buffer's process-mark, if other filter
functions have already modified the buffer.
#+end_quote
Looking at the implementation of =3Dcomint-strip-ctrl-m=3D it appears that =
it completely ignores the =3Dstring=3D argument and instead uses =3D(get-bu=
ffer-process (current-buffer))=3D in direct contradiction to the documentat=
ion.
#+begin_src emacs-lisp
(defun comint-strip-ctrl-m (&optional _string interactive)
"Strip trailing `^M' characters from the current output group.
This function could be on `comint-output-filter-functions' or bound to a ke=
y."
(interactive (list nil t))
(let ((process (get-buffer-process (current-buffer))))
(if (not process)
;; This function may be used in
;; `comint-output-filter-functions', and in that case, if
;; there's no process, then we should do nothing. If
;; interactive, report an error.
(when interactive
(error "No process in the current buffer"))
;;; rest omitted for brevity
)))
#+end_src
This represents unexpected and undocumented behavior, as you anticipate =3D=
comint-strip-ctrl-m=3D to behave like any other comint output filter functi=
ons. I'd like to propose 3 different possible solutions for a patch and wou=
ld like input on which is preferred as this code was originally introduced =
in 1994. I can submit a patch once a solution has been determined.
1. Update the documentation and leave as is. This is the simplest solution =
and would just require doc-string updates to indicate that =3Dcomint-strip-=
ctrl-m=3D is a "unique" filter function among the other filter functions th=
at exist. This does not seem preferable to me.
2. Update the implementation of =3Dcomint-strip-ctrl-m=3D itself to conform=
it to the documented API. This would mean anything currently depending on =
it reading the =3Dcurrent-buffer=3D would break, and since there are plenty=
of unknowns in that regard, this also does not seem preferable.
3. Add a new version of the function with a different name that conforms to=
the documented API =3Dcomint-strip-ctrl-m-output=3D or something similar a=
nd deprecate the original.
If we do decide to deprecate the original, I'm happy to include a deprecati=
on warning and keep an eye on it popping up in core to ensure that we handl=
e those issues over time.
Any guidance would be useful. Thank you all for your hard work.
- Jonathan
PS: Additional Context as promised:
I was developing a package that runs SQL queries in a "hidden" SQLi buffer =
and so I needed to strip carriage return characters out of the output. Usin=
g this filter I had thought it would perform the task, but it did not. So d=
igging through the documentation I discovered this error. I think it's pret=
ty reasonable that filter functions conform to the documented api or should=
at least be noted otherwise.
Jonathan <public@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#69914; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.