Received: (at 71913) by debbugs.gnu.org; 13 Jul 2024 06:20:50 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jul 13 02:20:50 2024 Received: from localhost ([127.0.0.1]:55010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sSW7m-0006wa-De for submit <at> debbugs.gnu.org; Sat, 13 Jul 2024 02:20:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60022) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1sSW7k-0006wL-GU for 71913 <at> debbugs.gnu.org; Sat, 13 Jul 2024 02:20:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1sSW7e-0000HI-9s; Sat, 13 Jul 2024 02:20:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=OrVZ/RJXv1DE4kV3rc5WYKH9lxW79H4gKnRmmagW6ac=; b=OSfUZoja0BtH eRQkQYpUdP8ZCWgTy1JbpR5EveNIVM5hRXZYZpR6/8APTi0mcmQs+edbmGPmAwk6cBx3ZKZBov3xx njS8RkpMyhNWJxV9faHwZCfoQ5kUp2GygEmQz0p0bqSwbQ45DpWaJXJnLy9bI6haNTUhye6+HzPa2 coo5UVrWGvEYTGMwE0OLWctQ/WoAaTHrdIMV7LLRJ324WS0ev/RH8OjMfUUcozcy9ortRoJansjC6 jiZPYqTMFOaoTkU0E0cyJOGp+i0lAXVaodt3d68DT/9pkMHIZx4zn8wPmLK78t/b68y1xakIy7H9I EtEv9EzHSS3r0iKekPbv1g==; Date: Sat, 13 Jul 2024 09:20:39 +0300 Message-Id: <867cdplsnc.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Jim Porter <jporterbugs@HIDDEN> In-Reply-To: <915d9119-1f82-0f0c-4c8b-e08e41315100@HIDDEN> (message from Jim Porter on Fri, 12 Jul 2024 21:11:35 -0700) Subject: Re: bug#71913: 29.1; shr: shr-resize-image does not behave as expected References: <m2a5izyo8v.fsf@HIDDEN> <630ff886-efa1-f122-3344-4dce503d0c0c@HIDDEN> <m25xtmz0fj.fsf@HIDDEN> <CANh=_JFKyagKwzmFUW7h4dUWCp69kT+F8RrL1QS9TyM5q8LjJA@HIDDEN> <m2y169ul2u.fsf@HIDDEN> <a4a59311-ee79-6ee5-f20d-087a23f8f6fb@HIDDEN> <86zfqnkv6z.fsf@HIDDEN> <915d9119-1f82-0f0c-4c8b-e08e41315100@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71913 Cc: george@HIDDEN, 71913 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Fri, 12 Jul 2024 21:11:35 -0700 > Cc: george@HIDDEN, 71913 <at> debbugs.gnu.org > From: Jim Porter <jporterbugs@HIDDEN> > > On 7/11/2024 10:58 PM, Eli Zaretskii wrote: > > What version of librsvg did you test this with? Please test also with > > librsvg 2.40.x, as that was the last version which didn't need a Rust > > compiler to build, and so some people (including yours truly) stay > > with those old versions to this day. > > I'm usually using 2.48.x since it's what my distro provides, but I've > now tested against 2.40.21 (after a slightly bumpy road getting > everything to build correctly) and the results are the same for both > versions of librsvg. (Out of an abundance of caution, I've also verified > with 'ldd' that the correct version of librsvg is in use during these > tests.) Thanks. Then I have no objections for fixing this on the emacs-30 release branch.
bug-gnu-emacs@HIDDEN
:bug#71913
; Package emacs
.
Full text available.Received: (at 71913) by debbugs.gnu.org; 13 Jul 2024 04:12:45 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jul 13 00:12:45 2024 Received: from localhost ([127.0.0.1]:54965 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sSU7o-0000nN-UB for submit <at> debbugs.gnu.org; Sat, 13 Jul 2024 00:12:45 -0400 Received: from mail-oo1-f49.google.com ([209.85.161.49]:54320) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <jporterbugs@HIDDEN>) id 1sSU7n-0000n8-2E for 71913 <at> debbugs.gnu.org; Sat, 13 Jul 2024 00:12:44 -0400 Received: by mail-oo1-f49.google.com with SMTP id 006d021491bc7-5cdf7edddc5so247333eaf.0 for <71913 <at> debbugs.gnu.org>; Fri, 12 Jul 2024 21:12:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720843896; x=1721448696; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=zRLsjD66xeS6N3MwScLapLERQGYW5iOWLqx74wariJc=; b=Oy9WtjPmfogn4pcmCzeBEAwxLFzpMz32cy5jIyu6uGUXBBArobhRrzdTs2EMekcUcs bwAXKrJVKzPf9XuGkB7tSA6oE4CyB5+W/YOavNRu9pI+bnHTwyMCG0XCC2bG1uEld17Z p04WNFl6y8xejPiRcWxcin/9lKDsAhoEnRYFgkXExaAHUzU5rQXxGy1WMNwTsXIU/kV+ 0rMwg1Rg/G9u87dhCnaGvnmOyE3QH63GxHJ9tlFfSnibtu07Qji/P3ddOvPE4kUtdiT6 RtBC4VHgrcm9OQdCPi3VV+622scCoJjavswLcNjQkLYPkrfUU7CrrGuXR4KBPKDkDR7V CQtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720843896; x=1721448696; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zRLsjD66xeS6N3MwScLapLERQGYW5iOWLqx74wariJc=; b=NGSKrIT8KfGAGvtbO6B2bXxfLScWR2kfvW3XPYkdVjZ44qYvEjJb46ipxf4HasqX+G ahDPsyHphqeil+Qk6GX8RiJfI/GEcn27Q5cuDspfmvQRZSCHhSYZuxGgkgzEmkP2tAIE 4bcaTDMJm9mwmWMjYSRD4TOQDuiK5ifLU5MQpUA2PxDpS2PIGwC6aZQDAhwL3MwRcBXy 8qFJE5dme+5ENllIo3sDcuyPN9CGjitYSgjDm6TVD4q+3SrNO0eQ5NOlQlldz9lF8i4w 54sBoJvzTCx/LKUFIIhVk7n1GQ0ZQ2R/n8RO3SZ0yZgLoRe2ewEz7vYgdE61Z1Qo6WFU eDLw== X-Forwarded-Encrypted: i=1; AJvYcCXqqpo2HQL0H0S6F8jzAJ5CmmNe65DtT158sUbbRAcXIh4T+TxF/ItQCOIXHPqMaS5C5lNq5x74xJXD4O7ePVrGjpopwz8= X-Gm-Message-State: AOJu0YxD4J6aSEEDCNaEf0QnR039s7ee4Zg1uSgF/Ua2uHNadzISUtkj D//FRs/Xh2I0t54xwQvEk4A/jzBvaestLMbywdunoAp9fCXC3HHf X-Google-Smtp-Source: AGHT+IHCVGWvIjTc7EMrZf6UVgqB2DPKEeiBkly7QFlfPOp67yyCQ2oJNoOlxETBm6Az6uulS0qSQQ== X-Received: by 2002:a05:6358:705c:b0:1a2:598a:452e with SMTP id e5c5f4694b2df-1aade085043mr945792455d.1.1720843896440; Fri, 12 Jul 2024 21:11:36 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-78e32e49ac4sm201113a12.12.2024.07.12.21.11.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Jul 2024 21:11:36 -0700 (PDT) Message-ID: <915d9119-1f82-0f0c-4c8b-e08e41315100@HIDDEN> Date: Fri, 12 Jul 2024 21:11:35 -0700 MIME-Version: 1.0 Subject: Re: bug#71913: 29.1; shr: shr-resize-image does not behave as expected Content-Language: en-US To: Eli Zaretskii <eliz@HIDDEN> References: <m2a5izyo8v.fsf@HIDDEN> <630ff886-efa1-f122-3344-4dce503d0c0c@HIDDEN> <m25xtmz0fj.fsf@HIDDEN> <CANh=_JFKyagKwzmFUW7h4dUWCp69kT+F8RrL1QS9TyM5q8LjJA@HIDDEN> <m2y169ul2u.fsf@HIDDEN> <a4a59311-ee79-6ee5-f20d-087a23f8f6fb@HIDDEN> <86zfqnkv6z.fsf@HIDDEN> From: Jim Porter <jporterbugs@HIDDEN> In-Reply-To: <86zfqnkv6z.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71913 Cc: george@HIDDEN, 71913 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On 7/11/2024 10:58 PM, Eli Zaretskii wrote: > What version of librsvg did you test this with? Please test also with > librsvg 2.40.x, as that was the last version which didn't need a Rust > compiler to build, and so some people (including yours truly) stay > with those old versions to this day. I'm usually using 2.48.x since it's what my distro provides, but I've now tested against 2.40.21 (after a slightly bumpy road getting everything to build correctly) and the results are the same for both versions of librsvg. (Out of an abundance of caution, I've also verified with 'ldd' that the correct version of librsvg is in use during these tests.)
bug-gnu-emacs@HIDDEN
:bug#71913
; Package emacs
.
Full text available.Received: (at 71913) by debbugs.gnu.org; 12 Jul 2024 05:58:58 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jul 12 01:58:58 2024 Received: from localhost ([127.0.0.1]:53008 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sS9J3-0000YQ-TF for submit <at> debbugs.gnu.org; Fri, 12 Jul 2024 01:58:58 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33646) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1sS9J1-0000YB-Iq for 71913 <at> debbugs.gnu.org; Fri, 12 Jul 2024 01:58:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1sS9Iv-0002uT-NF; Fri, 12 Jul 2024 01:58:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=webEypETvvpwHuo9SIJ1LNo5B0+4wMohBvWAxV30Okg=; b=VneQVktC7NU3 Xd7woVA4byuHz23wE+g+5JnpHNOOiQZkblR+Kkin3wih3K3Nrg0kqxvv3pU2xxNJ8286QYbvnZLt6 ZXZyu9O3Hx0YePxAb/Od4IE8OPcHylzbLfVpqwYuavncXc9KjqSv0cHnktIazDVfoZtDbaGXh782E M1hHygkw6TDjBrLNNbymA4KdLdCLCtn1wkkKdStsxGby/mw/7VJ7hkriPDHnUprzXZA2Zmdz7FdfX r9gN1hrJqWkZWVTHcxYgbn+1WJQJANMDO6qgW8v1Q3U2TfL6MBTvv/1+9hzeY244k8yOkpb7YsxTM DhPqNXtrh5n6cpTmBblnHQ==; Date: Fri, 12 Jul 2024 08:58:44 +0300 Message-Id: <86zfqnkv6z.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Jim Porter <jporterbugs@HIDDEN> In-Reply-To: <a4a59311-ee79-6ee5-f20d-087a23f8f6fb@HIDDEN> (message from Jim Porter on Thu, 11 Jul 2024 16:51:53 -0700) Subject: Re: bug#71913: 29.1; shr: shr-resize-image does not behave as expected References: <m2a5izyo8v.fsf@HIDDEN> <630ff886-efa1-f122-3344-4dce503d0c0c@HIDDEN> <m25xtmz0fj.fsf@HIDDEN> <CANh=_JFKyagKwzmFUW7h4dUWCp69kT+F8RrL1QS9TyM5q8LjJA@HIDDEN> <m2y169ul2u.fsf@HIDDEN> <a4a59311-ee79-6ee5-f20d-087a23f8f6fb@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71913 Cc: george@HIDDEN, 71913 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Cc: 71913 <at> debbugs.gnu.org > Date: Thu, 11 Jul 2024 16:51:53 -0700 > From: Jim Porter <jporterbugs@HIDDEN> > > On 7/10/2024 12:02 PM, George Huebner wrote: > > As I understand it, this decision was likely made because the dimensions > > of SVGs is weird; they aren't inherently required to have a size, but > > the SVG itself can define a viewbox with accompanying width and height > > (full disclosure: I have no idea what I'm talking about). > > I think this was just a mistake. I tried getting rid of the special case > for SVG and everything works just fine in builds with or without SVG > support. (In builds without SVG support, you just get the empty string > where an SVG would be, before and after this patch.) What version of librsvg did you test this with? Please test also with librsvg 2.40.x, as that was the last version which didn't need a Rust compiler to build, and so some people (including yours truly) stay with those old versions to this day. Thanks.
bug-gnu-emacs@HIDDEN
:bug#71913
; Package emacs
.
Full text available.Received: (at 71913) by debbugs.gnu.org; 11 Jul 2024 23:53:03 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jul 11 19:53:03 2024 Received: from localhost ([127.0.0.1]:52865 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sS3aw-0007r3-NP for submit <at> debbugs.gnu.org; Thu, 11 Jul 2024 19:53:03 -0400 Received: from mail-oi1-f175.google.com ([209.85.167.175]:48295) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <jporterbugs@HIDDEN>) id 1sS3av-0007qW-CK for 71913 <at> debbugs.gnu.org; Thu, 11 Jul 2024 19:53:01 -0400 Received: by mail-oi1-f175.google.com with SMTP id 5614622812f47-3d9dd3c1e59so819765b6e.0 for <71913 <at> debbugs.gnu.org>; Thu, 11 Jul 2024 16:53:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720741916; x=1721346716; darn=debbugs.gnu.org; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=f7NCWfFdz03xxYBHaQJmCr4rOcOPVat3rt5Twbrs1Fg=; b=leAN79pg47jRlS7ncchSU9D+I1K6nrnFG4YcWWWOWcSlXlAUfJ2/aLC5PnahnqSOuk Ii3eiKYoHDB6P6F+iqhhgBVSmb8PQdyj12wXKj/OWFXDtF/t7gn4eVWGS59uSrSBHwxp PUWHtTXq11fFF780E9FWyYm9xqZAHdmBNBN2vYpDdUXNbor/rhox5J+n4kqJi3Qrrx6n ++8g7+g6SQO1suSXrM8B0ARKOMXJxA6EroiIBe2DS8ic89qwbq6rOe6rcSAEmEXL4w3D BmWwgdevEXXGqIWi/+ikMUJCnkrNSSUJR3x4VfWcElj/bjv/VQH1f3lJPC+IPHLSGKid 1+cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720741916; x=1721346716; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=f7NCWfFdz03xxYBHaQJmCr4rOcOPVat3rt5Twbrs1Fg=; b=Aot4fgfCWwLfexS9zsOjvDg+UF0sraqv1Rg7E3gArnxVE8SF93WHpJHxmbTWopxrj0 cvXoz+xbSab2sfQ3TIeaShkCiLKU3OuM1KNDRtlkEwhd9GlvtsJBVLrwDAdfR9SgS56y PhnwOqCmeRAm7suy2EG3wckpq793DAxozf/7owJcHi9TlW7uNIWGYB6JkzEX77wwEUxA eS/7N7IMDDVQVnkYl02ncIPCCTpoRNG8ytEvBEaBj5rO71Vc09FJjzJ4mdXqkf2TA7SE rS8RCixslCBhrQIZrs6QC8T/f+c3wOg0aMNRIf67JXC6996ETlWlXu+Qm62Iv6G7rHT5 De7g== X-Gm-Message-State: AOJu0YyyrAP9tGXa/eqLgPeLrXq6hffFIDMNAxqtr8kws+T7ZphZZt1b fM/Cbp7Br4GQ4OtO5HGvFfxoxefCqASwv0Au+WhcQcbvirLHR60HnqOlFA== X-Google-Smtp-Source: AGHT+IF4ZR5v+WNP4eEn6XjDfAMcdfhIH8iryyRNVveM+fUXQIoNPVdxKH27oywQZY38zQTjBkaW+g== X-Received: by 2002:aca:1a1a:0:b0:3d9:c14b:eea6 with SMTP id 5614622812f47-3d9c14bf1camr7228332b6e.8.1720741915688; Thu, 11 Jul 2024 16:51:55 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-77d603fa567sm4939091a12.35.2024.07.11.16.51.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jul 2024 16:51:55 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------iouCoNOL5L3leXbWV2Imh1Dk" Message-ID: <a4a59311-ee79-6ee5-f20d-087a23f8f6fb@HIDDEN> Date: Thu, 11 Jul 2024 16:51:53 -0700 MIME-Version: 1.0 Subject: Re: bug#71913: 29.1; shr: shr-resize-image does not behave as expected Content-Language: en-US To: George Huebner <george@HIDDEN> References: <m2a5izyo8v.fsf@HIDDEN> <630ff886-efa1-f122-3344-4dce503d0c0c@HIDDEN> <m25xtmz0fj.fsf@HIDDEN> <CANh=_JFKyagKwzmFUW7h4dUWCp69kT+F8RrL1QS9TyM5q8LjJA@HIDDEN> <m2y169ul2u.fsf@HIDDEN> From: Jim Porter <jporterbugs@HIDDEN> In-Reply-To: <m2y169ul2u.fsf@HIDDEN> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71913 Cc: 71913 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------iouCoNOL5L3leXbWV2Imh1Dk Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/10/2024 12:02 PM, George Huebner wrote: > As I understand it, this decision was likely made because the dimensions > of SVGs is weird; they aren't inherently required to have a size, but > the SVG itself can define a viewbox with accompanying width and height > (full disclosure: I have no idea what I'm talking about). I think this was just a mistake. I tried getting rid of the special case for SVG and everything works just fine in builds with or without SVG support. (In builds without SVG support, you just get the empty string where an SVG would be, before and after this patch.) --------------iouCoNOL5L3leXbWV2Imh1Dk Content-Type: text/plain; charset=UTF-8; name="0001-Treat-SVG-images-like-other-image-types-in-shr-put-i.patch" Content-Disposition: attachment; filename*0="0001-Treat-SVG-images-like-other-image-types-in-shr-put-i.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA3MGVjYzE5ZjczNWUwY2VhMGZkYTg3MjFkN2YyNzA5YzM5ZjFiYmZmIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFRodSwgMTEgSnVsIDIwMjQgMTY6Mjk6MzcgLTA3MDAKU3ViamVjdDogW1BB VENIXSBUcmVhdCBTVkcgaW1hZ2VzIGxpa2Ugb3RoZXIgaW1hZ2UgdHlwZXMgaW4gJ3Noci1w dXQtaW1hZ2UnCgpGb3IgYm90aCBTVkcgYW5kIG5vLVNWRyBidWlsZHMsIHRoaXMgd29ya3Mg YXMgZXhwZWN0ZWQgKGluIHRoZSBuby1TVkcKY2FzZSwgaXQgd291bGQgcmFpc2UgYW4gZXJy b3Igd2hpY2ggc3Vic2VxdWVudGx5IGdldHMgaWdub3JlZCkuCkhvd2V2ZXIsIGNvbXBhcmVk IHRvIHRoZSBwcmV2aW91cyBpbXBsZW1lbnRhdGlvbiwgdGhpcyBsZXRzIHVzZXJzIHJlc2l6 ZQpTVkcgaW1hZ2VzIGp1c3QgbGlrZSBldmVyeSBvdGhlciBpbWFnZSB0eXBlLgoKKiBsaXNw L25ldC9zaHIuZWwgKHNoci1wdXQtaW1hZ2UpOiBEb24ndCBzcGVjaWFsLWNhc2UgU1ZHcy4K LS0tCiBsaXNwL25ldC9zaHIuZWwgfCAxNyArKysrKystLS0tLS0tLS0tLQogMSBmaWxlIGNo YW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgMTEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv bGlzcC9uZXQvc2hyLmVsIGIvbGlzcC9uZXQvc2hyLmVsCmluZGV4IDM5MjcxY2M1Mjk2Li5k M2M0OGIzNDQyOCAxMDA2NDQKLS0tIGEvbGlzcC9uZXQvc2hyLmVsCisrKyBiL2xpc3AvbmV0 L3Noci5lbApAQCAtMTE5MywyMyArMTE5MywxOCBAQCBzaHItcHV0LWltYWdlCiAgIChpZiAo ZGlzcGxheS1ncmFwaGljLXApCiAgICAgICAobGV0KiAoKHpvb20gKG9yIChwbGlzdC1nZXQg ZmxhZ3MgOnpvb20pCiAgICAgICAgICAgICAgICAgICAgICAgIChjYXIgc2hyLWltYWdlLXpv b20tbGV2ZWxzKSkpCi0gICAgICAgICAgICAgKHpvb20tZnVuY3Rpb24gKG50aCAyIChhc3Nx IHpvb20gc2hyLWltYWdlLXpvb20tbGV2ZWwtYWxpc3QpKSkKKyAgICAgICAgICAgICAoem9v bS1mdW5jdGlvbiAob3IgKG50aCAyIChhc3NxIHpvb20gc2hyLWltYWdlLXpvb20tbGV2ZWwt YWxpc3QpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoZXJyb3IgIlVucmVj b2duaXplZCB6b29tIGxldmVsICVzIiB6b29tKSkpCiAJICAgICAoZGF0YSAoaWYgKGNvbnNw IHNwZWMpCiAJCSAgICAgICAoY2FyIHNwZWMpCiAJCSAgICAgc3BlYykpCiAJICAgICAoY29u dGVudC10eXBlIChhbmQgKGNvbnNwIHNwZWMpCiAJCQkJKGNhZHIgc3BlYykpKQogCSAgICAg KHN0YXJ0IChwb2ludCkpCi0JICAgICAoaW1hZ2UgKGNvbmQKLQkJICAgICAoKGVxIGNvbnRl bnQtdHlwZSAnaW1hZ2Uvc3ZnK3htbCkKLSAgICAgICAgICAgICAgICAgICAgICAod2hlbiAo aW1hZ2UtdHlwZS1hdmFpbGFibGUtcCAnc3ZnKQotCQkgICAgICAgIChjcmVhdGUtaW1hZ2Ug ZGF0YSAnc3ZnIHQgOmFzY2VudCBzaHItaW1hZ2UtYXNjZW50KSkpCi0gICAgICAgICAgICAg ICAgICAgICAoem9vbS1mdW5jdGlvbgotICAgICAgICAgICAgICAgICAgICAgIChpZ25vcmUt ZXJyb3JzCi0gICAgICAgICAgICAgICAgICAgICAgICAoZnVuY2FsbCB6b29tLWZ1bmN0aW9u IGRhdGEgY29udGVudC10eXBlCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAo cGxpc3QtZ2V0IGZsYWdzIDp3aWR0aCkKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIChwbGlzdC1nZXQgZmxhZ3MgOmhlaWdodCkpKSkKLSAgICAgICAgICAgICAgICAgICAg ICh0IChlcnJvciAiVW5yZWNvZ25pemVkIHpvb20gbGV2ZWwgJXMiIHpvb20pKSkpKQorCSAg ICAgKGltYWdlIChpZ25vcmUtZXJyb3JzCisgICAgICAgICAgICAgICAgICAgICAgKGZ1bmNh bGwgem9vbS1mdW5jdGlvbiBkYXRhIGNvbnRlbnQtdHlwZQorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIChwbGlzdC1nZXQgZmxhZ3MgOndpZHRoKQorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIChwbGlzdC1nZXQgZmxhZ3MgOmhlaWdodCkpKSkpCiAgICAgICAg ICh3aGVuIGltYWdlCiAgICAgICAgICAgOzsgVGhlIHRyYWlsaW5nIHNwYWNlIGNhbiBjb25m dXNlIHNoci1pbnNlcnQgaW50byBub3QKICAgICAgICAgICA7OyBwdXR0aW5nIGFueSBzcGFj ZSBhZnRlciBpbmxpbmUgaW1hZ2VzLgotLSAKMi4yNS4xCgo= --------------iouCoNOL5L3leXbWV2Imh1Dk--
bug-gnu-emacs@HIDDEN
:bug#71913
; Package emacs
.
Full text available.Received: (at 71913) by debbugs.gnu.org; 11 Jul 2024 04:30:26 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jul 11 00:30:26 2024 Received: from localhost ([127.0.0.1]:50636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sRlRo-00046V-Ph for submit <at> debbugs.gnu.org; Thu, 11 Jul 2024 00:30:26 -0400 Received: from mail-qk1-f180.google.com ([209.85.222.180]:58501) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ghubs25@HIDDEN>) id 1sRcaV-0000Xs-Bk for 71913 <at> debbugs.gnu.org; Wed, 10 Jul 2024 15:02:48 -0400 Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-79f178351d4so8436585a.0 for <71913 <at> debbugs.gnu.org>; Wed, 10 Jul 2024 12:02:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720638155; x=1721242955; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=36EsRuJj5C8ZISkHsXV1YAg719u/65sh8+b5ErH12sg=; b=R2hCA2QFMVAxDMPPgjUYhWnh2gbq7WSowheRPLk8fG1l4OTPc8A1L7NXy0TTDawUUi rsNcylxDio+EzNh/fkzat/O+nA5SeHZdXMWlEG9xY6WpTu0ILRJ9EzNLMU+o7YrrmGnM 0KozrH81hEoRCBHCaSlIqU9mMt+/ug2TGAY/zAdE3OWvUK8oZsqB1GbIcTZUTgZUHvtV C8Euqwvdrne2W/J38Y6+TmIU1EUgFNdBsF+Up35TpqabvkNioilxi2LQEK7/NBC7rSKk rozN5HQT8Vr9cxzGOztCY+k+6WZubNZw1eRnqa9DRHMTROFhjkztKIERfBiDdDMRY96r 62Mg== X-Gm-Message-State: AOJu0YxNtrc7yKmfdibS+6HWaMEzRz+RFm+WRV8jycybfihgls/T03sg ook0RbnVj+JDtqva4I7wvdQ0q3D6wo8i6TrEaKvpISTdypwjZ6c65n4VpA== X-Google-Smtp-Source: AGHT+IG/BPSg4nJ16zhxvEl3Ln3/LvXQQBvSO4/Hyi6Tyh46+0D0+itictKWNqPoOJK5TP2UGEdesA== X-Received: by 2002:a05:620a:848:b0:79f:556:5f31 with SMTP id af79cd13be357-79f19a7d6fbmr770644085a.37.1720638155266; Wed, 10 Jul 2024 12:02:35 -0700 (PDT) Received: from localhost (mobile-130-126-255-14.near.illinois.edu. [130.126.255.14]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-447f9b26b96sm22748561cf.11.2024.07.10.12.02.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jul 2024 12:02:34 -0700 (PDT) From: George Huebner <george@HIDDEN> To: Jim Porter <jporterbugs@HIDDEN> Subject: Re: bug#71913: 29.1; shr: shr-resize-image does not behave as expected In-Reply-To: <CANh=_JFKyagKwzmFUW7h4dUWCp69kT+F8RrL1QS9TyM5q8LjJA@HIDDEN> (Jim Porter's message of "Fri, 5 Jul 2024 11:11:29 -0700") References: <m2a5izyo8v.fsf@HIDDEN> <630ff886-efa1-f122-3344-4dce503d0c0c@HIDDEN> <m25xtmz0fj.fsf@HIDDEN> <CANh=_JFKyagKwzmFUW7h4dUWCp69kT+F8RrL1QS9TyM5q8LjJA@HIDDEN> Date: Wed, 10 Jul 2024 14:02:33 -0500 Message-ID: <m2y169ul2u.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 71913 X-Mailman-Approved-At: Thu, 11 Jul 2024 00:30:24 -0400 Cc: 71913 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain; format=flowed Aha: after patching Elfeed to render after buffer display (which seems to fix the display of raster images), I actually did find behaviour that I believe should be addressed in shr, not in Elfeed; let me know what you think. If an image is a SVG, `shr-put-image` will not respect `shr-max-image-proportion`, because it will pass it directly to `create-image`, instead of resizing it: #+begin_src elisp ;; in `shr-put-image` ((eq content-type 'image/svg+xml) (when (image-type-available-p 'svg) (create-image data 'svg t :ascent shr-image-ascent))) (t (ignore-errors (shr-rescale-image data content-type (plist-get flags :width) (plist-get flags :height))))))) #+end_src As I understand it, this decision was likely made because the dimensions of SVGs is weird; they aren't inherently required to have a size, but the SVG itself can define a viewbox with accompanying width and height (full disclosure: I have no idea what I'm talking about). Using `shr-rescale-image` instead seems to do the trick (and respects SVGs that should display smaller than `shr-max-image-proportion`), but please do let me know if I'm ignoring an edge case or there's a better way to address this. #+begin_src elisp (setq shr-put-image-function (lambda (spec alt &optional flags) (if (display-graphic-p) (let* ((size (cdr (assq 'size flags))) (data (if (consp spec) (car spec) spec)) (content-type (and (consp spec) (cadr spec))) (start (point)) (image (cond ((eq size 'original) (create-image data nil t :ascent 100 :format content-type)) ;; BEGIN fix ((eq content-type 'image/svg+xml) (when (image-type-available-p 'svg) ; (create-image data 'svg t :ascent 100))) (shr-rescale-image data 'svg (plist-get flags :width) (plist-get flags :height)))) ;; END fix ((eq size 'full) (ignore-errors (shr-rescale-image data content-type (plist-get flags :width) (plist-get flags :height)))) (t (ignore-errors (shr-rescale-image data content-type (plist-get flags :width) (plist-get flags :height))))))) (when image ;; When inserting big-ish pictures, put them at the ;; beginning of the line. (when (and (> (current-column) 0) (> (car (image-size image t)) 400)) (insert "\n")) (let ((image-pos (point))) (if (eq size 'original) (insert-sliced-image image (or alt "*") nil 20 1) (insert-image image (or alt "*"))) (put-text-property start (point) 'image-size size) (when (and shr-image-animate (cdr (image-multi-frame-p image))) (image-animate image nil 60 image-pos)))) image) (insert (or alt ""))))) #+end_src elisp --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=elfeed-shr.patch Content-Description: Elfeed: render after display From 8f911a56beaf52f0df18537d0f9abae8373d7133 Mon Sep 17 00:00:00 2001 From: George Huebner <george@HIDDEN> Date: Wed, 10 Jul 2024 01:57:15 -0500 Subject: [PATCH] elfeed-show: render after switching to entry buffer shr can't respect `shr-max-image-proportion` because it isn't rendered in a window; call `elfeed-search-show-entry` first to fix this. See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=71913 --- elfeed-show.el | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/elfeed-show.el b/elfeed-show.el index 4915cae..e16b4bf 100644 --- a/elfeed-show.el +++ b/elfeed-show.el @@ -214,9 +214,9 @@ The result depends on the value of `elfeed-show-unique-buffers'." (let ((buff (get-buffer-create (elfeed-show--buffer-name entry)))) (with-current-buffer buff (elfeed-show-mode) - (setq elfeed-show-entry entry) - (elfeed-show-refresh)) - (funcall elfeed-show-entry-switch buff))) + (setq elfeed-show-entry entry)) + (funcall elfeed-show-entry-switch buff) + (elfeed-show-refresh))) (defun elfeed-show-next () "Show the next item in the elfeed-search buffer." -- 2.44.1 --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On Fri, Jul 5, 2024 at 13:11:29 EST Jim Porter wrote: > (Cc'ing the bug list to follow up there too.) > > On Wed, Jul 3, 2024 at 1:26=E2=80=AFPM George Huebner <george@HIDDEN>=20 > wrote: >> >> You're quite right... I understood ~(not (get-buffer-window >> (current-buffer) t))~ (in shr-rescale-image) was preventing >> rescaling in undisplayed buffers, but in retrospect this is the >> responsibility of the caller, as you say. >> >> Apologies for the fruitless bug report, this thread can be=20 >> closed. > > On the contrary, I think it makes sense to do *something*=20 > here. At > minimum, Elfeed should probably get a fix, since I've noticed=20 > this > issue there too (but never bothered to figure out why). Now that=20 > you > found minimal steps to reproduce, hopefully we can fix Elfeed. > > It might also be good to at least document this limitation, or=20 > even > enhance 'shr-max-image-proportion' to support absolute pixel=20 > sizes, > which would be immune to this issue. --=-=-=--
bug-gnu-emacs@HIDDEN
:bug#71913
; Package emacs
.
Full text available.Received: (at 71913) by debbugs.gnu.org; 5 Jul 2024 18:12:51 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jul 05 14:12:51 2024 Received: from localhost ([127.0.0.1]:44945 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sPnQR-0006X6-5K for submit <at> debbugs.gnu.org; Fri, 05 Jul 2024 14:12:51 -0400 Received: from mail-qv1-f53.google.com ([209.85.219.53]:48279) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <jporterbugs@HIDDEN>) id 1sPnQO-0006Wl-Sg for 71913 <at> debbugs.gnu.org; Fri, 05 Jul 2024 14:12:49 -0400 Received: by mail-qv1-f53.google.com with SMTP id 6a1803df08f44-6b5e4466931so8482156d6.0 for <71913 <at> debbugs.gnu.org>; Fri, 05 Jul 2024 11:12:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720203100; x=1720807900; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xv1UYudtRt2OuxcUnft3vUeNZn0zQZ9TbbtgmYPDB7c=; b=F8h9ofDa7aZjC41q9k2QXkjsFEp1HHSSaRVOxROwXwr2iNouLnD/LEcRZsx7fD4CM+ TlWA1U2TKC07W4OfnokKCdmnLwQANnpZBneh1L6m18pXyI+60MTK+7axbKTtyXPAGlQV iEGmd5lFSFZxrMgkLYZVpvaXN+d59QxapIU4u/WeGw3xr2FWSt5H5kSmTh18aTW7EBDg t70R2nv/m+FNzZnriDqOIOrk9ASzdwI6NgSrUlF3xUgYValDepsZGF2vw5ehISrhLB+4 ZJufJuTFy5mL8NIZBAtF8UBPh8eX9z1uHXNkMYoPcj7196ga8K9pqCCuuFUXsQB7finS MzSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720203100; x=1720807900; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xv1UYudtRt2OuxcUnft3vUeNZn0zQZ9TbbtgmYPDB7c=; b=G/Obe484GlCozHdRPXJ8udug764UIHhQ7vUQP4ijZCa+wyPgH/yb1ex+UmWtGJe1QF +k1KqRdM9QCn3HMkRGf1cpi27mvAtJyvNShddqYrnzlTjal0biZ251a0y91pVVyfa7u3 xjTqlTdNQ7Avevc9cSt6D3UWZqlSbwtcfXgy00cMn1706jcEFo/szIrXicYGc9r4Q0NO 8PiVNBPeTo8txdjfmSyBLdtxYP8KwnlyZnIkc5BOPApKWZjjeykPiT+0HM6t1oxmBU/e ybcJTMO2VhP3AMMlp/9Zs1S/poUxzZKLuRj3xSVbvHPvnOFfIQmRvVVze3v90a/1sXZ4 pgwA== X-Gm-Message-State: AOJu0Yx+sZjyKOo+oTiToev9Ur2QgwQQM9llLVBp2y1kqAhZko4sJOc+ pg79AXHGmvplsE4Kqd+yGclWwZR1pPu2KfLWL7g0vcAs4kGfSzjT41geBzV3osFC2A0ZVtxlEcK iPEDSqY+fOtA1BfcJehyeoARaPXECycQp X-Google-Smtp-Source: AGHT+IHTIzFetld/Q/g1AHx7J2xPKnk/OltO4iQAVaKbtjC21s/L9TRL6+XsBF1XGaWjFoHY8pQzHcQGXC4Yl5mC45Y= X-Received: by 2002:a05:6214:2686:b0:6b5:101d:201 with SMTP id 6a1803df08f44-6b5ed006f2fmr64645396d6.39.1720203100037; Fri, 05 Jul 2024 11:11:40 -0700 (PDT) MIME-Version: 1.0 References: <m2a5izyo8v.fsf@HIDDEN> <630ff886-efa1-f122-3344-4dce503d0c0c@HIDDEN> <m25xtmz0fj.fsf@HIDDEN> In-Reply-To: <m25xtmz0fj.fsf@HIDDEN> From: Jim Porter <jporterbugs@HIDDEN> Date: Fri, 5 Jul 2024 11:11:29 -0700 Message-ID: <CANh=_JFKyagKwzmFUW7h4dUWCp69kT+F8RrL1QS9TyM5q8LjJA@HIDDEN> Subject: Re: bug#71913: 29.1; shr: shr-resize-image does not behave as expected To: George Huebner <george@HIDDEN> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71913 Cc: 71913 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) (Cc'ing the bug list to follow up there too.) On Wed, Jul 3, 2024 at 1:26=E2=80=AFPM George Huebner <george@HIDDEN> wro= te: > > You're quite right... I understood ~(not (get-buffer-window > (current-buffer) t))~ (in shr-rescale-image) was preventing > rescaling in undisplayed buffers, but in retrospect this is the > responsibility of the caller, as you say. > > Apologies for the fruitless bug report, this thread can be closed. On the contrary, I think it makes sense to do *something* here. At minimum, Elfeed should probably get a fix, since I've noticed this issue there too (but never bothered to figure out why). Now that you found minimal steps to reproduce, hopefully we can fix Elfeed. It might also be good to at least document this limitation, or even enhance 'shr-max-image-proportion' to support absolute pixel sizes, which would be immune to this issue.
bug-gnu-emacs@HIDDEN
:bug#71913
; Package emacs
.
Full text available.Received: (at 71913) by debbugs.gnu.org; 3 Jul 2024 15:49:50 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jul 03 11:49:50 2024 Received: from localhost ([127.0.0.1]:40183 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sP2Ew-0005ES-Fg for submit <at> debbugs.gnu.org; Wed, 03 Jul 2024 11:49:50 -0400 Received: from mail-il1-f177.google.com ([209.85.166.177]:54620) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <jporterbugs@HIDDEN>) id 1sP2Eu-0005EK-SJ for 71913 <at> debbugs.gnu.org; Wed, 03 Jul 2024 11:49:49 -0400 Received: by mail-il1-f177.google.com with SMTP id e9e14a558f8ab-380deeb250eso6962085ab.1 for <71913 <at> debbugs.gnu.org>; Wed, 03 Jul 2024 08:49:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720021726; x=1720626526; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=GHiox3OcBt2KxBWb2mxvG0TDBNhJBzrn5/cs7lgxaew=; b=Lz4Qc+kW3BD+9vwqXS7ipOBtTDYIr3v1Dqhvfa+RpGg9GwqvfpgAUu3qt+tU760RVD 0MzL3pI/mbj2iTHyNOjMWaxOt+gqDfgGqqvZQfYbyQziwAK88MM45IF6TeEWFdgJhDAH x3pjlkMr3QhE1CPm2FF1FTjfaAndbTiatRxZqGGhft3vWBGP/PhUXx8jGtY1AZFOzkD5 0KDjRLtcuxJW2cu72H8XeEdVi8oPcnbBwQwuUKKiKZAvE2mazDG4Ef6iZx0tVB7ImQDe HodPzUAadn8bxbR2p/tWZtUmqJ3gnEvHcaEN+hzySsf58kq0i5L1kFt/Oes/+xhDV/bs Amxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720021726; x=1720626526; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GHiox3OcBt2KxBWb2mxvG0TDBNhJBzrn5/cs7lgxaew=; b=jxUucq6fo776lgoLmlldmi2FgJcx14YmmGSHW73jPjzCPfB0uh9Kc/rahU60kSkn8f Pud9EeBaiMAS49gY4ZagX25p7/siixFq4rnM7Ambl6RbRYxIitV0u+u6GbZ4w64FA5uy r26z/yhmqTyc1pIr4PSX4cRrnIP/eOuPN3wxnd2tNJMJE6cYIvnOxTzpPgAk8k9RTGTa 7W7YtLw14leyre3Yd4QzI3Nr+yKbKfCVzsM+oLbUCfBUg5cew737TUI8gXRBei3PYie5 4QVc41CpdcaTThNDGztJETQGe1NevXSBDul6ONXpAdyBtrch2r5+w97W2o1hOTn3XalB Z5pQ== X-Forwarded-Encrypted: i=1; AJvYcCVRqm8nTaPJJq4oCk5bFwRvg4j69h9SweaV8Pcz1iU9VcZFhzWoldcJAQeVAj2YieWGPAE2sK89OBS1T6jIQ/TOBy+U6Ow= X-Gm-Message-State: AOJu0YytOnhWDD8XemBnbOrInf/ZSZTcJPjGyJ1ZuFL63Z2D9xGr5VIH d6X3ivRCwnKRIh73ayI+0UdetorfSo5P1TzzyjLx0ld9oE8OhM+g4dfVNA== X-Google-Smtp-Source: AGHT+IGEbdSkOHUZnX0cESVleZEXRIpIwY6UR47mBxylIe851qmwLFcyjYyMqVAlBhJWpEDNFgF2vg== X-Received: by 2002:a05:6e02:1649:b0:382:325c:f7b3 with SMTP id e9e14a558f8ab-382325cfa93mr23101965ab.4.1720021726266; Wed, 03 Jul 2024 08:48:46 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-72c6c9e1634sm8344528a12.58.2024.07.03.08.48.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Jul 2024 08:48:45 -0700 (PDT) Message-ID: <630ff886-efa1-f122-3344-4dce503d0c0c@HIDDEN> Date: Wed, 3 Jul 2024 08:48:46 -0700 MIME-Version: 1.0 Subject: Re: bug#71913: 29.1; shr: shr-resize-image does not behave as expected To: George Huebner <george@HIDDEN>, 71913 <at> debbugs.gnu.org References: <m2a5izyo8v.fsf@HIDDEN> Content-Language: en-US From: Jim Porter <jporterbugs@HIDDEN> In-Reply-To: <m2a5izyo8v.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71913 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On 7/2/2024 11:37 PM, George Huebner wrote: > I noticed an issue with =shr-max-image-proportion= wherein images would > be correctly resized on initial load, but would then appear much larger. [snip] > Here's a minimal reproducible example (credit to Sacha Chua): > #+begin_src elisp :eval no > ;; run this (image is very large), run again many times without > killing *test* (image is correct size), kill *test* and run again > (image is large again) > ;; won't observe this behaviour if you disable cache > ;; (setq shr-ignore-cache t) > (setq shr-max-image-proportion 0.5) > (with-current-buffer (get-buffer-create "*test*") > (erase-buffer) > (insert "<img > src=\"https://upload.wikimedia.org/wikipedia/commons/8/83/The_GNU_logo.png\">") > (shr-insert-document (libxml-parse-html-region (point-min) (point-max))) > (display-buffer (current-buffer))) > #+end_src elisp The bug here is really in your steps to reproduce, which I suppose is roughly what Elfeed is doing too (though I haven't looked at that code to be totally sure). SHR scales images with respect to the size of the buffer's window. However, by rendering the HTML document with SHR *before* displaying the buffer in a window, it's impossible for Emacs to do that: there's no such window yet! If you swap the 'display-buffer' and 'shr-insert-document' lines though, all should work properly.
bug-gnu-emacs@HIDDEN
:bug#71913
; Package emacs
.
Full text available.Received: (at submit) by debbugs.gnu.org; 3 Jul 2024 07:36:38 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jul 03 03:36:38 2024 Received: from localhost ([127.0.0.1]:38531 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sOuXc-0002I9-RG for submit <at> debbugs.gnu.org; Wed, 03 Jul 2024 03:36:37 -0400 Received: from lists.gnu.org ([209.51.188.17]:55030) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ghubs25@HIDDEN>) id 1sOtcx-0000n2-Au for submit <at> debbugs.gnu.org; Wed, 03 Jul 2024 02:38:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ghubs25@HIDDEN>) id 1sOtcv-0005v6-2c for bug-gnu-emacs@HIDDEN; Wed, 03 Jul 2024 02:38:01 -0400 Received: from mail-il1-f181.google.com ([209.85.166.181]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <ghubs25@HIDDEN>) id 1sOtcs-0006I1-9t for bug-gnu-emacs@HIDDEN; Wed, 03 Jul 2024 02:38:00 -0400 Received: by mail-il1-f181.google.com with SMTP id e9e14a558f8ab-375af3538f2so23754945ab.3 for <bug-gnu-emacs@HIDDEN>; Tue, 02 Jul 2024 23:37:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719988676; x=1720593476; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=pk+PX4Md0NNmxDOGYDSaZ8RhXaIvkY9RZa0DRFbLYYE=; b=LIsrTruxBLhvBBysozMBk2NcWmBF4KZ0BcCS+wWIGc+Ik7ll3eoc0rc0XxocoO09Mx +V2wuFhQEfZ4G1o5ulEbh0tg6DyCKS9nuJvSsAab5St3JjjGw5lv5sTyJfO3zdGYrbPz BEMfEsytMhqKty+fyi5O/qB2UBQkecdclRHHU2Xj2PG9FVgTjbnz9Q0yCbQkIqAo8V3q F09ckXzw6E2guvEYH8k7SEqLvd1ZQSuP0AEDMhMVp0jNzHNOa27IC1W+/MOOfL0hLdIK Rp34koty+Oyd1vTCO9ZanH3D2ngGvBvcYYs116rCARXHP3Se/JIRBXFRtFlRyK6bNg/g 02HA== X-Gm-Message-State: AOJu0Yy/IEtVJQRNZTEeY7KUuGz/nbOwSqZqTk2CR1uBhnl/D73zmerW 2F1CFgpqMwkHyD9qXXY5Ya6ClW8+8twGoRcLRXJGS4gqLhrpaaimmRldlg== X-Google-Smtp-Source: AGHT+IFWaImq+l0z/lP3kWYEa5KqKPPuVxE2atZrRLm4cH4SvaJ5hWzqoFRlzjNQ8D2DE7uqNtAjOw== X-Received: by 2002:a05:6e02:20c9:b0:380:f340:ad66 with SMTP id e9e14a558f8ab-380f34ffb7fmr30671175ab.26.1719988675637; Tue, 02 Jul 2024 23:37:55 -0700 (PDT) Received: from localhost (s-29-93.flex.volo.net. [76.191.29.93]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3826c45308esm817755ab.83.2024.07.02.23.37.55 for <bug-gnu-emacs@HIDDEN> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jul 2024 23:37:55 -0700 (PDT) From: George Huebner <george@HIDDEN> To: bug-gnu-emacs@HIDDEN Subject: 29.1; shr: shr-resize-image does not behave as expected Date: Wed, 03 Jul 2024 01:37:52 -0500 Message-ID: <m2a5izyo8v.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; format=flowed Received-SPF: pass client-ip=209.85.166.181; envelope-from=ghubs25@HIDDEN; helo=mail-il1-f181.google.com X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 03 Jul 2024 03:36:33 -0400 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.8 (-) I noticed an issue with =shr-max-image-proportion= wherein images would be correctly resized on initial load, but would then appear much larger. I suspected this was an issue with caching, and sure enough, either disabling the cache with ~(setq shr-ignore-cache t)~ or manually deleting images from the cache results in images displaying correctly. This unanswered [[https://www.reddit.com/r/emacs/comments/esa3x5/image_scaling_in_elfeed_entry_window/][Reddit post]] seems to corroborate this behaviour. It looks like it might be because of the codepath taken in ~shr-tag-img~ wherein a cache miss results in the creation of a placeholder image; I had some trouble with edebug though, so that's just an educated guess. Here's a minimal reproducible example (credit to Sacha Chua): #+begin_src elisp :eval no ;; run this (image is very large), run again many times without killing *test* (image is correct size), kill *test* and run again (image is large again) ;; won't observe this behaviour if you disable cache ;; (setq shr-ignore-cache t) (setq shr-max-image-proportion 0.5) (with-current-buffer (get-buffer-create "*test*") (erase-buffer) (insert "<img src=\"https://upload.wikimedia.org/wikipedia/commons/8/83/The_GNU_logo.png\">") (shr-insert-document (libxml-parse-html-region (point-min) (point-max))) (display-buffer (current-buffer))) #+end_src elisp I also observed this behaviour on Emacs master (667ca66), but I daily drive 29.1. In GNU Emacs 29.1 (build 1, aarch64-apple-darwin23.4.0, Carbon Version 170 AppKit 2487.5) Windowing system distributor 'Apple Inc.', version 14.4.0 System Description: macOS 14.4 Configured using: 'configure --prefix=/nix/store/ismv7jzf3hcqziq5bpjfs54zd4qfjjn7-emacs-mac-macport-29.1 --disable-build-details --with-modules --without-gif --without-jpeg --without-png --without-tiff --without-x --without-xpm '--enable-mac-app=$$out/Applications' --with-gnutls --with-mac --with-xml2 --without-ns --with-compress-install --with-toolkit-scroll-bars --with-native-compilation --without-imagemagick --with-mailutils --without-small-ja-dic --with-tree-sitter --without-xinput2 --without-xwidgets --without-dbus --without-selinux --with-xwidgets'
George Huebner <george@HIDDEN>
:bug-gnu-emacs@HIDDEN
.
Full text available.bug-gnu-emacs@HIDDEN
:bug#71913
; Package emacs
.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.