GNU logs - #72397, boring messages

Message sent to guix-patches@HIDDEN:

Subject: [bug#72397] [PATCH] gnu: Add fennel-ls.
Resent-From: sydney goose <lomiskiam@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 31 Jul 2024 10:14:01 +0000
Resent-Message-ID: <handler.72397.B.172242078713508 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 72397 <at> debbugs.gnu.org
MIME-Version: 1.0
From: sydney goose <lomiskiam@HIDDEN>
Date: Wed, 31 Jul 2024 00:27:44 -0600
Message-ID: <CAE0SKk2+oAXBLxr5K3dqUA1y_Tpt9345LtogS8y1EEyBgVc_bQ@HIDDEN>
Content-Type: multipart/mixed; boundary="000000000000d30130061e853134"
Received-SPF: pass client-ip=2607:f8b0:4864:20::b34;
 envelope-from=lomiskiam@HIDDEN; helo=mail-yb1-xb34.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Mailman-Approved-At: Wed, 31 Jul 2024 06:13:04 -0400
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

--000000000000d30130061e853134
Content-Type: multipart/alternative; boundary="000000000000d3012f061e853132"

--000000000000d3012f061e853132
Content-Type: text/plain; charset="UTF-8"

* gnu/packages/fennel.scm (fennel-ls): New variable.

--000000000000d3012f061e853132
Content-Type: text/html; charset="UTF-8"

<div dir="ltr">* gnu/packages/fennel.scm (fennel-ls): New variable.<br></div>

--000000000000d3012f061e853132--

--000000000000d30130061e853134
Content-Type: text/x-patch; charset="US-ASCII"; name="0001-gnu-Add-fennel-ls.patch"
Content-Disposition: attachment; filename="0001-gnu-Add-fennel-ls.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_lz9gt82v0>
X-Attachment-Id: f_lz9gt82v0

RnJvbSAwMGRjMTQxZDk5NTM5YWI5YWVjMDFkNWFkZjQzYjBmYWZiMWYzMmY0IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpNZXNzYWdlLUlEOiA8MDBkYzE0MWQ5OTUzOWFiOWFlYzAxZDVhZGY0M2Iw
ZmFmYjFmMzJmNC4xNzIyNDA3MDQzLmdpdC5sb21pc2tpYW1AZ21haWwuY29tPgpGcm9tOiBjcnVt
YnRvbyA8Y3J1bWJAZHVjay5jb20+CkRhdGU6IFdlZCwgMzEgSnVsIDIwMjQgMDA6MTM6NTIgLTA2
MDAKU3ViamVjdDogW1BBVENIXSBnbnU6IEFkZCBmZW5uZWwtbHMuCgoqIGdudS9wYWNrYWdlcy9m
ZW5uZWwuc2NtIChmZW5uZWwtbHMpOiBOZXcgdmFyaWFibGUuCgpDaGFuZ2UtSWQ6IElkOGE0NjVm
MmM1NDlmMDdmMDE0YWQ5ZjY1YWYyODM3ZThlMThlNmQwCi0tLQogZ251L3BhY2thZ2VzL2x1YS5z
Y20gfCAzMSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCiAxIGZpbGUgY2hhbmdlZCwg
MzEgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy9sdWEuc2NtIGIvZ251
L3BhY2thZ2VzL2x1YS5zY20KaW5kZXggMWU1ODNiNTliMy4uMGJlOTkxNGU2NSAxMDA2NDQKLS0t
IGEvZ251L3BhY2thZ2VzL2x1YS5zY20KKysrIGIvZ251L3BhY2thZ2VzL2x1YS5zY20KQEAgLTEz
OTcsNiArMTM5NywzNyBAQCAoZGVmaW5lLXB1YmxpYyBmZW5uZWwKIHN5c3RlbS4iKQogICAgIChs
aWNlbnNlIGxpY2Vuc2U6ZXhwYXQpKSkKIAorKGRlZmluZS1wdWJsaWMgZmVubmVsLWxzCisgIChw
YWNrYWdlCisgICAgKG5hbWUgImZlbm5lbC1scyIpCisgICAgKHZlcnNpb24gIjAuMS4zIikKKyAg
ICAoc291cmNlCisgICAgIChvcmlnaW4KKyAgICAgICAobWV0aG9kIHVybC1mZXRjaCkKKyAgICAg
ICAodXJpIChzdHJpbmctYXBwZW5kICJodHRwczovL2dpdC5zci5odC9+eGVyb29sL2Zlbm5lbC1s
cy9hcmNoaXZlLyIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgIHZlcnNpb24gIi50YXIuZ3oi
KSkKKyAgICAgICAoc2hhMjU2CisgICAgICAgIChiYXNlMzIgIjBuYjN5Y2x2OXYybXdjbmFtNWRq
dmhnMHZnbWRzazBnYXZidnExYXI1djJqMG05cHpyN2YiKSkpKQorICAgIChidWlsZC1zeXN0ZW0g
Z251LWJ1aWxkLXN5c3RlbSkKKyAgICAoYXJndW1lbnRzCisgICAgIChsaXN0CisgICAgICAjOnRl
c3QtdGFyZ2V0ICJ0ZXN0IgorICAgICAgIzpwaGFzZXMgI34obW9kaWZ5LXBoYXNlcyAlc3RhbmRh
cmQtcGhhc2VzCisgICAgICAgICAgICAgICAgICAgKGRlbGV0ZSAnY29uZmlndXJlKQorICAgICAg
ICAgICAgICAgICAgIChhZGQtYWZ0ZXIgJ2J1aWxkICdwYXRjaC1mZW5uZWwtbHMKKyAgICAgICAg
ICAgICAgICAgICAgIChsYW1iZGEqICgjOmtleSBpbnB1dHMgIzphbGxvdy1vdGhlci1rZXlzKQor
ICAgICAgICAgICAgICAgICAgICAgICAoc3Vic3RpdHV0ZSogImZlbm5lbC1scyIKKyAgICAgICAg
ICAgICAgICAgICAgICAgICAoKCIvdXNyL2Jpbi9lbnYgLipsdWEiKQorICAgICAgICAgICAgICAg
ICAgICAgICAgICAoc2VhcmNoLWlucHV0LWZpbGUgaW5wdXRzICIvYmluL2x1YSIpKSkpKSkKKyAg
ICAgICM6bWFrZS1mbGFncyAjfihsaXN0IChzdHJpbmctYXBwZW5kICJQUkVGSVg9IgorICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGFzc29jLXJlZiAlb3V0cHV0cyAi
b3V0IikpKSkpCisgICAgKGlucHV0cyAobGlzdCBsdWEtNS40IGZlbm5lbCkpCisgICAgKGhvbWUt
cGFnZSAiaHR0cHM6Ly9naXQuc3IuaHQvfnhlcm9vbC9mZW5uZWwtbHMiKQorICAgIChsaWNlbnNl
IGxpY2Vuc2U6ZXhwYXQpCisgICAgKHN5bm9wc2lzICJQcm92aWRlcyBpbnRlbGxpZ2VudCBlZGl0
aW5nIGZlYXR1cmVzIGZvciBGZW5uZWwgZmlsZXMiKQorICAgIChkZXNjcmlwdGlvbiAiQSBsYW5n
dWFnZSBzZXJ2ZXIgZm9yIEZlbm5lbC4gIFByb3ZpZGVzIGludGVsbGlnZW50IGVkaXRpbmcKK2Zl
YXR1cmVzIGZvciBGZW5uZWwgZmlsZXMuIikpKQorCiAoZGVmaW5lLXB1YmxpYyBhbnRpZmVubmVs
CiAgIChwYWNrYWdlCiAgICAgKHZlcnNpb24gIjAuMi4wIikKCmJhc2UtY29tbWl0OiBmNTljNDEy
NjgyN2FmM2QyMDQxZDQ5ZjFkMGE4Y2UxMmI0MTQ3MGNmCi0tIAoyLjQ1LjIKCg==
--000000000000d30130061e853134--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: sydney goose <lomiskiam@HIDDEN>
Subject: bug#72397: Acknowledgement ([PATCH] gnu: Add fennel-ls.)
Message-ID: <handler.72397.B.172242078713508.ack <at> debbugs.gnu.org>
References: <CAE0SKk2+oAXBLxr5K3dqUA1y_Tpt9345LtogS8y1EEyBgVc_bQ@HIDDEN>
X-Gnu-PR-Message: ack 72397
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 72397 <at> debbugs.gnu.org
Date: Wed, 31 Jul 2024 10:14:01 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 72397 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
72397: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D72397
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to guix-patches@HIDDEN:

Subject: [bug#72397] [PATCH] gnu: Add fennel-ls.
Resent-From: Nicolas Graves <ngraves@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 15 Aug 2024 14:33:01 +0000
Resent-Message-ID: <handler.72397.B72397.172373236430256 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: sydney goose <lomiskiam@HIDDEN>, 72397 <at> debbugs.gnu.org
From: Nicolas Graves <ngraves@HIDDEN>
In-Reply-To: <CAE0SKk2+oAXBLxr5K3dqUA1y_Tpt9345LtogS8y1EEyBgVc_bQ@HIDDEN>
References: <CAE0SKk2+oAXBLxr5K3dqUA1y_Tpt9345LtogS8y1EEyBgVc_bQ@HIDDEN>
Date: Thu, 15 Aug 2024 16:32:01 +0200
Message-ID: <878qwxeu1q.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

On 2024-07-31 00:27, sydney goose wrote:

> * gnu/packages/fennel.scm (fennel-ls): New variable.

> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://git.sr.ht/~xerool/fennel-ls/archive/"
> +                           version ".tar.gz"))
> +       (sha256
> +        (base32 "0nb3yclv9v2mwcnam5djvhg0vgmdsk0gavbvq1ar5v2j0m9pzr7f"))))

Is there a reason why we use archives rather than git fetching here?
Otherwise I would advise against, given the codebase is small.
This would probably also solve the two following lints:

fennel-ls@HIDDEN: the source file name should contain the package name
fennel-ls@HIDDEN: no updater for fennel-ls

> +    (build-system gnu-build-system)
> +    (arguments
> +     (list
> +      #:test-target "test"
> +      #:phases #~(modify-phases %standard-phases
> +                   (delete 'configure)
> +                   (add-after 'build 'patch-fennel-ls
> +                     (lambda* (#:key inputs #:allow-other-keys)
> +                       (substitute* "fennel-ls"
> +                         (("/usr/bin/env .*lua")
> +                          (search-input-file inputs "/bin/lua"))))))
> +      #:make-flags #~(list (string-append "PREFIX="
> +                                          (assoc-ref %outputs "out")))))
> +    (inputs (list lua-5.4 fennel))
> +    (home-page "https://git.sr.ht/~xerool/fennel-ls")
> +    (license license:expat)
> +    (synopsis "Provides intelligent editing features for Fennel files")

Nitpick/proposition : "A language server for Fennel"

> +    (description "A language server for Fennel.  Provides intelligent editing
> +features for Fennel files.")))

Nitpick/proposition : "This package provides a language server for
Fennel that provides intelligent editing features for Fennel files."

Otherwise LGTM. Please send an updated patch ;)

-- 
Best regards,
Nicolas Graves

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 28 Aug 2024 14:26:30 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Aug 28 10:26:30 2024
Received: from localhost ([127.0.0.1]:49468 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1sjJd0-00066R-EN
	for submit <at> debbugs.gnu.org; Wed, 28 Aug 2024 10:26:30 -0400
Received: from eggs.gnu.org ([209.51.188.92]:47906)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1sjJcz-00066F-8u
 for control <at> debbugs.gnu.org; Wed, 28 Aug 2024 10:26:29 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1sjJc1-00074k-Dg
 for control <at> debbugs.gnu.org; Wed, 28 Aug 2024 10:25:29 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:Subject:From:To:Date:in-reply-to:
 references; bh=qqm+pr+H/Xez7YyGHEC1P+DPMez1HLL3I2u2TBgeC+c=; b=OEkkag/syI6iGS
 YU/OXc2L8g6o7XCc0DNEV4HHVJxyU8cm86ZREYiAZBLiwtfnyu+ushm3rrxuGH2KdOBE2X4B4DSDA
 IdFZPlsZBnIiYxshq08aiUcVckZcvES/8JvRDXgO6I5m7eE9UN7kgRSodxdwk1aIN1m3eequBXZ6s
 VYNtQg5RTkrh5xzdxkwBjALjleC1ssEaJLyvgWQgBIw9nHM50BeDTDoVVJxWUGn15fWkX+JCIa16M
 Fyv+FWj6NQ6YNO/9zItxbn67KEowOBGbBRD8yP1KTOVbuWBl25Im1RKibNXZevjEzNnqqH0ffa80M
 3w9aj3cT5uHIIP1acbSA==;
Date: Wed, 28 Aug 2024 16:25:26 +0200
Message-Id: <87bk1clo6h.fsf@HIDDEN>
To: control <at> debbugs.gnu.org
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
Subject: control message for bug #72397
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

tags 72397 + moreinfo
quit

Last modified: Sun, 12 Jan 2025 05:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.