Ludovic Courtès <ludo@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.
Received: (at 72397) by debbugs.gnu.org; 15 Aug 2024 14:32:44 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Aug 15 10:32:44 2024
Received: from localhost ([127.0.0.1]:49496 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1sebWu-0007rw-9j
for submit <at> debbugs.gnu.org; Thu, 15 Aug 2024 10:32:44 -0400
Received: from 8.mo550.mail-out.ovh.net ([178.33.110.239]:33147)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ngraves@HIDDEN>) id 1sebWq-0007rk-WC
for 72397 <at> debbugs.gnu.org; Thu, 15 Aug 2024 10:32:43 -0400
Received: from director7.ghost.mail-out.ovh.net (unknown [10.109.148.65])
by mo550.mail-out.ovh.net (Postfix) with ESMTP id 4Wl6yV677bz1SWM
for <72397 <at> debbugs.gnu.org>; Thu, 15 Aug 2024 14:32:02 +0000 (UTC)
Received: from ghost-submission-6684bf9d7b-8sbc6 (unknown [10.110.178.91])
by director7.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 768561FE57;
Thu, 15 Aug 2024 14:32:02 +0000 (UTC)
Received: from ngraves.fr ([37.59.142.95])
by ghost-submission-6684bf9d7b-8sbc6 with ESMTPSA
id IusAG2IRvmbKowAAKEarfQ
(envelope-from <ngraves@HIDDEN>); Thu, 15 Aug 2024 14:32:02 +0000
Authentication-Results: garm.ovh; auth=pass
(GARM-95G0016a496447-cb79-4904-b4bf-ce8a5ce66d80,
F32C19C47665EA1857B9600CE3BE07B773229FBC) smtp.auth=ngraves@HIDDEN
X-OVh-ClientIp: 81.67.146.208
From: Nicolas Graves <ngraves@HIDDEN>
To: sydney goose <lomiskiam@HIDDEN>, 72397 <at> debbugs.gnu.org
Subject: Re: [bug#72397] [PATCH] gnu: Add fennel-ls.
In-Reply-To: <CAE0SKk2+oAXBLxr5K3dqUA1y_Tpt9345LtogS8y1EEyBgVc_bQ@HIDDEN>
References: <CAE0SKk2+oAXBLxr5K3dqUA1y_Tpt9345LtogS8y1EEyBgVc_bQ@HIDDEN>
Date: Thu, 15 Aug 2024 16:32:01 +0200
Message-ID: <878qwxeu1q.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Ovh-Tracer-Id: 1252563649810129501
X-VR-SPAMSTATE: OK
X-VR-SPAMSCORE: 0
X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeeftddruddtiedgjeejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucenucfjughrpefhvffujghffffkgggtsehttdertddttddtnecuhfhrohhmpefpihgtohhlrghsucfirhgrvhgvshcuoehnghhrrghvvghssehnghhrrghvvghsrdhfrheqnecuggftrfgrthhtvghrnhepteeikeffkeefjeevffdtveekveehveelgffhkeegudfgleehuedvteffudevvdehnecuffhomhgrihhnpehsrhdrhhhtnecukfhppeduvdejrddtrddtrddupdekuddrieejrddugeeirddvtdekpdefjedrheelrddugedvrdelheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepnhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrpdhnsggprhgtphhtthhopedupdhrtghpthhtohepjedvfeeljeesuggvsggsuhhgshdrghhnuhdrohhrghdpoffvtefjohhsthepmhhoheehtddpmhhouggvpehsmhhtphhouhht
DKIM-Signature: a=rsa-sha256; bh=CR32lNxCPA7QpwjhF1DxzqUN8K3xZnzHh4TY0x3WyyY=;
c=relaxed/relaxed; d=ngraves.fr; h=From;
s=ovhmo4487190-selector1; t=1723732323; v=1;
b=th4ZBNADFecpKriaEKs/jrZGFGhTskV2PeUfjYs+69Gj5SH5NrSM71hkL+Ygxcgpu3dVi0LI
j/sfCb7O9R6eZx3oUSP/+A1rWdAQzgKbfl42dB4iV9dZTV+N3JUPVQnfXIn5NjjK0TNtdUw4sTo
Kp1ef8/zD7sCidlqFNjVX6anLhRcikUn7QnrgTmmxfRL2fxbMxgIyBivOU/t6GPE6HchN9xTf0y
enr0ARFtn6+Ymu8J4cs+s1AgUtlZqCrkKqFYQCja+6bYp9KtXmtZCZOOBXwUWzzjFoIYoIBqJI3
/WGhnQvL1R1FrGG677ULHkibbB6bNj9g7vykZI0nJcA/g==
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 72397
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
On 2024-07-31 00:27, sydney goose wrote:
> * gnu/packages/fennel.scm (fennel-ls): New variable.
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append "https://git.sr.ht/~xerool/fennel-ls/archive/"
> + version ".tar.gz"))
> + (sha256
> + (base32 "0nb3yclv9v2mwcnam5djvhg0vgmdsk0gavbvq1ar5v2j0m9pzr7f"))))
Is there a reason why we use archives rather than git fetching here?
Otherwise I would advise against, given the codebase is small.
This would probably also solve the two following lints:
fennel-ls@HIDDEN: the source file name should contain the package name
fennel-ls@HIDDEN: no updater for fennel-ls
> + (build-system gnu-build-system)
> + (arguments
> + (list
> + #:test-target "test"
> + #:phases #~(modify-phases %standard-phases
> + (delete 'configure)
> + (add-after 'build 'patch-fennel-ls
> + (lambda* (#:key inputs #:allow-other-keys)
> + (substitute* "fennel-ls"
> + (("/usr/bin/env .*lua")
> + (search-input-file inputs "/bin/lua"))))))
> + #:make-flags #~(list (string-append "PREFIX="
> + (assoc-ref %outputs "out")))))
> + (inputs (list lua-5.4 fennel))
> + (home-page "https://git.sr.ht/~xerool/fennel-ls")
> + (license license:expat)
> + (synopsis "Provides intelligent editing features for Fennel files")
Nitpick/proposition : "A language server for Fennel"
> + (description "A language server for Fennel. Provides intelligent editing
> +features for Fennel files.")))
Nitpick/proposition : "This package provides a language server for
Fennel that provides intelligent editing features for Fennel files."
Otherwise LGTM. Please send an updated patch ;)
--
Best regards,
Nicolas Graves
guix-patches@HIDDEN:bug#72397; Package guix-patches.
Full text available.Received: (at submit) by debbugs.gnu.org; 31 Jul 2024 10:13:07 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jul 31 06:13:07 2024 Received: from localhost ([127.0.0.1]:49217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1sZ6KQ-0003Vi-4J for submit <at> debbugs.gnu.org; Wed, 31 Jul 2024 06:13:07 -0400 Received: from lists.gnu.org ([209.51.188.17]:54164) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <lomiskiam@HIDDEN>) id 1sZ2oq-0006Cn-ND for submit <at> debbugs.gnu.org; Wed, 31 Jul 2024 02:28:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <lomiskiam@HIDDEN>) id 1sZ2ob-0005kV-87 for guix-patches@HIDDEN; Wed, 31 Jul 2024 02:28:01 -0400 Received: from mail-yb1-xb34.google.com ([2607:f8b0:4864:20::b34]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <lomiskiam@HIDDEN>) id 1sZ2oZ-0004x0-EE for guix-patches@HIDDEN; Wed, 31 Jul 2024 02:28:00 -0400 Received: by mail-yb1-xb34.google.com with SMTP id 3f1490d57ef6-e08724b2a08so4144661276.1 for <guix-patches@HIDDEN>; Tue, 30 Jul 2024 23:27:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722407275; x=1723012075; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=C/wgRRMBECtSXLorLwvu6QAPbOM4xslcz5KK85v0Bbw=; b=VrpPh5TFg7SRMUhzBF3Ke4p6rDZxK7thvoJbTK7Bch4dhaB+/N+r9OOXQxkzJBof7x i8iRFMmmEzhFSZX4KxI7Qvymalp7YBqAJU3ZFmZ9VV30oDCcPHLMgoIb3CeSWaH0AFla fSNaMZq8/wqrnsMcW0TwQPNbB2ZMB8COnpVO2Md+wE9sWt9HhdK5j7/FW1c8w6dR6GJC AK5emoQ0+nWj/r9vE1ucVOSoUTIXvBwOzaP7pSGPonfD3/IUfwgmDYTaoLXZF+u6wLor q0uUly7sLZpKGPdBJivUxqGs4muZcMZNIJumUGxbREJekaHa1L38k2blYC6s6H5iF38q aWtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722407275; x=1723012075; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=C/wgRRMBECtSXLorLwvu6QAPbOM4xslcz5KK85v0Bbw=; b=turbzSQwjzkhBhOPNnBVEpHtAdH1WjKYTZQTcbKDShf6mXK7UhVCv6uounLSlCi2by Y5pADVCHju3pyAh6eC3Grnq+nX7U3yhuSAmc/xyGccF7lodeExv8vCBuyJYwFmxOk+2u 0Fz+/ftZPe9rOrMCEx5PTkDCRDI2r3d2YbAx3W4ljq5O2tpGkGwqdFV9H9GJ27524ugz Tidumnv+rsdGgY9y5QVDZi49q0dY1cBtfraU8KUm7HPh1uhefFI/4j+NaOj6Fs6DZYk1 8ZH80KdOuDB9Mgl+tVnjuhkULpuGOctW8fEJMjHbaICQy0F/26qSksLWVhMqepsnQNrG 9rew== X-Gm-Message-State: AOJu0YzK7I7QJEbWEtGgBhza9X0hhKOzgbnrMnxVMMJMFHhf2AimGQSz TJ8zCpMbZDSXCWO1ONNE9ZanEKVR9k5iVhEm3TpLaL7r5Ox+Me+ezjM81O2Sc8hDzUo4t8C5nEo 00Itd1P2qp3j+XAovBx3LL+S3OepYEo0= X-Google-Smtp-Source: AGHT+IHn7I8zxSTufdSM5MEjcNzMV3gRlwOv/uZFrWdsmJYfftrh007Oj1O82eIp3F7K41xl79sT4yTuus+NLSkoZRQ= X-Received: by 2002:a05:6902:90f:b0:dfb:61e:3ee0 with SMTP id 3f1490d57ef6-e0b543f498dmr14676818276.10.1722407275641; Tue, 30 Jul 2024 23:27:55 -0700 (PDT) MIME-Version: 1.0 From: sydney goose <lomiskiam@HIDDEN> Date: Wed, 31 Jul 2024 00:27:44 -0600 Message-ID: <CAE0SKk2+oAXBLxr5K3dqUA1y_Tpt9345LtogS8y1EEyBgVc_bQ@HIDDEN> Subject: [PATCH] gnu: Add fennel-ls. To: guix-patches@HIDDEN Content-Type: multipart/mixed; boundary="000000000000d30130061e853134" Received-SPF: pass client-ip=2607:f8b0:4864:20::b34; envelope-from=lomiskiam@HIDDEN; helo=mail-yb1-xb34.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 31 Jul 2024 06:13:04 -0400 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.3 (--) --000000000000d30130061e853134 Content-Type: multipart/alternative; boundary="000000000000d3012f061e853132" --000000000000d3012f061e853132 Content-Type: text/plain; charset="UTF-8" * gnu/packages/fennel.scm (fennel-ls): New variable. --000000000000d3012f061e853132 Content-Type: text/html; charset="UTF-8" <div dir="ltr">* gnu/packages/fennel.scm (fennel-ls): New variable.<br></div> --000000000000d3012f061e853132-- --000000000000d30130061e853134 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-gnu-Add-fennel-ls.patch" Content-Disposition: attachment; filename="0001-gnu-Add-fennel-ls.patch" Content-Transfer-Encoding: base64 Content-ID: <f_lz9gt82v0> X-Attachment-Id: f_lz9gt82v0 RnJvbSAwMGRjMTQxZDk5NTM5YWI5YWVjMDFkNWFkZjQzYjBmYWZiMWYzMmY0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpNZXNzYWdlLUlEOiA8MDBkYzE0MWQ5OTUzOWFiOWFlYzAxZDVhZGY0M2Iw ZmFmYjFmMzJmNC4xNzIyNDA3MDQzLmdpdC5sb21pc2tpYW1AZ21haWwuY29tPgpGcm9tOiBjcnVt YnRvbyA8Y3J1bWJAZHVjay5jb20+CkRhdGU6IFdlZCwgMzEgSnVsIDIwMjQgMDA6MTM6NTIgLTA2 MDAKU3ViamVjdDogW1BBVENIXSBnbnU6IEFkZCBmZW5uZWwtbHMuCgoqIGdudS9wYWNrYWdlcy9m ZW5uZWwuc2NtIChmZW5uZWwtbHMpOiBOZXcgdmFyaWFibGUuCgpDaGFuZ2UtSWQ6IElkOGE0NjVm MmM1NDlmMDdmMDE0YWQ5ZjY1YWYyODM3ZThlMThlNmQwCi0tLQogZ251L3BhY2thZ2VzL2x1YS5z Y20gfCAzMSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCiAxIGZpbGUgY2hhbmdlZCwg MzEgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy9sdWEuc2NtIGIvZ251 L3BhY2thZ2VzL2x1YS5zY20KaW5kZXggMWU1ODNiNTliMy4uMGJlOTkxNGU2NSAxMDA2NDQKLS0t IGEvZ251L3BhY2thZ2VzL2x1YS5zY20KKysrIGIvZ251L3BhY2thZ2VzL2x1YS5zY20KQEAgLTEz OTcsNiArMTM5NywzNyBAQCAoZGVmaW5lLXB1YmxpYyBmZW5uZWwKIHN5c3RlbS4iKQogICAgIChs aWNlbnNlIGxpY2Vuc2U6ZXhwYXQpKSkKIAorKGRlZmluZS1wdWJsaWMgZmVubmVsLWxzCisgIChw YWNrYWdlCisgICAgKG5hbWUgImZlbm5lbC1scyIpCisgICAgKHZlcnNpb24gIjAuMS4zIikKKyAg ICAoc291cmNlCisgICAgIChvcmlnaW4KKyAgICAgICAobWV0aG9kIHVybC1mZXRjaCkKKyAgICAg ICAodXJpIChzdHJpbmctYXBwZW5kICJodHRwczovL2dpdC5zci5odC9+eGVyb29sL2Zlbm5lbC1s cy9hcmNoaXZlLyIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgIHZlcnNpb24gIi50YXIuZ3oi KSkKKyAgICAgICAoc2hhMjU2CisgICAgICAgIChiYXNlMzIgIjBuYjN5Y2x2OXYybXdjbmFtNWRq dmhnMHZnbWRzazBnYXZidnExYXI1djJqMG05cHpyN2YiKSkpKQorICAgIChidWlsZC1zeXN0ZW0g Z251LWJ1aWxkLXN5c3RlbSkKKyAgICAoYXJndW1lbnRzCisgICAgIChsaXN0CisgICAgICAjOnRl c3QtdGFyZ2V0ICJ0ZXN0IgorICAgICAgIzpwaGFzZXMgI34obW9kaWZ5LXBoYXNlcyAlc3RhbmRh cmQtcGhhc2VzCisgICAgICAgICAgICAgICAgICAgKGRlbGV0ZSAnY29uZmlndXJlKQorICAgICAg ICAgICAgICAgICAgIChhZGQtYWZ0ZXIgJ2J1aWxkICdwYXRjaC1mZW5uZWwtbHMKKyAgICAgICAg ICAgICAgICAgICAgIChsYW1iZGEqICgjOmtleSBpbnB1dHMgIzphbGxvdy1vdGhlci1rZXlzKQor ICAgICAgICAgICAgICAgICAgICAgICAoc3Vic3RpdHV0ZSogImZlbm5lbC1scyIKKyAgICAgICAg ICAgICAgICAgICAgICAgICAoKCIvdXNyL2Jpbi9lbnYgLipsdWEiKQorICAgICAgICAgICAgICAg ICAgICAgICAgICAoc2VhcmNoLWlucHV0LWZpbGUgaW5wdXRzICIvYmluL2x1YSIpKSkpKSkKKyAg ICAgICM6bWFrZS1mbGFncyAjfihsaXN0IChzdHJpbmctYXBwZW5kICJQUkVGSVg9IgorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGFzc29jLXJlZiAlb3V0cHV0cyAi b3V0IikpKSkpCisgICAgKGlucHV0cyAobGlzdCBsdWEtNS40IGZlbm5lbCkpCisgICAgKGhvbWUt cGFnZSAiaHR0cHM6Ly9naXQuc3IuaHQvfnhlcm9vbC9mZW5uZWwtbHMiKQorICAgIChsaWNlbnNl IGxpY2Vuc2U6ZXhwYXQpCisgICAgKHN5bm9wc2lzICJQcm92aWRlcyBpbnRlbGxpZ2VudCBlZGl0 aW5nIGZlYXR1cmVzIGZvciBGZW5uZWwgZmlsZXMiKQorICAgIChkZXNjcmlwdGlvbiAiQSBsYW5n dWFnZSBzZXJ2ZXIgZm9yIEZlbm5lbC4gIFByb3ZpZGVzIGludGVsbGlnZW50IGVkaXRpbmcKK2Zl YXR1cmVzIGZvciBGZW5uZWwgZmlsZXMuIikpKQorCiAoZGVmaW5lLXB1YmxpYyBhbnRpZmVubmVs CiAgIChwYWNrYWdlCiAgICAgKHZlcnNpb24gIjAuMi4wIikKCmJhc2UtY29tbWl0OiBmNTljNDEy NjgyN2FmM2QyMDQxZDQ5ZjFkMGE4Y2UxMmI0MTQ3MGNmCi0tIAoyLjQ1LjIKCg== --000000000000d30130061e853134--
sydney goose <lomiskiam@HIDDEN>:guix-patches@HIDDEN.
Full text available.guix-patches@HIDDEN:bug#72397; Package guix-patches.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.