X-Loop: help-debbugs@HIDDEN
Subject: bug#75550: smartd fails to send an email
Resent-From: Tomas Volf <~@wolfsden.cz>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Tue, 14 Jan 2025 01:37:01 +0000
Resent-Message-ID: <handler.75550.B.17368186015430 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: report 75550
X-GNU-PR-Package: guix
X-GNU-PR-Keywords:
To: 75550 <at> debbugs.gnu.org
X-Debbugs-Original-To: bug-guix@HIDDEN
Received: via spool by submit <at> debbugs.gnu.org id=B.17368186015430
(code B ref -1); Tue, 14 Jan 2025 01:37:01 +0000
Received: (at submit) by debbugs.gnu.org; 14 Jan 2025 01:36:41 +0000
Received: from localhost ([127.0.0.1]:53370 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tXVrE-0001PW-UX
for submit <at> debbugs.gnu.org; Mon, 13 Jan 2025 20:36:41 -0500
Received: from lists.gnu.org ([2001:470:142::17]:48698)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <~@wolfsden.cz>) id 1tXVrD-0001PF-7v
for submit <at> debbugs.gnu.org; Mon, 13 Jan 2025 20:36:39 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1tXVr5-0003qx-A7
for bug-guix@HIDDEN; Mon, 13 Jan 2025 20:36:31 -0500
Received: from wolfsden.cz ([37.205.8.62])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1tXVr2-0003Q6-SK
for bug-guix@HIDDEN; Mon, 13 Jan 2025 20:36:30 -0500
Received: by wolfsden.cz (Postfix, from userid 104)
id C734C3528DD; Tue, 14 Jan 2025 01:36:22 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
t=1736818582; bh=xaZH6JL7Xit7Cmt91/OPwp0NpEzYtJHnTPKs2RSlIRM=;
h=From:To:Subject:Date;
b=P1bi3ZbulZ5q/G9Un7TSbgq5m2m6ciNtxZpfWnqJ1/A3dnxjAJ4+IQaw80bfJemAo
jZAXgS7FMblmVk/ezF6v9hMVOvyAOmk5moDSGslP/ZCFWnmANFrSzWD0IhnApiwaOs
+r9e/+Qr6emFt8QeLcIU0i76/D5RbQUEDJc9qNAoSO8u00ANZaM8gcgC50nm9gmLcV
HOhvIblJ1cXUHmXSUts6Joa/foiwXa/rf8NoZuz+qx/hIlgMcOdSAG6YqihKIMkcll
ZmPKxp9uT5OIfJ455P7PW7GqvwVshBaSkv/QjV38p1IwZNSKdvAh0ezX+jufZronKB
dAUjJUt/jJ1nI/yMwQMsk9RiMR/enNGY8WfkEPSpeG4kGFXIKSefivKFVtDYK6CNS1
jNTR9Ye07WfwNphm9g1hhLngZ0R0lcxrCAmCzhyH8l+0IvDw6LdzIGve0Tg7Qfflty
uSgDA/T4qmIwGl8bQVSGA5R8WVX2XEZNKJK9hZVq6mNvfy2jEYYmCZMAvf42noN563
O8+d1r7fC27RgX2GHcazJE9l9pWGObNNynFfPJrh0UlQvlgM9KA4yJYGD8MVz/D3E+
HDemogLn6LYpFj8hYqho6Vg/FhZZpIihYXmTeAwEpzI8mudsWHHP9ulB7LAJFQpS3O
IAbMfJ7hr17rg738VfGETkAA=
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden
X-Spam-Level:
X-Spam-Status: No, score=-3.1 required=5.0 tests=ALL_TRUSTED,BAYES_00,
DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED
autolearn=ham autolearn_force=no version=3.4.6
Received: from localhost (unknown [193.32.127.158])
by wolfsden.cz (Postfix) with ESMTPSA id DA05F352756
for <bug-guix@HIDDEN>; Tue, 14 Jan 2025 01:36:21 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
t=1736818582; bh=xaZH6JL7Xit7Cmt91/OPwp0NpEzYtJHnTPKs2RSlIRM=;
h=From:To:Subject:Date;
b=P1bi3ZbulZ5q/G9Un7TSbgq5m2m6ciNtxZpfWnqJ1/A3dnxjAJ4+IQaw80bfJemAo
jZAXgS7FMblmVk/ezF6v9hMVOvyAOmk5moDSGslP/ZCFWnmANFrSzWD0IhnApiwaOs
+r9e/+Qr6emFt8QeLcIU0i76/D5RbQUEDJc9qNAoSO8u00ANZaM8gcgC50nm9gmLcV
HOhvIblJ1cXUHmXSUts6Joa/foiwXa/rf8NoZuz+qx/hIlgMcOdSAG6YqihKIMkcll
ZmPKxp9uT5OIfJ455P7PW7GqvwVshBaSkv/QjV38p1IwZNSKdvAh0ezX+jufZronKB
dAUjJUt/jJ1nI/yMwQMsk9RiMR/enNGY8WfkEPSpeG4kGFXIKSefivKFVtDYK6CNS1
jNTR9Ye07WfwNphm9g1hhLngZ0R0lcxrCAmCzhyH8l+0IvDw6LdzIGve0Tg7Qfflty
uSgDA/T4qmIwGl8bQVSGA5R8WVX2XEZNKJK9hZVq6mNvfy2jEYYmCZMAvf42noN563
O8+d1r7fC27RgX2GHcazJE9l9pWGObNNynFfPJrh0UlQvlgM9KA4yJYGD8MVz/D3E+
HDemogLn6LYpFj8hYqho6Vg/FhZZpIihYXmTeAwEpzI8mudsWHHP9ulB7LAJFQpS3O
IAbMfJ7hr17rg738VfGETkAA=
From: Tomas Volf <~@wolfsden.cz>
Date: Tue, 14 Jan 2025 02:36:21 +0100
Message-ID: <87r056rxbe.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=37.205.8.62; envelope-from=~@wolfsden.cz;
helo=wolfsden.cz
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,
SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
Hi,
I have tried to write a service type for smartd from smartmontools,
however the bundled script fails.
When the test (-m root -M test) is executed, some programs seem to be
missing in the $PATH:
--8<---------------cut here---------------start------------->8---
Jan 14 01:34:19 localhost smartd[3138]: Executing test of <mail> to root ...
Jan 14 01:34:19 localhost smartd[3138]: Test of <mail> to root produced unexpected output (118 bytes) to STDOUT/STDERR:
Jan 14 01:34:19 localhost smartd[3138]: /gnu/store/ks6lnp8hssm9zkka47ysa4qp9xd9f8bv-smartmontools-7.4/etc/smartd_warning.sh: line 132: sed: command not found
Jan 14 01:34:19 localhost smartd[3138]: Test of <mail> to root: failed (32-bit/8-bit exit status: 32512/127)
--8<---------------cut here---------------end--------------->8---
At the start of the script I see:
--8<---------------cut here---------------start------------->8---
export PATH="/usr/local/bin:/usr/bin:/bin"
--8<---------------cut here---------------end--------------->8---
That does not look correct. I am not sure if any wrapping is necessary.
Have a nice day,
Tomas
--
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Tomas Volf <~@wolfsden.cz> Subject: bug#75550: Acknowledgement (smartd fails to send an email) Message-ID: <handler.75550.B.17368186015430.ack <at> debbugs.gnu.org> References: <87r056rxbe.fsf@HIDDEN> X-Gnu-PR-Message: ack 75550 X-Gnu-PR-Package: guix Reply-To: 75550 <at> debbugs.gnu.org Date: Tue, 14 Jan 2025 01:37:01 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): bug-guix@HIDDEN If you wish to submit further information on this problem, please send it to 75550 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 75550: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D75550 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
X-Loop: help-debbugs@HIDDEN
Subject: bug#75550: smartd fails to send an email
Resent-From: 45mg <45mg.writes@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Tue, 14 Jan 2025 05:31:02 +0000
Resent-Message-ID: <handler.75550.B75550.173683266113717 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75550
X-GNU-PR-Package: guix
X-GNU-PR-Keywords:
To: Tomas Volf <~@wolfsden.cz>, 75550 <at> debbugs.gnu.org
Received: via spool by 75550-submit <at> debbugs.gnu.org id=B75550.173683266113717
(code B ref 75550); Tue, 14 Jan 2025 05:31:02 +0000
Received: (at 75550) by debbugs.gnu.org; 14 Jan 2025 05:31:01 +0000
Received: from localhost ([127.0.0.1]:53627 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tXZW0-0003ZB-QB
for submit <at> debbugs.gnu.org; Tue, 14 Jan 2025 00:31:01 -0500
Received: from mail-pj1-x1041.google.com ([2607:f8b0:4864:20::1041]:52611)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <45mg.writes@HIDDEN>)
id 1tXZVx-0003Yv-2P
for 75550 <at> debbugs.gnu.org; Tue, 14 Jan 2025 00:30:58 -0500
Received: by mail-pj1-x1041.google.com with SMTP id
98e67ed59e1d1-2ee51f8c47dso6831361a91.1
for <75550 <at> debbugs.gnu.org>; Mon, 13 Jan 2025 21:30:57 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1736832650; x=1737437450; darn=debbugs.gnu.org;
h=mime-version:message-id:date:references:in-reply-to:subject:to:from
:from:to:cc:subject:date:message-id:reply-to;
bh=4CrSdoabVx4mRE+ilB4SiA2z605KMQd32lH5XCipaOc=;
b=Kk52yzOy4TEMTkgDdUqrwEHVNEeem5bDoUf9koQmcjQuWSGzB0Tuiu22Q6H7B60q0j
wc9vD8SbZSByjQMRcOOHAObmfeVq618nHXLKNxZ1V2AKugrTt/sR2TAFqMxyJ/AkISMb
65DVMva3x3QI1yZ6S56fY49qA6BNGR0Kkx+aBZd2pJ1yO4BhEoPRqDlU60vC+EhfKTiD
PufDzZmF6h72BPxYsFQfUsn6cog6RxgR3NdWBiS+mRSBgqSrUx/rpSI3Wy9w2KDQ43iz
YWQ2lLZEdq/R3Z/RikuFfGq4sB9pj9IsBIUvoYi5YXhC4N8xfWbIu6iCaNKprsaOnjSm
QSLA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1736832650; x=1737437450;
h=mime-version:message-id:date:references:in-reply-to:subject:to:from
:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=4CrSdoabVx4mRE+ilB4SiA2z605KMQd32lH5XCipaOc=;
b=s5t72i3eTvB4oVayqtb3X8xt7B792o9w0CzKTbvY9IGxSCCX/B7yUaMwKGeBjZii41
+DGALqNlTQqkcFfdJAAC2mIrulRHTVV3/jWyxp1v0momE1AnViTUcU3ENsHEeg5c0kbw
9rT1A7sgTr43XhHrfR7byIqXdRKKXil1Yo1A9UD33w7X6KALzrb3zZlU5JkxhD+28Rl6
PP4Si8p8NsKmkHTLoxteaQSPOR9esdvMWUNzKkfKk8yhJJh8flC+OaPoYfi2OxkhPdVd
7P6FmuAIneZrg/JIbte3UoWPtSpIysjwm/MGaJPQEDHsRqS8swzGzFA1dMSVhvODymL6
rEWQ==
X-Forwarded-Encrypted: i=1;
AJvYcCWOCUurhvNF0Yko10cl2Sn0l850uD86tIiW5FdB+Skni99u2Z62zqHNp2WQ1JpxQhTLafC5hA==@debbugs.gnu.org
X-Gm-Message-State: AOJu0YzctZKwRIB1laIVGaqMbQcV8hubg/t/gEjwgMr5TR0N7gKN8mC1
2X/uNPubakRyjJpOOEisWKKZ0iC2XrxbfY9cxy1zxxg03IfEWTunpNLnddBA
X-Gm-Gg: ASbGnctDs2KJdLLi8OijGQpW8+bkJSVR7sS61qSH9We+Zl8woXxn0cpOtpYCp8//9Eq
0fk9DXLT539sJQQRBNehrC7hgqL941Y30xCTdYREzuU1fZUEJt1yFhF8ELSqIHyotqk51qLo1jf
t42xsMPjg4dnXUCkMiWejr2b5G8/lklsIJyB4Ag2fIISZ06uDUCJkF4ahQXZa3D0ltCq0za2bEs
WDnjXtd8ZG5Oh2OwvzQ++YRAUC6MJc50zKWKVjrZSYetoXGoknARRm+6w==
X-Google-Smtp-Source: AGHT+IGqshjxLqjOFRjLZyl4bk9wSdIVX6oworjw/SA5jPPngqPVyBRmtVFlyZKgEtVjJHH0ugFw1w==
X-Received: by 2002:a17:90b:5188:b0:2ee:df57:b194 with SMTP id
98e67ed59e1d1-2f548eceb00mr31068965a91.21.1736832650361;
Mon, 13 Jan 2025 21:30:50 -0800 (PST)
Received: from guix1 (utm3.nitt.edu. [14.139.162.2])
by smtp.gmail.com with ESMTPSA id
98e67ed59e1d1-2f54a289118sm12039896a91.13.2025.01.13.21.30.48
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 13 Jan 2025 21:30:50 -0800 (PST)
From: 45mg <45mg.writes@HIDDEN>
In-Reply-To: <87r056rxbe.fsf@HIDDEN>
References: <87r056rxbe.fsf@HIDDEN>
Date: Tue, 14 Jan 2025 05:30:47 +0000
Message-ID: <87wmeyc67s.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Hi Tomas,
Tomas Volf <~@wolfsden.cz> writes:
> Hi,
>
> I have tried to write a service type for smartd from smartmontools,
> however the bundled script fails.
>
> When the test (-m root -M test) is executed, some programs seem to be
> missing in the $PATH:
>
> --8<---------------cut here---------------start------------->8---
> Jan 14 01:34:19 localhost smartd[3138]: Executing test of <mail> to root ...
> Jan 14 01:34:19 localhost smartd[3138]: Test of <mail> to root produced unexpected output (118 bytes) to STDOUT/STDERR:
> Jan 14 01:34:19 localhost smartd[3138]: /gnu/store/ks6lnp8hssm9zkka47ysa4qp9xd9f8bv-smartmontools-7.4/etc/smartd_warning.sh: line 132: sed: command not found
> Jan 14 01:34:19 localhost smartd[3138]: Test of <mail> to root: failed (32-bit/8-bit exit status: 32512/127)
> --8<---------------cut here---------------end--------------->8---
I've seen other package definitions deal with this problem by using
`substitute*` to replace executables specified in scripts, etc. (like
sed here) with the corresponding store paths. See 'light' in (gnu
packages linux) for an example.
X-Loop: help-debbugs@HIDDEN
Subject: bug#75550: [PATCH] gnu: smartmontools: Fix PATH in smartd_warning.sh.
References: <87r056rxbe.fsf@HIDDEN>
In-Reply-To: <87r056rxbe.fsf@HIDDEN>
Resent-From: Tomas Volf <~@wolfsden.cz>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: sharlatanus@HIDDEN, bug-guix@HIDDEN
Resent-Date: Tue, 14 Jan 2025 23:41:03 +0000
Resent-Message-ID: <handler.75550.B75550.173689803523527 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75550
X-GNU-PR-Package: guix
X-GNU-PR-Keywords:
To: 75550 <at> debbugs.gnu.org, guix-patches@HIDDEN
Cc: Tomas Volf <~@wolfsden.cz>, Sharlatan Hellseher <sharlatanus@HIDDEN>
X-Debbugs-Original-Xcc: Sharlatan Hellseher <sharlatanus@HIDDEN>
Received: via spool by 75550-submit <at> debbugs.gnu.org id=B75550.173689803523527
(code B ref 75550); Tue, 14 Jan 2025 23:41:03 +0000
Received: (at 75550) by debbugs.gnu.org; 14 Jan 2025 23:40:35 +0000
Received: from localhost ([127.0.0.1]:56148 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tXqWQ-00067O-TE
for submit <at> debbugs.gnu.org; Tue, 14 Jan 2025 18:40:35 -0500
Received: from wolfsden.cz ([37.205.8.62]:37034)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <~@wolfsden.cz>) id 1tXqWL-000674-CF
for 75550 <at> debbugs.gnu.org; Tue, 14 Jan 2025 18:40:33 -0500
Received: by wolfsden.cz (Postfix, from userid 104)
id 78AA5356687; Tue, 14 Jan 2025 23:40:27 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
t=1736898027; bh=GbcOvYJg8uRvTCKQKVZQEtT+9/4vwZsW0OeI3M+u+HQ=;
h=From:To:Cc:Subject:Date;
b=AAtqvEBLU3AdjXME5ZH9TXX0DKdyA197fqPLL424/eBjTJ5AjnGn4HTHHR7a0xU3l
qn5i7/cKnoSlEzSwBoAhPWp7TCCFhQ8Y55WiVSXfdonucZldJK0e2mtp7Z2Nznro9K
6EFCzQSsDQfdnx1Ct7CIiI8vVYEJsBiyJnBcRQ8wJ2jU5Oox4xAjgAsWWojIOfZdWP
P8ZdK8YefFnajrY4D87rne5hJupa9qiktpPNYEtuEMcFlv3ZOTyPgzW8fO226dPwSw
rf/R+mTY8NrJpLsWfi8bgGkHu4sgcsrGHRpauOg9ffv3cnQkXKLGsY6wgv9r9vsUfp
NDOMkHlHHUi8aHCyLklQUZrydlMbJfCCgqiJ/eqpbac6+FQ/4BUQoilr2Ygkwyybnn
8YWAY2DGkiSP34J0B7zo3uZdgtbzcvRuAkZd9DMZ0g8Nsqty7C7Bu7OcNkNBLJYmIQ
BXtJyPuCwuxj6Yt99Kv5chzNzT+rQoR62z2Q1pAAGdENfkkwPwXpqHTQRBYWvWlQRH
rrEe/5k5LAZOTi2GF8aFNQmrKBNUN8ck1+0qj4Lz2lINlNuX11nHhkSnc7E0GpY2zF
OSEsWbT+lM2HEUnLHC17gugmA80U9GBruXrOCsrfbtq/KPNP+TiwJPODbRxDExh93n
bmPtDAIaMW9+SBxhQ5ssLfM4=
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden
X-Spam-Level:
X-Spam-Status: No, score=-3.1 required=5.0 tests=ALL_TRUSTED,BAYES_00,
DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED
autolearn=unavailable autolearn_force=no version=3.4.6
Received: from localhost (unknown [193.32.127.158])
by wolfsden.cz (Postfix) with ESMTPSA id 6AC85356609;
Tue, 14 Jan 2025 23:40:26 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
t=1736898026; bh=GbcOvYJg8uRvTCKQKVZQEtT+9/4vwZsW0OeI3M+u+HQ=;
h=From:To:Cc:Subject:Date;
b=ohqVSpGHiitCIgF8YK9Mb4tntzEe/mHpwBe+jZ+20NWjA+LHIAoHBmq1Cez94UVfY
Np/3Ncp0ZmPEH9xUCDQ3NNZXRXNjC5Qnn0TT2vsqLxv86gsk+zKENWqW+QsmM+zqCN
PYZJ++rJ9I4t3xbVMZ1erjjMy51s8UmE4ab4pcc7Vg+/AWg7IDa7MLKLoY6/Sr4xxe
GV+uS772WES4biC3EMtfA4kHguM5vbJv3tX/RFkGIgNCgLnelkHZnYOej/8PqACGYG
npZFLlCy1TAskcYHEqW+9FLjOWWlZ/W+QsHsVwP3DI9mNuC9Tu3F+46Y3BKYJmxUg1
tjnLwYmNVXyRxXnd40yr4tNZj81cXLFFbjhWClVwEdDnShspdkEYpPL4wncT9NZSZm
Wix07pZV49cjRICPg/6wRtBnid/bIEkTI4hD0kN8H7FqzKMqh1PV+NujFTMYHhPNVd
ZJzDlwxtPgYPOYojjwlQSD+hDZaykUFEACz5vAKbcoqOclqYMCOVhaTQoD3oQL2UGV
Y5Lqbsb2U1Huil9dfio/jrVYoX9MVxi5SAUd3MRSEE0pZ1B8ZnytGw5RE865BCN/Zc
GRoueh972yYJUcZjy9OcKA2LJXfkztqunIsRkEHSoqDyBDz+iviy8grjOndwBvo7uU
T2RPagqes+TbOUwxwd6LLFtM=
From: Tomas Volf <~@wolfsden.cz>
Date: Wed, 15 Jan 2025 00:40:19 +0100
Message-ID: <d7320ddeb1939ce0eeeea10f7267883692c269e7.1736898019.git.~@wolfsden.cz>
X-Mailer: git-send-email 2.47.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
The script started with reset of the $PATH to a value not suitable to Guix.
In addition, the script requires coreutils and sed, so add those into the
$PATH.
* gnu/packages/admin.scm (smartmontools)[arguments]<#:phases>: Add 'fix-path.
Change-Id: Ide97f572e6f369fe24337f945474dc7a65584eda
---
gnu/packages/admin.scm | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 7f50d5f4e9..098e21ff8a 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -2921,8 +2921,19 @@ (define-public smartmontools
"0gcrzcb4g7f994n6nws26g6x15yjija1gyzd359sjv7r3xj1z9p9"))))
(build-system gnu-build-system)
(arguments
- (list #:make-flags
- #~(list "BUILD_INFO=\"(Guix)\"")))
+ (list
+ #:make-flags
+ #~(list "BUILD_INFO=\"(Guix)\"")
+ #:phases
+ #~(modify-phases %standard-phases
+ (add-after 'install 'fix-path
+ (lambda _
+ (substitute* (string-append #$output "/etc/smartd_warning.sh")
+ (("export PATH=.*$" all)
+ (string-append "PATH="
+ #$(file-append sed "/bin") ":"
+ #$(file-append coreutils "/bin") ":"
+ "$PATH\n"))))))))
(inputs (list libcap-ng))
(home-page "https://www.smartmontools.org/")
(synopsis "S.M.A.R.T. harddisk control and monitoring tools")
--
2.47.1
Received: (at control) by debbugs.gnu.org; 14 Jan 2025 23:42:43 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 14 18:42:43 2025 Received: from localhost ([127.0.0.1]:56163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tXqYV-0006C8-0s for submit <at> debbugs.gnu.org; Tue, 14 Jan 2025 18:42:43 -0500 Received: from wolfsden.cz ([37.205.8.62]:58662) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <~@wolfsden.cz>) id 1tXqYS-0006Bx-Tl for control <at> debbugs.gnu.org; Tue, 14 Jan 2025 18:42:42 -0500 Received: by wolfsden.cz (Postfix, from userid 104) id 977FE354ABA; Tue, 14 Jan 2025 23:42:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1736898159; bh=yZr11v2RwMHCOvtfJqQcnFOHiKtsvYo+ehDgqrEVI14=; h=Date:To:From:Subject; b=v76vqFEyb3If/iFYUS+BoUL/GcSmRhK0BN3TaQIMCLbNjQsqWuktuTm8VoLaMrSb6 vS27y3EFRykies79BtuSg/jwq1CAX2g0jSis0tgZv0IhXGsMpVpNwwLJ5bn0RkgDT3 zF/UpxOmmy2lHXEn9YJDqvoBHP05CkHgcfl+KhkTJwrTx7KcnZeXL0RLm6rCxRAaJh xXlnFmUDhBsk9U1iojrdIwIEkczU45S9WKSHe3scWAEQFMjxidLx2o6OCJK1XrVE7C 0JtwQuzrAGtfZJF9ev3pEoP1OE0lW8huRhnt9NbcpufT/nFRDGcOXfzwWBR/fYsu4F QHRPtsPG3+31yfTAiTvtNEOnasW4wIZyOFLPHcjQ0gWxBEsohhQdemfeJG2g/7aYiU J9mL22Lpud/n3WfltfZmabfV9MrigkoyRFR7xc24TmjworwVx8D0k0UMAiYExuJVEH kn5IwFzYYj0ExgUGXkWsoXM+uCupZpB5lGVZ5RjMuc6xCp2wVKCCbKcK30vQcFfTrV eTr8+KbG6FxoBs9zIBM7W34YyBzfnSIoQGFobYYCc8EMH3NQ+XuxuqqUWhV0JvBaH9 EN/4hVvkfTGqD5LvFAle/j9ClhO2V7HhwEKTRVTSQQ+CSNNO5Gy9CF/bPcafwSkeRI 5trU/EZiF2r6LNhywzP8lGuI= X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (unknown [193.32.127.158]) by wolfsden.cz (Postfix) with ESMTPSA id 3EE20356706 for <control <at> debbugs.gnu.org>; Tue, 14 Jan 2025 23:42:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1736898159; bh=yZr11v2RwMHCOvtfJqQcnFOHiKtsvYo+ehDgqrEVI14=; h=Date:To:From:Subject; b=v76vqFEyb3If/iFYUS+BoUL/GcSmRhK0BN3TaQIMCLbNjQsqWuktuTm8VoLaMrSb6 vS27y3EFRykies79BtuSg/jwq1CAX2g0jSis0tgZv0IhXGsMpVpNwwLJ5bn0RkgDT3 zF/UpxOmmy2lHXEn9YJDqvoBHP05CkHgcfl+KhkTJwrTx7KcnZeXL0RLm6rCxRAaJh xXlnFmUDhBsk9U1iojrdIwIEkczU45S9WKSHe3scWAEQFMjxidLx2o6OCJK1XrVE7C 0JtwQuzrAGtfZJF9ev3pEoP1OE0lW8huRhnt9NbcpufT/nFRDGcOXfzwWBR/fYsu4F QHRPtsPG3+31yfTAiTvtNEOnasW4wIZyOFLPHcjQ0gWxBEsohhQdemfeJG2g/7aYiU J9mL22Lpud/n3WfltfZmabfV9MrigkoyRFR7xc24TmjworwVx8D0k0UMAiYExuJVEH kn5IwFzYYj0ExgUGXkWsoXM+uCupZpB5lGVZ5RjMuc6xCp2wVKCCbKcK30vQcFfTrV eTr8+KbG6FxoBs9zIBM7W34YyBzfnSIoQGFobYYCc8EMH3NQ+XuxuqqUWhV0JvBaH9 EN/4hVvkfTGqD5LvFAle/j9ClhO2V7HhwEKTRVTSQQ+CSNNO5Gy9CF/bPcafwSkeRI 5trU/EZiF2r6LNhywzP8lGuI= Date: Wed, 15 Jan 2025 00:42:38 +0100 Message-ID: <338703f3736c814d1d204e9b74acbdc9@HIDDEN> To: control <at> debbugs.gnu.org From: Tomas Volf <~@wolfsden.cz> Subject: control message for bug #75550 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) reassign 75550 guix-patches quit
X-Loop: help-debbugs@HIDDEN
Subject: [bug#75550] [PATCH] gnu: smartmontools: Fix PATH in smartd_warning.sh.
Resent-From: Hilton Chain <hako@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 15 Jan 2025 02:54:01 +0000
Resent-Message-ID: <handler.75550.B75550.17369096063949 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75550
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords:
To: Tomas Volf <~@wolfsden.cz>
Cc: 75550 <at> debbugs.gnu.org, Sharlatan Hellseher <sharlatanus@HIDDEN>
Received: via spool by 75550-submit <at> debbugs.gnu.org id=B75550.17369096063949
(code B ref 75550); Wed, 15 Jan 2025 02:54:01 +0000
Received: (at 75550) by debbugs.gnu.org; 15 Jan 2025 02:53:26 +0000
Received: from localhost ([127.0.0.1]:56420 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tXtX3-00011d-VM
for submit <at> debbugs.gnu.org; Tue, 14 Jan 2025 21:53:26 -0500
Received: from mx.boiledscript.com ([2a01:4f8:10b:392::42]:54700)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <hako@HIDDEN>)
id 1tXtX0-00011S-3f
for 75550 <at> debbugs.gnu.org; Tue, 14 Jan 2025 21:53:23 -0500
Date: Wed, 15 Jan 2025 10:50:35 +0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space;
s=mail; t=1736909600;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
in-reply-to:in-reply-to:references:references;
bh=vHKuPJy6nnTRo1fsEF1794785hmEUTKCNoPf6J4QFqo=;
b=VCHtuHiKVcI6R6O9kqpQZBIewqosfvwquNqyRPGc8++r5yRLU+rCBX8ic9LPYItvZM8xTL
JiyM86g2d8M0wWIcPDztBy6PQFLZFSxFE37Bicd1vJv4VDJ8iDh8Xnvytie1oCgHdjlKMb
s14YA0Y1vs3Xqyh93QvSgDfFweewJYHRXGy4JvEP2wNv75x4ZDaqfWGMcQwiDiviK7m+Li
ToRfhQyCQGHuGYrr0cHjDDc5rLVhpDWd1br2K8ByxGPVWi3MRCdzjgY5dakBpBk40Ri4Ju
Eav3LLu5gw+fkeN6/KEBC4s4It7fM5naPM5mXggIdzf1x++/bgvfxf/Ek+zH1w==
Message-ID: <87ed14ssck.wl-hako@HIDDEN>
From: Hilton Chain <hako@HIDDEN>
In-Reply-To: <d7320ddeb1939ce0eeeea10f7267883692c269e7.1736898019.git.~@wolfsden.cz>
References: <87r056rxbe.fsf@HIDDEN>
<d7320ddeb1939ce0eeeea10f7267883692c269e7.1736898019.git.~@wolfsden.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Hi Tomas,
On Wed, 15 Jan 2025 07:40:19 +0800,
Tomas Volf wrote:
>
> The script started with reset of the $PATH to a value not suitable to Guix.
> In addition, the script requires coreutils and sed, so add those into the
> $PATH.
>
> * gnu/packages/admin.scm (smartmontools)[arguments]<#:phases>: Add 'fix-path.
>
> Change-Id: Ide97f572e6f369fe24337f945474dc7a65584eda
> ---
> gnu/packages/admin.scm | 15 +++++++++++++--
> 1 file changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
> index 7f50d5f4e9..098e21ff8a 100644
> --- a/gnu/packages/admin.scm
> +++ b/gnu/packages/admin.scm
> @@ -2921,8 +2921,19 @@ (define-public smartmontools
> "0gcrzcb4g7f994n6nws26g6x15yjija1gyzd359sjv7r3xj1z9p9"))))
> (build-system gnu-build-system)
> (arguments
> - (list #:make-flags
> - #~(list "BUILD_INFO=\"(Guix)\"")))
> + (list
> + #:make-flags
> + #~(list "BUILD_INFO=\"(Guix)\"")
> + #:phases
> + #~(modify-phases %standard-phases
> + (add-after 'install 'fix-path
> + (lambda _
> + (substitute* (string-append #$output "/etc/smartd_warning.sh")
> + (("export PATH=.*$" all)
> + (string-append "PATH="
> + #$(file-append sed "/bin") ":"
> + #$(file-append coreutils "/bin") ":"
> + "$PATH\n"))))))))
Please add sed and coreutils-minimal to inputs and use search-input-file or
this-package-input instead.
For smartmontools the proper way is to set --with-scriptpath='...' configure
flag, which is documented in its INSTALL file. (It can be disabled with a 'no'
value as well.)
> (inputs (list libcap-ng))
> (home-page "https://www.smartmontools.org/")
> (synopsis "S.M.A.R.T. harddisk control and monitoring tools")
> --
> 2.47.1
Thanks
X-Loop: help-debbugs@HIDDEN
Subject: [bug#75550] [PATCH] gnu: smartmontools: Fix PATH in smartd_warning.sh.
Resent-From: Tomas Volf <~@wolfsden.cz>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 24 Jan 2025 15:33:02 +0000
Resent-Message-ID: <handler.75550.B75550.173773272224261 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75550
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords:
To: Hilton Chain <hako@HIDDEN>
Cc: 75550 <at> debbugs.gnu.org, Sharlatan Hellseher <sharlatanus@HIDDEN>
Received: via spool by 75550-submit <at> debbugs.gnu.org id=B75550.173773272224261
(code B ref 75550); Fri, 24 Jan 2025 15:33:02 +0000
Received: (at 75550) by debbugs.gnu.org; 24 Jan 2025 15:32:02 +0000
Received: from localhost ([127.0.0.1]:46585 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tbLf8-0006J4-0o
for submit <at> debbugs.gnu.org; Fri, 24 Jan 2025 10:32:02 -0500
Received: from wolfsden.cz ([37.205.8.62]:43814)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <~@wolfsden.cz>) id 1tbLf5-0006Ik-Cc
for 75550 <at> debbugs.gnu.org; Fri, 24 Jan 2025 10:32:00 -0500
Received: by wolfsden.cz (Postfix, from userid 104)
id 5F41133C994; Fri, 24 Jan 2025 15:31:57 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
t=1737732717; bh=mZ7+eBtbOYeU9QslzRBCmUBslsVQfxdVWNUbJLZ7/BQ=;
h=From:To:Cc:Subject:In-Reply-To:References:Date;
b=nu/1fgYjetXKZI4gJWQMvJdLkQKCnwQg4CsVQLuRlNteGDxUur1P77edYkxhKDmAC
UCBbiAg6B5HGS+4Uswgv39Ox+97Xrq6TxDXgLNVqWbcg5KTeZ7W48U9hvXRhcrwANB
YXxM107hasa547FV/OdyI362CpyQjCL1YXs7JxIDgAGYt7Qp9iaZQOMFiBmc0rQ1DD
9vLxvlN4Xso5BE8UgUpzvj4sNoaixWzTouPykeCVLlWUaI5een7X7T2/9D0WJlqLrq
NOTwvcMt4rf5aE7pGb/7tY33+Pii3sTNS8+VMCSru5inRt89d7r5J4i8G+OYSZe7Jp
73Uh6EMs3HL5IW+DoMvBRsL7NASAnTY0skDed/xmaTNo4QwEQQQCC+TnUkcULvwAJt
suNRjn1NFfj3tDVSL48AykUlfolvMdlqnMD+sa0oInNyw4Fpvlx60L+ajqbMt19ty2
87g4djHW5xf1mdQzURNVW+a4BYvH9eYB5t+lo1TDeSdV+xAYAWNDrMlHF+bmZTmisN
NqERAq2SDi5dVVTFCEbX5oZwRZmOT/TMoIi8gBLA4SGhToEWO5CZMMfhnc4cq+um/S
Q86n8M7Noh/TnLF1hxWSSPYbLlPmerx2YDerfT/B7GoLyoDyONsOhzEi75SwWCaOcw
vyMLxB3ugQ0+Lf8j6mNIUR+4=
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden
X-Spam-Level:
X-Spam-Status: No, score=-3.1 required=5.0 tests=ALL_TRUSTED,BAYES_00,
DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED
autolearn=ham autolearn_force=no version=3.4.6
Received: from localhost (unknown [128.0.188.242])
by wolfsden.cz (Postfix) with ESMTPSA id 8513833B3F1;
Fri, 24 Jan 2025 15:31:56 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
t=1737732716; bh=mZ7+eBtbOYeU9QslzRBCmUBslsVQfxdVWNUbJLZ7/BQ=;
h=From:To:Cc:Subject:In-Reply-To:References:Date;
b=VvsahdyRWxqKKS3wlcTcbA7Ynhd7AgtYXZuZHF9TT35aYsq3aG+J6jbuCaFVaGFsT
Ki/CryJlDf9JJEtixDfARpwRBs2S3tTFAAkMc7ljN6/j8MUu4uFkT8yc8JrhCteFxy
NTdrhSN6U21R7IWApreNWPLpGV7C1N2G2GljlGRxX5qBxOw5KCud/PjF7ttErpIQsG
i55Ym/iYwqLSCg5pd8+mJ5YghRDxxw1r9nVOd1wAxWMoHDjQagmYI5XkrsB1DHuZ35
IhuGENwTdnz8Ei8AgC7ykzA9txdXe2s+lDGQiuvqJueh7eginhMphr5nriHQg2KutK
jIW16Nz9LTRGK5NGw95R+M6vTG27aWMdWk+UHu22FTWiAc6G1aJF5FdvwIx6gWMV9a
DzJahStcvCqFzwYBbk5VaDZJ4uMxuNKKhEXWHwzdFRuKpl6yTsqaD1h7RW+lNWyU+1
89Tpk1fo3w92vggioaEFYdTPJO1JRw3sBHdVlDXl2l1LdMEAPJrMxc2xfGy4RwDA+7
YzWxuxfyPNu2l6POCZFtS+XANd6oOAfLlLGJV4mtUvGq+2P1bsuBCb+ZA8QE1mY0Cm
Wsz+Kfxu370jeAyiC7YiCBBVemt8uFxWxj5/jgmqR1D6OfMVIXz9aVtllXUPx6l1ue
SG/VSFzpOkdFe4FioS7NI6kg=
From: Tomas Volf <~@wolfsden.cz>
In-Reply-To: <87ed14ssck.wl-hako@HIDDEN> (Hilton Chain's message of
"Wed, 15 Jan 2025 10:50:35 +0800")
References: <87r056rxbe.fsf@HIDDEN>
<d7320ddeb1939ce0eeeea10f7267883692c269e7.1736898019.git.~@wolfsden.cz>
<87ed14ssck.wl-hako@HIDDEN>
Date: Fri, 24 Jan 2025 16:31:56 +0100
Message-ID: <877c6kjkib.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
Thank you for the review, responses below.
Hilton Chain <hako@HIDDEN> writes:
> Hi Tomas,
>
> On Wed, 15 Jan 2025 07:40:19 +0800,
> Tomas Volf wrote:
>>
>> The script started with reset of the $PATH to a value not suitable to Gu=
ix.
>> In addition, the script requires coreutils and sed, so add those into the
>> $PATH.
>>
>> * gnu/packages/admin.scm (smartmontools)[arguments]<#:phases>: Add 'fix-=
path.
>>
>> Change-Id: Ide97f572e6f369fe24337f945474dc7a65584eda
>> ---
>> gnu/packages/admin.scm | 15 +++++++++++++--
>> 1 file changed, 13 insertions(+), 2 deletions(-)
>>
>> diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
>> index 7f50d5f4e9..098e21ff8a 100644
>> --- a/gnu/packages/admin.scm
>> +++ b/gnu/packages/admin.scm
>> @@ -2921,8 +2921,19 @@ (define-public smartmontools
>> "0gcrzcb4g7f994n6nws26g6x15yjija1gyzd359sjv7r3xj1z9p9")=
)))
>> (build-system gnu-build-system)
>> (arguments
>> - (list #:make-flags
>> - #~(list "BUILD_INFO=3D\"(Guix)\"")))
>> + (list
>> + #:make-flags
>> + #~(list "BUILD_INFO=3D\"(Guix)\"")
>> + #:phases
>> + #~(modify-phases %standard-phases
>> + (add-after 'install 'fix-path
>> + (lambda _
>> + (substitute* (string-append #$output "/etc/smartd_warning=
.sh")
>> + (("export PATH=3D.*$" all)
>> + (string-append "PATH=3D"
>> + #$(file-append sed "/bin") ":"
>> + #$(file-append coreutils "/bin") ":"
>> + "$PATH\n"))))))))
>
> Please add sed and coreutils-minimal to inputs and use search-input-file =
or
> this-package-input instead.
Why? I will of course do so, but would first like to understand why.
The current way seems to work and keeps all the references in just one
place. If I switch to the suggested approach, both `sed' and
`coreutils' will be referenced in two places (once in the `inputs' and
once here) and those will need to be kept in sync. So, uh, why do it?
>
> For smartmontools the proper way is to set --with-scriptpath=3D'...' conf=
igure
> flag, which is documented in its INSTALL file. (It can be disabled with =
a 'no'
> value as well.)
This does indeed seem to be more elegant approach, will use it for v2.
>
>> (inputs (list libcap-ng))
>> (home-page "https://www.smartmontools.org/")
>> (synopsis "S.M.A.R.T. harddisk control and monitoring tools")
>> --
>> 2.47.1
>
> Thanks
Tomas
=2D-=20
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.
--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQJCBAEBCgAsFiEEt4NJs4wUfTYpiGikL7/ufbZ/wakFAmeTsmwOHH5Ad29sZnNk
ZW4uY3oACgkQL7/ufbZ/wanI5w//RgKJ61iB5BO70O8AdgNZz8hvv5XStvP8vani
KyDTeWSd1Rnkc5R2nxJjwJuWtTJKIf2yGPsLyU5YO9gNc2sj2h1aQ6R6BV69bOVe
rvksqUNrYuWmfiEE43FdESjI1b1oSrSaoAxg7RMxXcWT1yzImSxOeVKy23HSFHV6
tlyg2evu9FbqwDyNUJP22IKP6ogaaerbTI7+RfpIyUWauMuNGb1azzVhcS8I1t/J
nZA3qZFn4g0tKxwU1EtV0eyTosjphJf5YZoFJh1IOopzISk2FIPpHYYrBOIS1T8u
Jtf+awfffy80E5Up7RBh8lIlfo6co+fPXsgwHNcNCqOABz2dVkOdnGJbHe3G+wDD
a+kTlvuRVHCm19gr0AaN/6stIJkellIBITG8VDY+LBGvFUZYlkaSlMkoV02VEu/b
0uhr5Tt5Mc9g076/NMODPI3GWMYiiGAMvJjyB4VigbfDaEWF4bULaownYWsYvo5u
RlOZljVwAMplNElR0ST7PZIfbR1teCqX4QNzyeaMtM6Q6etQgemNRa1rO63zw9Y5
lNS8xO44SgfOxQOQlw2/UGHROeZuqmEShU9RmBsnS77R0hKalYPGOqN3w2faSBd3
R47YEKJQMCrubyX0xPppyNm8BiI2ojUa7DB2Jn5h5e0BMEosPSz30ZGa3ltnR4OE
XXFo2o0=
=EeeP
-----END PGP SIGNATURE-----
--=-=-=--
X-Loop: help-debbugs@HIDDEN
Subject: [bug#75550] [PATCH] gnu: smartmontools: Fix PATH in smartd_warning.sh.
Resent-From: Hilton Chain <hako@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 24 Jan 2025 16:20:01 +0000
Resent-Message-ID: <handler.75550.B75550.173773556232485 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75550
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords:
To: Tomas Volf <~@wolfsden.cz>
Cc: 75550 <at> debbugs.gnu.org, Sharlatan Hellseher <sharlatanus@HIDDEN>
Received: via spool by 75550-submit <at> debbugs.gnu.org id=B75550.173773556232485
(code B ref 75550); Fri, 24 Jan 2025 16:20:01 +0000
Received: (at 75550) by debbugs.gnu.org; 24 Jan 2025 16:19:22 +0000
Received: from localhost ([127.0.0.1]:46669 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tbMOw-0008Rs-0n
for submit <at> debbugs.gnu.org; Fri, 24 Jan 2025 11:19:22 -0500
Received: from mx.boiledscript.com ([88.99.243.112]:56316)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <hako@HIDDEN>)
id 1tbMOt-0008Re-0X
for 75550 <at> debbugs.gnu.org; Fri, 24 Jan 2025 11:19:19 -0500
Date: Sat, 25 Jan 2025 00:19:06 +0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space;
s=mail; t=1737735556;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
in-reply-to:in-reply-to:references:references;
bh=299uch34Zl9RyubS5Qo//gv9BwxSUHuuTAu/r3LVsyY=;
b=K6jdtG71JPiS+gSXdmFlCn7oi7AeEk4ojlG88ZW4qHALsy1Co+oChRadO2Zd5sqie3uGT3
xTC+Go3r9ZdNkywgA8OhSvh+PLIa1BZbaGv7mnSn94uugFeMVSE5Dfd4UCmMwVUjXxbMIE
FDI90LG5TJXuB+WrINdPz2eiqHbKPPzcr/GDa9DhBN9jn9xFyfLjzguz068qd+8dVxwJPN
Hh34Zug1TQgwt/WU/2PvlSrvftwNJMlOA/PLW2eL0nFWDYLm8UAVvfyq8UfUoYN1W0+3jS
wppCEB1nSK4FGibPhyafl//v+oT43CGdg4voK5x4GAs0UCrJeICJm6994PhLeQ==
Message-ID: <877c6kyykl.wl-hako@HIDDEN>
From: Hilton Chain <hako@HIDDEN>
In-Reply-To: <877c6kjkib.fsf@HIDDEN>
References: <87r056rxbe.fsf@HIDDEN>
<d7320ddeb1939ce0eeeea10f7267883692c269e7.1736898019.git.~@wolfsden.cz>
<87ed14ssck.wl-hako@HIDDEN> <877c6kjkib.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
On Fri, 24 Jan 2025 23:31:56 +0800,
Tomas Volf wrote:
> [...]
> >> + (string-append "PATH="
> >> + #$(file-append sed "/bin") ":"
> >> + #$(file-append coreutils "/bin") ":"
> >> + "$PATH\n"))))))))
> >
> > Please add sed and coreutils-minimal to inputs and use search-input-file or
> > this-package-input instead.
>
> Why? I will of course do so, but would first like to understand why.
> The current way seems to work and keeps all the references in just one
> place. If I switch to the suggested approach, both `sed' and
> `coreutils' will be referenced in two places (once in the `inputs' and
> once here) and those will need to be kept in sync. So, uh, why do it?
The reason is to record dependency information at <package> level, since this is
where the UI and most of the tools work. (`guix show', `guix refresh', package
transformation etc.)
For referencing dependencies from inputs in arguments, the benefit is mainly for
transformations. Maybe it doesn't make much sense in this case (sed and
coreutils), but it's a good practice to follow.
X-Loop: help-debbugs@HIDDEN
Subject: [bug#75550] [PATCH] gnu: smartmontools: Fix PATH in smartd_warning.sh.
Resent-From: Tomas Volf <~@wolfsden.cz>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 28 Jan 2025 22:12:01 +0000
Resent-Message-ID: <handler.75550.B75550.173810231616322 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75550
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords:
To: Hilton Chain <hako@HIDDEN>
Cc: 75550 <at> debbugs.gnu.org, Sharlatan Hellseher <sharlatanus@HIDDEN>
Received: via spool by 75550-submit <at> debbugs.gnu.org id=B75550.173810231616322
(code B ref 75550); Tue, 28 Jan 2025 22:12:01 +0000
Received: (at 75550) by debbugs.gnu.org; 28 Jan 2025 22:11:56 +0000
Received: from localhost ([127.0.0.1]:38990 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tctoJ-0004FC-V1
for submit <at> debbugs.gnu.org; Tue, 28 Jan 2025 17:11:56 -0500
Received: from wolfsden.cz ([37.205.8.62]:59220)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <~@wolfsden.cz>) id 1tctoG-0004Ex-TL
for 75550 <at> debbugs.gnu.org; Tue, 28 Jan 2025 17:11:54 -0500
Received: by wolfsden.cz (Postfix, from userid 104)
id 9788A358E2F; Tue, 28 Jan 2025 22:11:50 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
t=1738102310; bh=BPOrAdd1YowaeGDbdX9LDQcr2r3XOPb7or4INoGjGi0=;
h=From:To:Cc:Subject:In-Reply-To:References:Date;
b=JlVOJ+oE+knFXkBvitpGhwzu0cVlRZB+YEXWSVcyYwE9GN+ImV9hW65K00qDXjepz
kqeOXoM04Yr8aqnQgbtlGLrOQ1hECCr7nbOuf/wJ7BpcqkTFakSUUC/Iw4vepTsVkl
aG+ISkwGt+v+zxoCDozsyurn96SdIqY08SF2MGomYbK/4mdXDmXRrLkig6T0bszdPL
ld47F3BIIGHSybH5E2tGTkwewPXCyOlaD15OVtX3I3KLvJQkggl21+aLqPK+e7oWTu
j8q9ikcuNWMALaII8Vre33At3D/F7ZX5eAMVDPNvQCdZS/fzVKh2JF6CKsOEnGnBPg
8M0A2K3i/1+1vBZAhx+Fe0xkbYKXzXYkG6N/yS4O8ILV+TgOVIzd1SVCzAPiSPTjwy
E8/lWA37oCKJ2zSl+N1HlOccFrdz7KxBEPRKs0Muk0bp1E3HhgNvyAXU59P9WJgPYu
oFr9rPG/PkXDA/clCVrLtTRD6gIeG25fUJkmZrROLEg8pHzl0BF1Qr2n5fP2JgXC+j
JmO6A/5AwDXGWusL3Jf6qS5o7pf51xIw3JGEswQ2VPFOV51ou3XmwWmGbWPA2TgTPl
0/5CTiPNAa1uTbgVWSA/DtNuCLbWi/gAc2y8gVtaN96upahITROHunhl9m0IURcMZF
zdv06vkvSYTuCLDpqM3M39bM=
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden
X-Spam-Level:
X-Spam-Status: No, score=-3.1 required=5.0 tests=ALL_TRUSTED,BAYES_00,
DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
version=3.4.6
Received: from localhost (unknown [128.0.188.242])
by wolfsden.cz (Postfix) with ESMTPSA id C2206359355;
Tue, 28 Jan 2025 22:11:49 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
t=1738102309; bh=BPOrAdd1YowaeGDbdX9LDQcr2r3XOPb7or4INoGjGi0=;
h=From:To:Cc:Subject:In-Reply-To:References:Date;
b=B3+lHIp3pQj9bTkeRX5hGAT2LQaYjzVUcbqVhMlQpis30Clt0frLbUcyixAySpgdR
30chV3jgAgKdD5+aEgMcETSQAlFA/UFfA2nx4ob66Oej/wZ16fTdrvUS4RSsU6zq6l
o8XTmlDsCFP9d83UFcF/DRaKAwPqp7rr2EqTfUM4eVq690PrB79BcnUgiS7ehnwAoj
bNQo22pdykFdFYpATPSlxs2gyFS2Pk1Rr57vJzmkl4pt9JCewIuGJA2aWUn2PwU3gg
ULxkaUZLC0AQ5Lu4tPDnYCHdg8B/VA8E2yKDyKw5Q5S+J/O22UHCtvT9wJn01OP9lT
REuTPTBUzCQSabujkIrD4DIhQZNTvNqrj7zHovjMLfr/S+W2KBGtFIuttuN5B+c9XA
RvcEwl5g+bUpuEsFH5vo2OtknuBv/PYk8RI8iDMMWqdbZlMXSYSgB7Rw1mfIOxUMbW
/WN1g/yvhdpYcqZHZFZpVQK0+/WP1vvy2iUK90g2lIuj4j66hLDQVYj80bds4nWImS
VyUjHJpVxG2GvjMu3SK0NQ//PLSEDpQDIN0fd80nb+5o7/ldMCtCdCO75ps10cUzap
sYo2x4r+2MIWtERr2MB6yo7sQahsaQTjg6fTOEWc4FGS82FNZEEp5xKA7uHypTiNxd
tmCag5cqbZ+7Onof0yfRyFL0=
From: Tomas Volf <~@wolfsden.cz>
In-Reply-To: <877c6kyykl.wl-hako@HIDDEN> (Hilton Chain's message of
"Sat, 25 Jan 2025 00:19:06 +0800")
References: <87r056rxbe.fsf@HIDDEN>
<d7320ddeb1939ce0eeeea10f7267883692c269e7.1736898019.git.~@wolfsden.cz>
<87ed14ssck.wl-hako@HIDDEN> <877c6kjkib.fsf@HIDDEN>
<877c6kyykl.wl-hako@HIDDEN>
Date: Tue, 28 Jan 2025 23:11:48 +0100
Message-ID: <87o6zqfv17.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
Hilton Chain <hako@HIDDEN> writes:
> On Fri, 24 Jan 2025 23:31:56 +0800,
> Tomas Volf wrote:
>> [...]
>> >> + (string-append "PATH=3D"
>> >> + #$(file-append sed "/bin") ":"
>> >> + #$(file-append coreutils "/bin") ":"
>> >> + "$PATH\n"))))))))
>> >
>> > Please add sed and coreutils-minimal to inputs and use search-input-fi=
le or
>> > this-package-input instead.
>>
>> Why? I will of course do so, but would first like to understand why.
>> The current way seems to work and keeps all the references in just one
>> place. If I switch to the suggested approach, both `sed' and
>> `coreutils' will be referenced in two places (once in the `inputs' and
>> once here) and those will need to be kept in sync. So, uh, why do it?
>
> The reason is to record dependency information at <package> level, since =
this is
> where the UI and most of the tools work. (`guix show', `guix refresh', p=
ackage
> transformation etc.)
Is there a technical reason it cannot inspect the gexps used or is it
just matter of "no one wrote the code yet"?
>
> For referencing dependencies from inputs in arguments, the benefit is mai=
nly for
> transformations. Maybe it doesn't make much sense in this case (sed and
> coreutils), but it's a good practice to follow.
I did not realize this at all. That is very good to know.
Tomas
=2D-=20
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.
--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQJCBAEBCgAsFiEEt4NJs4wUfTYpiGikL7/ufbZ/wakFAmeZViQOHH5Ad29sZnNk
ZW4uY3oACgkQL7/ufbZ/walLAQ/+MUtkTPuAvabDHhuNCJBOEI66Ggtwa/lXEdjE
gF558n/07oHiBqM5k06/dsu/BMMX5USp9/7qDLKbyh+qBU9suFp2w+CGH6prVZos
5MSvi7xV0mB3tRtwXz1F907TnJqmekuQ/4UnuR9pqOWXC6LzYoeESFBMdrrwCwI9
TvOQqnjI7WkVq97h9UpnA3nrLPWRCrA1oOcS7bR9/cbiYdFZC5vi8vrwTS7YgbVH
NudP2YufK4XFvP93714rn/zLiaVwU+VnL7sEMPVzDoqDvIo4ci294VjlIJAbSLPD
4rjAK9rOjr40yZ6MgN05TJtB+QBJpl5qMEjr0Wxk3a757KnBTg1EHbnDMSq/cE1T
pZnXvZxYeDT/PwmXm2WQpRSWJNMpMbjT1/m7HgMAKAhrEA8LYMRihEYlHHiM8A6r
r4s2EFbzj0zXM/6KQemC2X8HLvBWb2cdFF6u5IbQ25JRLue+IUlR/Lf7vciKnU1t
5XXaY4sIJX5wn/ALUzx10iQe/2LFwqc0P/HzGMBWMxbKYOCeMsFZXwkHw0eAmbPy
37QGad/nHp3sIJkzAYGBQYdvWSPDtMdyHy6btfAxy2v7TjYqiWq+ge+9HbxHmnZF
WwTY4ht3It6XfPrN2QLK1+gExN8+c+6wDCaA0+9+Y3HeC2SQSb01EF+oyaT8Cmcs
GG8JlZk=
=xzY/
-----END PGP SIGNATURE-----
--=-=-=--
X-Loop: help-debbugs@HIDDEN
Subject: [bug#75550] [PATCH v2] gnu: smartmontools: Fix PATH in smartd_warning.sh.
References: <87r056rxbe.fsf@HIDDEN>
In-Reply-To: <87r056rxbe.fsf@HIDDEN>
Resent-From: Tomas Volf <~@wolfsden.cz>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: sharlatanus@HIDDEN, guix-patches@HIDDEN
Resent-Date: Tue, 28 Jan 2025 23:01:01 +0000
Resent-Message-ID: <handler.75550.B75550.173810523825469 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75550
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords:
To: 75550 <at> debbugs.gnu.org
Cc: Tomas Volf <~@wolfsden.cz>, Sharlatan Hellseher <sharlatanus@HIDDEN>
X-Debbugs-Original-Xcc: Sharlatan Hellseher <sharlatanus@HIDDEN>
Received: via spool by 75550-submit <at> debbugs.gnu.org id=B75550.173810523825469
(code B ref 75550); Tue, 28 Jan 2025 23:01:01 +0000
Received: (at 75550) by debbugs.gnu.org; 28 Jan 2025 23:00:38 +0000
Received: from localhost ([127.0.0.1]:39084 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tcuZN-0006cg-SN
for submit <at> debbugs.gnu.org; Tue, 28 Jan 2025 18:00:38 -0500
Received: from wolfsden.cz ([37.205.8.62]:41580)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <~@wolfsden.cz>) id 1tcuZK-0006cS-Vy
for 75550 <at> debbugs.gnu.org; Tue, 28 Jan 2025 18:00:32 -0500
Received: by wolfsden.cz (Postfix, from userid 104)
id 0ADAF359915; Tue, 28 Jan 2025 23:00:29 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
t=1738105229; bh=O7+QM0+smRsJxiVpJmWxreOWu/DSAWe+VNpRozZzHgk=;
h=From:To:Cc:Subject:Date;
b=oSw35b2eqk1Po0fpnRGMhH/dy9amOKXMz3KQzZckfZ5TORyxpTN2xWQUuiB6WzHnQ
wzB6DVAMvj/jUk+Mhu3sLb7G8r8b465AQLdpZueLCSkXZiQM9Qn9bwKUuGr+BiG6CP
0KHkdzeirNI2rHY0nzm2pKsp0UD+u6lWn7EBZ6jLYpXjwj1pmhAWC72ucll28E/td/
ijNCZrDA0gWIlF+6YuktOGMjPF7IDgWwEEe94YpNogmAum6C79/XcgQgWQETVy6qo6
AJdSdgb+6xOCzr9lllOWjrNFMAbodPxGXH0p5D4M0lccGc0ekmbEgnS7Zf0BnaS1oC
/kVdvsceLHtZSGWGhvqBVzQtLhKvf9i0vOAzLm7kdscOrS94+uaGyPP59paDn1ywVQ
qRrohMyIB9tv55zamzAYeZ0RT0cxnZx96W+HJ49+7RZKlb9/jDJcYYWPf54Vmacxyy
w4uMuXyoCx3vhYP3uNEY+0OoNbGXbdoHKJc2S81BpmwuHHYvSQdAI6M7712t0qp/Z5
EVn2RtBrwP2WNIPnESSxntDbcB+t5fAe+/ZT0uSbtnIVI4jYZ40Dar7JRJTS+2sOaU
uLdzXZRye8sLW5kiyb3AZcS5lRgbWGjJTG2dZUCN/mKhr4JMd6eLMArP+giEY4Q65b
FjNO17deUJ1bJNSiY2Mfvvk8=
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden
X-Spam-Level:
X-Spam-Status: No, score=-3.1 required=5.0 tests=ALL_TRUSTED,BAYES_00,
DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable
autolearn_force=no version=3.4.6
Received: from localhost (unknown [128.0.188.242])
by wolfsden.cz (Postfix) with ESMTPSA id BF917358D30;
Tue, 28 Jan 2025 23:00:24 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
t=1738105224; bh=O7+QM0+smRsJxiVpJmWxreOWu/DSAWe+VNpRozZzHgk=;
h=From:To:Cc:Subject:Date;
b=Ev2iCscV9qAErxNCTN/DxTinsqKbCq8JyJM4ApVjKjHdfBfgSsRyc5WkLJX36hd4N
sSstg+hkAwWtroaUwQc0/RBe9O4/Dua3A8viFF9LOTJYFZFSja1zCY//gnEsGHo0g4
Z+/XCVldx5JW72WINvIjNjhMvcsjb4XMKp+xuM6wKJYJ/CBZzmcjgFMQD5IudDbz1d
w36JJwLKuBkvAscSpHwU5/jVml/YMxt0lBAD5kcwtGhL2bEeTlq4ZlIabo5QnThwEM
PkcuZvQjLeQRhdw7BSm60ZIb+27LQlmnKlFXbhyFqjNOaPwBx2jMHZL95NzU9VVu41
Su4C9zroT0ARsob4uS6oR9j9vDQo7IKZxx2uYbTG/mwm2dyHiSQpXbP55L1Xv1TitY
ww8lcI9RK0AqV7BXMZk20H9KhCzd/SBiaBD2DBnAS27dy6rlHitTiOnlTlDiVyYPSa
cG2Zg4c9GYyuO55s1vg39sHXkFNH51Yq4YZmjI+oyFA2aCSpfoUi7HCRblT2OqmMGL
T4wQf2wISvr5vHwgPRY7MjdrpUF9VC7w0JuYrRMJktrTC0SgSZnLWGWtIy0nzcsSAd
XRAQUKNrTuDotzycvUeYXYyDg4ZdqpGe3uTFmnffCr94EKqNHbKADtLzBIM0ndAqrz
e/PSI6x+aEJ/XzwkwSqZUXnI=
From: Tomas Volf <~@wolfsden.cz>
Date: Wed, 29 Jan 2025 00:00:15 +0100
Message-ID: <3a4c0627e02cfe286e21017c77cc8100bb42b4fc.1738105215.git.~@wolfsden.cz>
X-Mailer: git-send-email 2.47.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
The script started with reset of the $PATH to a value not suitable to Guix.
In addition, the script requires coreutils and sed, so add those into the
$PATH.
* gnu/packages/admin.scm (smartmontools)[inputs]: Add sed, coreutils-minimal.
[arguments]<#:configure-flags>: Pass --with-scriptpath=.
Change-Id: Ide97f572e6f369fe24337f945474dc7a65584eda
---
gnu/packages/admin.scm | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index fd5d67ec50..e21f3f6e19 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -3051,9 +3051,16 @@ (define-public smartmontools
"0gcrzcb4g7f994n6nws26g6x15yjija1gyzd359sjv7r3xj1z9p9"))))
(build-system gnu-build-system)
(arguments
- (list #:make-flags
- #~(list "BUILD_INFO=\"(Guix)\"")))
- (inputs (list libcap-ng))
+ (list
+ #:make-flags
+ #~(list "BUILD_INFO=\"(Guix)\"")
+ #:configure-flags
+ #~(list (format #f "--with-scriptpath=~a:~a:$PATH"
+ (dirname (search-input-file %build-inputs "bin/sed"))
+ (dirname (search-input-file %build-inputs "bin/true"))))))
+ (inputs (list coreutils-minimal
+ libcap-ng
+ sed))
(home-page "https://www.smartmontools.org/")
(synopsis "S.M.A.R.T. harddisk control and monitoring tools")
(description
--
2.47.1
X-Loop: help-debbugs@HIDDEN
Subject: [bug#75550] [PATCH] gnu: smartmontools: Fix PATH in smartd_warning.sh.
Resent-From: Tomas Volf <~@wolfsden.cz>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 28 Jan 2025 23:03:01 +0000
Resent-Message-ID: <handler.75550.B75550.173810532925683 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75550
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords:
To: Hilton Chain <hako@HIDDEN>
Cc: 75550 <at> debbugs.gnu.org, Sharlatan Hellseher <sharlatanus@HIDDEN>
Received: via spool by 75550-submit <at> debbugs.gnu.org id=B75550.173810532925683
(code B ref 75550); Tue, 28 Jan 2025 23:03:01 +0000
Received: (at 75550) by debbugs.gnu.org; 28 Jan 2025 23:02:09 +0000
Received: from localhost ([127.0.0.1]:39094 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tcuav-0006gA-DT
for submit <at> debbugs.gnu.org; Tue, 28 Jan 2025 18:02:09 -0500
Received: from wolfsden.cz ([37.205.8.62]:55422)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <~@wolfsden.cz>) id 1tcuas-0006g0-Jl
for 75550 <at> debbugs.gnu.org; Tue, 28 Jan 2025 18:02:07 -0500
Received: by wolfsden.cz (Postfix, from userid 104)
id 754573583F3; Tue, 28 Jan 2025 23:02:05 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
t=1738105325; bh=StFU3r3RgZSaTb/qRLuLn9RJW1OUWHZsjlSEaTHmqqs=;
h=From:To:Cc:Subject:In-Reply-To:References:Date;
b=xyvNm+OyZkSln/fbmEBe6AizjkBGpZ5Vm73PxRmIbkevfGozZeWuPahj8KZCx5Yrv
gqB7hppTeQdOszgAqF16pQ/qL5DYQysg70ntvzaZYFfZcMTIumgDCiJX0NGzUSIcij
ZO0d9Z2VIc1eDtPtRghD/2c0qE5UDbAT0f1meRoS3tUH91ceoS2AtnaOzchF8yonT+
FIwVt4Wul64CuRsXd6xfXUd1CWKUMAuGN7qtRdj7TA6tWCv0r3FTaNyjPX5FPXZZax
AINWAOoCucax8940uZsdWWh0qNMtdEPttuMJEWQhdO/katt8rQZOPdqDlOwsSWXUN+
drrDsNtKgeoo1B1iEXoBI6rju8ODPuS9I7vBvj60sMqMBArxQJ41bWOCfgbhCfxeft
UOuZr/lDxIvHw/s5I4p8qA6rDZaycdnMTCzY0Jqn5+MXl1CObT9bTsxMte0qg6mIx/
N7yXrsyPCDUFrWuVaGd5Pdkr1zO5y8kUHnTYDxq5N4UJR0eyVYgXMTp0cz+NWAZuof
Wwrq9lXsNnVQuPZDvIXJ2RjAPSPvEbUnp8TnD+0d5XvQPJIJeeNd+//3QrEstwA2Kw
EmM96Ol9Pe/6s5x1dN0UHiOLxydSdB40yptRsFDe8xgjHyv0YbVDsLYM+fAirlNBhu
OKUDApjnCcquPTr+ple+9eYA=
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden
X-Spam-Level:
X-Spam-Status: No, score=-3.1 required=5.0 tests=ALL_TRUSTED,BAYES_00,
DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
version=3.4.6
Received: from localhost (unknown [128.0.188.242])
by wolfsden.cz (Postfix) with ESMTPSA id 2E014358566;
Tue, 28 Jan 2025 23:02:05 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
t=1738105325; bh=StFU3r3RgZSaTb/qRLuLn9RJW1OUWHZsjlSEaTHmqqs=;
h=From:To:Cc:Subject:In-Reply-To:References:Date;
b=xyvNm+OyZkSln/fbmEBe6AizjkBGpZ5Vm73PxRmIbkevfGozZeWuPahj8KZCx5Yrv
gqB7hppTeQdOszgAqF16pQ/qL5DYQysg70ntvzaZYFfZcMTIumgDCiJX0NGzUSIcij
ZO0d9Z2VIc1eDtPtRghD/2c0qE5UDbAT0f1meRoS3tUH91ceoS2AtnaOzchF8yonT+
FIwVt4Wul64CuRsXd6xfXUd1CWKUMAuGN7qtRdj7TA6tWCv0r3FTaNyjPX5FPXZZax
AINWAOoCucax8940uZsdWWh0qNMtdEPttuMJEWQhdO/katt8rQZOPdqDlOwsSWXUN+
drrDsNtKgeoo1B1iEXoBI6rju8ODPuS9I7vBvj60sMqMBArxQJ41bWOCfgbhCfxeft
UOuZr/lDxIvHw/s5I4p8qA6rDZaycdnMTCzY0Jqn5+MXl1CObT9bTsxMte0qg6mIx/
N7yXrsyPCDUFrWuVaGd5Pdkr1zO5y8kUHnTYDxq5N4UJR0eyVYgXMTp0cz+NWAZuof
Wwrq9lXsNnVQuPZDvIXJ2RjAPSPvEbUnp8TnD+0d5XvQPJIJeeNd+//3QrEstwA2Kw
EmM96Ol9Pe/6s5x1dN0UHiOLxydSdB40yptRsFDe8xgjHyv0YbVDsLYM+fAirlNBhu
OKUDApjnCcquPTr+ple+9eYA=
From: Tomas Volf <~@wolfsden.cz>
In-Reply-To: <87ed14ssck.wl-hako@HIDDEN> (Hilton Chain's message of
"Wed, 15 Jan 2025 10:50:35 +0800")
References: <87r056rxbe.fsf@HIDDEN>
<d7320ddeb1939ce0eeeea10f7267883692c269e7.1736898019.git.~@wolfsden.cz>
<87ed14ssck.wl-hako@HIDDEN>
Date: Wed, 29 Jan 2025 00:02:04 +0100
Message-ID: <87h65ifspf.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
Hilton Chain <hako@HIDDEN> writes:
>
> Please add sed and coreutils-minimal to inputs and use search-input-file =
or
> this-package-input instead.
>
> For smartmontools the proper way is to set --with-scriptpath=3D'...' conf=
igure
> flag, which is documented in its INSTALL file. (It can be disabled with =
a 'no'
> value as well.)
Thank you for the review, I have sent v2 that hopefully incorporates
your feedback.
Tomas
=2D-=20
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.
--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQJCBAEBCgAsFiEEt4NJs4wUfTYpiGikL7/ufbZ/wakFAmeZYewOHH5Ad29sZnNk
ZW4uY3oACgkQL7/ufbZ/walY3w/9GlYjZdREHw+/ufbit5qHM8PdLFISBrQoFDCe
lww+ViYjIUgCoJJk4dQjQu9BRUsSioyZnP/LGudnjUzNyjoMzGKkLD5KkB8an24e
eNeF8UyCvm9DkXjwLkXFHwOqxoTUItvWV61LaXpYJQ6aXZC/Od55caUmCjr5hG7L
aMzUE2nsftN5pPtCISwoEhd6NKHX372jTzOewziAh8Qc7o0rt+DisoySwmC3dNuH
MO9dQRv9s+RZfLnayid0P0fZoO5dQhoP479G1fWyyuxTK5WxenN+DW3FQyDpQO5c
ECJaxUuesArkErj9kgxJFdR+7GwZMivwAW/E4qcXHZLWZFocS4ekDPX8LCKVXUrw
AXVbwqA2vpwnOer/BONaSr1sLnOk14cTjzrEmMso4xLU8qDG8iYkUy7J0hY4ViJ6
hfrZ/gGnTlSjHdf1wR3iRJZ+dQw+MMbasDU4UHFGyt0A08d9lpGf685lgb+Af7py
jG92kU1rDBc8nhDa0wYyx6D3wL2co/vak8GP8PhgalBKdtD768joWgQBcOMOgBgs
f1xbp4WkEmB399570WIWD28eO34UY6OFTHgRbRSuaofOTqYLF2LAutX6UXCWBMwb
MywAX9ShrS9WopUGGmTxOXAsdYPoEC5qwcyPuAK4+5dsAIZeA1w/sc9VruEaHNyI
kb2OEE0=
=DrQe
-----END PGP SIGNATURE-----
--=-=-=--
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Hilton Chain <hako@HIDDEN>
Subject: bug#75550: closed (smartd fails to send an email)
CC: tracker <at> debbugs.gnu.org
Message-ID: <handler.75550.D75550.173824023428610.ackdone <at> debbugs.gnu.org>
References: <87jzaccwo4.wl-hako@HIDDEN> <87r056rxbe.fsf@HIDDEN>
X-Gnu-PR-Message: closed 75550
X-Gnu-PR-Package: guix-patches
Date: Thu, 30 Jan 2025 12:31:02 +0000
Content-Type: multipart/mixed; boundary="----------=_1738240262-32647-0"
This is a multi-part message in MIME format...
------------=_1738240262-32647-0
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=utf-8
Your message dated Thu, 30 Jan 2025 20:29:15 +0800
with message-id <87jzaccwo4.wl-hako@HIDDEN>
and subject line Re: [bug#75550] [PATCH v2] gnu: smartmontools: Fix PATH in=
smartd_warning.sh.
has caused the debbugs.gnu.org bug report #75550,
regarding smartd fails to send an email
to be marked as done.
(If you believe you have received this mail in error, please contact
help-debbugs@HIDDEN)
--=20
75550: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D75550
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems
------------=_1738240262-32647-0
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
Received: (at submit) by debbugs.gnu.org; 14 Jan 2025 01:36:41 +0000
Received: from localhost ([127.0.0.1]:53370 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tXVrE-0001PW-UX
for submit <at> debbugs.gnu.org; Mon, 13 Jan 2025 20:36:41 -0500
Received: from lists.gnu.org ([2001:470:142::17]:48698)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <~@wolfsden.cz>) id 1tXVrD-0001PF-7v
for submit <at> debbugs.gnu.org; Mon, 13 Jan 2025 20:36:39 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1tXVr5-0003qx-A7
for bug-guix@HIDDEN; Mon, 13 Jan 2025 20:36:31 -0500
Received: from wolfsden.cz ([37.205.8.62])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1tXVr2-0003Q6-SK
for bug-guix@HIDDEN; Mon, 13 Jan 2025 20:36:30 -0500
Received: by wolfsden.cz (Postfix, from userid 104)
id C734C3528DD; Tue, 14 Jan 2025 01:36:22 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
t=1736818582; bh=xaZH6JL7Xit7Cmt91/OPwp0NpEzYtJHnTPKs2RSlIRM=;
h=From:To:Subject:Date;
b=P1bi3ZbulZ5q/G9Un7TSbgq5m2m6ciNtxZpfWnqJ1/A3dnxjAJ4+IQaw80bfJemAo
jZAXgS7FMblmVk/ezF6v9hMVOvyAOmk5moDSGslP/ZCFWnmANFrSzWD0IhnApiwaOs
+r9e/+Qr6emFt8QeLcIU0i76/D5RbQUEDJc9qNAoSO8u00ANZaM8gcgC50nm9gmLcV
HOhvIblJ1cXUHmXSUts6Joa/foiwXa/rf8NoZuz+qx/hIlgMcOdSAG6YqihKIMkcll
ZmPKxp9uT5OIfJ455P7PW7GqvwVshBaSkv/QjV38p1IwZNSKdvAh0ezX+jufZronKB
dAUjJUt/jJ1nI/yMwQMsk9RiMR/enNGY8WfkEPSpeG4kGFXIKSefivKFVtDYK6CNS1
jNTR9Ye07WfwNphm9g1hhLngZ0R0lcxrCAmCzhyH8l+0IvDw6LdzIGve0Tg7Qfflty
uSgDA/T4qmIwGl8bQVSGA5R8WVX2XEZNKJK9hZVq6mNvfy2jEYYmCZMAvf42noN563
O8+d1r7fC27RgX2GHcazJE9l9pWGObNNynFfPJrh0UlQvlgM9KA4yJYGD8MVz/D3E+
HDemogLn6LYpFj8hYqho6Vg/FhZZpIihYXmTeAwEpzI8mudsWHHP9ulB7LAJFQpS3O
IAbMfJ7hr17rg738VfGETkAA=
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden
X-Spam-Level:
X-Spam-Status: No, score=-3.1 required=5.0 tests=ALL_TRUSTED,BAYES_00,
DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED
autolearn=ham autolearn_force=no version=3.4.6
Received: from localhost (unknown [193.32.127.158])
by wolfsden.cz (Postfix) with ESMTPSA id DA05F352756
for <bug-guix@HIDDEN>; Tue, 14 Jan 2025 01:36:21 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
t=1736818582; bh=xaZH6JL7Xit7Cmt91/OPwp0NpEzYtJHnTPKs2RSlIRM=;
h=From:To:Subject:Date;
b=P1bi3ZbulZ5q/G9Un7TSbgq5m2m6ciNtxZpfWnqJ1/A3dnxjAJ4+IQaw80bfJemAo
jZAXgS7FMblmVk/ezF6v9hMVOvyAOmk5moDSGslP/ZCFWnmANFrSzWD0IhnApiwaOs
+r9e/+Qr6emFt8QeLcIU0i76/D5RbQUEDJc9qNAoSO8u00ANZaM8gcgC50nm9gmLcV
HOhvIblJ1cXUHmXSUts6Joa/foiwXa/rf8NoZuz+qx/hIlgMcOdSAG6YqihKIMkcll
ZmPKxp9uT5OIfJ455P7PW7GqvwVshBaSkv/QjV38p1IwZNSKdvAh0ezX+jufZronKB
dAUjJUt/jJ1nI/yMwQMsk9RiMR/enNGY8WfkEPSpeG4kGFXIKSefivKFVtDYK6CNS1
jNTR9Ye07WfwNphm9g1hhLngZ0R0lcxrCAmCzhyH8l+0IvDw6LdzIGve0Tg7Qfflty
uSgDA/T4qmIwGl8bQVSGA5R8WVX2XEZNKJK9hZVq6mNvfy2jEYYmCZMAvf42noN563
O8+d1r7fC27RgX2GHcazJE9l9pWGObNNynFfPJrh0UlQvlgM9KA4yJYGD8MVz/D3E+
HDemogLn6LYpFj8hYqho6Vg/FhZZpIihYXmTeAwEpzI8mudsWHHP9ulB7LAJFQpS3O
IAbMfJ7hr17rg738VfGETkAA=
From: Tomas Volf <~@wolfsden.cz>
To: bug-guix@HIDDEN
Subject: smartd fails to send an email
Date: Tue, 14 Jan 2025 02:36:21 +0100
Message-ID: <87r056rxbe.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=37.205.8.62; envelope-from=~@wolfsden.cz;
helo=wolfsden.cz
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,
SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
Hi,
I have tried to write a service type for smartd from smartmontools,
however the bundled script fails.
When the test (-m root -M test) is executed, some programs seem to be
missing in the $PATH:
--8<---------------cut here---------------start------------->8---
Jan 14 01:34:19 localhost smartd[3138]: Executing test of <mail> to root ...
Jan 14 01:34:19 localhost smartd[3138]: Test of <mail> to root produced unexpected output (118 bytes) to STDOUT/STDERR:
Jan 14 01:34:19 localhost smartd[3138]: /gnu/store/ks6lnp8hssm9zkka47ysa4qp9xd9f8bv-smartmontools-7.4/etc/smartd_warning.sh: line 132: sed: command not found
Jan 14 01:34:19 localhost smartd[3138]: Test of <mail> to root: failed (32-bit/8-bit exit status: 32512/127)
--8<---------------cut here---------------end--------------->8---
At the start of the script I see:
--8<---------------cut here---------------start------------->8---
export PATH="/usr/local/bin:/usr/bin:/bin"
--8<---------------cut here---------------end--------------->8---
That does not look correct. I am not sure if any wrapping is necessary.
Have a nice day,
Tomas
--
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.
------------=_1738240262-32647-0
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
Received: (at 75550-done) by debbugs.gnu.org; 30 Jan 2025 12:30:34 +0000
Received: from localhost ([127.0.0.1]:44884 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tdTgo-0007QO-3Y
for submit <at> debbugs.gnu.org; Thu, 30 Jan 2025 07:30:34 -0500
Received: from mx.boiledscript.com ([2a01:4f8:10b:392::42]:44510)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <hako@HIDDEN>)
id 1tdTgh-00073P-BE
for 75550-done <at> debbugs.gnu.org; Thu, 30 Jan 2025 07:30:28 -0500
Date: Thu, 30 Jan 2025 20:29:15 +0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space;
s=mail; t=1738240226;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=TJmqXFydw5TQZsNse72hS7VdCGUPTXIQwNU9qaMNRik=;
b=Lnm3quvESI9rB6s8RgzcVGA/NYpIwB7c5l5BcZN7+LB13wi/q1A1NJyezk1Vq2zKuRoPH0
7hJxN7MvZeBrTaqrmWWvje2NvliCjFgzlmzak3njVWglT7GOQm+K3GAfCNA9GPIgL2OulI
TXk+vfbB/8fnp5n8AuEoD+bHlr5Qiirq5Fji1i1p57W0oZFPRV0DSrNmo9zE7p48/njBrv
VpyMLLM8zYeGMx4Mkf45tNTeVFqjQXAgwy2dx4bL/lNHK7qjhZycfdD5ZFn5pLmX8ZZtWP
T50LSxEfTcPE4IGfET+1JdsNi6l7Im3EuGnqYhB/BSg/PtZKBveUBhrznRGeJQ==
Message-ID: <87jzaccwo4.wl-hako@HIDDEN>
From: Hilton Chain <hako@HIDDEN>
To: Tomas Volf <~@wolfsden.cz>
Subject: Re: [bug#75550] [PATCH v2] gnu: smartmontools: Fix PATH in
smartd_warning.sh.
In-Reply-To: <3a4c0627e02cfe286e21017c77cc8100bb42b4fc.1738105215.git.~@wolfsden.cz>
References: <87r056rxbe.fsf@HIDDEN> <3a4c0627e02cfe286e21017c77cc8100bb42b4fc.1738105215.git.~@wolfsden.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 75550-done
Cc: 75550-done <at> debbugs.gnu.org, Sharlatan Hellseher <sharlatanus@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
On Wed, 29 Jan 2025 07:00:15 +0800,
Tomas Volf wrote:
>
> The script started with reset of the $PATH to a value not suitable to Gui=
x.
> In addition, the script requires coreutils and sed, so add those into the
> $PATH.
>
> * gnu/packages/admin.scm (smartmontools)[inputs]: Add sed, coreutils-mini=
mal.
> [arguments]<#:configure-flags>: Pass --with-scriptpath=3D.
>
> Change-Id: Ide97f572e6f369fe24337f945474dc7a65584eda
> ---
> gnu/packages/admin.scm | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
> index fd5d67ec50..e21f3f6e19 100644
> --- a/gnu/packages/admin.scm
> +++ b/gnu/packages/admin.scm
> @@ -3051,9 +3051,16 @@ (define-public smartmontools
> "0gcrzcb4g7f994n6nws26g6x15yjija1gyzd359sjv7r3xj1z9p9"))=
))
> (build-system gnu-build-system)
> (arguments
> - (list #:make-flags
> - #~(list "BUILD_INFO=3D\"(Guix)\"")))
> - (inputs (list libcap-ng))
> + (list
> + #:make-flags
> + #~(list "BUILD_INFO=3D\"(Guix)\"")
> + #:configure-flags
> + #~(list (format #f "--with-scriptpath=3D~a:~a:$PATH"
> + (dirname (search-input-file %build-inputs "bin/sed=
"))
> + (dirname (search-input-file %build-inputs "bin/tru=
e"))))))
I have modified #:configure-flags to use `this-package-input', to have prop=
er
cross build support:
--8<---------------cut here---------------start------------->8---
#~(list (format #f "--with-scriptpath=3D~{~a:~}$PATH"
(map (lambda (pkg)
(in-vicinity pkg "bin"))
'#$(list (this-package-input "coreutils-minimal")
(this-package-input "sed")))))
--8<---------------cut here---------------end--------------->8---
Thinking of the limitation of %build-inputs, it might be convenient to defi=
ne
`inputs' and `native-inputs' directly in builder's environment. =F0=9F=A4=
=94
Anyway, applied as f7fc4caf7da8f1d7cc76b3bc6ac0c4e643507454 with above chan=
ge.
> + (inputs (list coreutils-minimal
> + libcap-ng
> + sed))
> (home-page "https://www.smartmontools.org/")
> (synopsis "S.M.A.R.T. harddisk control and monitoring tools")
> (description
> --
> 2.47.1
Thanks
------------=_1738240262-32647-0--
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Tomas Volf <~@wolfsden.cz>
Subject: bug#75550: closed (Re: [bug#75550] [PATCH v2] gnu: smartmontools:
Fix PATH in smartd_warning.sh.)
Message-ID: <handler.75550.D75550.173824023428610.notifdone <at> debbugs.gnu.org>
References: <87jzaccwo4.wl-hako@HIDDEN> <87r056rxbe.fsf@HIDDEN>
X-Gnu-PR-Message: they-closed 75550
X-Gnu-PR-Package: guix-patches
Reply-To: 75550 <at> debbugs.gnu.org
Date: Thu, 30 Jan 2025 12:31:02 +0000
Content-Type: multipart/mixed; boundary="----------=_1738240262-32647-1"
This is a multi-part message in MIME format...
------------=_1738240262-32647-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
Your bug report
#75550: smartd fails to send an email
which was filed against the guix-patches package, has been closed.
The explanation is attached below, along with your original report.
If you require more details, please reply to 75550 <at> debbugs.gnu.org.
--=20
75550: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D75550
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems
------------=_1738240262-32647-1
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
Received: (at 75550-done) by debbugs.gnu.org; 30 Jan 2025 12:30:34 +0000
Received: from localhost ([127.0.0.1]:44884 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tdTgo-0007QO-3Y
for submit <at> debbugs.gnu.org; Thu, 30 Jan 2025 07:30:34 -0500
Received: from mx.boiledscript.com ([2a01:4f8:10b:392::42]:44510)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <hako@HIDDEN>)
id 1tdTgh-00073P-BE
for 75550-done <at> debbugs.gnu.org; Thu, 30 Jan 2025 07:30:28 -0500
Date: Thu, 30 Jan 2025 20:29:15 +0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space;
s=mail; t=1738240226;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=TJmqXFydw5TQZsNse72hS7VdCGUPTXIQwNU9qaMNRik=;
b=Lnm3quvESI9rB6s8RgzcVGA/NYpIwB7c5l5BcZN7+LB13wi/q1A1NJyezk1Vq2zKuRoPH0
7hJxN7MvZeBrTaqrmWWvje2NvliCjFgzlmzak3njVWglT7GOQm+K3GAfCNA9GPIgL2OulI
TXk+vfbB/8fnp5n8AuEoD+bHlr5Qiirq5Fji1i1p57W0oZFPRV0DSrNmo9zE7p48/njBrv
VpyMLLM8zYeGMx4Mkf45tNTeVFqjQXAgwy2dx4bL/lNHK7qjhZycfdD5ZFn5pLmX8ZZtWP
T50LSxEfTcPE4IGfET+1JdsNi6l7Im3EuGnqYhB/BSg/PtZKBveUBhrznRGeJQ==
Message-ID: <87jzaccwo4.wl-hako@HIDDEN>
From: Hilton Chain <hako@HIDDEN>
To: Tomas Volf <~@wolfsden.cz>
Subject: Re: [bug#75550] [PATCH v2] gnu: smartmontools: Fix PATH in
smartd_warning.sh.
In-Reply-To: <3a4c0627e02cfe286e21017c77cc8100bb42b4fc.1738105215.git.~@wolfsden.cz>
References: <87r056rxbe.fsf@HIDDEN> <3a4c0627e02cfe286e21017c77cc8100bb42b4fc.1738105215.git.~@wolfsden.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 75550-done
Cc: 75550-done <at> debbugs.gnu.org, Sharlatan Hellseher <sharlatanus@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
On Wed, 29 Jan 2025 07:00:15 +0800,
Tomas Volf wrote:
>
> The script started with reset of the $PATH to a value not suitable to Gui=
x.
> In addition, the script requires coreutils and sed, so add those into the
> $PATH.
>
> * gnu/packages/admin.scm (smartmontools)[inputs]: Add sed, coreutils-mini=
mal.
> [arguments]<#:configure-flags>: Pass --with-scriptpath=3D.
>
> Change-Id: Ide97f572e6f369fe24337f945474dc7a65584eda
> ---
> gnu/packages/admin.scm | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
> index fd5d67ec50..e21f3f6e19 100644
> --- a/gnu/packages/admin.scm
> +++ b/gnu/packages/admin.scm
> @@ -3051,9 +3051,16 @@ (define-public smartmontools
> "0gcrzcb4g7f994n6nws26g6x15yjija1gyzd359sjv7r3xj1z9p9"))=
))
> (build-system gnu-build-system)
> (arguments
> - (list #:make-flags
> - #~(list "BUILD_INFO=3D\"(Guix)\"")))
> - (inputs (list libcap-ng))
> + (list
> + #:make-flags
> + #~(list "BUILD_INFO=3D\"(Guix)\"")
> + #:configure-flags
> + #~(list (format #f "--with-scriptpath=3D~a:~a:$PATH"
> + (dirname (search-input-file %build-inputs "bin/sed=
"))
> + (dirname (search-input-file %build-inputs "bin/tru=
e"))))))
I have modified #:configure-flags to use `this-package-input', to have prop=
er
cross build support:
--8<---------------cut here---------------start------------->8---
#~(list (format #f "--with-scriptpath=3D~{~a:~}$PATH"
(map (lambda (pkg)
(in-vicinity pkg "bin"))
'#$(list (this-package-input "coreutils-minimal")
(this-package-input "sed")))))
--8<---------------cut here---------------end--------------->8---
Thinking of the limitation of %build-inputs, it might be convenient to defi=
ne
`inputs' and `native-inputs' directly in builder's environment. =F0=9F=A4=
=94
Anyway, applied as f7fc4caf7da8f1d7cc76b3bc6ac0c4e643507454 with above chan=
ge.
> + (inputs (list coreutils-minimal
> + libcap-ng
> + sed))
> (home-page "https://www.smartmontools.org/")
> (synopsis "S.M.A.R.T. harddisk control and monitoring tools")
> (description
> --
> 2.47.1
Thanks
------------=_1738240262-32647-1
Content-Type: message/rfc822
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
Received: (at submit) by debbugs.gnu.org; 14 Jan 2025 01:36:41 +0000
Received: from localhost ([127.0.0.1]:53370 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tXVrE-0001PW-UX
for submit <at> debbugs.gnu.org; Mon, 13 Jan 2025 20:36:41 -0500
Received: from lists.gnu.org ([2001:470:142::17]:48698)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <~@wolfsden.cz>) id 1tXVrD-0001PF-7v
for submit <at> debbugs.gnu.org; Mon, 13 Jan 2025 20:36:39 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1tXVr5-0003qx-A7
for bug-guix@HIDDEN; Mon, 13 Jan 2025 20:36:31 -0500
Received: from wolfsden.cz ([37.205.8.62])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1tXVr2-0003Q6-SK
for bug-guix@HIDDEN; Mon, 13 Jan 2025 20:36:30 -0500
Received: by wolfsden.cz (Postfix, from userid 104)
id C734C3528DD; Tue, 14 Jan 2025 01:36:22 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
t=1736818582; bh=xaZH6JL7Xit7Cmt91/OPwp0NpEzYtJHnTPKs2RSlIRM=;
h=From:To:Subject:Date;
b=P1bi3ZbulZ5q/G9Un7TSbgq5m2m6ciNtxZpfWnqJ1/A3dnxjAJ4+IQaw80bfJemAo
jZAXgS7FMblmVk/ezF6v9hMVOvyAOmk5moDSGslP/ZCFWnmANFrSzWD0IhnApiwaOs
+r9e/+Qr6emFt8QeLcIU0i76/D5RbQUEDJc9qNAoSO8u00ANZaM8gcgC50nm9gmLcV
HOhvIblJ1cXUHmXSUts6Joa/foiwXa/rf8NoZuz+qx/hIlgMcOdSAG6YqihKIMkcll
ZmPKxp9uT5OIfJ455P7PW7GqvwVshBaSkv/QjV38p1IwZNSKdvAh0ezX+jufZronKB
dAUjJUt/jJ1nI/yMwQMsk9RiMR/enNGY8WfkEPSpeG4kGFXIKSefivKFVtDYK6CNS1
jNTR9Ye07WfwNphm9g1hhLngZ0R0lcxrCAmCzhyH8l+0IvDw6LdzIGve0Tg7Qfflty
uSgDA/T4qmIwGl8bQVSGA5R8WVX2XEZNKJK9hZVq6mNvfy2jEYYmCZMAvf42noN563
O8+d1r7fC27RgX2GHcazJE9l9pWGObNNynFfPJrh0UlQvlgM9KA4yJYGD8MVz/D3E+
HDemogLn6LYpFj8hYqho6Vg/FhZZpIihYXmTeAwEpzI8mudsWHHP9ulB7LAJFQpS3O
IAbMfJ7hr17rg738VfGETkAA=
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden
X-Spam-Level:
X-Spam-Status: No, score=-3.1 required=5.0 tests=ALL_TRUSTED,BAYES_00,
DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED
autolearn=ham autolearn_force=no version=3.4.6
Received: from localhost (unknown [193.32.127.158])
by wolfsden.cz (Postfix) with ESMTPSA id DA05F352756
for <bug-guix@HIDDEN>; Tue, 14 Jan 2025 01:36:21 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
t=1736818582; bh=xaZH6JL7Xit7Cmt91/OPwp0NpEzYtJHnTPKs2RSlIRM=;
h=From:To:Subject:Date;
b=P1bi3ZbulZ5q/G9Un7TSbgq5m2m6ciNtxZpfWnqJ1/A3dnxjAJ4+IQaw80bfJemAo
jZAXgS7FMblmVk/ezF6v9hMVOvyAOmk5moDSGslP/ZCFWnmANFrSzWD0IhnApiwaOs
+r9e/+Qr6emFt8QeLcIU0i76/D5RbQUEDJc9qNAoSO8u00ANZaM8gcgC50nm9gmLcV
HOhvIblJ1cXUHmXSUts6Joa/foiwXa/rf8NoZuz+qx/hIlgMcOdSAG6YqihKIMkcll
ZmPKxp9uT5OIfJ455P7PW7GqvwVshBaSkv/QjV38p1IwZNSKdvAh0ezX+jufZronKB
dAUjJUt/jJ1nI/yMwQMsk9RiMR/enNGY8WfkEPSpeG4kGFXIKSefivKFVtDYK6CNS1
jNTR9Ye07WfwNphm9g1hhLngZ0R0lcxrCAmCzhyH8l+0IvDw6LdzIGve0Tg7Qfflty
uSgDA/T4qmIwGl8bQVSGA5R8WVX2XEZNKJK9hZVq6mNvfy2jEYYmCZMAvf42noN563
O8+d1r7fC27RgX2GHcazJE9l9pWGObNNynFfPJrh0UlQvlgM9KA4yJYGD8MVz/D3E+
HDemogLn6LYpFj8hYqho6Vg/FhZZpIihYXmTeAwEpzI8mudsWHHP9ulB7LAJFQpS3O
IAbMfJ7hr17rg738VfGETkAA=
From: Tomas Volf <~@wolfsden.cz>
To: bug-guix@HIDDEN
Subject: smartd fails to send an email
Date: Tue, 14 Jan 2025 02:36:21 +0100
Message-ID: <87r056rxbe.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=37.205.8.62; envelope-from=~@wolfsden.cz;
helo=wolfsden.cz
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,
SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
Hi,
I have tried to write a service type for smartd from smartmontools,
however the bundled script fails.
When the test (-m root -M test) is executed, some programs seem to be
missing in the $PATH:
--8<---------------cut here---------------start------------->8---
Jan 14 01:34:19 localhost smartd[3138]: Executing test of <mail> to root ...
Jan 14 01:34:19 localhost smartd[3138]: Test of <mail> to root produced unexpected output (118 bytes) to STDOUT/STDERR:
Jan 14 01:34:19 localhost smartd[3138]: /gnu/store/ks6lnp8hssm9zkka47ysa4qp9xd9f8bv-smartmontools-7.4/etc/smartd_warning.sh: line 132: sed: command not found
Jan 14 01:34:19 localhost smartd[3138]: Test of <mail> to root: failed (32-bit/8-bit exit status: 32512/127)
--8<---------------cut here---------------end--------------->8---
At the start of the script I see:
--8<---------------cut here---------------start------------->8---
export PATH="/usr/local/bin:/usr/bin:/bin"
--8<---------------cut here---------------end--------------->8---
That does not look correct. I am not sure if any wrapping is necessary.
Have a nice day,
Tomas
--
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.
------------=_1738240262-32647-1--
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.