GNU bug report logs - #75550
smartd fails to send an email

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Tomas Volf <~@wolfsden.cz>; Done: Hilton Chain <hako@HIDDEN>; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 75550-done <at> debbugs.gnu.org:

Received: (at 75550-done) by debbugs.gnu.org; 30 Jan 2025 12:30:34 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Jan 30 07:30:34 2025
Received: from localhost ([127.0.0.1]:44884 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tdTgo-0007QO-3Y
	for submit <at> debbugs.gnu.org; Thu, 30 Jan 2025 07:30:34 -0500
Received: from mx.boiledscript.com ([2a01:4f8:10b:392::42]:44510)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <hako@HIDDEN>)
 id 1tdTgh-00073P-BE
 for 75550-done <at> debbugs.gnu.org; Thu, 30 Jan 2025 07:30:28 -0500
Date: Thu, 30 Jan 2025 20:29:15 +0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space;
 s=mail; t=1738240226;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 content-transfer-encoding:content-transfer-encoding:
 in-reply-to:in-reply-to:references:references;
 bh=TJmqXFydw5TQZsNse72hS7VdCGUPTXIQwNU9qaMNRik=;
 b=Lnm3quvESI9rB6s8RgzcVGA/NYpIwB7c5l5BcZN7+LB13wi/q1A1NJyezk1Vq2zKuRoPH0
 7hJxN7MvZeBrTaqrmWWvje2NvliCjFgzlmzak3njVWglT7GOQm+K3GAfCNA9GPIgL2OulI
 TXk+vfbB/8fnp5n8AuEoD+bHlr5Qiirq5Fji1i1p57W0oZFPRV0DSrNmo9zE7p48/njBrv
 VpyMLLM8zYeGMx4Mkf45tNTeVFqjQXAgwy2dx4bL/lNHK7qjhZycfdD5ZFn5pLmX8ZZtWP
 T50LSxEfTcPE4IGfET+1JdsNi6l7Im3EuGnqYhB/BSg/PtZKBveUBhrznRGeJQ==
Message-ID: <87jzaccwo4.wl-hako@HIDDEN>
From: Hilton Chain <hako@HIDDEN>
To: Tomas Volf <~@wolfsden.cz>
Subject: Re: [bug#75550] [PATCH v2] gnu: smartmontools: Fix PATH in
 smartd_warning.sh.
In-Reply-To: <3a4c0627e02cfe286e21017c77cc8100bb42b4fc.1738105215.git.~@wolfsden.cz>
References: <87r056rxbe.fsf@HIDDEN>	<3a4c0627e02cfe286e21017c77cc8100bb42b4fc.1738105215.git.~@wolfsden.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 75550-done
Cc: 75550-done <at> debbugs.gnu.org, Sharlatan Hellseher <sharlatanus@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On Wed, 29 Jan 2025 07:00:15 +0800,
Tomas Volf wrote:
>
> The script started with reset of the $PATH to a value not suitable to Gui=
x.
> In addition, the script requires coreutils and sed, so add those into the
> $PATH.
>
> * gnu/packages/admin.scm (smartmontools)[inputs]: Add sed, coreutils-mini=
mal.
> [arguments]<#:configure-flags>: Pass --with-scriptpath=3D.
>
> Change-Id: Ide97f572e6f369fe24337f945474dc7a65584eda
> ---
>  gnu/packages/admin.scm | 13 ++++++++++---
>  1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
> index fd5d67ec50..e21f3f6e19 100644
> --- a/gnu/packages/admin.scm
> +++ b/gnu/packages/admin.scm
> @@ -3051,9 +3051,16 @@ (define-public smartmontools
>                  "0gcrzcb4g7f994n6nws26g6x15yjija1gyzd359sjv7r3xj1z9p9"))=
))
>      (build-system gnu-build-system)
>      (arguments
> -     (list #:make-flags
> -           #~(list "BUILD_INFO=3D\"(Guix)\"")))
> -    (inputs (list libcap-ng))
> +     (list
> +      #:make-flags
> +      #~(list "BUILD_INFO=3D\"(Guix)\"")
> +      #:configure-flags
> +      #~(list (format #f "--with-scriptpath=3D~a:~a:$PATH"
> +                      (dirname (search-input-file %build-inputs "bin/sed=
"))
> +                      (dirname (search-input-file %build-inputs "bin/tru=
e"))))))

I have modified #:configure-flags to use `this-package-input', to have prop=
er
cross build support:
--8<---------------cut here---------------start------------->8---
#~(list (format #f "--with-scriptpath=3D~{~a:~}$PATH"
                (map (lambda (pkg)
                       (in-vicinity pkg "bin"))
                     '#$(list (this-package-input "coreutils-minimal")
                              (this-package-input "sed")))))
--8<---------------cut here---------------end--------------->8---

Thinking of the limitation of %build-inputs, it might be convenient to defi=
ne
`inputs' and `native-inputs' directly in builder's environment.  =F0=9F=A4=
=94

Anyway, applied as f7fc4caf7da8f1d7cc76b3bc6ac0c4e643507454 with above chan=
ge.

> +    (inputs (list coreutils-minimal
> +                  libcap-ng
> +                  sed))
>      (home-page "https://www.smartmontools.org/")
>      (synopsis "S.M.A.R.T. harddisk control and monitoring tools")
>      (description
> --
> 2.47.1

Thanks

Notification sent to Tomas Volf <~@wolfsden.cz>:
bug acknowledged by developer. Full text available.

Reply sent to Hilton Chain <hako@HIDDEN>:
You have taken responsibility. Full text available.