GNU logs - #75568, boring messages

Message sent to sharlatanus@HIDDEN, guix-patches@HIDDEN:

Subject: [bug#75568] [PATCH] gnu: smartmontools: Fix PATH in smartd_warning.sh.
Resent-From: Tomas Volf <~@wolfsden.cz>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: sharlatanus@HIDDEN, guix-patches@HIDDEN
Resent-Date: Tue, 14 Jan 2025 23:41:02 +0000
Resent-Message-ID: <handler.75568.B.173689804123546 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 75550 <at> debbugs.gnu.org, 75568 <at> debbugs.gnu.org
Cc: Tomas Volf <~@wolfsden.cz>, Sharlatan Hellseher <sharlatanus@HIDDEN>
From: Tomas Volf <~@wolfsden.cz>
Date: Wed, 15 Jan 2025 00:40:19 +0100
Message-ID: <d7320ddeb1939ce0eeeea10f7267883692c269e7.1736898019.git.~@wolfsden.cz>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=37.205.8.62; envelope-from=~@wolfsden.cz;
 helo=wolfsden.cz
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,
 SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)

The script started with reset of the $PATH to a value not suitable to Guix.
In addition, the script requires coreutils and sed, so add those into the
$PATH.

* gnu/packages/admin.scm (smartmontools)[arguments]<#:phases>: Add 'fix-path.

Change-Id: Ide97f572e6f369fe24337f945474dc7a65584eda
---
 gnu/packages/admin.scm | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 7f50d5f4e9..098e21ff8a 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -2921,8 +2921,19 @@ (define-public smartmontools
                 "0gcrzcb4g7f994n6nws26g6x15yjija1gyzd359sjv7r3xj1z9p9"))))
     (build-system gnu-build-system)
     (arguments
-     (list #:make-flags
-           #~(list "BUILD_INFO=\"(Guix)\"")))
+     (list
+      #:make-flags
+      #~(list "BUILD_INFO=\"(Guix)\"")
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'install 'fix-path
+            (lambda _
+              (substitute* (string-append #$output "/etc/smartd_warning.sh")
+                (("export PATH=.*$" all)
+                 (string-append "PATH="
+                                #$(file-append sed "/bin") ":"
+                                #$(file-append coreutils "/bin") ":"
+                                "$PATH\n"))))))))
     (inputs (list libcap-ng))
     (home-page "https://www.smartmontools.org/")
     (synopsis "S.M.A.R.T. harddisk control and monitoring tools")
-- 
2.47.1

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Tomas Volf <~@wolfsden.cz>
Subject: bug#75568: Acknowledgement ([PATCH] gnu: smartmontools: Fix PATH
 in smartd_warning.sh.)
Message-ID: <handler.75568.B.173689804123546.ack <at> debbugs.gnu.org>
References: <d7320ddeb1939ce0eeeea10f7267883692c269e7.1736898019.git.~@wolfsden.cz>
X-Gnu-PR-Message: ack 75568
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 75568 <at> debbugs.gnu.org
Date: Tue, 14 Jan 2025 23:41:03 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

As you requested using X-Debbugs-CC, your message was also forwarded to
  Sharlatan Hellseher <sharlatanus@HIDDEN>
(after having been given a bug report number, if it did not have one).

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 75568 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
75568: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D75568
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to guix-patches@HIDDEN:

Subject: [bug#75568] [PATCH] gnu: smartmontools: Fix PATH in smartd_warning.sh.
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 26 Mar 2025 21:36:02 +0000
Resent-Message-ID: <handler.75568.B75568.17430249251786 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Tomas Volf <~@wolfsden.cz>
Cc: 75550 <at> debbugs.gnu.org, 75568 <at> debbugs.gnu.org, Sharlatan Hellseher <sharlatanus@HIDDEN>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
In-Reply-To: <d7320ddeb1939ce0eeeea10f7267883692c269e7.1736898019.git.~@wolfsden.cz>
 (Tomas Volf's message of "Wed, 15 Jan 2025 00:40:19 +0100")
References: <d7320ddeb1939ce0eeeea10f7267883692c269e7.1736898019.git.~@wolfsden.cz>
Date: Wed, 26 Mar 2025 22:35:08 +0100
Message-ID: <87iknvjx0z.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Tomas Volf <~@wolfsden.cz> skribis:

> The script started with reset of the $PATH to a value not suitable to Gui=
x.
> In addition, the script requires coreutils and sed, so add those into the
> $PATH.
>
> * gnu/packages/admin.scm (smartmontools)[arguments]<#:phases>: Add 'fix-p=
ath.
>
> Change-Id: Ide97f572e6f369fe24337f945474dc7a65584eda

[...]

> +          (add-after 'install 'fix-path
> +            (lambda _
> +              (substitute* (string-append #$output "/etc/smartd_warning.=
sh")
> +                (("export PATH=3D.*$" all)
> +                 (string-append "PATH=3D"
> +                                #$(file-append sed "/bin") ":"
> +                                #$(file-append coreutils "/bin") ":"

Please use (dirname (search-input-file inputs "/bin/sed")) etc. instead.
That way, when creating a variant with different inputs, the right thing
will be used.

Thanks,
Ludo=E2=80=99.

Message sent to guix-patches@HIDDEN:

Subject: [bug#75568] [PATCH] gnu: smartmontools: Fix PATH in smartd_warning.sh.
Resent-From: Tomas Volf <~@wolfsden.cz>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Wed, 26 Mar 2025 21:46:03 +0000
Resent-Message-ID: <handler.75568.B75568.17430255625338 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Cc: 75550 <at> debbugs.gnu.org, 75568 <at> debbugs.gnu.org, Sharlatan Hellseher <sharlatanus@HIDDEN>
From: Tomas Volf <~@wolfsden.cz>
In-Reply-To: <87iknvjx0z.fsf@HIDDEN> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Wed, 26 Mar 2025 22:35:08 +0100")
References: <d7320ddeb1939ce0eeeea10f7267883692c269e7.1736898019.git.~@wolfsden.cz>
 <87iknvjx0z.fsf@HIDDEN>
Date: Wed, 26 Mar 2025 22:45:55 +0100
Message-ID: <87h63f4ga4.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Ludovic Court=C3=A8s <ludo@HIDDEN> writes:

> Tomas Volf <~@wolfsden.cz> skribis:
>
>> The script started with reset of the $PATH to a value not suitable to Gu=
ix.
>> In addition, the script requires coreutils and sed, so add those into the
>> $PATH.
>>
>> * gnu/packages/admin.scm (smartmontools)[arguments]<#:phases>: Add 'fix-=
path.
>>
>> Change-Id: Ide97f572e6f369fe24337f945474dc7a65584eda
>
> [...]
>
>> +          (add-after 'install 'fix-path
>> +            (lambda _
>> +              (substitute* (string-append #$output "/etc/smartd_warning=
.sh")
>> +                (("export PATH=3D.*$" all)
>> +                 (string-append "PATH=3D"
>> +                                #$(file-append sed "/bin") ":"
>> +                                #$(file-append coreutils "/bin") ":"
>
> Please use (dirname (search-input-file inputs "/bin/sed")) etc. instead.
> That way, when creating a variant with different inputs, the right thing
> will be used.

Merged version uses the following:

=2D-8<---------------cut here---------------start------------->8---
    (arguments
     (list
      #:make-flags
      #~(list "BUILD_INFO=3D\"(Guix)\"")
      #:configure-flags
      #~(list (format #f "--with-scriptpath=3D~{~a:~}$PATH"
                      (map (lambda (pkg)
                             (in-vicinity pkg "bin"))
                           '#$(list (this-package-input "coreutils-minimal")
                                    (this-package-input "sed")))))))
=2D-8<---------------cut here---------------end--------------->8---

Is that acceptable as well or should I send a patch switching to
search-input-file?

Tomas

=2D-=20
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJCBAEBCgAsFiEEt4NJs4wUfTYpiGikL7/ufbZ/wakFAmfkdZMOHH5Ad29sZnNk
ZW4uY3oACgkQL7/ufbZ/wamsEA//eLSluJ3VCfvvBqso8sBfjo0BoidDKAycg3M9
Bi/6bOqXKDFFT39GTrH+AeoTDatC19V3U1KHcKgyxovQUMvTrkWLGCwvTRgPFjdi
a88LSnVYIKuct9osYynV0wUkOEkanw90y9Qv4Lv3QM0ZY262GGv8dUzjG5gVg3XG
qaZ+KMwSm/EWhHE5zkpmnazK/Q6owi9dEcyCqpkWRuc8fvU+KsOBo/BitEIBx9Zs
oZuJQuIq5IZVMC3aZXQwriwI7+xyIADgOJ4Ne59MbqqGNdii/kiSuxwqXhEGrbk+
ONvmurO7Dm8+xfLTK0kAaXhFesqlKsYf1IacM/PnrgU3Wouhtvk7l42+zvl3pkEo
6Z2UfiLI/I24blUCE711v9pZo0MYskeO8gU/mYBecJ6wHU7wP1/BE3iToL+CnzlL
ozp0YeRdp5tjnpvNcpGW4rZ4Ct3LGV7PF/iLRpOSid/Jca0Kknq1d4Ql5QXse9m4
ZQ9qHxHvlqB+5eA0zB5H/Yi6+Kcos7rdgQICqgYWSL1vNk0j8nc646A1pNN4Zzsv
rOzineiRldjWpUCIwB4jQIgHTS8C7hPgfxOxwuzrDLhZ/03POZQax5LFy6t7p+H2
UuopIZ+6QML7KIlTlwXylz0emNUc9kHrq00svF9i8kgvMh2+GlfE+N8fiFibyigM
mbaO9MA=
=3w6h
-----END PGP SIGNATURE-----
--=-=-=--

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#75568] [PATCH] gnu: smartmontools: Fix PATH in smartd_warning.sh.
Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 01 Apr 2025 10:16:02 +0000
Resent-Message-ID: <handler.75568.B75568.174350255113667 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 75568
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Tomas Volf <~@wolfsden.cz>
Cc: 75550 <at> debbugs.gnu.org, 75568 <at> debbugs.gnu.org, Sharlatan Hellseher <sharlatanus@HIDDEN>
Received: via spool by 75568-submit <at> debbugs.gnu.org id=B75568.174350255113667
          (code B ref 75568); Tue, 01 Apr 2025 10:16:02 +0000
Received: (at 75568) by debbugs.gnu.org; 1 Apr 2025 10:15:51 +0000
Received: from localhost ([127.0.0.1]:46508 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1tzYet-0003YM-5T
	for submit <at> debbugs.gnu.org; Tue, 01 Apr 2025 06:15:51 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:49234)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <ludo@HIDDEN>)
 id 1tzYeq-0003Y1-I3; Tue, 01 Apr 2025 06:15:49 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
 id 1tzYei-0007HD-7a; Tue, 01 Apr 2025 06:15:40 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To:
 From; bh=BkcVaWCRsm+Vkk+PJbOrCIVrDfmlDvFI4YvySz3sWk4=; b=rdVb21C0Z3xnwvdQZiGz
 quP8R9Ja1kGysG9A1Qzx78vkLjzOQck1y2JTeHMnDtH7jt/5rCwPFE+JI78J4q81m707KLAy3PkDt
 QU/YZ7QFe/G2507sw51u1NBiGU4RbECO05yTTQAsPS9UArsOVBJFPuT5vYXSrubQUaGCuLb2CMLc8
 Brk2P+TWIUNH4ToszEJaSUHBAkqW+xxcFItv4/5/OBrXdcwDhbEJYU2vmBtk93OsecCRNqSqODtEY
 AlE+XUgWY7UJlmjmOa6oNLLJnkzJWZzNqu+tUrsVr5n92xM2aQRVWWZcl45Z0U2qDIAjaRPC/BeEh
 giXbTDCt9IB9FA==;
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
In-Reply-To: <87h63f4ga4.fsf@HIDDEN> (Tomas Volf's message of "Wed, 26
 Mar 2025 22:45:55 +0100")
References: <d7320ddeb1939ce0eeeea10f7267883692c269e7.1736898019.git.~@wolfsden.cz>
 <87iknvjx0z.fsf@HIDDEN> <87h63f4ga4.fsf@HIDDEN>
X-URL: http://www.fdn.fr/~lcourtes/
X-Revolutionary-Date: Duodi 12 Germinal an 233 de la =?UTF-8?Q?R=C3=A9volution,?= jour du Charme
X-PGP-Key-ID: 0x090B11993D9AEBB5
X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc
X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4  0CFB 090B 1199 3D9A EBB5
X-OS: x86_64-pc-linux-gnu
Date: Tue, 01 Apr 2025 12:15:37 +0200
Message-ID: <87ldskfara.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Hi,

Tomas Volf <~@wolfsden.cz> skribis:

> Merged version uses the following:
>
>     (arguments
>      (list
>       #:make-flags
>       #~(list "BUILD_INFO=3D\"(Guix)\"")
>       #:configure-flags
>       #~(list (format #f "--with-scriptpath=3D~{~a:~}$PATH"
>                       (map (lambda (pkg)
>                              (in-vicinity pkg "bin"))
>                            '#$(list (this-package-input "coreutils-minima=
l")
>                                     (this-package-input "sed")))))))
>
> Is that acceptable as well or should I send a patch switching to
> search-input-file?

I have a slight preference for =E2=80=98search-input-file=E2=80=99 but this=
 version is
perfectly fine.

Thanks,
Ludo=E2=80=99.

Last modified: Tue, 1 Apr 2025 10:30:03 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.