Ludovic Courtès <ludo@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.
Received: (at 75568) by debbugs.gnu.org; 1 Apr 2025 10:15:51 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Apr 01 06:15:51 2025
Received: from localhost ([127.0.0.1]:46508 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tzYet-0003YM-5T
for submit <at> debbugs.gnu.org; Tue, 01 Apr 2025 06:15:51 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:49234)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <ludo@HIDDEN>)
id 1tzYeq-0003Y1-I3; Tue, 01 Apr 2025 06:15:49 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <ludo@HIDDEN>)
id 1tzYei-0007HD-7a; Tue, 01 Apr 2025 06:15:40 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To:
From; bh=BkcVaWCRsm+Vkk+PJbOrCIVrDfmlDvFI4YvySz3sWk4=; b=rdVb21C0Z3xnwvdQZiGz
quP8R9Ja1kGysG9A1Qzx78vkLjzOQck1y2JTeHMnDtH7jt/5rCwPFE+JI78J4q81m707KLAy3PkDt
QU/YZ7QFe/G2507sw51u1NBiGU4RbECO05yTTQAsPS9UArsOVBJFPuT5vYXSrubQUaGCuLb2CMLc8
Brk2P+TWIUNH4ToszEJaSUHBAkqW+xxcFItv4/5/OBrXdcwDhbEJYU2vmBtk93OsecCRNqSqODtEY
AlE+XUgWY7UJlmjmOa6oNLLJnkzJWZzNqu+tUrsVr5n92xM2aQRVWWZcl45Z0U2qDIAjaRPC/BeEh
giXbTDCt9IB9FA==;
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
To: Tomas Volf <~@wolfsden.cz>
Subject: Re: [bug#75568] [PATCH] gnu: smartmontools: Fix PATH in
smartd_warning.sh.
In-Reply-To: <87h63f4ga4.fsf@HIDDEN> (Tomas Volf's message of "Wed, 26
Mar 2025 22:45:55 +0100")
References: <d7320ddeb1939ce0eeeea10f7267883692c269e7.1736898019.git.~@wolfsden.cz>
<87iknvjx0z.fsf@HIDDEN> <87h63f4ga4.fsf@HIDDEN>
X-URL: http://www.fdn.fr/~lcourtes/
X-Revolutionary-Date: Duodi 12 Germinal an 233 de la =?utf-8?Q?R=C3=A9volu?=
=?utf-8?Q?tion=2C?= jour du Charme
X-PGP-Key-ID: 0x090B11993D9AEBB5
X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc
X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5
X-OS: x86_64-pc-linux-gnu
Date: Tue, 01 Apr 2025 12:15:37 +0200
Message-ID: <87ldskfara.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 75568
Cc: 75550 <at> debbugs.gnu.org, 75568 <at> debbugs.gnu.org,
Sharlatan Hellseher <sharlatanus@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
Hi,
Tomas Volf <~@wolfsden.cz> skribis:
> Merged version uses the following:
>
> (arguments
> (list
> #:make-flags
> #~(list "BUILD_INFO=3D\"(Guix)\"")
> #:configure-flags
> #~(list (format #f "--with-scriptpath=3D~{~a:~}$PATH"
> (map (lambda (pkg)
> (in-vicinity pkg "bin"))
> '#$(list (this-package-input "coreutils-minima=
l")
> (this-package-input "sed")))))))
>
> Is that acceptable as well or should I send a patch switching to
> search-input-file?
I have a slight preference for =E2=80=98search-input-file=E2=80=99 but this=
version is
perfectly fine.
Thanks,
Ludo=E2=80=99.
guix-patches@HIDDEN:bug#75568; Package guix-patches.
Full text available.
Received: (at 75568) by debbugs.gnu.org; 26 Mar 2025 21:46:02 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Mar 26 17:46:02 2025
Received: from localhost ([127.0.0.1]:44680 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1txYZV-0001Nr-H4
for submit <at> debbugs.gnu.org; Wed, 26 Mar 2025 17:46:02 -0400
Received: from wolfsden.cz ([37.205.8.62]:53278)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <~@wolfsden.cz>)
id 1txYZS-0001NF-4v; Wed, 26 Mar 2025 17:45:59 -0400
Received: by wolfsden.cz (Postfix, from userid 104)
id AC842393008; Wed, 26 Mar 2025 21:45:56 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
t=1743025556; bh=9ljnU5NmmpOfdvlZUUh6z5NGHq0TmZ3cj59/LClWACA=;
h=From:To:Cc:Subject:In-Reply-To:References:Date;
b=xx/di6AKQ9YZi8kk4j6fbtMCEHF3VUYl/afjU6ufOKFZQ5HCLb1VeY5To4Z7LWGG3
5eGUoBrd3p09/UIlntMTUU01po2wMGtA4kpfxSNCZbWGLWEtYP0t7wyYkh8ERC0uDN
Hwh8h1yOTwk9+Aw3RuAz9iUGzV+GUb/MFdB5Z1kQ/tYPnikjM4I8ORu2wdUSvSnH4m
iAAxICTT10L5PBfgKIWApyVM1eOSC3BGfhteySiKuWSQWsY5SfqisJgcoSb0iw9Vvv
ux8uJfaL/DrtQWhiK0Z+ZN/UmX8ppqaBqYoNih4ZXEC0OY6XYZkSELlacjMogHnMKX
+EgU7vsXfLmR/ptAMVLVbNHWGstNZPpo+cQNaUDjpWrhGUl8L0N3vubFd/JXr8XP0K
WwW43AB82cOmosuA89+UeIoUqIYpBKAjZAb1VX1RHoJn3wJFV/N/aR/fbCXudCFmAB
UKJJ+cxbWauHHIFZXYEZGLX7ynhGH/xnqtQM2PSHhiOBXn4uwdlrZNmPqbyyytVW5A
Fir9rfBWo47XAEQYRuhOz9jV7YLvUOlwtlY12v1FyEcoukIiiJ0+XcpCAaiU+oUGUH
663+SZmQYqf+MK4UmIX3BjHL1ha+SRGEbywt6Iy3Y1S9KHZI6odIC81OSoecGd92h1
gdrBCN78sC3SD6jQcgMJTUpY=
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden
X-Spam-Level:
X-Spam-Status: No, score=-3.1 required=5.0 tests=ALL_TRUSTED,BAYES_00,
DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED
autolearn=ham autolearn_force=no version=3.4.6
Received: from localhost (unknown [128.0.188.242])
by wolfsden.cz (Postfix) with ESMTPSA id 47CC3391EF1;
Wed, 26 Mar 2025 21:45:56 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
t=1743025556; bh=9ljnU5NmmpOfdvlZUUh6z5NGHq0TmZ3cj59/LClWACA=;
h=From:To:Cc:Subject:In-Reply-To:References:Date;
b=xx/di6AKQ9YZi8kk4j6fbtMCEHF3VUYl/afjU6ufOKFZQ5HCLb1VeY5To4Z7LWGG3
5eGUoBrd3p09/UIlntMTUU01po2wMGtA4kpfxSNCZbWGLWEtYP0t7wyYkh8ERC0uDN
Hwh8h1yOTwk9+Aw3RuAz9iUGzV+GUb/MFdB5Z1kQ/tYPnikjM4I8ORu2wdUSvSnH4m
iAAxICTT10L5PBfgKIWApyVM1eOSC3BGfhteySiKuWSQWsY5SfqisJgcoSb0iw9Vvv
ux8uJfaL/DrtQWhiK0Z+ZN/UmX8ppqaBqYoNih4ZXEC0OY6XYZkSELlacjMogHnMKX
+EgU7vsXfLmR/ptAMVLVbNHWGstNZPpo+cQNaUDjpWrhGUl8L0N3vubFd/JXr8XP0K
WwW43AB82cOmosuA89+UeIoUqIYpBKAjZAb1VX1RHoJn3wJFV/N/aR/fbCXudCFmAB
UKJJ+cxbWauHHIFZXYEZGLX7ynhGH/xnqtQM2PSHhiOBXn4uwdlrZNmPqbyyytVW5A
Fir9rfBWo47XAEQYRuhOz9jV7YLvUOlwtlY12v1FyEcoukIiiJ0+XcpCAaiU+oUGUH
663+SZmQYqf+MK4UmIX3BjHL1ha+SRGEbywt6Iy3Y1S9KHZI6odIC81OSoecGd92h1
gdrBCN78sC3SD6jQcgMJTUpY=
From: Tomas Volf <~@wolfsden.cz>
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Subject: Re: [bug#75568] [PATCH] gnu: smartmontools: Fix PATH in
smartd_warning.sh.
In-Reply-To: <87iknvjx0z.fsf@HIDDEN> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?=
=?utf-8?Q?s?= message of "Wed, 26 Mar 2025 22:35:08 +0100")
References: <d7320ddeb1939ce0eeeea10f7267883692c269e7.1736898019.git.~@wolfsden.cz>
<87iknvjx0z.fsf@HIDDEN>
Date: Wed, 26 Mar 2025 22:45:55 +0100
Message-ID: <87h63f4ga4.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 75568
Cc: 75550 <at> debbugs.gnu.org, 75568 <at> debbugs.gnu.org,
Sharlatan Hellseher <sharlatanus@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Ludovic Court=C3=A8s <ludo@HIDDEN> writes:
> Tomas Volf <~@wolfsden.cz> skribis:
>
>> The script started with reset of the $PATH to a value not suitable to Gu=
ix.
>> In addition, the script requires coreutils and sed, so add those into the
>> $PATH.
>>
>> * gnu/packages/admin.scm (smartmontools)[arguments]<#:phases>: Add 'fix-=
path.
>>
>> Change-Id: Ide97f572e6f369fe24337f945474dc7a65584eda
>
> [...]
>
>> + (add-after 'install 'fix-path
>> + (lambda _
>> + (substitute* (string-append #$output "/etc/smartd_warning=
.sh")
>> + (("export PATH=3D.*$" all)
>> + (string-append "PATH=3D"
>> + #$(file-append sed "/bin") ":"
>> + #$(file-append coreutils "/bin") ":"
>
> Please use (dirname (search-input-file inputs "/bin/sed")) etc. instead.
> That way, when creating a variant with different inputs, the right thing
> will be used.
Merged version uses the following:
=2D-8<---------------cut here---------------start------------->8---
(arguments
(list
#:make-flags
#~(list "BUILD_INFO=3D\"(Guix)\"")
#:configure-flags
#~(list (format #f "--with-scriptpath=3D~{~a:~}$PATH"
(map (lambda (pkg)
(in-vicinity pkg "bin"))
'#$(list (this-package-input "coreutils-minimal")
(this-package-input "sed")))))))
=2D-8<---------------cut here---------------end--------------->8---
Is that acceptable as well or should I send a patch switching to
search-input-file?
Tomas
=2D-=20
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.
--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQJCBAEBCgAsFiEEt4NJs4wUfTYpiGikL7/ufbZ/wakFAmfkdZMOHH5Ad29sZnNk
ZW4uY3oACgkQL7/ufbZ/wamsEA//eLSluJ3VCfvvBqso8sBfjo0BoidDKAycg3M9
Bi/6bOqXKDFFT39GTrH+AeoTDatC19V3U1KHcKgyxovQUMvTrkWLGCwvTRgPFjdi
a88LSnVYIKuct9osYynV0wUkOEkanw90y9Qv4Lv3QM0ZY262GGv8dUzjG5gVg3XG
qaZ+KMwSm/EWhHE5zkpmnazK/Q6owi9dEcyCqpkWRuc8fvU+KsOBo/BitEIBx9Zs
oZuJQuIq5IZVMC3aZXQwriwI7+xyIADgOJ4Ne59MbqqGNdii/kiSuxwqXhEGrbk+
ONvmurO7Dm8+xfLTK0kAaXhFesqlKsYf1IacM/PnrgU3Wouhtvk7l42+zvl3pkEo
6Z2UfiLI/I24blUCE711v9pZo0MYskeO8gU/mYBecJ6wHU7wP1/BE3iToL+CnzlL
ozp0YeRdp5tjnpvNcpGW4rZ4Ct3LGV7PF/iLRpOSid/Jca0Kknq1d4Ql5QXse9m4
ZQ9qHxHvlqB+5eA0zB5H/Yi6+Kcos7rdgQICqgYWSL1vNk0j8nc646A1pNN4Zzsv
rOzineiRldjWpUCIwB4jQIgHTS8C7hPgfxOxwuzrDLhZ/03POZQax5LFy6t7p+H2
UuopIZ+6QML7KIlTlwXylz0emNUc9kHrq00svF9i8kgvMh2+GlfE+N8fiFibyigM
mbaO9MA=
=3w6h
-----END PGP SIGNATURE-----
--=-=-=--
guix-patches@HIDDEN:bug#75568; Package guix-patches.
Full text available.
Received: (at 75568) by debbugs.gnu.org; 26 Mar 2025 21:35:25 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Mar 26 17:35:25 2025
Received: from localhost ([127.0.0.1]:44642 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1txYPB-0000ST-C3
for submit <at> debbugs.gnu.org; Wed, 26 Mar 2025 17:35:25 -0400
Received: from hera.aquilenet.fr ([185.233.100.1]:60992)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <ludo@HIDDEN>)
id 1txYP8-0000OJ-Bv; Wed, 26 Mar 2025 17:35:19 -0400
Received: from localhost (localhost [127.0.0.1])
by hera.aquilenet.fr (Postfix) with ESMTP id 38CF0B29;
Wed, 26 Mar 2025 22:35:11 +0100 (CET)
Authentication-Results: hera.aquilenet.fr;
none
X-Virus-Scanned: Debian amavis at hera.aquilenet.fr
Received: from hera.aquilenet.fr ([127.0.0.1])
by localhost (hera.aquilenet.fr [127.0.0.1]) (amavis, port 10024) with ESMTP
id tCZCiUuOqzIb; Wed, 26 Mar 2025 22:35:10 +0100 (CET)
Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201])
by hera.aquilenet.fr (Postfix) with ESMTPSA id 374D378;
Wed, 26 Mar 2025 22:35:09 +0100 (CET)
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
To: Tomas Volf <~@wolfsden.cz>
Subject: Re: [bug#75568] [PATCH] gnu: smartmontools: Fix PATH in
smartd_warning.sh.
In-Reply-To: <d7320ddeb1939ce0eeeea10f7267883692c269e7.1736898019.git.~@wolfsden.cz>
(Tomas Volf's message of "Wed, 15 Jan 2025 00:40:19 +0100")
References: <d7320ddeb1939ce0eeeea10f7267883692c269e7.1736898019.git.~@wolfsden.cz>
Date: Wed, 26 Mar 2025 22:35:08 +0100
Message-ID: <87iknvjx0z.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Rspamd-Queue-Id: 38CF0B29
X-Spamd-Result: default: False [-6.10 / 15.00]; BAYES_HAM(-3.00)[99.99%];
NEURAL_HAM(-3.00)[-1.000]; MIME_GOOD(-0.10)[text/plain];
FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+];
RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[];
TO_DN_SOME(0.00)[]; ARC_NA(0.00)[];
TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[];
MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[];
FREEMAIL_ENVRCPT(0.00)[gmail.com]; RCPT_COUNT_THREE(0.00)[4];
FREEMAIL_CC(0.00)[debbugs.gnu.org,gmail.com]
X-Rspamd-Action: no action
X-Spamd-Bar: ------
X-Rspamd-Server: hera
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: 75568
Cc: 75550 <at> debbugs.gnu.org, 75568 <at> debbugs.gnu.org,
Sharlatan Hellseher <sharlatanus@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
Tomas Volf <~@wolfsden.cz> skribis:
> The script started with reset of the $PATH to a value not suitable to Gui=
x.
> In addition, the script requires coreutils and sed, so add those into the
> $PATH.
>
> * gnu/packages/admin.scm (smartmontools)[arguments]<#:phases>: Add 'fix-p=
ath.
>
> Change-Id: Ide97f572e6f369fe24337f945474dc7a65584eda
[...]
> + (add-after 'install 'fix-path
> + (lambda _
> + (substitute* (string-append #$output "/etc/smartd_warning.=
sh")
> + (("export PATH=3D.*$" all)
> + (string-append "PATH=3D"
> + #$(file-append sed "/bin") ":"
> + #$(file-append coreutils "/bin") ":"
Please use (dirname (search-input-file inputs "/bin/sed")) etc. instead.
That way, when creating a variant with different inputs, the right thing
will be used.
Thanks,
Ludo=E2=80=99.
guix-patches@HIDDEN:bug#75568; Package guix-patches.
Full text available.
Received: (at submit) by debbugs.gnu.org; 14 Jan 2025 23:40:41 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 14 18:40:41 2025
Received: from localhost ([127.0.0.1]:56153 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1tXqWX-00067i-AK
for submit <at> debbugs.gnu.org; Tue, 14 Jan 2025 18:40:41 -0500
Received: from lists.gnu.org ([2001:470:142::17]:55456)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <~@wolfsden.cz>) id 1tXqWU-00067A-Ky
for submit <at> debbugs.gnu.org; Tue, 14 Jan 2025 18:40:39 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1tXqWN-0000xx-WB
for guix-patches@HIDDEN; Tue, 14 Jan 2025 18:40:32 -0500
Received: from wolfsden.cz ([37.205.8.62])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1tXqWM-0007rb-A7
for guix-patches@HIDDEN; Tue, 14 Jan 2025 18:40:31 -0500
Received: by wolfsden.cz (Postfix, from userid 104)
id 57FDD3559A8; Tue, 14 Jan 2025 23:40:27 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
t=1736898027; bh=GbcOvYJg8uRvTCKQKVZQEtT+9/4vwZsW0OeI3M+u+HQ=;
h=From:To:Cc:Subject:Date;
b=AAtqvEBLU3AdjXME5ZH9TXX0DKdyA197fqPLL424/eBjTJ5AjnGn4HTHHR7a0xU3l
qn5i7/cKnoSlEzSwBoAhPWp7TCCFhQ8Y55WiVSXfdonucZldJK0e2mtp7Z2Nznro9K
6EFCzQSsDQfdnx1Ct7CIiI8vVYEJsBiyJnBcRQ8wJ2jU5Oox4xAjgAsWWojIOfZdWP
P8ZdK8YefFnajrY4D87rne5hJupa9qiktpPNYEtuEMcFlv3ZOTyPgzW8fO226dPwSw
rf/R+mTY8NrJpLsWfi8bgGkHu4sgcsrGHRpauOg9ffv3cnQkXKLGsY6wgv9r9vsUfp
NDOMkHlHHUi8aHCyLklQUZrydlMbJfCCgqiJ/eqpbac6+FQ/4BUQoilr2Ygkwyybnn
8YWAY2DGkiSP34J0B7zo3uZdgtbzcvRuAkZd9DMZ0g8Nsqty7C7Bu7OcNkNBLJYmIQ
BXtJyPuCwuxj6Yt99Kv5chzNzT+rQoR62z2Q1pAAGdENfkkwPwXpqHTQRBYWvWlQRH
rrEe/5k5LAZOTi2GF8aFNQmrKBNUN8ck1+0qj4Lz2lINlNuX11nHhkSnc7E0GpY2zF
OSEsWbT+lM2HEUnLHC17gugmA80U9GBruXrOCsrfbtq/KPNP+TiwJPODbRxDExh93n
bmPtDAIaMW9+SBxhQ5ssLfM4=
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden
X-Spam-Level:
X-Spam-Status: No, score=-3.1 required=5.0 tests=ALL_TRUSTED,BAYES_00,
DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED
autolearn=ham autolearn_force=no version=3.4.6
Received: from localhost (unknown [193.32.127.158])
by wolfsden.cz (Postfix) with ESMTPSA id 6AC85356609;
Tue, 14 Jan 2025 23:40:26 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail;
t=1736898026; bh=GbcOvYJg8uRvTCKQKVZQEtT+9/4vwZsW0OeI3M+u+HQ=;
h=From:To:Cc:Subject:Date;
b=ohqVSpGHiitCIgF8YK9Mb4tntzEe/mHpwBe+jZ+20NWjA+LHIAoHBmq1Cez94UVfY
Np/3Ncp0ZmPEH9xUCDQ3NNZXRXNjC5Qnn0TT2vsqLxv86gsk+zKENWqW+QsmM+zqCN
PYZJ++rJ9I4t3xbVMZ1erjjMy51s8UmE4ab4pcc7Vg+/AWg7IDa7MLKLoY6/Sr4xxe
GV+uS772WES4biC3EMtfA4kHguM5vbJv3tX/RFkGIgNCgLnelkHZnYOej/8PqACGYG
npZFLlCy1TAskcYHEqW+9FLjOWWlZ/W+QsHsVwP3DI9mNuC9Tu3F+46Y3BKYJmxUg1
tjnLwYmNVXyRxXnd40yr4tNZj81cXLFFbjhWClVwEdDnShspdkEYpPL4wncT9NZSZm
Wix07pZV49cjRICPg/6wRtBnid/bIEkTI4hD0kN8H7FqzKMqh1PV+NujFTMYHhPNVd
ZJzDlwxtPgYPOYojjwlQSD+hDZaykUFEACz5vAKbcoqOclqYMCOVhaTQoD3oQL2UGV
Y5Lqbsb2U1Huil9dfio/jrVYoX9MVxi5SAUd3MRSEE0pZ1B8ZnytGw5RE865BCN/Zc
GRoueh972yYJUcZjy9OcKA2LJXfkztqunIsRkEHSoqDyBDz+iviy8grjOndwBvo7uU
T2RPagqes+TbOUwxwd6LLFtM=
From: Tomas Volf <~@wolfsden.cz>
To: 75550 <at> debbugs.gnu.org,
guix-patches@HIDDEN
Subject: [PATCH] gnu: smartmontools: Fix PATH in smartd_warning.sh.
Date: Wed, 15 Jan 2025 00:40:19 +0100
Message-ID: <d7320ddeb1939ce0eeeea10f7267883692c269e7.1736898019.git.~@wolfsden.cz>
X-Mailer: git-send-email 2.47.1
MIME-Version: 1.0
X-Debbugs-Cc: Sharlatan Hellseher <sharlatanus@HIDDEN>
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=37.205.8.62; envelope-from=~@wolfsden.cz;
helo=wolfsden.cz
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,
SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 1.0 (+)
X-Debbugs-Envelope-To: submit
Cc: Tomas Volf <~@wolfsden.cz>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.0 (/)
The script started with reset of the $PATH to a value not suitable to Guix.
In addition, the script requires coreutils and sed, so add those into the
$PATH.
* gnu/packages/admin.scm (smartmontools)[arguments]<#:phases>: Add 'fix-path.
Change-Id: Ide97f572e6f369fe24337f945474dc7a65584eda
---
gnu/packages/admin.scm | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 7f50d5f4e9..098e21ff8a 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -2921,8 +2921,19 @@ (define-public smartmontools
"0gcrzcb4g7f994n6nws26g6x15yjija1gyzd359sjv7r3xj1z9p9"))))
(build-system gnu-build-system)
(arguments
- (list #:make-flags
- #~(list "BUILD_INFO=\"(Guix)\"")))
+ (list
+ #:make-flags
+ #~(list "BUILD_INFO=\"(Guix)\"")
+ #:phases
+ #~(modify-phases %standard-phases
+ (add-after 'install 'fix-path
+ (lambda _
+ (substitute* (string-append #$output "/etc/smartd_warning.sh")
+ (("export PATH=.*$" all)
+ (string-append "PATH="
+ #$(file-append sed "/bin") ":"
+ #$(file-append coreutils "/bin") ":"
+ "$PATH\n"))))))))
(inputs (list libcap-ng))
(home-page "https://www.smartmontools.org/")
(synopsis "S.M.A.R.T. harddisk control and monitoring tools")
--
2.47.1
Tomas Volf <~@wolfsden.cz>:sharlatanus@HIDDEN, guix-patches@HIDDEN.
Full text available.sharlatanus@HIDDEN, guix-patches@HIDDEN:bug#75568; Package guix-patches.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.